binutils-gdb/gdb/testsuite/gdb.ada
Pierre-Marie de Rodat e6c2c623f7 [Ada] Fix handling of array renamings
Compilers can materialize renamings of arrays (or of accesses to arrays)
in Ada into variables whose types are references to the actual array
types.  Before this change, trying to use such an array renaming yielded
an error in GDB:

    (gdb) print my_array(1)
    cannot subscript or call a record
    (gdb) print my_array_ptr(1)
    cannot subscript or call something of type `(null)'

This behavior comes from bad handling for array renamings, in particular
the OP_FUNCALL expression operator handling from ada-lang.c
(ada_evaluate_subexp): in one place we turn the reference into a
pointer, but the code that follows expect the value to be an array.

This patch fixes how we handle references in call/subscript evaluation
so that we turn these references into the actual array values instead of
pointers to them.

gdb/ChangeLog:

	* ada-lang.c (ada_evaluate_subexp) <OP_FUNCALL>: When the input
	value is a reference, actually dereference it in order to get
	the underlying value.

gdb/testsuite/ChangeLog:

	* gdb.ada/array_ptr_renaming.exp: New testcase.
	* gdb.ada/array_ptr_renaming/foo.adb: New file.
	* gdb.ada/array_ptr_renaming/pack.ads: New file.

Tested on x86_64-linux, no regression.
2015-09-23 22:14:18 +02:00
..
O2_float_param
access_to_packed_array [Ada] Fix the evaluation of access to packed array subscript 2015-09-14 16:28:23 +02:00
addr_arith
aliased_array
arr_arr
array_bounds
array_char_idx
array_of_variable_length [Ada] Enhance type printing for arrays with variable-sized elements 2015-09-15 23:16:22 +02:00
array_ptr_renaming [Ada] Fix handling of array renamings 2015-09-23 22:14:18 +02:00
array_return
array_subscript_addr
arraydim
arrayidx
arrayparam
arrayptr
atomic_enum
attr_ref_and_charlit [Ada] Fix parsing for expressions with attributes and characters 2015-08-20 10:12:24 +02:00
bad-task-bp-keyword
bp_enum_homonym
bp_on_var
bp_range_type
bp_reset
byte_packed_arr Non bit-packed packed arrays as variable-length fields 2015-05-15 14:00:57 -07:00
call_pn
catch_ex
char_enum
char_param
complete [Ada] Fix completion for multiple function matches 2015-09-01 14:54:19 +02:00
cond_lang
disc_arr_bound gdb/DWARF: Support for arrays whose bound is a discriminant. 2015-01-29 12:08:47 +04:00
dot_all
dyn_arrayidx
dyn_loc
enum_idx_packed
exec_changed testcase for PR symtab/17855 2015-02-22 09:11:55 -08:00
expr_delims
exprs
fixed_cmp
fixed_points
float_param
formatted_ref
frame_args
fullname_bp
fun_addr
fun_in_declare
fun_renaming [Ada] Add support for subprogram renamings 2015-08-13 09:33:42 +02:00
funcall_char [Ada] Make string_char_type a true TYPE_CODE_CHAR type in Ada 2015-09-03 17:52:05 +02:00
funcall_param
funcall_ref Do not consider reference types as dynamic 2015-04-03 15:23:49 +02:00
homonym
info_exc
info_locals_renaming
int_deref
interface
iwide
lang_switch
mi_catch_ex
mi_dyn_arr
mi_ex_cond
mi_exc_info
mi_interface
mi_task_arg
mi_task_info
mi_var_array [Ada/varobj] number of children of null pointer to dynamic array. 2015-01-29 12:07:25 +04:00
mod_from_name
n_arr_bound
nested
null_array
null_record
operator_bp
optim_drec
out_of_line_in_inlined DWARF: cannot break on out-of-line function nested inside inlined function. 2015-05-05 11:06:09 -07:00
packed_array
packed_tagged
pckd_arr_ren
pckd_neg [Ada] problem printing negative integer values in packed arrays. 2015-05-15 07:37:15 -07:00
pkd_arr_elem
pp-rec-component
print_chars
ptr_typedef
ptype_field
ptype_tagged_param
py_range
rdv_wait
rec_comp [Ada] Preserve typedef layer when getting struct element 2015-04-27 11:04:47 +02:00
rec_return
ref_param
ref_tick_size
same_enum
set_pckd_arr_elt
set_wstr
small_reg_param
start
str_ref_cmp
str_uninit
sym_print_name
taft_type
tagged
tagged_access
tagged_not_init
task_bp
tasks
tick_last_segv
tick_length_array_enum_idx
type_coercion
unc_arr_ptr_in_var_rec
uninitialized_vars
var_arr_attrs [Ada] 'first/'last/'length of array whose bound is a discriminant 2015-01-15 12:53:33 +04:00
var_arr_typedef gdb/gdbtypes: fix handling of typedef layers between array types 2015-07-23 14:59:58 +02:00
var_rec_arr testsuite/gdb.ada/var_rec_arr: New testcase. 2015-05-05 10:48:21 -07:00
variant_record_packed_array
watch_arg
whatis_array_val
widewide
win_fu_syms
Makefile.in
O2_float_param.exp
access_to_packed_array.exp [Ada] Fix the evaluation of access to packed array subscript 2015-09-14 16:28:23 +02:00
addr_arith.exp
aliased_array.exp
arr_arr.exp
array_bounds.exp
array_char_idx.exp
array_of_variable_length.exp [Ada] Enhance type printing for arrays with variable-sized elements 2015-09-15 23:16:22 +02:00
array_ptr_renaming.exp [Ada] Fix handling of array renamings 2015-09-23 22:14:18 +02:00
array_return.exp
array_subscript_addr.exp
arraydim.exp
arrayidx.exp
arrayparam.exp
arrayptr.exp
assign_1.exp
atomic_enum.exp
attr_ref_and_charlit.exp [Ada] Fix parsing for expressions with attributes and characters 2015-08-20 10:12:24 +02:00
bad-task-bp-keyword.exp
boolean_expr.exp
bp_enum_homonym.exp
bp_on_var.exp
bp_range_type.exp
bp_reset.exp
byte_packed_arr.exp Non bit-packed packed arrays as variable-length fields 2015-05-15 14:00:57 -07:00
call_pn.exp
catch_ex.exp
char_enum.exp
char_param.exp
complete.exp [Ada] Fix completion for multiple function matches 2015-09-01 14:54:19 +02:00
cond_lang.exp
disc_arr_bound.exp gdb/DWARF: Support for arrays whose bound is a discriminant. 2015-01-29 12:08:47 +04:00
dot_all.exp
dyn_arrayidx.exp gdb.ada/dyn_arrayidx.exp: Add additional_flags=-gnat12. 2015-01-31 14:26:54 -08:00
dyn_loc.exp
enum_idx_packed.exp
exec_changed.exp testcase for PR symtab/17855 2015-02-22 09:11:55 -08:00
expr_delims.exp
exprs.exp
fixed_cmp.exp
fixed_points.exp
float_param.exp
formatted_ref.exp
frame_args.exp
fullname_bp.exp
fun_addr.exp
fun_in_declare.exp
fun_renaming.exp [Ada] Add support for subprogram renamings 2015-08-13 09:33:42 +02:00
funcall_char.exp [Ada] Make string_char_type a true TYPE_CODE_CHAR type in Ada 2015-09-03 17:52:05 +02:00
funcall_param.exp
funcall_ref.exp Do not consider reference types as dynamic 2015-04-03 15:23:49 +02:00
gnat_ada.gpr
homonym.exp
info_exc.exp gdb.ada/info_exc.exp: Adjust expected output in "info exception" test. 2015-07-20 15:18:24 -07:00
info_locals_renaming.exp
info_types.c
info_types.exp
int_deref.exp
interface.exp
iwide.exp
lang_switch.exp
mi_catch_ex.exp
mi_dyn_arr.exp
mi_ex_cond.exp
mi_exc_info.exp
mi_interface.exp
mi_task_arg.exp
mi_task_info.exp
mi_var_array.exp [Ada/varobj] number of children of null pointer to dynamic array. 2015-01-29 12:07:25 +04:00
mod_from_name.exp
n_arr_bound.exp
nested.exp
null_array.exp
null_record.exp
operator_bp.exp
optim_drec.exp
out_of_line_in_inlined.exp out of line functions nested inside inline functions. 2015-05-05 11:08:14 -07:00
packed_array.exp
packed_tagged.exp Share the "multi_line" helper among all testcases 2015-04-01 15:06:39 +02:00
pckd_arr_ren.exp
pckd_neg.exp [Ada] problem printing negative integer values in packed arrays. 2015-05-15 07:37:15 -07:00
pkd_arr_elem.exp
pp-rec-component.exp
pp-rec-component.py
print_chars.exp
print_pc.exp
ptr_typedef.exp
ptype_arith_binop.exp
ptype_field.exp Share the "multi_line" helper among all testcases 2015-04-01 15:06:39 +02:00
ptype_tagged_param.exp
py_range.exp
rdv_wait.exp
rec_comp.exp [Ada] Preserve typedef layer when getting struct element 2015-04-27 11:04:47 +02:00
rec_return.exp
ref_param.exp
ref_tick_size.exp
same_enum.exp
set_pckd_arr_elt.exp
set_wstr.exp
small_reg_param.exp
start.exp
str_ref_cmp.exp
str_uninit.exp
sym_print_name.exp Share the "multi_line" helper among all testcases 2015-04-01 15:06:39 +02:00
taft_type.exp
tagged.exp Share the "multi_line" helper among all testcases 2015-04-01 15:06:39 +02:00
tagged_access.exp
tagged_not_init.exp
task_bp.exp
tasks.exp
tick_last_segv.exp
tick_length_array_enum_idx.exp
type_coercion.exp
unc_arr_ptr_in_var_rec.exp
uninitialized_vars.exp
var_arr_attrs.exp [Ada] 'first/'last/'length of array whose bound is a discriminant 2015-01-15 12:53:33 +04:00
var_arr_typedef.exp gdb/gdbtypes: fix handling of typedef layers between array types 2015-07-23 14:59:58 +02:00
var_rec_arr.exp testsuite/gdb.ada/var_rec_arr: New testcase. 2015-05-05 10:48:21 -07:00
variant_record_packed_array.exp
watch_arg.exp
whatis_array_val.exp
widewide.exp
win_fu_syms.exp