948f8e3d72
-Wpointer-sign catches all these cases across the codebase that should be using gdb_byte for raw target bytes. I think these are all obvious, hence I've collapsed into a single patch. gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * aarch64-tdep.c (aarch64_default_breakpoint): Change type to gdb_byte[]. (aarch64_breakpoint_from_pc): Change return type to gdb_byte *. * ada-lang.c (ada_value_assign): Use gdb_byte. * alphanbsd-tdep.c (sigtramp_retcode): Change type to gdb_byte[]. (alphanbsd_sigtramp_offset): Use gdb_byte. * arm-linux-tdep.c (arm_linux_arm_le_breakpoint) (arm_linux_arm_be_breakpoint, eabi_linux_arm_le_breakpoint) (eabi_linux_arm_be_breakpoint, arm_linux_thumb_be_breakpoint) (arm_linux_thumb_le_breakpoint, arm_linux_thumb2_be_breakpoint) (arm_linux_thumb2_le_breakpoint): Change type to gdb_byte[]. * arm-tdep.c (arm_stub_unwind_sniffer) (arm_displaced_init_closure): Use gdb_byte. (arm_default_arm_le_breakpoint, arm_default_arm_be_breakpoint) (arm_default_thumb_le_breakpoint) (arm_default_thumb_be_breakpoint): Change type to gdb_byte[]. * arm-tdep.h (struct gdbarch_tdep) <arm_breakpoint, thumb_breakpoint, thumb2_breakpoint>: Change type to gdb_byte *. * arm-wince-tdep.c (arm_wince_le_breakpoint) (arm_wince_thumb_le_breakpoint): Change type to gdb_byte[]. * armnbsd-tdep.c (arm_nbsd_arm_le_breakpoint) (arm_nbsd_arm_be_breakpoint, arm_nbsd_thumb_le_breakpoint) (arm_nbsd_thumb_be_breakpoint): Change type to gdb_byte[]. * armobsd-tdep.c (arm_obsd_thumb_le_breakpoint) (arm_obsd_thumb_be_breakpoint): Change type to gdb_byte[]. * cris-tdep.c (push_stack_item, cris_push_dummy_call) (cris_store_return_value, cris_extract_return_value): Use gdb_byte. (constraint): Change type of parameter to char * from signed char*. Use gdb_byte. * dwarf2loc.c (read_pieced_value, write_pieced_value): Change type of local buffer to gdb_byte *. * dwarf2read.c (read_index_from_section): Use gdb_byte. (create_dwp_hash_table): Change type of locals to gdb_byte *. (add_address_entry): Change type of local buffer to gdb_byte[]. * frv-tdep.c (frv_adjust_breakpoint_address, find_func_descr) (frv_push_dummy_call): Use gdb_byte. * hppa-hpux-tdep.c (hppa_hpux_push_dummy_code) (hppa_hpux_supply_ss_fpblock, hppa_hpux_supply_ss_wide) (hppa_hpux_supply_save_state): Use gdb_byte. * hppa-tdep.c (hppa32_push_dummy_call) (hppa64_convert_code_addr_to_fptr): Use gdb_byte. * ia64-tdep.c (extract_bit_field, replace_bit_field) (slotN_contents, replace_slotN_contents): Change type of parameter to gdb_byte *. (fetch_instruction, ia64_pseudo_register_write) (ia64_register_to_value, ia64_value_to_register) (ia64_extract_return_value, ia64_store_return_value) (ia64_push_dummy_call): Use gdb_byte. * m32c-tdep.c (m32c_return_value): Remove cast. * m68hc11-tdep.c (m68hc11_pseudo_register_write) (m68hc11_push_dummy_call, m68hc11_store_return_value): Use gdb_byte. * mipsnbsd-tdep.c (mipsnbsd_get_longjmp_target): Use gdb_byte. * mn10300-tdep.c (mn10300_store_return_value) (mn10300_breakpoint_from_pc, mn10300_push_dummy_call): Use gdb_byte. * moxie-tdep.c (moxie_process_readu): Use gdb_byte. (moxie_process_record): Remove casts. * ppc-ravenscar-thread.c (supply_register_at_address) (ppc_ravenscar_generic_store_registers): Use gdb_byte. * ravenscar-thread.c (get_running_thread_id): Use gdb_byte. * remote-m32r-sdi.c (m32r_fetch_register): Use gdb_byte. * remote-mips.c (mips_xfer_memory): Use gdb_byte. * remote.c (compare_sections_command): Use gdb_byte. * score-tdep.c (score7_free_memblock): Change type of parameter to gdb_byte *. * sh-tdep.c (sh_justify_value_in_reg): Change return type to gdb_byte *. Use gdb_byte. (sh_push_dummy_call_fpu): Use gdb_byte. (sh_extract_return_value_nofpu, sh_extract_return_value_fpu) (sh_store_return_value_nofpu, sh_store_return_value_fpu) (sh_register_convert_to_virtual, sh_register_convert_to_raw): Change parameter type to 'gdb_byte *'. Use gdb_byte. (sh_pseudo_register_read, sh_pseudo_register_write): Use gdb_byte. * sh64-tdep.c (sh64_push_dummy_call): Use gdb_byte. (sh64_store_return_value, sh64_register_convert_to_virtual): Change parameter type to 'gdb_byte *'. Use gdb_byte. (sh64_pseudo_register_write): Use gdb_byte. * solib-darwin.c (darwin_current_sos): Add casts to 'gdb_byte *'. * solib-irix.c (fetch_lm_info): Likewise. Use gdb_byte for byte buffer. (irix_current_sos): Use gdb_byte. * solib-som.c (som_current_sos): Use gdb_byte. * sparc-ravenscar-thread.c (supply_register_at_address) (sparc_ravenscar_generic_store_registers): Use gdb_byte. * spu-multiarch.c (spu_xfer_partial): Add cast to 'char *'. * spu-tdep.c (spu_get_overlay_table): Use gdb_byte. * tic6x-tdep.c (tic6x_breakpoint_from_pc): Change return type to 'gdb_byte *'. * tic6x-tdep.h (struct gdbarch_tdep) <breakpoint>: Change type to 'gdb_byte *'. * tracepoint.c (tfile_fetch_registers): Use gdb_byte. * xstormy16-tdep.c (xstormy16_extract_return_value) (xstormy16_store_return_value): Change parameter type to 'gdb_byte *'. Adjust. (xstormy16_push_dummy_call): Use gdb_byte. * xtensa-tdep.c (xtensa_scan_prologue, call0_ret) (call0_analyze_prologue, execute_code): Use gdb_byte.
171 lines
5.2 KiB
C
171 lines
5.2 KiB
C
/* Target-dependent code for Windows CE running on ARM processors,
|
|
for GDB.
|
|
|
|
Copyright (C) 2007-2013 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "osabi.h"
|
|
#include "gdbcore.h"
|
|
#include "target.h"
|
|
#include "solib.h"
|
|
#include "solib-target.h"
|
|
#include "frame.h"
|
|
|
|
#include "gdb_string.h"
|
|
|
|
#include "arm-tdep.h"
|
|
|
|
static const gdb_byte arm_wince_le_breakpoint[] = { 0x10, 0x00, 0x00, 0xe6 };
|
|
static const gdb_byte arm_wince_thumb_le_breakpoint[] = { 0xfe, 0xdf };
|
|
|
|
/* Description of the longjmp buffer. */
|
|
#define ARM_WINCE_JB_ELEMENT_SIZE INT_REGISTER_SIZE
|
|
#define ARM_WINCE_JB_PC 10
|
|
|
|
static CORE_ADDR
|
|
arm_pe_skip_trampoline_code (struct frame_info *frame, CORE_ADDR pc)
|
|
{
|
|
struct gdbarch *gdbarch = get_frame_arch (frame);
|
|
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
|
ULONGEST indirect;
|
|
struct bound_minimal_symbol indsym;
|
|
const char *symname;
|
|
CORE_ADDR next_pc;
|
|
|
|
/* The format of an ARM DLL trampoline is:
|
|
ldr ip, [pc]
|
|
ldr pc, [ip]
|
|
.dw __imp_<func> */
|
|
|
|
if (pc == 0
|
|
|| read_memory_unsigned_integer (pc + 0, 4, byte_order) != 0xe59fc000
|
|
|| read_memory_unsigned_integer (pc + 4, 4, byte_order) != 0xe59cf000)
|
|
return 0;
|
|
|
|
indirect = read_memory_unsigned_integer (pc + 8, 4, byte_order);
|
|
if (indirect == 0)
|
|
return 0;
|
|
|
|
indsym = lookup_minimal_symbol_by_pc (indirect);
|
|
if (indsym.minsym == NULL)
|
|
return 0;
|
|
|
|
symname = SYMBOL_LINKAGE_NAME (indsym.minsym);
|
|
if (symname == NULL || strncmp (symname, "__imp_", 6) != 0)
|
|
return 0;
|
|
|
|
next_pc = read_memory_unsigned_integer (indirect, 4, byte_order);
|
|
if (next_pc != 0)
|
|
return next_pc;
|
|
|
|
/* Check with the default arm gdbarch_skip_trampoline. */
|
|
return arm_skip_stub (frame, pc);
|
|
}
|
|
|
|
/* GCC emits a call to __gccmain in the prologue of main.
|
|
|
|
The function below examines the code pointed at by PC and checks to
|
|
see if it corresponds to a call to __gccmain. If so, it returns
|
|
the address of the instruction following that call. Otherwise, it
|
|
simply returns PC. */
|
|
|
|
static CORE_ADDR
|
|
arm_wince_skip_main_prologue (struct gdbarch *gdbarch, CORE_ADDR pc)
|
|
{
|
|
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
|
ULONGEST this_instr;
|
|
|
|
this_instr = read_memory_unsigned_integer (pc, 4, byte_order);
|
|
|
|
/* bl offset <__gccmain> */
|
|
if ((this_instr & 0xfff00000) == 0xeb000000)
|
|
{
|
|
#define sign_extend(V, N) \
|
|
(((long) (V) ^ (1L << ((N) - 1))) - (1L << ((N) - 1)))
|
|
|
|
long offset = sign_extend (this_instr & 0x000fffff, 23) << 2;
|
|
CORE_ADDR call_dest = (pc + 8 + offset) & 0xffffffffU;
|
|
struct bound_minimal_symbol s = lookup_minimal_symbol_by_pc (call_dest);
|
|
|
|
if (s.minsym != NULL
|
|
&& SYMBOL_LINKAGE_NAME (s.minsym) != NULL
|
|
&& strcmp (SYMBOL_LINKAGE_NAME (s.minsym), "__gccmain") == 0)
|
|
pc += 4;
|
|
}
|
|
|
|
return pc;
|
|
}
|
|
|
|
static void
|
|
arm_wince_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
|
{
|
|
struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
|
|
|
|
tdep->arm_breakpoint = arm_wince_le_breakpoint;
|
|
tdep->arm_breakpoint_size = sizeof (arm_wince_le_breakpoint);
|
|
tdep->thumb_breakpoint = arm_wince_thumb_le_breakpoint;
|
|
tdep->thumb_breakpoint_size = sizeof (arm_wince_thumb_le_breakpoint);
|
|
tdep->struct_return = pcc_struct_return;
|
|
|
|
tdep->fp_model = ARM_FLOAT_SOFT_VFP;
|
|
|
|
tdep->jb_pc = ARM_WINCE_JB_PC;
|
|
tdep->jb_elt_size = ARM_WINCE_JB_ELEMENT_SIZE;
|
|
|
|
/* On ARM WinCE char defaults to signed. */
|
|
set_gdbarch_char_signed (gdbarch, 1);
|
|
|
|
/* Shared library handling. */
|
|
set_solib_ops (gdbarch, &solib_target_so_ops);
|
|
set_gdbarch_skip_trampoline_code (gdbarch, arm_pe_skip_trampoline_code);
|
|
|
|
/* Single stepping. */
|
|
set_gdbarch_software_single_step (gdbarch, arm_software_single_step);
|
|
|
|
/* Skip call to __gccmain that gcc places in main. */
|
|
set_gdbarch_skip_main_prologue (gdbarch, arm_wince_skip_main_prologue);
|
|
|
|
/* Canonical paths on this target look like `\Windows\coredll.dll',
|
|
for example. */
|
|
set_gdbarch_has_dos_based_file_system (gdbarch, 1);
|
|
}
|
|
|
|
static enum gdb_osabi
|
|
arm_wince_osabi_sniffer (bfd *abfd)
|
|
{
|
|
const char *target_name = bfd_get_target (abfd);
|
|
|
|
if (strcmp (target_name, "pei-arm-wince-little") == 0)
|
|
return GDB_OSABI_WINCE;
|
|
|
|
return GDB_OSABI_UNKNOWN;
|
|
}
|
|
|
|
/* Provide a prototype to silence -Wmissing-prototypes. */
|
|
void _initialize_arm_wince_tdep (void);
|
|
|
|
void
|
|
_initialize_arm_wince_tdep (void)
|
|
{
|
|
gdbarch_register_osabi_sniffer (bfd_arch_arm, bfd_target_coff_flavour,
|
|
arm_wince_osabi_sniffer);
|
|
|
|
gdbarch_register_osabi (bfd_arch_arm, 0, GDB_OSABI_WINCE,
|
|
arm_wince_init_abi);
|
|
}
|