binutils-gdb/gdb/testsuite/gdb.server
Tom de Vries d1e36019c1 [gdb/testsuite] Remove superfluous 3rd argument from gdb_test call (2)
There's a pattern:
...
gdb_test <command> <pattern> <command>
...
that can be written shorter as:
...
gdb_test <command> <pattern>
...

Detect this pattern in proc gdb_test:
...
     global gdb_prompt
     upvar timeout timeout

     if [llength $args]>2 then {
        set message [lindex $args 2]
+       if { $message == [lindex $args 0] && [llength $args] == 3 } {
+           error "HERE"
+       }
     } else {
         set message [lindex $args 0]
     }
...
and fix all occurrences in some gdb testsuite subdirs.

Tested on x86_64-linux.

gdb/testsuite/ChangeLog:

2019-10-31  Tom de Vries  <tdevries@suse.de>

	* gdb.arch/amd64-disp-step-avx.exp: Drop superfluous 3rd argument to
	gdb_test.
	* gdb.arch/amd64-disp-step.exp: Same.
	* gdb.asm/asm-source.exp: Same.
	* gdb.btrace/buffer-size.exp: Same.
	* gdb.btrace/cpu.exp: Same.
	* gdb.btrace/enable.exp: Same.
	* gdb.dwarf2/count.exp: Same.
	* gdb.dwarf2/dw2-ranges-func.exp: Same.
	* gdb.dwarf2/dw2-ranges-psym.exp: Same.
	* gdb.fortran/vla-datatypes.exp: Same.
	* gdb.fortran/vla-history.exp: Same.
	* gdb.fortran/vla-ptype.exp: Same.
	* gdb.fortran/vla-value.exp: Same.
	* gdb.fortran/whatis_type.exp: Same.
	* gdb.guile/guile.exp: Same.
	* gdb.multi/tids.exp: Same.
	* gdb.python/py-finish-breakpoint.exp: Same.
	* gdb.python/py-framefilter.exp: Same.
	* gdb.python/py-pp-registration.exp: Same.
	* gdb.python/py-xmethods.exp: Same.
	* gdb.python/python.exp: Same.
	* gdb.server/connect-with-no-symbol-file.exp: Same.
	* gdb.server/no-thread-db.exp: Same.
	* gdb.server/run-without-local-binary.exp: Same.
	* gdb.stabs/weird.exp: Same.
	* gdb.threads/attach-many-short-lived-threads.exp: Same.
	* gdb.threads/thread-find.exp: Same.
	* gdb.threads/tls-shared.exp: Same.
	* gdb.threads/tls.exp: Same.
	* gdb.threads/wp-replication.exp: Same.
	* gdb.trace/ax.exp: Same.
	* lib/gdb.exp (gdb_test_exact, help_test_raw): Same.

Change-Id: I2fa544c68f8c0099a77e03ff04ddc010eb2b6c7c
2019-10-31 23:03:25 +01:00
..
abspath.exp
connect-stopped-target.c
connect-stopped-target.exp
connect-with-no-symbol-file.c
connect-with-no-symbol-file.exp [gdb/testsuite] Remove superfluous 3rd argument from gdb_test call (2) 2019-10-31 23:03:25 +01:00
connect-without-multi-process.c
connect-without-multi-process.exp
ext-attach.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
ext-attach.exp
ext-restart.exp
ext-run.exp
ext-wrapper.exp
extended-remote-restart.c
extended-remote-restart.exp
file-transfer.exp
no-thread-db.c
no-thread-db.exp [gdb/testsuite] Remove superfluous 3rd argument from gdb_test call (2) 2019-10-31 23:03:25 +01:00
non-existing-program.exp
normal.c Update copyright year range in all GDB files. 2019-01-01 10:01:51 +04:00
reconnect-ctrl-c.c
reconnect-ctrl-c.exp Skip GDB test reconnect-ctrl-c.exp if nointerrupts is set. 2019-08-04 14:34:31 -07:00
run-without-local-binary.exp [gdb/testsuite] Remove superfluous 3rd argument from gdb_test call (2) 2019-10-31 23:03:25 +01:00
server-connect.exp [gdb/testsuite] Handle unreachable network in server-connect.exp 2019-09-19 00:23:54 +02:00
server-exec-info.exp
server-kill.c
server-kill.exp
server-mon.exp
server-run.exp
server.c
solib-list-lib.c
solib-list-main.c
solib-list.exp
stop-reply-no-thread.c
stop-reply-no-thread.exp
sysroot.c
sysroot.exp
transfer.txt
unittest.exp i386/AArch64: Remove old xml tests 2019-07-04 11:55:20 +01:00
wrapper.c
wrapper.exp