binutils-gdb/gdb/gdbserver
Pedro Alves 8e9db26e29 x86 Linux watchpoints: Couldn't write debug register: Invalid argument.
This patch fixes this on x86 Linux:

 (gdb) watch *buf@2
 Hardware watchpoint 8: *buf@2
 (gdb) si
 0x00000000004005a7      34        for (i = 0; i < 100000; i++); /* stepi line */
 (gdb) del
 Delete all breakpoints? (y or n) y
 (gdb) watch *(buf+1)@1
 Hardware watchpoint 9: *(buf+1)@1
 (gdb) si
 0x00000000004005a7 in main () at ../../../src/gdb/testsuite/gdb.base/watchpoint-reuse-slot.c:34
 34        for (i = 0; i < 100000; i++); /* stepi line */
 Couldn't write debug register: Invalid argument.
 (gdb)

In the example above the debug registers are being switched from this
state:

        CONTROL (DR7): 0000000000050101          STATUS (DR6): 0000000000000000
        DR0: addr=0x0000000000601040, ref.count=1  DR1: addr=0x0000000000000000, ref.count=0
        DR2: addr=0x0000000000000000, ref.count=0  DR3: addr=0x0000000000000000, ref.count=0

to this:

        CONTROL (DR7): 0000000000010101          STATUS (DR6): 0000000000000000
        DR0: addr=0x0000000000601041, ref.count=1  DR1: addr=0x0000000000000000, ref.count=0
        DR2: addr=0x0000000000000000, ref.count=0  DR3: addr=0x0000000000000000, ref.count=0

That is, before, DR7 was setup for watching a 2 byte region starting
at what's in DR0 (0x601040).

And after, DR7 is setup for watching a 1 byte region starting at
what's in DR0 (0x601041).

We always write DR0..DR3 before DR7, because if we enable a slot's
bits in DR7, you need to have already written the corresponding
DR0..DR3 registers -- the kernel rejects the DR7 write with EINVAL
otherwise.

The error shown above is the opposite scenario.  When we try to write
0x601041 to DR0, DR7's bits still indicate intent of watching a 2-byte
region.  That DR0/DR7 combination is invalid, because 0x601041 is
unaligned.  To watch two bytes, we'd have to use two slots.  So the
kernel errors out with EINVAL.

Fix this by always first clearing DR7, then writing DR0..DR3, and then
setting DR7's bits.

A little optimization -- if we're disabling the last watchpoint, then
we can clear DR7 just once.  The changes to nat/i386-dregs.c make that
easier to detect, and as bonus, they make it a little easier to make
sense of DR7 in the debug logs, as we no longer need to remember we're
seeing stale bits.

Tested on x86_64 Fedora 20, native and GDBserver.

This adds an exhaustive test that switches between many different
combinations of watchpoint types and addresses and widths.

gdb/
2014-06-23  Pedro Alves  <palves@redhat.com>

	* amd64-linux-nat.c (amd64_linux_prepare_to_resume): Clear
	DR_CONTROL before setting DR0..DR3.
	* i386-linux-nat.c (i386_linux_prepare_to_resume): Likewise.
	* nat/i386-dregs.c (i386_remove_aligned_watchpoint): Clear all
	bits of DR_CONTROL related to the debug register slot being
	disabled.  If all slots are vacant, clear local slowdown as well,
	and assert DR_CONTROL is 0.

gdb/gdbserver/
2014-06-23  Pedro Alves  <palves@redhat.com>

	* linux-x86-low.c (x86_linux_prepare_to_resume): Clear DR_CONTROL
	before setting DR0..DR3.

gdb/testsuite/
2014-06-23  Pedro Alves  <palves@redhat.com>

	* gdb.base/watchpoint-reuse-slot.c: New file.
	* gdb.base/watchpoint-reuse-slot.exp: New file.
2014-06-23 16:44:04 +01:00
..
.gitignore
acinclude.m4
aclocal.m4
ax.c gdbserver: on GDB breakpoint reinsertion, also delete the breakpoint's commands. 2014-06-02 22:27:32 +01:00
ax.h gdbserver: on GDB breakpoint reinsertion, also delete the breakpoint's commands. 2014-06-02 22:27:32 +01:00
ChangeLog x86 Linux watchpoints: Couldn't write debug register: Invalid argument. 2014-06-23 16:44:04 +01:00
config.in Fix mingw32 build on x86-64 RHEL 6.5 2014-06-20 15:41:28 +01:00
configure Fix mingw32 build on x86-64 RHEL 6.5 2014-06-20 15:41:28 +01:00
configure.ac Fix mingw32 build on x86-64 RHEL 6.5 2014-06-20 15:41:28 +01:00
configure.srv Create nat/i386-dregs.c 2014-06-19 10:56:00 +01:00
debug.c link gdbserver against libiberty 2014-06-12 14:35:47 -06:00
debug.h
dll.c Replace code accessing list implementation details with API calls. 2014-02-19 15:30:38 -08:00
dll.h
event-loop.c
event-loop.h
gdb_proc_service.h
gdbreplay.c
gdbthread.h Add backlink from lwp_info to thread_info. 2014-02-19 16:38:44 -08:00
hostio-errno.c
hostio.c
hostio.h
i386-low.c Create nat/i386-dregs.c 2014-06-19 10:56:00 +01:00
i386-low.h Vectorize gdbserver x86 debug register accessors 2014-06-20 13:05:50 +01:00
i387-fp.c Add AVX512 registers support to GDB and GDBserver. 2014-04-24 16:30:03 +02:00
i387-fp.h
inferiors.c * inferiors.c (get_first_inferior): Fix buglet. 2014-02-20 11:11:34 -08:00
inferiors.h Teach GDBserver's Linux backend about no unwaited-for children (TARGET_WAITKIND_NO_RESUMED). 2014-02-27 14:30:08 +00:00
linux-aarch64-low.c Include asm/ptrace.h for linux-aarch64-low.c 2014-05-23 09:01:14 +01:00
linux-amd64-ipa.c
linux-arm-low.c [GDBserver] Make Zx/zx packet handling idempotent. 2014-05-20 18:42:30 +01:00
linux-bfin-low.c
linux-cris-low.c
linux-crisv32-low.c [GDBserver] Make Zx/zx packet handling idempotent. 2014-05-20 18:42:30 +01:00
linux-i386-ipa.c
linux-ia64-low.c
linux-low.c Move shared native target specific code to gdb/nat 2014-06-20 14:06:48 +01:00
linux-low.h Move shared native target specific code to gdb/nat 2014-06-20 14:06:48 +01:00
linux-m32r-low.c
linux-m68k-low.c
linux-mips-low.c Move shared native target specific code to gdb/nat 2014-06-20 14:06:48 +01:00
linux-nios2-low.c
linux-ppc-low.c [GDBserver] Make Zx/zx packet handling idempotent. 2014-05-20 18:42:30 +01:00
linux-s390-low.c [GDBserver] Make Zx/zx packet handling idempotent. 2014-05-20 18:42:30 +01:00
linux-sh-low.c
linux-sparc-low.c [GDBserver] Make Zx/zx packet handling idempotent. 2014-05-20 18:42:30 +01:00
linux-tic6x-low.c
linux-tile-low.c Remove all_lwps global. 2014-02-20 12:25:18 -08:00
linux-x86-low.c x86 Linux watchpoints: Couldn't write debug register: Invalid argument. 2014-06-23 16:44:04 +01:00
linux-xtensa-low.c
lynx-i386-low.c
lynx-low.c [GDBserver] Make Zx/zx packet handling idempotent. 2014-05-20 18:42:30 +01:00
lynx-low.h
lynx-ppc-low.c
Makefile.in Move shared native target specific code to gdb/nat 2014-06-20 14:06:48 +01:00
mem-break.c gdbserver crash if the_target->supports_z_point_type is NULL 2014-06-04 17:57:21 -04:00
mem-break.h gdbserver: on GDB breakpoint reinsertion, also delete the breakpoint's commands. 2014-06-02 22:27:32 +01:00
notif.c
notif.h
nto-low.c [GDBserver] Make Zx/zx packet handling idempotent. 2014-05-20 18:42:30 +01:00
nto-low.h
nto-x86-low.c
proc-service.c Remove all_lwps global. 2014-02-20 12:25:18 -08:00
proc-service.list
README
regcache.c
regcache.h
remote-utils.c
remote-utils.h
server.c link gdbserver against libiberty 2014-06-12 14:35:47 -06:00
server.h
spu-low.c [GDBserver] Make Zx/zx packet handling idempotent. 2014-05-20 18:42:30 +01:00
target.c Replace code accessing list implementation details with API calls. 2014-02-19 15:30:38 -08:00
target.h [GDBserver] Make Zx/zx packet handling idempotent. 2014-05-20 18:42:30 +01:00
tdesc.c
tdesc.h
terminal.h
thread-db.c Move shared native target specific code to gdb/nat 2014-06-20 14:06:48 +01:00
tracepoint.c Replace code accessing list implementation details with API calls. 2014-02-19 15:30:38 -08:00
tracepoint.h
utils.c delete gdbserver's freeargv 2014-06-12 14:35:49 -06:00
utils.h gdbserver: perror_with_name: Add ATTRIBUTE_NORETURN. 2014-04-23 17:29:54 +01:00
win32-arm-low.c [GDBserver] Make Zx/zx packet handling idempotent. 2014-05-20 18:42:30 +01:00
win32-i386-low.c Vectorize gdbserver x86 debug register accessors 2014-06-20 13:05:50 +01:00
win32-low.c [GDBserver] Make Zx/zx packet handling idempotent. 2014-05-20 18:42:30 +01:00
win32-low.h [GDBserver] Make Zx/zx packet handling idempotent. 2014-05-20 18:42:30 +01:00
wincecompat.c
wincecompat.h
xtensa-xtregs.c

		   README for GDBserver & GDBreplay
		    by Stu Grossman and Fred Fish

Introduction:

This is GDBserver, a remote server for Un*x-like systems.  It can be used to
control the execution of a program on a target system from a GDB on a different
host.  GDB and GDBserver communicate using the standard remote serial protocol
implemented in remote.c, and various *-stub.c files.  They communicate via
either a serial line or a TCP connection.

For more information about GDBserver, see the GDB manual.

Usage (server (target) side):

First, you need to have a copy of the program you want to debug put onto
the target system.  The program can be stripped to save space if needed, as
GDBserver doesn't care about symbols.  All symbol handling is taken care of by
the GDB running on the host system.

To use the server, you log on to the target system, and run the `gdbserver'
program.  You must tell it (a) how to communicate with GDB, (b) the name of
your program, and (c) its arguments.  The general syntax is:

	target> gdbserver COMM PROGRAM [ARGS ...]

For example, using a serial port, you might say:

	target> gdbserver /dev/com1 emacs foo.txt

This tells GDBserver to debug emacs with an argument of foo.txt, and to
communicate with GDB via /dev/com1.  GDBserver now waits patiently for the
host GDB to communicate with it.

To use a TCP connection, you could say:

	target> gdbserver host:2345 emacs foo.txt

This says pretty much the same thing as the last example, except that we are
going to communicate with the host GDB via TCP.  The `host:2345' argument means
that we are expecting to see a TCP connection from `host' to local TCP port
2345.  (Currently, the `host' part is ignored.)  You can choose any number you
want for the port number as long as it does not conflict with any existing TCP
ports on the target system.  This same port number must be used in the host
GDBs `target remote' command, which will be described shortly.  Note that if
you chose a port number that conflicts with another service, GDBserver will
print an error message and exit.

On some targets, GDBserver can also attach to running programs.  This is
accomplished via the --attach argument.  The syntax is:

	target> gdbserver --attach COMM PID

PID is the process ID of a currently running process.  It isn't necessary
to point GDBserver at a binary for the running process.

Usage (host side):

You need an unstripped copy of the target program on your host system, since
GDB needs to examine it's symbol tables and such.  Start up GDB as you normally
would, with the target program as the first argument.  (You may need to use the
--baud option if the serial line is running at anything except 9600 baud.)
Ie: `gdb TARGET-PROG', or `gdb --baud BAUD TARGET-PROG'.  After that, the only
new command you need to know about is `target remote'.  It's argument is either
a device name (usually a serial device, like `/dev/ttyb'), or a HOST:PORT
descriptor.  For example:

	(gdb) target remote /dev/ttyb

communicates with the server via serial line /dev/ttyb, and:

	(gdb) target remote the-target:2345

communicates via a TCP connection to port 2345 on host `the-target', where
you previously started up GDBserver with the same port number.  Note that for
TCP connections, you must start up GDBserver prior to using the `target remote'
command, otherwise you may get an error that looks something like
`Connection refused'.

Building GDBserver:

The supported targets as of November 2006 are:
	arm-*-linux*
	bfin-*-uclinux
	bfin-*-linux-uclibc
	crisv32-*-linux*
	cris-*-linux*
	i[34567]86-*-cygwin*
	i[34567]86-*-linux*
	i[34567]86-*-mingw*
	ia64-*-linux*
	m32r*-*-linux*
	m68*-*-linux*
	m68*-*-uclinux*
	mips*64*-*-linux*
	mips*-*-linux*
	powerpc[64]-*-linux*
	s390[x]-*-linux*
	sh-*-linux*
	spu*-*-*
	x86_64-*-linux*

Configuring GDBserver you should specify the same machine for host and
target (which are the machine that GDBserver is going to run on.  This
is not the same as the machine that GDB is going to run on; building
GDBserver automatically as part of building a whole tree of tools does
not currently work if cross-compilation is involved (we don't get the
right CC in the Makefile, to start with)).

Building GDBserver for your target is very straightforward.  If you build
GDB natively on a target which GDBserver supports, it will be built
automatically when you build GDB.  You can also build just GDBserver:

	% mkdir obj
	% cd obj
	% path-to-gdbserver-sources/configure
	% make

If you prefer to cross-compile to your target, then you can also build
GDBserver that way.  In a Bourne shell, for example:

	% export CC=your-cross-compiler
	% path-to-gdbserver-sources/configure your-target-name
	% make

Using GDBreplay:

A special hacked down version of GDBserver can be used to replay remote
debug log files created by GDB.  Before using the GDB "target" command to
initiate a remote debug session, use "set remotelogfile <filename>" to tell
GDB that you want to make a recording of the serial or tcp session.  Note
that when replaying the session, GDB communicates with GDBreplay via tcp,
regardless of whether the original session was via a serial link or tcp.

Once you are done with the remote debug session, start GDBreplay and
tell it the name of the log file and the host and port number that GDB
should connect to (typically the same as the host running GDB):

	$ gdbreplay logfile host:port

Then start GDB (preferably in a different screen or window) and use the
"target" command to connect to GDBreplay:

	(gdb) target remote host:port

Repeat the same sequence of user commands to GDB that you gave in the
original debug session.  GDB should not be able to tell that it is talking
to GDBreplay rather than a real target, all other things being equal.  Note
that GDBreplay echos the command lines to stderr, as well as the contents of
the packets it sends and receives.  The last command echoed by GDBreplay is
the next command that needs to be typed to GDB to continue the session in
sync with the original session.