192b62ce0b
This introduces a new specialization of gdb::ref_ptr that can be used to manage BFD reference counts. Then it changes most places in gdb to use this new class, rather than explicit reference-counting or cleanups. This patch removes make_cleanup_bfd_unref. If you look you will see a couple of spots using "release" where a use of gdb_bfd_ref_ptr would be cleaner. These will be fixed in the next patch. I think this patch fixes some latent bugs. For example, it seems to me that previously objfpy_add_separate_debug_file leaked a BFD. I'm not 100% certain that the macho_symfile_read_all_oso change is correct. The existing code here is hard for me to follow. One goal of this sort of automated reference counting, though, is to make it more difficult to make logic errors; so hopefully the code is clear now. 2017-01-10 Tom Tromey <tom@tromey.com> * windows-tdep.c (windows_xfer_shared_library): Update. * windows-nat.c (windows_make_so): Update. * utils.h (make_cleanup_bfd_unref): Remove. * utils.c (do_bfd_close_cleanup, make_cleanup_bfd_unref): Remove. * symfile.h (symfile_bfd_open) (find_separate_debug_file_in_section): Return gdb_bfd_ref_ptr. * symfile.c (read_symbols, symbol_file_add) (separate_debug_file_exists): Update. (symfile_bfd_open): Return gdb_bfd_ref_ptr. (generic_load, reread_symbols): Update. * symfile-mem.c (symbol_file_add_from_memory): Update. * spu-linux-nat.c (spu_bfd_open): Return gdb_bfd_ref_ptr. (spu_symbol_file_add_from_memory): Update. * solist.h (struct target_so_ops) <bfd_open>: Return gdb_bfd_ref_ptr. (solib_bfd_fopen, solib_bfd_open): Return gdb_bfd_ref_ptr. * solib.c (solib_bfd_fopen, solib_bfd_open): Return gdb_bfd_ref_ptr. (solib_map_sections, reload_shared_libraries_1): Update. * solib-svr4.c (enable_break): Update. * solib-spu.c (spu_bfd_fopen): Return gdb_bfd_ref_ptr. * solib-frv.c (enable_break2): Update. * solib-dsbt.c (enable_break): Update. * solib-darwin.c (gdb_bfd_mach_o_fat_extract): Return gdb_bfd_ref_ptr. (darwin_solib_get_all_image_info_addr_at_init): Update. (darwin_bfd_open): Return gdb_bfd_ref_ptr. * solib-aix.c (solib_aix_bfd_open): Return gdb_bfd_ref_ptr. * record-full.c (record_full_save): Update. * python/py-objfile.c (objfpy_add_separate_debug_file): Update. * procfs.c (insert_dbx_link_bpt_in_file): Update. * minidebug.c (find_separate_debug_file_in_section): Return gdb_bfd_ref_ptr. * machoread.c (macho_add_oso_symfile): Change abfd to gdb_bfd_ref_ptr. (macho_symfile_read_all_oso): Update. (macho_check_dsym): Return gdb_bfd_ref_ptr. (macho_symfile_read): Update. * jit.c (bfd_open_from_target_memory): Return gdb_bfd_ref_ptr. (jit_bfd_try_read_symtab): Update. * gdb_bfd.h (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr) (gdb_bfd_openw, gdb_bfd_openr_iovec) (gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return gdb_bfd_ref_ptr. (gdb_bfd_ref_policy): New struct. (gdb_bfd_ref_ptr): New typedef. * gdb_bfd.c (gdb_bfd_open, gdb_bfd_fopen, gdb_bfd_openr) (gdb_bfd_openw, gdb_bfd_openr_iovec) (gdb_bfd_openr_next_archived_file, gdb_bfd_fdopenr): Return gdb_bfd_ref_ptr. * gcore.h (create_gcore_bfd): Return gdb_bfd_ref_ptr. * gcore.c (create_gcore_bfd): Return gdb_bfd_ref_ptr. (gcore_command): Update. * exec.c (exec_file_attach): Update. * elfread.c (elf_symfile_read): Update. * dwarf2read.c (dwarf2_get_dwz_file): Update. (try_open_dwop_file, open_dwo_file): Return gdb_bfd_ref_ptr. (open_and_init_dwo_file): Update. (open_dwp_file): Return gdb_bfd_ref_ptr. (open_and_init_dwp_file): Update. * corelow.c (core_open): Update. * compile/compile-object-load.c (compile_object_load): Update. * common/gdb_ref_ptr.h (ref_ptr::operator->): New operator. * coffread.c (coff_symfile_read): Update. * cli/cli-dump.c (bfd_openr_or_error, bfd_openw_or_error): Return gdb_bfd_ref_ptr. Rename. (dump_bfd_file, restore_command): Update. * build-id.h (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr. * build-id.c (build_id_to_debug_bfd): Return gdb_bfd_ref_ptr. (find_separate_debug_file_by_buildid): Update.
394 lines
12 KiB
C++
394 lines
12 KiB
C++
/* *INDENT-OFF* */ /* ATTRIBUTE_PRINTF confuses indent, avoid running it
|
||
for now. */
|
||
/* I/O, string, cleanup, and other random utilities for GDB.
|
||
Copyright (C) 1986-2017 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#ifndef UTILS_H
|
||
#define UTILS_H
|
||
|
||
#include "exceptions.h"
|
||
#include "common/scoped_restore.h"
|
||
#include <chrono>
|
||
|
||
extern void initialize_utils (void);
|
||
|
||
/* String utilities. */
|
||
|
||
extern int sevenbit_strings;
|
||
|
||
extern int strcmp_iw (const char *, const char *);
|
||
|
||
extern int strcmp_iw_ordered (const char *, const char *);
|
||
|
||
extern int streq (const char *, const char *);
|
||
|
||
extern int subset_compare (char *, char *);
|
||
|
||
int compare_positive_ints (const void *ap, const void *bp);
|
||
int compare_strings (const void *ap, const void *bp);
|
||
|
||
/* A wrapper for bfd_errmsg to produce a more helpful error message
|
||
in the case of bfd_error_file_ambiguously recognized.
|
||
MATCHING, if non-NULL, is the corresponding argument to
|
||
bfd_check_format_matches, and will be freed. */
|
||
|
||
extern const char *gdb_bfd_errmsg (bfd_error_type error_tag, char **matching);
|
||
|
||
/* Reset the prompt_for_continue clock. */
|
||
void reset_prompt_for_continue_wait_time (void);
|
||
/* Return the time spent in prompt_for_continue. */
|
||
std::chrono::steady_clock::duration get_prompt_for_continue_wait_time ();
|
||
|
||
/* Parsing utilites. */
|
||
|
||
extern int parse_pid_to_attach (const char *args);
|
||
|
||
extern int parse_escape (struct gdbarch *, const char **);
|
||
|
||
char **gdb_buildargv (const char *);
|
||
|
||
/* Cleanup utilities. */
|
||
|
||
extern struct cleanup *make_cleanup_freeargv (char **);
|
||
|
||
struct ui_file;
|
||
extern struct cleanup *make_cleanup_ui_file_delete (struct ui_file *);
|
||
|
||
struct ui_out;
|
||
extern struct cleanup *
|
||
make_cleanup_ui_out_redirect_pop (struct ui_out *uiout);
|
||
|
||
struct section_addr_info;
|
||
extern struct cleanup *(make_cleanup_free_section_addr_info
|
||
(struct section_addr_info *));
|
||
|
||
/* For make_cleanup_close see common/filestuff.h. */
|
||
|
||
extern struct cleanup *make_cleanup_fclose (FILE *file);
|
||
|
||
struct obstack;
|
||
extern struct cleanup *make_cleanup_obstack_free (struct obstack *obstack);
|
||
|
||
extern struct cleanup *make_cleanup_restore_integer (int *variable);
|
||
extern struct cleanup *make_cleanup_restore_uinteger (unsigned int *variable);
|
||
|
||
struct target_ops;
|
||
extern struct cleanup *make_cleanup_unpush_target (struct target_ops *ops);
|
||
|
||
extern struct cleanup *make_cleanup_value_free_to_mark (struct value *);
|
||
extern struct cleanup *make_cleanup_value_free (struct value *);
|
||
|
||
struct so_list;
|
||
extern struct cleanup *make_cleanup_free_so (struct so_list *so);
|
||
|
||
extern struct cleanup *make_cleanup_restore_current_language (void);
|
||
|
||
/* A deleter for a hash table. */
|
||
struct htab_deleter
|
||
{
|
||
void operator() (htab *ptr) const
|
||
{
|
||
htab_delete (ptr);
|
||
}
|
||
};
|
||
|
||
/* A unique_ptr wrapper for htab_t. */
|
||
typedef std::unique_ptr<htab, htab_deleter> htab_up;
|
||
|
||
struct parser_state;
|
||
extern struct cleanup *make_cleanup_clear_parser_state
|
||
(struct parser_state **p);
|
||
|
||
extern void free_current_contents (void *);
|
||
|
||
extern void init_page_info (void);
|
||
|
||
extern struct cleanup *make_cleanup_restore_page_info (void);
|
||
extern struct cleanup *
|
||
set_batch_flag_and_make_cleanup_restore_page_info (void);
|
||
|
||
extern struct cleanup *make_bpstat_clear_actions_cleanup (void);
|
||
|
||
/* Path utilities. */
|
||
|
||
extern char *gdb_realpath (const char *);
|
||
|
||
extern char *gdb_realpath_keepfile (const char *);
|
||
|
||
extern char *gdb_abspath (const char *);
|
||
|
||
extern int gdb_filename_fnmatch (const char *pattern, const char *string,
|
||
int flags);
|
||
|
||
extern void substitute_path_component (char **stringp, const char *from,
|
||
const char *to);
|
||
|
||
char *ldirname (const char *filename);
|
||
|
||
extern int count_path_elements (const char *path);
|
||
|
||
extern const char *strip_leading_path_elements (const char *path, int n);
|
||
|
||
/* GDB output, ui_file utilities. */
|
||
|
||
struct ui_file;
|
||
|
||
extern int query (const char *, ...) ATTRIBUTE_PRINTF (1, 2);
|
||
extern int nquery (const char *, ...) ATTRIBUTE_PRINTF (1, 2);
|
||
extern int yquery (const char *, ...) ATTRIBUTE_PRINTF (1, 2);
|
||
|
||
extern void begin_line (void);
|
||
|
||
extern void wrap_here (const char *);
|
||
|
||
extern void reinitialize_more_filter (void);
|
||
|
||
extern int pagination_enabled;
|
||
|
||
extern struct ui_file **current_ui_gdb_stdout_ptr (void);
|
||
extern struct ui_file **current_ui_gdb_stdin_ptr (void);
|
||
extern struct ui_file **current_ui_gdb_stderr_ptr (void);
|
||
extern struct ui_file **current_ui_gdb_stdlog_ptr (void);
|
||
|
||
/* The current top level's ui_file streams. */
|
||
|
||
/* Normal results */
|
||
#define gdb_stdout (*current_ui_gdb_stdout_ptr ())
|
||
/* Input stream */
|
||
#define gdb_stdin (*current_ui_gdb_stdin_ptr ())
|
||
/* Serious error notifications */
|
||
#define gdb_stderr (*current_ui_gdb_stderr_ptr ())
|
||
/* Log/debug/trace messages that should bypass normal stdout/stderr
|
||
filtering. For moment, always call this stream using
|
||
*_unfiltered. In the very near future that restriction shall be
|
||
removed - either call shall be unfiltered. (cagney 1999-06-13). */
|
||
#define gdb_stdlog (*current_ui_gdb_stdlog_ptr ())
|
||
|
||
/* Truly global ui_file streams. These are all defined in main.c. */
|
||
|
||
/* Target output that should bypass normal stdout/stderr filtering.
|
||
For moment, always call this stream using *_unfiltered. In the
|
||
very near future that restriction shall be removed - either call
|
||
shall be unfiltered. (cagney 1999-07-02). */
|
||
extern struct ui_file *gdb_stdtarg;
|
||
extern struct ui_file *gdb_stdtargerr;
|
||
extern struct ui_file *gdb_stdtargin;
|
||
|
||
/* Set the screen dimensions to WIDTH and HEIGHT. */
|
||
|
||
extern void set_screen_width_and_height (int width, int height);
|
||
|
||
/* More generic printf like operations. Filtered versions may return
|
||
non-locally on error. */
|
||
|
||
extern void fputs_filtered (const char *, struct ui_file *);
|
||
|
||
extern void fputs_unfiltered (const char *, struct ui_file *);
|
||
|
||
extern int fputc_filtered (int c, struct ui_file *);
|
||
|
||
extern int fputc_unfiltered (int c, struct ui_file *);
|
||
|
||
extern int putchar_filtered (int c);
|
||
|
||
extern int putchar_unfiltered (int c);
|
||
|
||
extern void puts_filtered (const char *);
|
||
|
||
extern void puts_unfiltered (const char *);
|
||
|
||
extern void puts_filtered_tabular (char *string, int width, int right);
|
||
|
||
extern void puts_debug (char *prefix, char *string, char *suffix);
|
||
|
||
extern void vprintf_filtered (const char *, va_list) ATTRIBUTE_PRINTF (1, 0);
|
||
|
||
extern void vfprintf_filtered (struct ui_file *, const char *, va_list)
|
||
ATTRIBUTE_PRINTF (2, 0);
|
||
|
||
extern void fprintf_filtered (struct ui_file *, const char *, ...)
|
||
ATTRIBUTE_PRINTF (2, 3);
|
||
|
||
extern void fprintfi_filtered (int, struct ui_file *, const char *, ...)
|
||
ATTRIBUTE_PRINTF (3, 4);
|
||
|
||
extern void printf_filtered (const char *, ...) ATTRIBUTE_PRINTF (1, 2);
|
||
|
||
extern void printfi_filtered (int, const char *, ...) ATTRIBUTE_PRINTF (2, 3);
|
||
|
||
extern void vprintf_unfiltered (const char *, va_list) ATTRIBUTE_PRINTF (1, 0);
|
||
|
||
extern void vfprintf_unfiltered (struct ui_file *, const char *, va_list)
|
||
ATTRIBUTE_PRINTF (2, 0);
|
||
|
||
extern void fprintf_unfiltered (struct ui_file *, const char *, ...)
|
||
ATTRIBUTE_PRINTF (2, 3);
|
||
|
||
extern void printf_unfiltered (const char *, ...) ATTRIBUTE_PRINTF (1, 2);
|
||
|
||
extern void print_spaces (int, struct ui_file *);
|
||
|
||
extern void print_spaces_filtered (int, struct ui_file *);
|
||
|
||
extern char *n_spaces (int);
|
||
|
||
extern void fputstr_filtered (const char *str, int quotr,
|
||
struct ui_file * stream);
|
||
|
||
extern void fputstr_unfiltered (const char *str, int quotr,
|
||
struct ui_file * stream);
|
||
|
||
extern void fputstrn_filtered (const char *str, int n, int quotr,
|
||
struct ui_file * stream);
|
||
|
||
extern void fputstrn_unfiltered (const char *str, int n, int quotr,
|
||
struct ui_file * stream);
|
||
|
||
/* Return nonzero if filtered printing is initialized. */
|
||
extern int filtered_printing_initialized (void);
|
||
|
||
/* Display the host ADDR on STREAM formatted as ``0x%x''. */
|
||
extern void gdb_print_host_address_1 (const void *addr, struct ui_file *stream);
|
||
|
||
/* Wrapper that avoids adding a pointless cast to all callers. */
|
||
#define gdb_print_host_address(ADDR, STREAM) \
|
||
gdb_print_host_address_1 ((const void *) ADDR, STREAM)
|
||
|
||
/* Convert CORE_ADDR to string in platform-specific manner.
|
||
This is usually formatted similar to 0x%lx. */
|
||
extern const char *paddress (struct gdbarch *gdbarch, CORE_ADDR addr);
|
||
|
||
/* Return a string representation in hexadecimal notation of ADDRESS,
|
||
which is suitable for printing. */
|
||
|
||
extern const char *print_core_address (struct gdbarch *gdbarch,
|
||
CORE_ADDR address);
|
||
|
||
/* Callback hash_f and eq_f for htab_create_alloc or htab_create_alloc_ex. */
|
||
extern hashval_t core_addr_hash (const void *ap);
|
||
extern int core_addr_eq (const void *ap, const void *bp);
|
||
|
||
extern CORE_ADDR string_to_core_addr (const char *my_string);
|
||
|
||
extern void fprintf_symbol_filtered (struct ui_file *, const char *,
|
||
enum language, int);
|
||
|
||
extern void throw_perror_with_name (enum errors errcode, const char *string)
|
||
ATTRIBUTE_NORETURN;
|
||
|
||
extern void perror_warning_with_name (const char *string);
|
||
|
||
extern void print_sys_errmsg (const char *, int);
|
||
|
||
/* Warnings and error messages. */
|
||
|
||
extern void (*deprecated_error_begin_hook) (void);
|
||
|
||
/* Message to be printed before the warning message, when a warning occurs. */
|
||
|
||
extern char *warning_pre_print;
|
||
|
||
extern void error_stream (struct ui_file *) ATTRIBUTE_NORETURN;
|
||
|
||
extern void demangler_vwarning (const char *file, int line,
|
||
const char *, va_list ap)
|
||
ATTRIBUTE_PRINTF (3, 0);
|
||
|
||
extern void demangler_warning (const char *file, int line,
|
||
const char *, ...) ATTRIBUTE_PRINTF (3, 4);
|
||
|
||
|
||
/* Misc. utilities. */
|
||
|
||
/* Allocation and deallocation functions for the libiberty hash table
|
||
which use obstacks. */
|
||
void *hashtab_obstack_allocate (void *data, size_t size, size_t count);
|
||
void dummy_obstack_deallocate (void *object, void *data);
|
||
|
||
#ifdef HAVE_WAITPID
|
||
extern pid_t wait_to_die_with_timeout (pid_t pid, int *status, int timeout);
|
||
#endif
|
||
|
||
extern int producer_is_gcc_ge_4 (const char *producer);
|
||
extern int producer_is_gcc (const char *producer, int *major, int *minor);
|
||
|
||
extern int myread (int, char *, int);
|
||
|
||
/* Ensure that V is aligned to an N byte boundary (B's assumed to be a
|
||
power of 2). Round up/down when necessary. Examples of correct
|
||
use include:
|
||
|
||
addr = align_up (addr, 8); -- VALUE needs 8 byte alignment
|
||
write_memory (addr, value, len);
|
||
addr += len;
|
||
|
||
and:
|
||
|
||
sp = align_down (sp - len, 16); -- Keep SP 16 byte aligned
|
||
write_memory (sp, value, len);
|
||
|
||
Note that uses such as:
|
||
|
||
write_memory (addr, value, len);
|
||
addr += align_up (len, 8);
|
||
|
||
and:
|
||
|
||
sp -= align_up (len, 8);
|
||
write_memory (sp, value, len);
|
||
|
||
are typically not correct as they don't ensure that the address (SP
|
||
or ADDR) is correctly aligned (relying on previous alignment to
|
||
keep things right). This is also why the methods are called
|
||
"align_..." instead of "round_..." as the latter reads better with
|
||
this incorrect coding style. */
|
||
|
||
extern ULONGEST align_up (ULONGEST v, int n);
|
||
extern ULONGEST align_down (ULONGEST v, int n);
|
||
|
||
/* Resource limits used by getrlimit and setrlimit. */
|
||
|
||
enum resource_limit_kind
|
||
{
|
||
LIMIT_CUR,
|
||
LIMIT_MAX
|
||
};
|
||
|
||
/* Check whether GDB will be able to dump core using the dump_core
|
||
function. Returns zero if GDB cannot or should not dump core.
|
||
If LIMIT_KIND is LIMIT_CUR the user's soft limit will be respected.
|
||
If LIMIT_KIND is LIMIT_MAX only the hard limit will be respected. */
|
||
|
||
extern int can_dump_core (enum resource_limit_kind limit_kind);
|
||
|
||
/* Print a warning that we cannot dump core. */
|
||
|
||
extern void warn_cant_dump_core (const char *reason);
|
||
|
||
/* Dump core trying to increase the core soft limit to hard limit
|
||
first. */
|
||
|
||
extern void dump_core (void);
|
||
|
||
/* Return the hex string form of LENGTH bytes of DATA.
|
||
Space for the result is malloc'd, caller must free. */
|
||
|
||
extern char *make_hex_string (const gdb_byte *data, size_t length);
|
||
|
||
#endif /* UTILS_H */
|