dccbb60975
This commit includes gdb_assert.h in common-defs.h and removes all other inclusions. gdb/ 2014-08-07 Gary Benson <gbenson@redhat.com> * common/common-defs.h: Include gdb_assert.h. * aarch64-tdep.c: Do not include gdb_assert.h. * addrmap.c: Likewise. * aix-thread.c: Likewise. * alpha-linux-tdep.c: Likewise. * alpha-mdebug-tdep.c: Likewise. * alphanbsd-tdep.c: Likewise. * amd64-nat.c: Likewise. * amd64-tdep.c: Likewise. * amd64bsd-nat.c: Likewise. * amd64fbsd-nat.c: Likewise. * amd64fbsd-tdep.c: Likewise. * amd64nbsd-nat.c: Likewise. * amd64nbsd-tdep.c: Likewise. * amd64obsd-nat.c: Likewise. * amd64obsd-tdep.c: Likewise. * arch-utils.c: Likewise. * arm-tdep.c: Likewise. * armbsd-tdep.c: Likewise. * auxv.c: Likewise. * bcache.c: Likewise. * bfin-tdep.c: Likewise. * blockframe.c: Likewise. * breakpoint.c: Likewise. * bsd-kvm.c: Likewise. * bsd-uthread.c: Likewise. * buildsym.c: Likewise. * c-exp.y: Likewise. * c-lang.c: Likewise. * charset.c: Likewise. * cleanups.c: Likewise. * cli-out.c: Likewise. * cli/cli-decode.c: Likewise. * cli/cli-dump.c: Likewise. * cli/cli-logging.c: Likewise. * cli/cli-script.c: Likewise. * cli/cli-utils.c: Likewise. * coffread.c: Likewise. * common/common-utils.c: Likewise. * common/queue.h: Likewise. * common/signals.c: Likewise. * common/vec.h: Likewise. * complaints.c: Likewise. * completer.c: Likewise. * corelow.c: Likewise. * cp-abi.c: Likewise. * cp-name-parser.y: Likewise. * cp-namespace.c: Likewise. * cp-support.c: Likewise. * cris-tdep.c: Likewise. * dbxread.c: Likewise. * dictionary.c: Likewise. * doublest.c: Likewise. * dsrec.c: Likewise. * dummy-frame.c: Likewise. * dwarf2-frame-tailcall.c: Likewise. * dwarf2-frame.c: Likewise. * dwarf2expr.c: Likewise. * dwarf2loc.c: Likewise. * dwarf2read.c: Likewise. * eval.c: Likewise. * event-loop.c: Likewise. * exceptions.c: Likewise. * expprint.c: Likewise. * f-valprint.c: Likewise. * fbsd-nat.c: Likewise. * findvar.c: Likewise. * frame-unwind.c: Likewise. * frame.c: Likewise. * frv-tdep.c: Likewise. * gcore.c: Likewise. * gdb-dlfcn.c: Likewise. * gdb_bfd.c: Likewise. * gdbarch.c: Likewise. * gdbarch.sh: Likewise. * gdbtypes.c: Likewise. * gnu-nat.c: Likewise. * gnu-v3-abi.c: Likewise. * go-lang.c: Likewise. * guile/scm-exception.c: Likewise. * guile/scm-gsmob.c: Likewise. * guile/scm-lazy-string.c: Likewise. * guile/scm-math.c: Likewise. * guile/scm-pretty-print.c: Likewise. * guile/scm-safe-call.c: Likewise. * guile/scm-utils.c: Likewise. * guile/scm-value.c: Likewise. * h8300-tdep.c: Likewise. * hppa-hpux-nat.c: Likewise. * hppa-tdep.c: Likewise. * hppanbsd-tdep.c: Likewise. * hppaobsd-tdep.c: Likewise. * i386-darwin-nat.c: Likewise. * i386-darwin-tdep.c: Likewise. * i386-nto-tdep.c: Likewise. * i386-tdep.c: Likewise. * i386bsd-nat.c: Likewise. * i386fbsd-tdep.c: Likewise. * i386gnu-nat.c: Likewise. * i386nbsd-tdep.c: Likewise. * i386obsd-tdep.c: Likewise. * i387-tdep.c: Likewise. * ia64-libunwind-tdep.c: Likewise. * ia64-tdep.c: Likewise. * inf-ptrace.c: Likewise. * inf-ttrace.c: Likewise. * infcall.c: Likewise. * infcmd.c: Likewise. * infrun.c: Likewise. * inline-frame.c: Likewise. * interps.c: Likewise. * jv-lang.c: Likewise. * jv-typeprint.c: Likewise. * linux-fork.c: Likewise. * linux-nat.c: Likewise. * linux-thread-db.c: Likewise. * m32c-tdep.c: Likewise. * m32r-linux-nat.c: Likewise. * m32r-tdep.c: Likewise. * m68k-tdep.c: Likewise. * m68kbsd-nat.c: Likewise. * m68kbsd-tdep.c: Likewise. * m88k-tdep.c: Likewise. * machoread.c: Likewise. * macroexp.c: Likewise. * macrotab.c: Likewise. * maint.c: Likewise. * mdebugread.c: Likewise. * memory-map.c: Likewise. * mep-tdep.c: Likewise. * mi/mi-common.c: Likewise. * microblaze-tdep.c: Likewise. * mingw-hdep.c: Likewise. * mips-linux-nat.c: Likewise. * mips-linux-tdep.c: Likewise. * mips-tdep.c: Likewise. * mips64obsd-tdep.c: Likewise. * mipsnbsd-tdep.c: Likewise. * mn10300-linux-tdep.c: Likewise. * mn10300-tdep.c: Likewise. * moxie-tdep.c: Likewise. * mt-tdep.c: Likewise. * nat/linux-btrace.c: Likewise. * nat/linux-osdata.c: Likewise. * nat/linux-ptrace.c: Likewise. * nat/mips-linux-watch.c: Likewise. * nios2-linux-tdep.c: Likewise. * nios2-tdep.c: Likewise. * objc-lang.c: Likewise. * objfiles.c: Likewise. * obsd-nat.c: Likewise. * opencl-lang.c: Likewise. * osabi.c: Likewise. * parse.c: Likewise. * ppc-linux-nat.c: Likewise. * ppc-sysv-tdep.c: Likewise. * ppcfbsd-nat.c: Likewise. * ppcfbsd-tdep.c: Likewise. * ppcnbsd-nat.c: Likewise. * ppcnbsd-tdep.c: Likewise. * ppcobsd-nat.c: Likewise. * ppcobsd-tdep.c: Likewise. * printcmd.c: Likewise. * procfs.c: Likewise. * prologue-value.c: Likewise. * psymtab.c: Likewise. * python/py-lazy-string.c: Likewise. * python/py-value.c: Likewise. * regcache.c: Likewise. * reggroups.c: Likewise. * registry.c: Likewise. * remote-sim.c: Likewise. * remote.c: Likewise. * rs6000-aix-tdep.c: Likewise. * rs6000-tdep.c: Likewise. * s390-linux-tdep.c: Likewise. * score-tdep.c: Likewise. * ser-base.c: Likewise. * ser-mingw.c: Likewise. * sh-tdep.c: Likewise. * sh64-tdep.c: Likewise. * solib-darwin.c: Likewise. * solib-spu.c: Likewise. * solib-svr4.c: Likewise. * source.c: Likewise. * sparc-nat.c: Likewise. * sparc-sol2-tdep.c: Likewise. * sparc-tdep.c: Likewise. * sparc64-sol2-tdep.c: Likewise. * sparc64-tdep.c: Likewise. * sparc64fbsd-tdep.c: Likewise. * sparc64nbsd-tdep.c: Likewise. * sparc64obsd-tdep.c: Likewise. * sparcnbsd-tdep.c: Likewise. * sparcobsd-tdep.c: Likewise. * spu-multiarch.c: Likewise. * spu-tdep.c: Likewise. * stabsread.c: Likewise. * stack.c: Likewise. * symfile.c: Likewise. * symtab.c: Likewise. * target-descriptions.c: Likewise. * target-memory.c: Likewise. * target.c: Likewise. * tic6x-linux-tdep.c: Likewise. * tic6x-tdep.c: Likewise. * tilegx-linux-nat.c: Likewise. * tilegx-tdep.c: Likewise. * top.c: Likewise. * tramp-frame.c: Likewise. * tui/tui-out.c: Likewise. * tui/tui-winsource.c: Likewise. * ui-out.c: Likewise. * user-regs.c: Likewise. * utils.c: Likewise. * v850-tdep.c: Likewise. * valops.c: Likewise. * value.c: Likewise. * varobj.c: Likewise. * vax-nat.c: Likewise. * xml-syscall.c: Likewise. * xml-tdesc.c: Likewise. * xstormy16-tdep.c: Likewise. * xtensa-linux-nat.c: Likewise. * xtensa-tdep.c: Likewise. gdb/gdbserver/ 2014-08-07 Gary Benson <gbenson@redhat.com> * server.h: Do not include gdb_assert.h.
333 lines
9.6 KiB
C
333 lines
9.6 KiB
C
/* Support for complaint handling during symbol reading in GDB.
|
|
|
|
Copyright (C) 1990-2014 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "complaints.h"
|
|
#include "command.h"
|
|
#include "gdbcmd.h"
|
|
|
|
extern void _initialize_complaints (void);
|
|
|
|
/* Should each complaint message be self explanatory, or should we
|
|
assume that a series of complaints is being produced? */
|
|
|
|
/* case 1: First message of a series that must
|
|
start off with explanation. case 2: Subsequent message of a series
|
|
that needs no explanation (the user already knows we have a problem
|
|
so we can just state our piece). */
|
|
enum complaint_series {
|
|
/* Isolated self explanatory message. */
|
|
ISOLATED_MESSAGE,
|
|
/* First message of a series, includes an explanation. */
|
|
FIRST_MESSAGE,
|
|
/* First message of a series, but does not need to include any sort
|
|
of explanation. */
|
|
SHORT_FIRST_MESSAGE,
|
|
/* Subsequent message of a series that needs no explanation (the
|
|
user already knows we have a problem so we can just state our
|
|
piece). */
|
|
SUBSEQUENT_MESSAGE
|
|
};
|
|
|
|
/* Structure to manage complaints about symbol file contents. */
|
|
|
|
struct complain
|
|
{
|
|
const char *file;
|
|
int line;
|
|
const char *fmt;
|
|
int counter;
|
|
struct complain *next;
|
|
};
|
|
|
|
/* The explanatory message that should accompany the complaint. The
|
|
message is in two parts - pre and post - that are printed around
|
|
the complaint text. */
|
|
struct explanation
|
|
{
|
|
const char *prefix;
|
|
const char *postfix;
|
|
};
|
|
|
|
struct complaints
|
|
{
|
|
struct complain *root;
|
|
|
|
/* Should each complaint be self explanatory, or should we assume
|
|
that a series of complaints is being produced? case 0: Isolated
|
|
self explanatory message. case 1: First message of a series that
|
|
must start off with explanation. case 2: Subsequent message of a
|
|
series that needs no explanation (the user already knows we have
|
|
a problem so we can just state our piece). */
|
|
int series;
|
|
|
|
/* The explanatory messages that should accompany the complaint.
|
|
NOTE: cagney/2002-08-14: In a desperate attempt at being vaguely
|
|
i18n friendly, this is an array of two messages. When present,
|
|
the PRE and POST EXPLANATION[SERIES] are used to wrap the
|
|
message. */
|
|
const struct explanation *explanation;
|
|
};
|
|
|
|
static struct complain complaint_sentinel;
|
|
|
|
/* The symbol table complaint table. */
|
|
|
|
static struct explanation symfile_explanations[] = {
|
|
{ "During symbol reading, ", "." },
|
|
{ "During symbol reading...", "..."},
|
|
{ "", "..."},
|
|
{ "", "..."},
|
|
{ NULL, NULL }
|
|
};
|
|
|
|
static struct complaints symfile_complaint_book = {
|
|
&complaint_sentinel,
|
|
0,
|
|
symfile_explanations
|
|
};
|
|
struct complaints *symfile_complaints = &symfile_complaint_book;
|
|
|
|
/* Wrapper function to, on-demand, fill in a complaints object. */
|
|
|
|
static struct complaints *
|
|
get_complaints (struct complaints **c)
|
|
{
|
|
if ((*c) != NULL)
|
|
return (*c);
|
|
(*c) = XNEW (struct complaints);
|
|
(*c)->root = &complaint_sentinel;
|
|
(*c)->series = ISOLATED_MESSAGE;
|
|
(*c)->explanation = NULL;
|
|
return (*c);
|
|
}
|
|
|
|
static struct complain * ATTRIBUTE_PRINTF (4, 0)
|
|
find_complaint (struct complaints *complaints, const char *file,
|
|
int line, const char *fmt)
|
|
{
|
|
struct complain *complaint;
|
|
|
|
/* Find the complaint in the table. A more efficient search
|
|
algorithm (based on hash table or something) could be used. But
|
|
that can wait until someone shows evidence that this lookup is
|
|
a real bottle neck. */
|
|
for (complaint = complaints->root;
|
|
complaint != NULL;
|
|
complaint = complaint->next)
|
|
{
|
|
if (complaint->fmt == fmt
|
|
&& complaint->file == file
|
|
&& complaint->line == line)
|
|
return complaint;
|
|
}
|
|
|
|
/* Oops not seen before, fill in a new complaint. */
|
|
complaint = XNEW (struct complain);
|
|
complaint->fmt = fmt;
|
|
complaint->file = file;
|
|
complaint->line = line;
|
|
complaint->counter = 0;
|
|
complaint->next = NULL;
|
|
|
|
/* File it, return it. */
|
|
complaint->next = complaints->root;
|
|
complaints->root = complaint;
|
|
return complaint;
|
|
}
|
|
|
|
|
|
/* How many complaints about a particular thing should be printed
|
|
before we stop whining about it? Default is no whining at all,
|
|
since so many systems have ill-constructed symbol files. */
|
|
|
|
static int stop_whining = 0;
|
|
|
|
/* Print a complaint, and link the complaint block into a chain for
|
|
later handling. */
|
|
|
|
static void ATTRIBUTE_PRINTF (4, 0)
|
|
vcomplaint (struct complaints **c, const char *file,
|
|
int line, const char *fmt,
|
|
va_list args)
|
|
{
|
|
struct complaints *complaints = get_complaints (c);
|
|
struct complain *complaint = find_complaint (complaints, file,
|
|
line, fmt);
|
|
enum complaint_series series;
|
|
|
|
gdb_assert (complaints != NULL);
|
|
|
|
complaint->counter++;
|
|
if (complaint->counter > stop_whining)
|
|
return;
|
|
|
|
if (info_verbose)
|
|
series = SUBSEQUENT_MESSAGE;
|
|
else
|
|
series = complaints->series;
|
|
|
|
if (complaint->file != NULL)
|
|
internal_vwarning (complaint->file, complaint->line,
|
|
complaint->fmt, args);
|
|
else if (deprecated_warning_hook)
|
|
(*deprecated_warning_hook) (complaint->fmt, args);
|
|
else
|
|
{
|
|
if (complaints->explanation == NULL)
|
|
/* A [v]warning() call always appends a newline. */
|
|
vwarning (complaint->fmt, args);
|
|
else
|
|
{
|
|
char *msg;
|
|
struct cleanup *cleanups;
|
|
msg = xstrvprintf (complaint->fmt, args);
|
|
cleanups = make_cleanup (xfree, msg);
|
|
wrap_here ("");
|
|
if (series != SUBSEQUENT_MESSAGE)
|
|
begin_line ();
|
|
/* XXX: i18n */
|
|
fprintf_filtered (gdb_stderr, "%s%s%s",
|
|
complaints->explanation[series].prefix, msg,
|
|
complaints->explanation[series].postfix);
|
|
/* Force a line-break after any isolated message. For the
|
|
other cases, clear_complaints() takes care of any missing
|
|
trailing newline, the wrap_here() is just a hint. */
|
|
if (series == ISOLATED_MESSAGE)
|
|
/* It would be really nice to use begin_line() here.
|
|
Unfortunately that function doesn't track GDB_STDERR and
|
|
consequently will sometimes supress a line when it
|
|
shouldn't. */
|
|
fputs_filtered ("\n", gdb_stderr);
|
|
else
|
|
wrap_here ("");
|
|
do_cleanups (cleanups);
|
|
}
|
|
}
|
|
|
|
switch (series)
|
|
{
|
|
case ISOLATED_MESSAGE:
|
|
break;
|
|
case FIRST_MESSAGE:
|
|
complaints->series = SUBSEQUENT_MESSAGE;
|
|
break;
|
|
case SUBSEQUENT_MESSAGE:
|
|
case SHORT_FIRST_MESSAGE:
|
|
complaints->series = SUBSEQUENT_MESSAGE;
|
|
break;
|
|
}
|
|
|
|
/* If GDB dumps core, we'd like to see the complaints first.
|
|
Presumably GDB will not be sending so many complaints that this
|
|
becomes a performance hog. */
|
|
|
|
gdb_flush (gdb_stderr);
|
|
}
|
|
|
|
void
|
|
complaint (struct complaints **complaints, const char *fmt, ...)
|
|
{
|
|
va_list args;
|
|
|
|
va_start (args, fmt);
|
|
vcomplaint (complaints, NULL/*file*/, 0/*line*/, fmt, args);
|
|
va_end (args);
|
|
}
|
|
|
|
void
|
|
internal_complaint (struct complaints **complaints, const char *file,
|
|
int line, const char *fmt, ...)
|
|
{
|
|
va_list args;
|
|
va_start (args, fmt);
|
|
vcomplaint (complaints, file, line, fmt, args);
|
|
va_end (args);
|
|
}
|
|
|
|
/* Clear out / initialize all complaint counters that have ever been
|
|
incremented. If LESS_VERBOSE is 1, be less verbose about
|
|
successive complaints, since the messages are appearing all
|
|
together during a command that is reporting a contiguous block of
|
|
complaints (rather than being interleaved with other messages). If
|
|
noisy is 1, we are in a noisy command, and our caller will print
|
|
enough context for the user to figure it out. */
|
|
|
|
void
|
|
clear_complaints (struct complaints **c, int less_verbose, int noisy)
|
|
{
|
|
struct complaints *complaints = get_complaints (c);
|
|
struct complain *p;
|
|
|
|
for (p = complaints->root; p != NULL; p = p->next)
|
|
{
|
|
p->counter = 0;
|
|
}
|
|
|
|
switch (complaints->series)
|
|
{
|
|
case FIRST_MESSAGE:
|
|
/* Haven't yet printed anything. */
|
|
break;
|
|
case SHORT_FIRST_MESSAGE:
|
|
/* Haven't yet printed anything. */
|
|
break;
|
|
case ISOLATED_MESSAGE:
|
|
/* The code above, always forces a line-break. No need to do it
|
|
here. */
|
|
break;
|
|
case SUBSEQUENT_MESSAGE:
|
|
/* It would be really nice to use begin_line() here.
|
|
Unfortunately that function doesn't track GDB_STDERR and
|
|
consequently will sometimes supress a line when it
|
|
shouldn't. */
|
|
fputs_unfiltered ("\n", gdb_stderr);
|
|
break;
|
|
default:
|
|
internal_error (__FILE__, __LINE__, _("bad switch"));
|
|
}
|
|
|
|
if (!less_verbose)
|
|
complaints->series = ISOLATED_MESSAGE;
|
|
else if (!noisy)
|
|
complaints->series = FIRST_MESSAGE;
|
|
else
|
|
complaints->series = SHORT_FIRST_MESSAGE;
|
|
}
|
|
|
|
static void
|
|
complaints_show_value (struct ui_file *file, int from_tty,
|
|
struct cmd_list_element *cmd, const char *value)
|
|
{
|
|
fprintf_filtered (file, _("Max number of complaints about incorrect"
|
|
" symbols is %s.\n"),
|
|
value);
|
|
}
|
|
|
|
void
|
|
_initialize_complaints (void)
|
|
{
|
|
add_setshow_zinteger_cmd ("complaints", class_support,
|
|
&stop_whining, _("\
|
|
Set max number of complaints about incorrect symbols."), _("\
|
|
Show max number of complaints about incorrect symbols."), NULL,
|
|
NULL, complaints_show_value,
|
|
&setlist, &showlist);
|
|
}
|