bef155c3e8
This introduces a new class, gdb::unlinker, that unlinks a file in the destructor. The user of this class has the option to preserve the file instead, by calling the "keep" method. This patch then changes the spots in gdb that use unlink in a cleanup to use this class instead. In one spot I went ahead and removed all the cleanups from the function. This fixes one latent bug -- do_bfd_delete_cleanup could refer to freed memory, by decref'ing the BFD before using its filename. 2017-01-10 Tom Tromey <tom@tromey.com> * record-full.c (record_full_save_cleanups): Remove. (record_full_save): Use gdb::unlinker. * gcore.c (do_bfd_delete_cleanup): Remove. (gcore_command): Use gdb::unlinker, unique_xmalloc_ptr. Remove cleanups. * dwarf2read.c (unlink_if_set): Remove. (write_psymtabs_to_index): Use gdb::unlinker. * common/gdb_unlinker.h: New file. |
||
---|---|---|
.. | ||
agent.c | ||
agent.h | ||
ax.def | ||
break-common.h | ||
btrace-common.c | ||
btrace-common.h | ||
buffer.c | ||
buffer.h | ||
cleanups.c | ||
cleanups.h | ||
common-debug.c | ||
common-debug.h | ||
common-defs.h | ||
common-exceptions.c | ||
common-exceptions.h | ||
common-regcache.c | ||
common-regcache.h | ||
common-types.h | ||
common-utils.c | ||
common-utils.h | ||
common.host | ||
common.m4 | ||
create-version.sh | ||
enum-flags.h | ||
errors.c | ||
errors.h | ||
fileio.c | ||
fileio.h | ||
filestuff.c | ||
filestuff.h | ||
format.c | ||
format.h | ||
gdb_assert.h | ||
gdb_locale.h | ||
gdb_ref_ptr.h | ||
gdb_setjmp.h | ||
gdb_signals.h | ||
gdb_sys_time.h | ||
gdb_unique_ptr.h | ||
gdb_unlinker.h | ||
gdb_vecs.c | ||
gdb_vecs.h | ||
gdb_wait.h | ||
host-defs.h | ||
mingw-strerror.c | ||
new-op.c | ||
posix-strerror.c | ||
print-utils.c | ||
print-utils.h | ||
ptid.c | ||
ptid.h | ||
queue.h | ||
rsp-low.c | ||
rsp-low.h | ||
run-time-clock.c | ||
run-time-clock.h | ||
scoped_restore.h | ||
signals-state-save-restore.c | ||
signals-state-save-restore.h | ||
signals.c | ||
symbol.h | ||
vec.c | ||
vec.h | ||
version.h | ||
x86-xstate.h | ||
xml-utils.c | ||
xml-utils.h |