bf47e2482d
Running gdbserver --debug under Valgrind shows: ==4803== Invalid read of size 4 ==4803== at 0x432B62: linux_write_memory (linux-low.c:5320) ==4803== by 0x4143F7: write_inferior_memory (target.c:83) ==4803== by 0x415895: remove_memory_breakpoint (mem-break.c:362) ==4803== by 0x432EF5: linux_remove_point (linux-low.c:5460) ==4803== by 0x416319: delete_raw_breakpoint (mem-break.c:802) ==4803== by 0x4163F3: release_breakpoint (mem-break.c:842) ==4803== by 0x416477: delete_breakpoint_1 (mem-break.c:869) ==4803== by 0x4164EF: delete_breakpoint (mem-break.c:891) ==4803== by 0x416843: delete_gdb_breakpoint_1 (mem-break.c:1069) ==4803== by 0x4168D8: delete_gdb_breakpoint (mem-break.c:1098) ==4803== by 0x4134E3: process_serial_event (server.c:4051) ==4803== by 0x4138E4: handle_serial_event (server.c:4196) ==4803== Address 0x4c6b930 is 0 bytes inside a block of size 1 alloc'd ==4803== at 0x4A0645D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==4803== by 0x4240C6: xmalloc (common-utils.c:43) ==4803== by 0x41439C: write_inferior_memory (target.c:80) ==4803== by 0x415895: remove_memory_breakpoint (mem-break.c:362) ==4803== by 0x432EF5: linux_remove_point (linux-low.c:5460) ==4803== by 0x416319: delete_raw_breakpoint (mem-break.c:802) ==4803== by 0x4163F3: release_breakpoint (mem-break.c:842) ==4803== by 0x416477: delete_breakpoint_1 (mem-break.c:869) ==4803== by 0x4164EF: delete_breakpoint (mem-break.c:891) ==4803== by 0x416843: delete_gdb_breakpoint_1 (mem-break.c:1069) ==4803== by 0x4168D8: delete_gdb_breakpoint (mem-break.c:1098) ==4803== by 0x4134E3: process_serial_event (server.c:4051) ==4803== And: ==7272== Conditional jump or move depends on uninitialised value(s) ==7272== at 0x3615E48361: vfprintf (vfprintf.c:1634) ==7272== by 0x414E89: debug_vprintf (debug.c:60) ==7272== by 0x42800A: debug_printf (common-debug.c:35) ==7272== by 0x43937B: my_waitpid (linux-waitpid.c:149) ==7272== by 0x42D740: linux_wait_for_event_filtered (linux-low.c:2441) ==7272== by 0x42DADA: linux_wait_for_event (linux-low.c:2552) ==7272== by 0x42E165: linux_wait_1 (linux-low.c:2860) ==7272== by 0x42F5D8: linux_wait (linux-low.c:3453) ==7272== by 0x4144A4: mywait (target.c:107) ==7272== by 0x413969: handle_target_event (server.c:4214) ==7272== by 0x41A1A6: handle_file_event (event-loop.c:429) ==7272== by 0x41996D: process_event (event-loop.c:184) gdb/ChangeLog: 2015-08-06 Pedro Alves <palves@redhat.com> * nat/linux-waitpid.c (my_waitpid): Only print *status if waitpid returned > 0. gdb/gdbserver/ChangeLog: 2015-08-06 Pedro Alves <palves@redhat.com> * linux-low.c (linux_write_memory): Rewrite debug output to avoid reading beyond the passed in buffer length.
152 lines
3.7 KiB
C
152 lines
3.7 KiB
C
/* Wrapper implementation for waitpid for GNU/Linux (LWP layer).
|
|
|
|
Copyright (C) 2001-2015 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "common-defs.h"
|
|
|
|
#ifdef GDBSERVER
|
|
/* FIXME: server.h is required for the definition of debug_threads
|
|
which is used in the gdbserver-specific debug printing in
|
|
linux_debug. This code should be made available to GDB also,
|
|
but the lack of a suitable flag to enable it prevents this. */
|
|
#include "server.h"
|
|
#endif
|
|
|
|
#include "linux-nat.h"
|
|
#include "linux-waitpid.h"
|
|
#include "gdb_wait.h"
|
|
|
|
/* Print debugging output based on the format string FORMAT and
|
|
its parameters. */
|
|
|
|
static inline void
|
|
linux_debug (const char *format, ...)
|
|
{
|
|
#ifdef GDBSERVER
|
|
if (debug_threads)
|
|
{
|
|
va_list args;
|
|
va_start (args, format);
|
|
vfprintf (stderr, format, args);
|
|
va_end (args);
|
|
}
|
|
#endif
|
|
}
|
|
|
|
/* Convert wait status STATUS to a string. Used for printing debug
|
|
messages only. */
|
|
|
|
char *
|
|
status_to_str (int status)
|
|
{
|
|
static char buf[64];
|
|
|
|
if (WIFSTOPPED (status))
|
|
{
|
|
if (WSTOPSIG (status) == SYSCALL_SIGTRAP)
|
|
snprintf (buf, sizeof (buf), "%s (stopped at syscall)",
|
|
strsignal (SIGTRAP));
|
|
else
|
|
snprintf (buf, sizeof (buf), "%s (stopped)",
|
|
strsignal (WSTOPSIG (status)));
|
|
}
|
|
else if (WIFSIGNALED (status))
|
|
snprintf (buf, sizeof (buf), "%s (terminated)",
|
|
strsignal (WTERMSIG (status)));
|
|
else
|
|
snprintf (buf, sizeof (buf), "%d (exited)", WEXITSTATUS (status));
|
|
|
|
return buf;
|
|
}
|
|
|
|
/* Wrapper function for waitpid which handles EINTR, and emulates
|
|
__WALL for systems where that is not available. */
|
|
|
|
int
|
|
my_waitpid (int pid, int *status, int flags)
|
|
{
|
|
int ret, out_errno;
|
|
|
|
linux_debug ("my_waitpid (%d, 0x%x)\n", pid, flags);
|
|
|
|
if (flags & __WALL)
|
|
{
|
|
sigset_t block_mask, org_mask, wake_mask;
|
|
int wnohang;
|
|
|
|
wnohang = (flags & WNOHANG) != 0;
|
|
flags &= ~(__WALL | __WCLONE);
|
|
|
|
if (!wnohang)
|
|
{
|
|
flags |= WNOHANG;
|
|
|
|
/* Block all signals while here. This avoids knowing about
|
|
LinuxThread's signals. */
|
|
sigfillset (&block_mask);
|
|
sigprocmask (SIG_BLOCK, &block_mask, &org_mask);
|
|
|
|
/* ... except during the sigsuspend below. */
|
|
sigemptyset (&wake_mask);
|
|
}
|
|
|
|
while (1)
|
|
{
|
|
/* Since all signals are blocked, there's no need to check
|
|
for EINTR here. */
|
|
ret = waitpid (pid, status, flags);
|
|
out_errno = errno;
|
|
|
|
if (ret == -1 && out_errno != ECHILD)
|
|
break;
|
|
else if (ret > 0)
|
|
break;
|
|
|
|
if (flags & __WCLONE)
|
|
{
|
|
/* We've tried both flavors now. If WNOHANG is set,
|
|
there's nothing else to do, just bail out. */
|
|
if (wnohang)
|
|
break;
|
|
|
|
linux_debug ("blocking\n");
|
|
|
|
/* Block waiting for signals. */
|
|
sigsuspend (&wake_mask);
|
|
}
|
|
flags ^= __WCLONE;
|
|
}
|
|
|
|
if (!wnohang)
|
|
sigprocmask (SIG_SETMASK, &org_mask, NULL);
|
|
}
|
|
else
|
|
{
|
|
do
|
|
ret = waitpid (pid, status, flags);
|
|
while (ret == -1 && errno == EINTR);
|
|
out_errno = errno;
|
|
}
|
|
|
|
linux_debug ("my_waitpid (%d, 0x%x): status(%x), %d\n",
|
|
pid, flags, (ret > 0 && status != NULL) ? *status : -1, ret);
|
|
|
|
errno = out_errno;
|
|
return ret;
|
|
}
|