466eeceef4
I have the goal of "poisoning" the XNEW/xfree-family of functions, so that we catch their usages with non-POD types. A few things need to be fixed in the mean time, this is one. The common lwp code in linux-nat.c and gdbserver/linux-low.c xfrees the private lwp data of type arch_lwp_info. However, that type is opaque from its point of view, as its defined differently in each arch-specific implementation. This trips on the std::is_pod<T> check, since the compiler can't tell whether the type is POD or not if it doesn't know about it. My initial patch [1] made a class hierarchy with a virtual destructor. However, as Pedro pointed out, we only have one native architecture at the time built in gdb and gdbserver, so that's overkill. Instead, we can move the responsibility of free'ing arch_lwp_info to the arch code (which is also the one that allocated it in the first place). This is what this patch does. Also, I had the concern that if we wanted to use C++ features in these structures, we would have a problem with the one-definition rule. However, since a build will only have one version of arch_lwp_info, that's not a problem. There are changes in arch-specific files, I was only able to built-test this patch with the following cross-compilers: aarch64-linux-gnu alpha-linux-gnu arm-linux-gnueabihf hppa-linux-gnu m68k-linux-gnu mips64el-linux-gnuabi64 powerpc64-linux-gnu s390x-linux-gnu sh4-linux-gnu sparc64-linux-gnu x86_64-linux-gnu x86_64-w64-mingw32 A buildbot run didn't find any regression. [1] https://sourceware.org/ml/gdb-patches/2017-08/msg00255.html gdb/ChangeLog: * linux-nat.h (linux_nat_set_delete_thread): New declaration. * linux-nat.c (linux_nat_delete_thread): New variable. (lwp_free): Invoke linux_nat_delete_thread if set. (linux_nat_set_delete_thread): New function. * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Assign thread delete callback. * arm-linux-nat.c (arm_linux_delete_thread): New function. (_initialize_arm_linux_nat): Assign thread delete callback. * s390-linux-nat.c (s390_delete_thread): New function. (_initialize_s390_nat): Assign thread delete callback. * x86-linux-nat.c (x86_linux_add_target): Likewise. * nat/aarch64-linux.c (aarch64_linux_delete_thread): New function. * nat/aarch64-linux.h (aarch64_linux_delete_thread): New declaration. * nat/x86-linux.c (x86_linux_delete_thread): New function. * nat/x86-linux.h (x86_linux_delete_thread): New declaration. gdb/gdbserver/ChangeLog: * linux-aarch64-low.c (the_low_target): Add thread delete callback. * linux-arm-low.c (arm_delete_thread): New function. (the_low_target): Add thread delete callback. * linux-bfin-low.c (the_low_target): Likewise. * linux-crisv32-low.c (the_low_target): Likewise. * linux-low.c (delete_lwp): Invoke delete_thread callback if set. * linux-low.h (struct linux_target_ops) <delete_thread>: New field. * linux-m32r-low.c (the_low_target): Add thread delete callback. * linux-mips-low.c (mips_linux_delete_thread): New function. (the_low_target): Add thread delete callback. * linux-ppc-low.c (the_low_target): Likewise. * linux-s390-low.c (the_low_target): Likewise. * linux-sh-low.c (the_low_target): Likewise. * linux-tic6x-low.c (the_low_target): Likewise. * linux-tile-low.c (the_low_target): Likewise. * linux-x86-low.c (the_low_target): Likewise. * linux-xtensa-low.c (the_low_target): Likewise.
248 lines
6.3 KiB
C
248 lines
6.3 KiB
C
/* Copyright (C) 2009-2017 Free Software Foundation, Inc.
|
|
Contributed by ARM Ltd.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "common-defs.h"
|
|
#include "break-common.h"
|
|
#include "nat/linux-nat.h"
|
|
#include "nat/aarch64-linux-hw-point.h"
|
|
#include "nat/aarch64-linux.h"
|
|
|
|
#include "elf/common.h"
|
|
#include "nat/gdb_ptrace.h"
|
|
#include <asm/ptrace.h>
|
|
#include <sys/uio.h>
|
|
|
|
/* Called when resuming a thread LWP.
|
|
The hardware debug registers are updated when there is any change. */
|
|
|
|
void
|
|
aarch64_linux_prepare_to_resume (struct lwp_info *lwp)
|
|
{
|
|
struct arch_lwp_info *info = lwp_arch_private_info (lwp);
|
|
|
|
/* NULL means this is the main thread still going through the shell,
|
|
or, no watchpoint has been set yet. In that case, there's
|
|
nothing to do. */
|
|
if (info == NULL)
|
|
return;
|
|
|
|
if (DR_HAS_CHANGED (info->dr_changed_bp)
|
|
|| DR_HAS_CHANGED (info->dr_changed_wp))
|
|
{
|
|
ptid_t ptid = ptid_of_lwp (lwp);
|
|
int tid = ptid_get_lwp (ptid);
|
|
struct aarch64_debug_reg_state *state
|
|
= aarch64_get_debug_reg_state (ptid_get_pid (ptid));
|
|
|
|
if (show_debug_regs)
|
|
debug_printf ("prepare_to_resume thread %d\n", tid);
|
|
|
|
/* Watchpoints. */
|
|
if (DR_HAS_CHANGED (info->dr_changed_wp))
|
|
{
|
|
aarch64_linux_set_debug_regs (state, tid, 1);
|
|
DR_CLEAR_CHANGED (info->dr_changed_wp);
|
|
}
|
|
|
|
/* Breakpoints. */
|
|
if (DR_HAS_CHANGED (info->dr_changed_bp))
|
|
{
|
|
aarch64_linux_set_debug_regs (state, tid, 0);
|
|
DR_CLEAR_CHANGED (info->dr_changed_bp);
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Function to call when a new thread is detected. */
|
|
|
|
void
|
|
aarch64_linux_new_thread (struct lwp_info *lwp)
|
|
{
|
|
struct arch_lwp_info *info = XNEW (struct arch_lwp_info);
|
|
|
|
/* Mark that all the hardware breakpoint/watchpoint register pairs
|
|
for this thread need to be initialized (with data from
|
|
aarch_process_info.debug_reg_state). */
|
|
DR_MARK_ALL_CHANGED (info->dr_changed_bp, aarch64_num_bp_regs);
|
|
DR_MARK_ALL_CHANGED (info->dr_changed_wp, aarch64_num_wp_regs);
|
|
|
|
lwp_set_arch_private_info (lwp, info);
|
|
}
|
|
|
|
/* See nat/aarch64-linux.h. */
|
|
|
|
void
|
|
aarch64_linux_delete_thread (struct arch_lwp_info *arch_lwp)
|
|
{
|
|
xfree (arch_lwp);
|
|
}
|
|
|
|
/* Convert native siginfo FROM to the siginfo in the layout of the
|
|
inferior's architecture TO. */
|
|
|
|
void
|
|
aarch64_compat_siginfo_from_siginfo (compat_siginfo_t *to, siginfo_t *from)
|
|
{
|
|
memset (to, 0, sizeof (*to));
|
|
|
|
to->si_signo = from->si_signo;
|
|
to->si_errno = from->si_errno;
|
|
to->si_code = from->si_code;
|
|
|
|
if (to->si_code == SI_TIMER)
|
|
{
|
|
to->cpt_si_timerid = from->si_timerid;
|
|
to->cpt_si_overrun = from->si_overrun;
|
|
to->cpt_si_ptr = (intptr_t) from->si_ptr;
|
|
}
|
|
else if (to->si_code == SI_USER)
|
|
{
|
|
to->cpt_si_pid = from->si_pid;
|
|
to->cpt_si_uid = from->si_uid;
|
|
}
|
|
else if (to->si_code < 0)
|
|
{
|
|
to->cpt_si_pid = from->si_pid;
|
|
to->cpt_si_uid = from->si_uid;
|
|
to->cpt_si_ptr = (intptr_t) from->si_ptr;
|
|
}
|
|
else
|
|
{
|
|
switch (to->si_signo)
|
|
{
|
|
case SIGCHLD:
|
|
to->cpt_si_pid = from->si_pid;
|
|
to->cpt_si_uid = from->si_uid;
|
|
to->cpt_si_status = from->si_status;
|
|
to->cpt_si_utime = from->si_utime;
|
|
to->cpt_si_stime = from->si_stime;
|
|
break;
|
|
case SIGILL:
|
|
case SIGFPE:
|
|
case SIGSEGV:
|
|
case SIGBUS:
|
|
to->cpt_si_addr = (intptr_t) from->si_addr;
|
|
break;
|
|
case SIGPOLL:
|
|
to->cpt_si_band = from->si_band;
|
|
to->cpt_si_fd = from->si_fd;
|
|
break;
|
|
default:
|
|
to->cpt_si_pid = from->si_pid;
|
|
to->cpt_si_uid = from->si_uid;
|
|
to->cpt_si_ptr = (intptr_t) from->si_ptr;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Convert inferior's architecture siginfo FROM to native siginfo TO. */
|
|
|
|
void
|
|
aarch64_siginfo_from_compat_siginfo (siginfo_t *to, compat_siginfo_t *from)
|
|
{
|
|
memset (to, 0, sizeof (*to));
|
|
|
|
to->si_signo = from->si_signo;
|
|
to->si_errno = from->si_errno;
|
|
to->si_code = from->si_code;
|
|
|
|
if (to->si_code == SI_TIMER)
|
|
{
|
|
to->si_timerid = from->cpt_si_timerid;
|
|
to->si_overrun = from->cpt_si_overrun;
|
|
to->si_ptr = (void *) (intptr_t) from->cpt_si_ptr;
|
|
}
|
|
else if (to->si_code == SI_USER)
|
|
{
|
|
to->si_pid = from->cpt_si_pid;
|
|
to->si_uid = from->cpt_si_uid;
|
|
}
|
|
if (to->si_code < 0)
|
|
{
|
|
to->si_pid = from->cpt_si_pid;
|
|
to->si_uid = from->cpt_si_uid;
|
|
to->si_ptr = (void *) (intptr_t) from->cpt_si_ptr;
|
|
}
|
|
else
|
|
{
|
|
switch (to->si_signo)
|
|
{
|
|
case SIGCHLD:
|
|
to->si_pid = from->cpt_si_pid;
|
|
to->si_uid = from->cpt_si_uid;
|
|
to->si_status = from->cpt_si_status;
|
|
to->si_utime = from->cpt_si_utime;
|
|
to->si_stime = from->cpt_si_stime;
|
|
break;
|
|
case SIGILL:
|
|
case SIGFPE:
|
|
case SIGSEGV:
|
|
case SIGBUS:
|
|
to->si_addr = (void *) (intptr_t) from->cpt_si_addr;
|
|
break;
|
|
case SIGPOLL:
|
|
to->si_band = from->cpt_si_band;
|
|
to->si_fd = from->cpt_si_fd;
|
|
break;
|
|
default:
|
|
to->si_pid = from->cpt_si_pid;
|
|
to->si_uid = from->cpt_si_uid;
|
|
to->si_ptr = (void* ) (intptr_t) from->cpt_si_ptr;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Called by libthread_db. Returns a pointer to the thread local
|
|
storage (or its descriptor). */
|
|
|
|
ps_err_e
|
|
aarch64_ps_get_thread_area (struct ps_prochandle *ph,
|
|
lwpid_t lwpid, int idx, void **base,
|
|
int is_64bit_p)
|
|
{
|
|
struct iovec iovec;
|
|
uint64_t reg64;
|
|
uint32_t reg32;
|
|
|
|
if (is_64bit_p)
|
|
{
|
|
iovec.iov_base = ®64;
|
|
iovec.iov_len = sizeof (reg64);
|
|
}
|
|
else
|
|
{
|
|
iovec.iov_base = ®32;
|
|
iovec.iov_len = sizeof (reg32);
|
|
}
|
|
|
|
if (ptrace (PTRACE_GETREGSET, lwpid, NT_ARM_TLS, &iovec) != 0)
|
|
return PS_ERR;
|
|
|
|
/* IDX is the bias from the thread pointer to the beginning of the
|
|
thread descriptor. It has to be subtracted due to implementation
|
|
quirks in libthread_db. */
|
|
if (is_64bit_p)
|
|
*base = (void *) (reg64 - idx);
|
|
else
|
|
*base = (void *) (uintptr_t) (reg32 - idx);
|
|
|
|
return PS_OK;
|
|
}
|