d82b3862f1
As mentioned here: https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Avoid_non-const_reference_parameters.2C_use_pointers_instead we prefer to avoid non-const references. This patch changes the non-const references I could find in the compile/ directory, either by making them rvalue-reference (&&) or changing them to pointers. I'd say all the changes are pretty obvious, except the one in compile_cplus_instance::enter_scope which might require more attention. gdb/ChangeLog: * compile/compile-c.h (generate_c_for_variable_locations): Change reference to pointer. * compile/compile-c-support.c (compile_program) <compute>: Likewise. * compile/compile-c-symbols.c (generate_vla_size): Likewise. (generate_c_for_for_one_variable): Likewise (generate_c_for_variable_locations): Likewise * compile/compile-c-types.c (compile_c_instance::convert_type): Likewise * compile/compile-cplus-symbols.c (convert_one_symbol): std::move the scope passed to enter_scope. * compile/compile-cplus-types.c (compile_cplus_instance::enter_scope): Make parameter rvalue-reference. (compile_cplus_instance::new_scope): Change reference to pointer. (compile_cplus_instance::convert_type): Likewise (compile_cplus_convert_typedef): std::move the scope passed to enter_scope. (compile_cplus_convert_struct_or_union): Likewise. (compile_cplus_convert_enum): Likewise. (compile_cplus_convert_namespace): Likewise. * compile/compile-cplus.h (compile_cplus_instance) <enter_scope>: Make parameter rvalue-reference. * compile/compile-internal.h (compile_instance) <get_cached_type>: Likewise * compile/compile-loc2c.c (push): Likewise (pushf): Likewise (unary): Likewise (binary): Likewise (print_label): Likewise (pushf_register_address): Likewise (pushf_register): Likewise (do_compile_dwarf_expr_to_c): Likewise (compile_dwarf_expr_to_c): Likewise (compile_dwarf_bounds_to_c): Likewise * compile/compile.c (compile_instance::get_cached_type): Likewise * compile/compile.h (compile_dwarf_expr_to_c): Likewise. (compile_dwarf_bounds_to_c): Likewise * dwarf2loc.c (locexpr_generate_c_location): Likewise. (dwarf2_compile_property_to_c): Likewise * dwarf2loc.h (dwarf2_compile_property_to_c): Likewise * symtab.h (struct symbol_computed_ops) <generate_c_location>: Likewise
96 lines
3.0 KiB
C++
96 lines
3.0 KiB
C++
/* Header file for GDB compile C-language support.
|
|
Copyright (C) 2014-2018 Free Software Foundation, Inc.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef GDB_COMPILE_C_H
|
|
#define GDB_COMPILE_C_H
|
|
|
|
#include "common/enum-flags.h"
|
|
#include "gcc-c-plugin.h"
|
|
|
|
/* enum-flags wrapper. */
|
|
|
|
DEF_ENUM_FLAGS_TYPE (enum gcc_qualifiers, gcc_qualifiers_flags);
|
|
|
|
/* A callback suitable for use as the GCC C symbol oracle. */
|
|
|
|
extern gcc_c_oracle_function gcc_convert_symbol;
|
|
|
|
/* A callback suitable for use as the GCC C address oracle. */
|
|
|
|
extern gcc_c_symbol_address_function gcc_symbol_address;
|
|
|
|
/* A subclass of compile_instance that is specific to the C front
|
|
end. */
|
|
|
|
class compile_c_instance : public compile_instance
|
|
{
|
|
public:
|
|
explicit compile_c_instance (struct gcc_c_context *gcc_c)
|
|
: compile_instance (&gcc_c->base, m_default_cflags),
|
|
m_plugin (gcc_c)
|
|
{
|
|
m_plugin.set_callbacks (gcc_convert_symbol, gcc_symbol_address, this);
|
|
}
|
|
|
|
/* Convert a gdb type, TYPE, to a GCC type.
|
|
|
|
The new GCC type is returned. */
|
|
gcc_type convert_type (struct type *type);
|
|
|
|
/* Return a handle for the GCC plug-in. */
|
|
gcc_c_plugin &plugin () { return m_plugin; }
|
|
|
|
private:
|
|
/* Default compiler flags for C. */
|
|
static const char *m_default_cflags;
|
|
|
|
/* The GCC plug-in. */
|
|
gcc_c_plugin m_plugin;
|
|
};
|
|
|
|
/* Emit code to compute the address for all the local variables in
|
|
scope at PC in BLOCK. Returns a malloc'd vector, indexed by gdb
|
|
register number, where each element indicates if the corresponding
|
|
register is needed to compute a local variable. */
|
|
|
|
extern gdb::unique_xmalloc_ptr<unsigned char>
|
|
generate_c_for_variable_locations
|
|
(compile_instance *compiler,
|
|
string_file *stream,
|
|
struct gdbarch *gdbarch,
|
|
const struct block *block,
|
|
CORE_ADDR pc);
|
|
|
|
/* Get the GCC mode attribute value for a given type size. */
|
|
|
|
extern const char *c_get_mode_for_size (int size);
|
|
|
|
/* Given a dynamic property, return an xmallocd name that is used to
|
|
represent its size. The result must be freed by the caller. The
|
|
contents of the resulting string will be the same each time for
|
|
each call with the same argument. */
|
|
|
|
struct dynamic_prop;
|
|
extern std::string c_get_range_decl_name (const struct dynamic_prop *prop);
|
|
|
|
/* Compute the name of the pointer representing a local symbol's
|
|
address. */
|
|
|
|
extern gdb::unique_xmalloc_ptr<char>
|
|
c_symbol_substitution_name (struct symbol *sym);
|
|
|
|
#endif /* GDB_COMPILE_C_H */
|