6c2659886f
I'd like to enable the -Wmissing-declarations warning. However, it
warns for every _initialize function, for example:
CXX dcache.o
/home/smarchi/src/binutils-gdb/gdb/dcache.c: In function ‘void _initialize_dcache()’:
/home/smarchi/src/binutils-gdb/gdb/dcache.c:688:1: error: no previous declaration for ‘void _initialize_dcache()’ [-Werror=missing-declarations]
_initialize_dcache (void)
^~~~~~~~~~~~~~~~~~
The only practical way forward I found is to add back the declarations,
which were removed by this commit:
commit 481695ed5f
Author: John Baldwin <jhb@FreeBSD.org>
Date: Sat Sep 9 11:02:37 2017 -0700
Remove unnecessary function prototypes.
I don't think it's a big problem to have the declarations for these
functions, but if anybody has a better solution for this, I'll be happy
to use it.
gdb/ChangeLog:
* aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
* aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
* aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
* aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
* aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
* ada-exp.y (_initialize_ada_exp): Add declaration.
* ada-lang.c (_initialize_ada_language): Add declaration.
* ada-tasks.c (_initialize_tasks): Add declaration.
* agent.c (_initialize_agent): Add declaration.
* aix-thread.c (_initialize_aix_thread): Add declaration.
* alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
* alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
* alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
* alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
* alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
* alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
* amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
* amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
* amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
* amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
* amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
* amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
* amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
* amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
* amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
* amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
* amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
* amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
* amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
* amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
* annotate.c (_initialize_annotate): Add declaration.
* arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
* arc-tdep.c (_initialize_arc_tdep): Add declaration.
* arch-utils.c (_initialize_gdbarch_utils): Add declaration.
* arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
* arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
* arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
* arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
* arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
* arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
* arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
* arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
* arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
* arm-tdep.c (_initialize_arm_tdep): Add declaration.
* arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
* auto-load.c (_initialize_auto_load): Add declaration.
* auxv.c (_initialize_auxv): Add declaration.
* avr-tdep.c (_initialize_avr_tdep): Add declaration.
* ax-gdb.c (_initialize_ax_gdb): Add declaration.
* bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
* bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
* break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
* break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
* break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
* breakpoint.c (_initialize_breakpoint): Add declaration.
* bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
* btrace.c (_initialize_btrace): Add declaration.
* charset.c (_initialize_charset): Add declaration.
* cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
* cli/cli-dump.c (_initialize_cli_dump): Add declaration.
* cli/cli-interp.c (_initialize_cli_interp): Add declaration.
* cli/cli-logging.c (_initialize_cli_logging): Add declaration.
* cli/cli-script.c (_initialize_cli_script): Add declaration.
* cli/cli-style.c (_initialize_cli_style): Add declaration.
* coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
* coffread.c (_initialize_coffread): Add declaration.
* compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
* compile/compile.c (_initialize_compile): Add declaration.
* complaints.c (_initialize_complaints): Add declaration.
* completer.c (_initialize_completer): Add declaration.
* copying.c (_initialize_copying): Add declaration.
* corefile.c (_initialize_core): Add declaration.
* corelow.c (_initialize_corelow): Add declaration.
* cp-abi.c (_initialize_cp_abi): Add declaration.
* cp-namespace.c (_initialize_cp_namespace): Add declaration.
* cp-support.c (_initialize_cp_support): Add declaration.
* cp-valprint.c (_initialize_cp_valprint): Add declaration.
* cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
* cris-tdep.c (_initialize_cris_tdep): Add declaration.
* csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
* csky-tdep.c (_initialize_csky_tdep): Add declaration.
* ctfread.c (_initialize_ctfread): Add declaration.
* d-lang.c (_initialize_d_language): Add declaration.
* darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
* darwin-nat.c (_initialize_darwin_nat): Add declaration.
* dbxread.c (_initialize_dbxread): Add declaration.
* dcache.c (_initialize_dcache): Add declaration.
* disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
* disasm.c (_initialize_disasm): Add declaration.
* dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
* dummy-frame.c (_initialize_dummy_frame): Add declaration.
* dwarf-index-cache.c (_initialize_index_cache): Add declaration.
* dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
* dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
* dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
* dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
* dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
* dwarf2read.c (_initialize_dwarf2_read): Add declaration.
* elfread.c (_initialize_elfread): Add declaration.
* exec.c (_initialize_exec): Add declaration.
* extension.c (_initialize_extension): Add declaration.
* f-lang.c (_initialize_f_language): Add declaration.
* f-valprint.c (_initialize_f_valprint): Add declaration.
* fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
* fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
* filesystem.c (_initialize_filesystem): Add declaration.
* findcmd.c (_initialize_mem_search): Add declaration.
* findvar.c (_initialize_findvar): Add declaration.
* fork-child.c (_initialize_fork_child): Add declaration.
* frame-base.c (_initialize_frame_base): Add declaration.
* frame-unwind.c (_initialize_frame_unwind): Add declaration.
* frame.c (_initialize_frame): Add declaration.
* frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
* frv-tdep.c (_initialize_frv_tdep): Add declaration.
* ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
* gcore.c (_initialize_gcore): Add declaration.
* gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
* gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
* gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
* gdbarch.c (_initialize_gdbarch): Add declaration.
* gdbtypes.c (_initialize_gdbtypes): Add declaration.
* gnu-nat.c (_initialize_gnu_nat): Add declaration.
* gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
* gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
* go-lang.c (_initialize_go_language): Add declaration.
* go32-nat.c (_initialize_go32_nat): Add declaration.
* guile/guile.c (_initialize_guile): Add declaration.
* h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
* hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
* hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
* hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
* hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
* hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
* hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
* hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
* i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
* i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
* i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
* i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
* i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
* i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
* i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
* i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
* i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
* i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
* i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
* i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
* i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
* i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
* i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
* i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
* i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
* i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
* i386-tdep.c (_initialize_i386_tdep): Add declaration.
* i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
* ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
* ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
* ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
* ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
* ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
* infcall.c (_initialize_infcall): Add declaration.
* infcmd.c (_initialize_infcmd): Add declaration.
* inflow.c (_initialize_inflow): Add declaration.
* infrun.c (_initialize_infrun): Add declaration.
* interps.c (_initialize_interpreter): Add declaration.
* iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
* jit.c (_initialize_jit): Add declaration.
* language.c (_initialize_language): Add declaration.
* linux-fork.c (_initialize_linux_fork): Add declaration.
* linux-nat.c (_initialize_linux_nat): Add declaration.
* linux-tdep.c (_initialize_linux_tdep): Add declaration.
* linux-thread-db.c (_initialize_thread_db): Add declaration.
* lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
* m2-lang.c (_initialize_m2_language): Add declaration.
* m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
* m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
* m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
* m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
* m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
* m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
* m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
* m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
* m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
* m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
* machoread.c (_initialize_machoread): Add declaration.
* macrocmd.c (_initialize_macrocmd): Add declaration.
* macroscope.c (_initialize_macroscope): Add declaration.
* maint-test-options.c (_initialize_maint_test_options): Add declaration.
* maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
* maint.c (_initialize_maint_cmds): Add declaration.
* mdebugread.c (_initialize_mdebugread): Add declaration.
* memattr.c (_initialize_mem): Add declaration.
* mep-tdep.c (_initialize_mep_tdep): Add declaration.
* mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
* mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
* mi/mi-interp.c (_initialize_mi_interp): Add declaration.
* mi/mi-main.c (_initialize_mi_main): Add declaration.
* microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
* microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
* mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
* mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
* mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
* mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
* mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
* mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
* mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
* mips-tdep.c (_initialize_mips_tdep): Add declaration.
* mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
* mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
* mipsread.c (_initialize_mipsread): Add declaration.
* mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
* mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
* moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
* msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
* nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
* nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
* nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
* nto-procfs.c (_initialize_procfs): Add declaration.
* objc-lang.c (_initialize_objc_language): Add declaration.
* observable.c (_initialize_observer): Add declaration.
* opencl-lang.c (_initialize_opencl_language): Add declaration.
* or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
* or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
* osabi.c (_initialize_gdb_osabi): Add declaration.
* osdata.c (_initialize_osdata): Add declaration.
* p-valprint.c (_initialize_pascal_valprint): Add declaration.
* parse.c (_initialize_parse): Add declaration.
* ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
* ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
* ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
* ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
* ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
* ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
* ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
* printcmd.c (_initialize_printcmd): Add declaration.
* probe.c (_initialize_probe): Add declaration.
* proc-api.c (_initialize_proc_api): Add declaration.
* proc-events.c (_initialize_proc_events): Add declaration.
* proc-service.c (_initialize_proc_service): Add declaration.
* procfs.c (_initialize_procfs): Add declaration.
* producer.c (_initialize_producer): Add declaration.
* psymtab.c (_initialize_psymtab): Add declaration.
* python/python.c (_initialize_python): Add declaration.
* ravenscar-thread.c (_initialize_ravenscar): Add declaration.
* record-btrace.c (_initialize_record_btrace): Add declaration.
* record-full.c (_initialize_record_full): Add declaration.
* record.c (_initialize_record): Add declaration.
* regcache-dump.c (_initialize_regcache_dump): Add declaration.
* regcache.c (_initialize_regcache): Add declaration.
* reggroups.c (_initialize_reggroup): Add declaration.
* remote-notif.c (_initialize_notif): Add declaration.
* remote-sim.c (_initialize_remote_sim): Add declaration.
* remote.c (_initialize_remote): Add declaration.
* reverse.c (_initialize_reverse): Add declaration.
* riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
* riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
* riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
* riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
* riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
* rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
* rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
* rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
Add declaration.
* rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
* rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
* run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
* rust-exp.y (_initialize_rust_exp): Add declaration.
* rx-tdep.c (_initialize_rx_tdep): Add declaration.
* s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
* s390-linux-nat.c (_initialize_s390_nat): Add declaration.
* s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
* s390-tdep.c (_initialize_s390_tdep): Add declaration.
* score-tdep.c (_initialize_score_tdep): Add declaration.
* ser-go32.c (_initialize_ser_dos): Add declaration.
* ser-mingw.c (_initialize_ser_windows): Add declaration.
* ser-pipe.c (_initialize_ser_pipe): Add declaration.
* ser-tcp.c (_initialize_ser_tcp): Add declaration.
* ser-uds.c (_initialize_ser_socket): Add declaration.
* ser-unix.c (_initialize_ser_hardwire): Add declaration.
* serial.c (_initialize_serial): Add declaration.
* sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
* sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
* sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
* sh-tdep.c (_initialize_sh_tdep): Add declaration.
* skip.c (_initialize_step_skip): Add declaration.
* sol-thread.c (_initialize_sol_thread): Add declaration.
* solib-aix.c (_initialize_solib_aix): Add declaration.
* solib-darwin.c (_initialize_darwin_solib): Add declaration.
* solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
* solib-frv.c (_initialize_frv_solib): Add declaration.
* solib-svr4.c (_initialize_svr4_solib): Add declaration.
* solib-target.c (_initialize_solib_target): Add declaration.
* solib.c (_initialize_solib): Add declaration.
* source-cache.c (_initialize_source_cache): Add declaration.
* source.c (_initialize_source): Add declaration.
* sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
* sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
* sparc-nat.c (_initialize_sparc_nat): Add declaration.
* sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
* sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
* sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
* sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
* sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
* sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
* sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
* sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
* sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
* sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
* sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
* sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
* sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
* sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
* sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
* sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
* stabsread.c (_initialize_stabsread): Add declaration.
* stack.c (_initialize_stack): Add declaration.
* stap-probe.c (_initialize_stap_probe): Add declaration.
* std-regs.c (_initialize_frame_reg): Add declaration.
* symfile-debug.c (_initialize_symfile_debug): Add declaration.
* symfile-mem.c (_initialize_symfile_mem): Add declaration.
* symfile.c (_initialize_symfile): Add declaration.
* symmisc.c (_initialize_symmisc): Add declaration.
* symtab.c (_initialize_symtab): Add declaration.
* target.c (_initialize_target): Add declaration.
* target-connection.c (_initialize_target_connection): Add
declaration.
* target-dcache.c (_initialize_target_dcache): Add declaration.
* target-descriptions.c (_initialize_target_descriptions): Add declaration.
* thread.c (_initialize_thread): Add declaration.
* tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
* tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
* tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
* tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
* tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
* tracectf.c (_initialize_ctf): Add declaration.
* tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
* tracefile.c (_initialize_tracefile): Add declaration.
* tracepoint.c (_initialize_tracepoint): Add declaration.
* tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
* tui/tui-interp.c (_initialize_tui_interp): Add declaration.
* tui/tui-layout.c (_initialize_tui_layout): Add declaration.
* tui/tui-regs.c (_initialize_tui_regs): Add declaration.
* tui/tui-stack.c (_initialize_tui_stack): Add declaration.
* tui/tui-win.c (_initialize_tui_win): Add declaration.
* tui/tui.c (_initialize_tui): Add declaration.
* typeprint.c (_initialize_typeprint): Add declaration.
* ui-style.c (_initialize_ui_style): Add declaration.
* unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
* unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
* unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
* unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
* unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
* unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
* unittests/filtered_iterator-selftests.c
(_initialize_filtered_iterator_selftests): Add declaration.
* unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
* unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
* unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
* unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
* unittests/main-thread-selftests.c
(_initialize_main_thread_selftests): Add declaration.
* unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
* unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
* unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
* unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
* unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
* unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
* unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
* unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
* unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
* unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
* unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
* unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
* unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
* unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
* unittests/tui-selftests.c (_initialize_tui_selftest): Add
declaration.
* unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
* unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
* unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
* unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
* user-regs.c (_initialize_user_regs): Add declaration.
* utils.c (_initialize_utils): Add declaration.
* v850-tdep.c (_initialize_v850_tdep): Add declaration.
* valops.c (_initialize_valops): Add declaration.
* valprint.c (_initialize_valprint): Add declaration.
* value.c (_initialize_values): Add declaration.
* varobj.c (_initialize_varobj): Add declaration.
* vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
* vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
* vax-tdep.c (_initialize_vax_tdep): Add declaration.
* windows-nat.c (_initialize_windows_nat): Add declaration.
(_initialize_check_for_gdb_ini): Add declaration.
(_initialize_loadable): Add declaration.
* windows-tdep.c (_initialize_windows_tdep): Add declaration.
* x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
* x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
* xcoffread.c (_initialize_xcoffread): Add declaration.
* xml-support.c (_initialize_xml_support): Add declaration.
* xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
* xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
* xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
* xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
Change-Id: I13eec7e0ed2b3c427377a7bdb055cf46da64def9
749 lines
22 KiB
C
749 lines
22 KiB
C
/* Skipping uninteresting files and functions while stepping.
|
|
|
|
Copyright (C) 2011-2020 Free Software Foundation, Inc.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "skip.h"
|
|
#include "value.h"
|
|
#include "valprint.h"
|
|
#include "ui-out.h"
|
|
#include "symtab.h"
|
|
#include "gdbcmd.h"
|
|
#include "command.h"
|
|
#include "completer.h"
|
|
#include "stack.h"
|
|
#include "cli/cli-utils.h"
|
|
#include "arch-utils.h"
|
|
#include "linespec.h"
|
|
#include "objfiles.h"
|
|
#include "breakpoint.h" /* for get_sal_arch () */
|
|
#include "source.h"
|
|
#include "filenames.h"
|
|
#include "fnmatch.h"
|
|
#include "gdb_regex.h"
|
|
#include "gdbsupport/gdb_optional.h"
|
|
#include <list>
|
|
#include "cli/cli-style.h"
|
|
|
|
/* True if we want to print debug printouts related to file/function
|
|
skipping. */
|
|
static bool debug_skip = false;
|
|
|
|
class skiplist_entry
|
|
{
|
|
public:
|
|
/* Create a skiplist_entry object and add it to the chain. */
|
|
static void add_entry (bool file_is_glob,
|
|
std::string &&file,
|
|
bool function_is_regexp,
|
|
std::string &&function);
|
|
|
|
/* Return true if the skip entry has a file or glob-style file
|
|
pattern that matches FUNCTION_SAL. */
|
|
bool skip_file_p (const symtab_and_line &function_sal) const;
|
|
|
|
/* Return true if the skip entry has a function or function regexp
|
|
that matches FUNCTION_NAME. */
|
|
bool skip_function_p (const char *function_name) const;
|
|
|
|
/* Getters. */
|
|
int number () const { return m_number; };
|
|
bool enabled () const { return m_enabled; };
|
|
bool file_is_glob () const { return m_file_is_glob; }
|
|
const std::string &file () const { return m_file; }
|
|
const std::string &function () const { return m_function; }
|
|
bool function_is_regexp () const { return m_function_is_regexp; }
|
|
|
|
/* Setters. */
|
|
void enable () { m_enabled = true; };
|
|
void disable () { m_enabled = false; };
|
|
|
|
/* Disable copy. */
|
|
skiplist_entry (const skiplist_entry &) = delete;
|
|
void operator= (const skiplist_entry &) = delete;
|
|
|
|
private:
|
|
/* Key that grants access to the constructor. */
|
|
struct private_key {};
|
|
public:
|
|
/* Public so we can construct with container::emplace_back. Since
|
|
it requires a private class key, it can't be called from outside.
|
|
Use the add_entry static factory method to construct instead. */
|
|
skiplist_entry (bool file_is_glob, std::string &&file,
|
|
bool function_is_regexp, std::string &&function,
|
|
private_key);
|
|
|
|
private:
|
|
/* Return true if we're stopped at a file to be skipped. */
|
|
bool do_skip_file_p (const symtab_and_line &function_sal) const;
|
|
|
|
/* Return true if we're stopped at a globbed file to be skipped. */
|
|
bool do_skip_gfile_p (const symtab_and_line &function_sal) const;
|
|
|
|
private: /* data */
|
|
int m_number = -1;
|
|
|
|
/* True if FILE is a glob-style pattern.
|
|
Otherwise it is the plain file name (possibly with directories). */
|
|
bool m_file_is_glob;
|
|
|
|
/* The name of the file or empty if no name. */
|
|
std::string m_file;
|
|
|
|
/* True if FUNCTION is a regexp.
|
|
Otherwise it is a plain function name (possibly with arguments,
|
|
for C++). */
|
|
bool m_function_is_regexp;
|
|
|
|
/* The name of the function or empty if no name. */
|
|
std::string m_function;
|
|
|
|
/* If this is a function regexp, the compiled form. */
|
|
gdb::optional<compiled_regex> m_compiled_function_regexp;
|
|
|
|
/* Enabled/disabled state. */
|
|
bool m_enabled = true;
|
|
};
|
|
|
|
static std::list<skiplist_entry> skiplist_entries;
|
|
static int highest_skiplist_entry_num = 0;
|
|
|
|
skiplist_entry::skiplist_entry (bool file_is_glob,
|
|
std::string &&file,
|
|
bool function_is_regexp,
|
|
std::string &&function,
|
|
private_key)
|
|
: m_file_is_glob (file_is_glob),
|
|
m_file (std::move (file)),
|
|
m_function_is_regexp (function_is_regexp),
|
|
m_function (std::move (function))
|
|
{
|
|
gdb_assert (!m_file.empty () || !m_function.empty ());
|
|
|
|
if (m_file_is_glob)
|
|
gdb_assert (!m_file.empty ());
|
|
|
|
if (m_function_is_regexp)
|
|
{
|
|
gdb_assert (!m_function.empty ());
|
|
|
|
int flags = REG_NOSUB;
|
|
#ifdef REG_EXTENDED
|
|
flags |= REG_EXTENDED;
|
|
#endif
|
|
|
|
gdb_assert (!m_function.empty ());
|
|
m_compiled_function_regexp.emplace (m_function.c_str (), flags,
|
|
_("regexp"));
|
|
}
|
|
}
|
|
|
|
void
|
|
skiplist_entry::add_entry (bool file_is_glob, std::string &&file,
|
|
bool function_is_regexp, std::string &&function)
|
|
{
|
|
skiplist_entries.emplace_back (file_is_glob,
|
|
std::move (file),
|
|
function_is_regexp,
|
|
std::move (function),
|
|
private_key {});
|
|
|
|
/* Incremented after push_back, in case push_back throws. */
|
|
skiplist_entries.back ().m_number = ++highest_skiplist_entry_num;
|
|
}
|
|
|
|
static void
|
|
skip_file_command (const char *arg, int from_tty)
|
|
{
|
|
struct symtab *symtab;
|
|
const char *filename = NULL;
|
|
|
|
/* If no argument was given, try to default to the last
|
|
displayed codepoint. */
|
|
if (arg == NULL)
|
|
{
|
|
symtab = get_last_displayed_symtab ();
|
|
if (symtab == NULL)
|
|
error (_("No default file now."));
|
|
|
|
/* It is not a typo, symtab_to_filename_for_display would be needlessly
|
|
ambiguous. */
|
|
filename = symtab_to_fullname (symtab);
|
|
}
|
|
else
|
|
filename = arg;
|
|
|
|
skiplist_entry::add_entry (false, std::string (filename),
|
|
false, std::string ());
|
|
|
|
printf_filtered (_("File %s will be skipped when stepping.\n"), filename);
|
|
}
|
|
|
|
/* Create a skiplist entry for the given function NAME and add it to the
|
|
list. */
|
|
|
|
static void
|
|
skip_function (const char *name)
|
|
{
|
|
skiplist_entry::add_entry (false, std::string (), false, std::string (name));
|
|
|
|
printf_filtered (_("Function %s will be skipped when stepping.\n"), name);
|
|
}
|
|
|
|
static void
|
|
skip_function_command (const char *arg, int from_tty)
|
|
{
|
|
/* Default to the current function if no argument is given. */
|
|
if (arg == NULL)
|
|
{
|
|
const char *name = NULL;
|
|
CORE_ADDR pc;
|
|
|
|
if (!last_displayed_sal_is_valid ())
|
|
error (_("No default function now."));
|
|
|
|
pc = get_last_displayed_addr ();
|
|
if (!find_pc_partial_function (pc, &name, NULL, NULL))
|
|
{
|
|
error (_("No function found containing current program point %s."),
|
|
paddress (get_current_arch (), pc));
|
|
}
|
|
skip_function (name);
|
|
return;
|
|
}
|
|
|
|
skip_function (arg);
|
|
}
|
|
|
|
/* Process "skip ..." that does not match "skip file" or "skip function". */
|
|
|
|
static void
|
|
skip_command (const char *arg, int from_tty)
|
|
{
|
|
const char *file = NULL;
|
|
const char *gfile = NULL;
|
|
const char *function = NULL;
|
|
const char *rfunction = NULL;
|
|
int i;
|
|
|
|
if (arg == NULL)
|
|
{
|
|
skip_function_command (arg, from_tty);
|
|
return;
|
|
}
|
|
|
|
gdb_argv argv (arg);
|
|
|
|
for (i = 0; argv[i] != NULL; ++i)
|
|
{
|
|
const char *p = argv[i];
|
|
const char *value = argv[i + 1];
|
|
|
|
if (strcmp (p, "-fi") == 0
|
|
|| strcmp (p, "-file") == 0)
|
|
{
|
|
if (value == NULL)
|
|
error (_("Missing value for %s option."), p);
|
|
file = value;
|
|
++i;
|
|
}
|
|
else if (strcmp (p, "-gfi") == 0
|
|
|| strcmp (p, "-gfile") == 0)
|
|
{
|
|
if (value == NULL)
|
|
error (_("Missing value for %s option."), p);
|
|
gfile = value;
|
|
++i;
|
|
}
|
|
else if (strcmp (p, "-fu") == 0
|
|
|| strcmp (p, "-function") == 0)
|
|
{
|
|
if (value == NULL)
|
|
error (_("Missing value for %s option."), p);
|
|
function = value;
|
|
++i;
|
|
}
|
|
else if (strcmp (p, "-rfu") == 0
|
|
|| strcmp (p, "-rfunction") == 0)
|
|
{
|
|
if (value == NULL)
|
|
error (_("Missing value for %s option."), p);
|
|
rfunction = value;
|
|
++i;
|
|
}
|
|
else if (*p == '-')
|
|
error (_("Invalid skip option: %s"), p);
|
|
else if (i == 0)
|
|
{
|
|
/* Assume the user entered "skip FUNCTION-NAME".
|
|
FUNCTION-NAME may be `foo (int)', and therefore we pass the
|
|
complete original arg to skip_function command as if the user
|
|
typed "skip function arg". */
|
|
skip_function_command (arg, from_tty);
|
|
return;
|
|
}
|
|
else
|
|
error (_("Invalid argument: %s"), p);
|
|
}
|
|
|
|
if (file != NULL && gfile != NULL)
|
|
error (_("Cannot specify both -file and -gfile."));
|
|
|
|
if (function != NULL && rfunction != NULL)
|
|
error (_("Cannot specify both -function and -rfunction."));
|
|
|
|
/* This shouldn't happen as "skip" by itself gets punted to
|
|
skip_function_command. */
|
|
gdb_assert (file != NULL || gfile != NULL
|
|
|| function != NULL || rfunction != NULL);
|
|
|
|
std::string entry_file;
|
|
if (file != NULL)
|
|
entry_file = file;
|
|
else if (gfile != NULL)
|
|
entry_file = gfile;
|
|
|
|
std::string entry_function;
|
|
if (function != NULL)
|
|
entry_function = function;
|
|
else if (rfunction != NULL)
|
|
entry_function = rfunction;
|
|
|
|
skiplist_entry::add_entry (gfile != NULL, std::move (entry_file),
|
|
rfunction != NULL, std::move (entry_function));
|
|
|
|
/* I18N concerns drive some of the choices here (we can't piece together
|
|
the output too much). OTOH we want to keep this simple. Therefore the
|
|
only polish we add to the output is to append "(s)" to "File" or
|
|
"Function" if they're a glob/regexp. */
|
|
{
|
|
const char *file_to_print = file != NULL ? file : gfile;
|
|
const char *function_to_print = function != NULL ? function : rfunction;
|
|
const char *file_text = gfile != NULL ? _("File(s)") : _("File");
|
|
const char *lower_file_text = gfile != NULL ? _("file(s)") : _("file");
|
|
const char *function_text
|
|
= rfunction != NULL ? _("Function(s)") : _("Function");
|
|
|
|
if (function_to_print == NULL)
|
|
{
|
|
printf_filtered (_("%s %s will be skipped when stepping.\n"),
|
|
file_text, file_to_print);
|
|
}
|
|
else if (file_to_print == NULL)
|
|
{
|
|
printf_filtered (_("%s %s will be skipped when stepping.\n"),
|
|
function_text, function_to_print);
|
|
}
|
|
else
|
|
{
|
|
printf_filtered (_("%s %s in %s %s will be skipped"
|
|
" when stepping.\n"),
|
|
function_text, function_to_print,
|
|
lower_file_text, file_to_print);
|
|
}
|
|
}
|
|
}
|
|
|
|
static void
|
|
info_skip_command (const char *arg, int from_tty)
|
|
{
|
|
int num_printable_entries = 0;
|
|
struct value_print_options opts;
|
|
|
|
get_user_print_options (&opts);
|
|
|
|
/* Count the number of rows in the table and see if we need space for a
|
|
64-bit address anywhere. */
|
|
for (const skiplist_entry &e : skiplist_entries)
|
|
if (arg == NULL || number_is_in_list (arg, e.number ()))
|
|
num_printable_entries++;
|
|
|
|
if (num_printable_entries == 0)
|
|
{
|
|
if (arg == NULL)
|
|
current_uiout->message (_("Not skipping any files or functions.\n"));
|
|
else
|
|
current_uiout->message (
|
|
_("No skiplist entries found with number %s.\n"), arg);
|
|
|
|
return;
|
|
}
|
|
|
|
ui_out_emit_table table_emitter (current_uiout, 6, num_printable_entries,
|
|
"SkiplistTable");
|
|
|
|
current_uiout->table_header (5, ui_left, "number", "Num"); /* 1 */
|
|
current_uiout->table_header (3, ui_left, "enabled", "Enb"); /* 2 */
|
|
current_uiout->table_header (4, ui_right, "regexp", "Glob"); /* 3 */
|
|
current_uiout->table_header (20, ui_left, "file", "File"); /* 4 */
|
|
current_uiout->table_header (2, ui_right, "regexp", "RE"); /* 5 */
|
|
current_uiout->table_header (40, ui_noalign, "function", "Function"); /* 6 */
|
|
current_uiout->table_body ();
|
|
|
|
for (const skiplist_entry &e : skiplist_entries)
|
|
{
|
|
QUIT;
|
|
if (arg != NULL && !number_is_in_list (arg, e.number ()))
|
|
continue;
|
|
|
|
ui_out_emit_tuple tuple_emitter (current_uiout, "blklst-entry");
|
|
current_uiout->field_signed ("number", e.number ()); /* 1 */
|
|
|
|
if (e.enabled ())
|
|
current_uiout->field_string ("enabled", "y"); /* 2 */
|
|
else
|
|
current_uiout->field_string ("enabled", "n"); /* 2 */
|
|
|
|
if (e.file_is_glob ())
|
|
current_uiout->field_string ("regexp", "y"); /* 3 */
|
|
else
|
|
current_uiout->field_string ("regexp", "n"); /* 3 */
|
|
|
|
current_uiout->field_string ("file",
|
|
e.file ().empty () ? "<none>"
|
|
: e.file ().c_str (),
|
|
e.file ().empty ()
|
|
? metadata_style.style ()
|
|
: file_name_style.style ()); /* 4 */
|
|
if (e.function_is_regexp ())
|
|
current_uiout->field_string ("regexp", "y"); /* 5 */
|
|
else
|
|
current_uiout->field_string ("regexp", "n"); /* 5 */
|
|
|
|
current_uiout->field_string ("function",
|
|
e.function ().empty () ? "<none>"
|
|
: e.function ().c_str (),
|
|
e.function ().empty ()
|
|
? metadata_style.style ()
|
|
: function_name_style.style ()); /* 6 */
|
|
|
|
current_uiout->text ("\n");
|
|
}
|
|
}
|
|
|
|
static void
|
|
skip_enable_command (const char *arg, int from_tty)
|
|
{
|
|
bool found = false;
|
|
|
|
for (skiplist_entry &e : skiplist_entries)
|
|
if (arg == NULL || number_is_in_list (arg, e.number ()))
|
|
{
|
|
e.enable ();
|
|
found = true;
|
|
}
|
|
|
|
if (!found)
|
|
error (_("No skiplist entries found with number %s."), arg);
|
|
}
|
|
|
|
static void
|
|
skip_disable_command (const char *arg, int from_tty)
|
|
{
|
|
bool found = false;
|
|
|
|
for (skiplist_entry &e : skiplist_entries)
|
|
if (arg == NULL || number_is_in_list (arg, e.number ()))
|
|
{
|
|
e.disable ();
|
|
found = true;
|
|
}
|
|
|
|
if (!found)
|
|
error (_("No skiplist entries found with number %s."), arg);
|
|
}
|
|
|
|
static void
|
|
skip_delete_command (const char *arg, int from_tty)
|
|
{
|
|
bool found = false;
|
|
|
|
for (auto it = skiplist_entries.begin (),
|
|
end = skiplist_entries.end ();
|
|
it != end;)
|
|
{
|
|
const skiplist_entry &e = *it;
|
|
|
|
if (arg == NULL || number_is_in_list (arg, e.number ()))
|
|
{
|
|
it = skiplist_entries.erase (it);
|
|
found = true;
|
|
}
|
|
else
|
|
++it;
|
|
}
|
|
|
|
if (!found)
|
|
error (_("No skiplist entries found with number %s."), arg);
|
|
}
|
|
|
|
bool
|
|
skiplist_entry::do_skip_file_p (const symtab_and_line &function_sal) const
|
|
{
|
|
if (debug_skip)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"skip: checking if file %s matches non-glob %s...",
|
|
function_sal.symtab->filename, m_file.c_str ());
|
|
|
|
bool result;
|
|
|
|
/* Check first sole SYMTAB->FILENAME. It may not be a substring of
|
|
symtab_to_fullname as it may contain "./" etc. */
|
|
if (compare_filenames_for_search (function_sal.symtab->filename,
|
|
m_file.c_str ()))
|
|
result = true;
|
|
|
|
/* Before we invoke realpath, which can get expensive when many
|
|
files are involved, do a quick comparison of the basenames. */
|
|
else if (!basenames_may_differ
|
|
&& filename_cmp (lbasename (function_sal.symtab->filename),
|
|
lbasename (m_file.c_str ())) != 0)
|
|
result = false;
|
|
else
|
|
{
|
|
/* Note: symtab_to_fullname caches its result, thus we don't have to. */
|
|
const char *fullname = symtab_to_fullname (function_sal.symtab);
|
|
|
|
result = compare_filenames_for_search (fullname, m_file.c_str ());
|
|
}
|
|
|
|
if (debug_skip)
|
|
fprintf_unfiltered (gdb_stdlog, result ? "yes.\n" : "no.\n");
|
|
|
|
return result;
|
|
}
|
|
|
|
bool
|
|
skiplist_entry::do_skip_gfile_p (const symtab_and_line &function_sal) const
|
|
{
|
|
if (debug_skip)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"skip: checking if file %s matches glob %s...",
|
|
function_sal.symtab->filename, m_file.c_str ());
|
|
|
|
bool result;
|
|
|
|
/* Check first sole SYMTAB->FILENAME. It may not be a substring of
|
|
symtab_to_fullname as it may contain "./" etc. */
|
|
if (gdb_filename_fnmatch (m_file.c_str (), function_sal.symtab->filename,
|
|
FNM_FILE_NAME | FNM_NOESCAPE) == 0)
|
|
result = true;
|
|
|
|
/* Before we invoke symtab_to_fullname, which is expensive, do a quick
|
|
comparison of the basenames.
|
|
Note that we assume that lbasename works with glob-style patterns.
|
|
If the basename of the glob pattern is something like "*.c" then this
|
|
isn't much of a win. Oh well. */
|
|
else if (!basenames_may_differ
|
|
&& gdb_filename_fnmatch (lbasename (m_file.c_str ()),
|
|
lbasename (function_sal.symtab->filename),
|
|
FNM_FILE_NAME | FNM_NOESCAPE) != 0)
|
|
result = false;
|
|
else
|
|
{
|
|
/* Note: symtab_to_fullname caches its result, thus we don't have to. */
|
|
const char *fullname = symtab_to_fullname (function_sal.symtab);
|
|
|
|
result = compare_glob_filenames_for_search (fullname, m_file.c_str ());
|
|
}
|
|
|
|
if (debug_skip)
|
|
fprintf_unfiltered (gdb_stdlog, result ? "yes.\n" : "no.\n");
|
|
|
|
return result;
|
|
}
|
|
|
|
bool
|
|
skiplist_entry::skip_file_p (const symtab_and_line &function_sal) const
|
|
{
|
|
if (m_file.empty ())
|
|
return false;
|
|
|
|
if (function_sal.symtab == NULL)
|
|
return false;
|
|
|
|
if (m_file_is_glob)
|
|
return do_skip_gfile_p (function_sal);
|
|
else
|
|
return do_skip_file_p (function_sal);
|
|
}
|
|
|
|
bool
|
|
skiplist_entry::skip_function_p (const char *function_name) const
|
|
{
|
|
if (m_function.empty ())
|
|
return false;
|
|
|
|
bool result;
|
|
|
|
if (m_function_is_regexp)
|
|
{
|
|
if (debug_skip)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"skip: checking if function %s matches regex %s...",
|
|
function_name, m_function.c_str ());
|
|
|
|
gdb_assert (m_compiled_function_regexp);
|
|
result
|
|
= (m_compiled_function_regexp->exec (function_name, 0, NULL, 0) == 0);
|
|
}
|
|
else
|
|
{
|
|
if (debug_skip)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
("skip: checking if function %s matches non-regex "
|
|
"%s..."),
|
|
function_name, m_function.c_str ());
|
|
result = (strcmp_iw (function_name, m_function.c_str ()) == 0);
|
|
}
|
|
|
|
if (debug_skip)
|
|
fprintf_unfiltered (gdb_stdlog, result ? "yes.\n" : "no.\n");
|
|
|
|
return result;
|
|
}
|
|
|
|
/* See skip.h. */
|
|
|
|
bool
|
|
function_name_is_marked_for_skip (const char *function_name,
|
|
const symtab_and_line &function_sal)
|
|
{
|
|
if (function_name == NULL)
|
|
return false;
|
|
|
|
for (const skiplist_entry &e : skiplist_entries)
|
|
{
|
|
if (!e.enabled ())
|
|
continue;
|
|
|
|
bool skip_by_file = e.skip_file_p (function_sal);
|
|
bool skip_by_function = e.skip_function_p (function_name);
|
|
|
|
/* If both file and function must match, make sure we don't errantly
|
|
exit if only one of them match. */
|
|
if (!e.file ().empty () && !e.function ().empty ())
|
|
{
|
|
if (skip_by_file && skip_by_function)
|
|
return true;
|
|
}
|
|
/* Only one of file/function is specified. */
|
|
else if (skip_by_file || skip_by_function)
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
/* Completer for skip numbers. */
|
|
|
|
static void
|
|
complete_skip_number (cmd_list_element *cmd,
|
|
completion_tracker &completer,
|
|
const char *text, const char *word)
|
|
{
|
|
size_t word_len = strlen (word);
|
|
|
|
for (const skiplist_entry &entry : skiplist_entries)
|
|
{
|
|
gdb::unique_xmalloc_ptr<char> name (xstrprintf ("%d", entry.number ()));
|
|
if (strncmp (word, name.get (), word_len) == 0)
|
|
completer.add_completion (std::move (name));
|
|
}
|
|
}
|
|
|
|
void _initialize_step_skip ();
|
|
void
|
|
_initialize_step_skip ()
|
|
{
|
|
static struct cmd_list_element *skiplist = NULL;
|
|
struct cmd_list_element *c;
|
|
|
|
add_prefix_cmd ("skip", class_breakpoint, skip_command, _("\
|
|
Ignore a function while stepping.\n\
|
|
\n\
|
|
Usage: skip [FUNCTION-NAME]\n\
|
|
skip [FILE-SPEC] [FUNCTION-SPEC]\n\
|
|
If no arguments are given, ignore the current function.\n\
|
|
\n\
|
|
FILE-SPEC is one of:\n\
|
|
-fi|-file FILE-NAME\n\
|
|
-gfi|-gfile GLOB-FILE-PATTERN\n\
|
|
FUNCTION-SPEC is one of:\n\
|
|
-fu|-function FUNCTION-NAME\n\
|
|
-rfu|-rfunction FUNCTION-NAME-REGULAR-EXPRESSION"),
|
|
&skiplist, "skip ", 1, &cmdlist);
|
|
|
|
c = add_cmd ("file", class_breakpoint, skip_file_command, _("\
|
|
Ignore a file while stepping.\n\
|
|
Usage: skip file [FILE-NAME]\n\
|
|
If no filename is given, ignore the current file."),
|
|
&skiplist);
|
|
set_cmd_completer (c, filename_completer);
|
|
|
|
c = add_cmd ("function", class_breakpoint, skip_function_command, _("\
|
|
Ignore a function while stepping.\n\
|
|
Usage: skip function [FUNCTION-NAME]\n\
|
|
If no function name is given, skip the current function."),
|
|
&skiplist);
|
|
set_cmd_completer (c, location_completer);
|
|
|
|
c = add_cmd ("enable", class_breakpoint, skip_enable_command, _("\
|
|
Enable skip entries.\n\
|
|
Usage: skip enable [NUMBER | RANGE]...\n\
|
|
You can specify numbers (e.g. \"skip enable 1 3\"),\n\
|
|
ranges (e.g. \"skip enable 4-8\"), or both (e.g. \"skip enable 1 3 4-8\").\n\n\
|
|
If you don't specify any numbers or ranges, we'll enable all skip entries."),
|
|
&skiplist);
|
|
set_cmd_completer (c, complete_skip_number);
|
|
|
|
c = add_cmd ("disable", class_breakpoint, skip_disable_command, _("\
|
|
Disable skip entries.\n\
|
|
Usage: skip disable [NUMBER | RANGE]...\n\
|
|
You can specify numbers (e.g. \"skip disable 1 3\"),\n\
|
|
ranges (e.g. \"skip disable 4-8\"), or both (e.g. \"skip disable 1 3 4-8\").\n\n\
|
|
If you don't specify any numbers or ranges, we'll disable all skip entries."),
|
|
&skiplist);
|
|
set_cmd_completer (c, complete_skip_number);
|
|
|
|
c = add_cmd ("delete", class_breakpoint, skip_delete_command, _("\
|
|
Delete skip entries.\n\
|
|
Usage: skip delete [NUMBER | RANGES]...\n\
|
|
You can specify numbers (e.g. \"skip delete 1 3\"),\n\
|
|
ranges (e.g. \"skip delete 4-8\"), or both (e.g. \"skip delete 1 3 4-8\").\n\n\
|
|
If you don't specify any numbers or ranges, we'll delete all skip entries."),
|
|
&skiplist);
|
|
set_cmd_completer (c, complete_skip_number);
|
|
|
|
add_info ("skip", info_skip_command, _("\
|
|
Display the status of skips.\n\
|
|
Usage: info skip [NUMBER | RANGES]...\n\
|
|
You can specify numbers (e.g. \"info skip 1 3\"), \n\
|
|
ranges (e.g. \"info skip 4-8\"), or both (e.g. \"info skip 1 3 4-8\").\n\n\
|
|
If you don't specify any numbers or ranges, we'll show all skips."));
|
|
set_cmd_completer (c, complete_skip_number);
|
|
|
|
add_setshow_boolean_cmd ("skip", class_maintenance,
|
|
&debug_skip, _("\
|
|
Set whether to print the debug output about skipping files and functions."),
|
|
_("\
|
|
Show whether the debug output about skipping files and functions is printed."),
|
|
_("\
|
|
When non-zero, debug output about skipping files and functions is displayed."),
|
|
NULL, NULL,
|
|
&setdebuglist, &showdebuglist);
|
|
}
|