f6ac5f3d63
I.e., use C++ virtual methods and inheritance instead of tables of function pointers. Unfortunately, there's no way to do a smooth transition. ALL native targets in the tree must be converted at the same time. I've tested all I could with cross compilers and with help from GCC compile farm, but naturally I haven't been able to test many of the ports. Still, I made a best effort to port everything over, and while I expect some build problems due to typos and such, which should be trivial to fix, I don't expect any design problems. * Implementation notes: - The flattened current_target is gone. References to current_target or current_target.beneath are replaced with references to target_stack (the top of the stack) directly. - To keep "set debug target" working, this adds a new debug_stratum layer that sits on top of the stack, prints the debug, and delegates to the target beneath. In addition, this makes the shortname and longname properties of target_ops be virtual methods instead of data fields, and makes the debug target defer those to the target beneath. This is so that debug code sprinkled around that does "if (debugtarget) ..." can transparently print the name of the target beneath. A patch later in the series actually splits out the shortname/longname methods to a separate structure, but I preferred to keep that chance separate as it is associated with changing a bit the design of how targets are registered and open. - Since you can't check whether a C++ virtual method is overridden, the old method of checking whether a target_ops implements a method by comparing the function pointer must be replaced with something else. Some cases are fixed by adding a parallel "can_do_foo" target_ops methods. E.g.,: + for (t = target_stack; t != NULL; t = t->beneath) { - if (t->to_create_inferior != NULL) + if (t->can_create_inferior ()) break; } Others are fixed by changing void return type to bool or int return type, and have the default implementation return false or -1, to indicate lack of support. - make-target-delegates was adjusted to generate C++ classes and methods. It needed tweaks to grok "virtual" in front of the target method name, and for the fact that methods are no longer function pointers. (In particular, the current code parsing the return type was simple because it could simply parse up until the '(' in '(*to_foo)'. It now generates a couple C++ classes that inherit target_ops: dummy_target and debug_target. Since we need to generate the class declarations as well, i.e., we need to emit methods twice, we now generate the code in two passes. - The core_target global is renamed to avoid conflict with the "core_target" class. - ctf/tfile targets init_tracefile_ops is replaced by a base class that is inherited by both ctf and tfile. - bsd-uthread The bsd_uthread_ops_hack hack is gone. It's not needed because nothing was extending a target created by bsd_uthread_target. - remote/extended-remote targets This is a first pass, just enough to C++ify target_ops. A later pass will convert more free functions to methods, and make remote_state be truly per remote instance, allowing multiple simultaneous instances of remote targets. - inf-child/"native" is converted to an actual base class (inf_child_target), that is inherited by all native targets. - GNU/Linux The old weird double-target linux_ops mechanism in linux-nat.c, is gone, replaced by adding a few virtual methods to linux-nat.h's target_ops, called low_XXX, that the concrete linux-nat implementations override. Sort of like gdbserver's linux_target_ops, but simpler, for requiring only one target_ops-like hierarchy, which spares implementing the same method twice when we need to forward the method to a low implementation. The low target simply reimplements the target_ops method directly in that case. There are a few remaining linux-nat.c hooks that would be better converted to low_ methods like above too. E.g.: linux_nat_set_new_thread (t, x86_linux_new_thread); linux_nat_set_new_fork (t, x86_linux_new_fork); linux_nat_set_forget_process That'll be done in a follow up patch. - We can no longer use functions like x86_use_watchpoints to install custom methods on an arbitrary base target. The patch replaces instances of such a pattern with template mixins. For example memory_breakpoint_target defined in target.h, or x86_nat_target in x86-nat.h. - linux_trad_target, MIPS and Alpha GNU/Linux The code in the new linux-nat-trad.h/c files which was split off of inf-ptrace.h/c recently, is converted to a C++ base class, and used by the MIPS and Alpha GNU/Linux ports. - BSD targets The $architecture x NetBSD/OpenBSD/FreeBSD support matrix complicates things a bit. There's common BSD target code, and there's common architecture-specific code shared between the different BSDs. Currently, all that is stiched together to form a final target, via the i386bsd_target, x86bsd_target, fbsd_nat_add_target functions etc. This introduces new fbsd_nat_target, obsd_nat_target and nbsd_nat_target classes that serve as base/prototype target for the corresponding BSD variant. And introduces generic i386/AMD64 BSD targets, to be used as template mixin to build a final target. Similarly, a generic SPARC target is added, used by both BSD and Linux ports. - bsd_kvm_add_target, BSD libkvm target I considered making bsd_kvm_supply_pcb a virtual method, and then have each port inherit bsd_kvm_target and override that method, but that was resulting in lots of unjustified churn, so I left the function pointer mechanism alone. gdb/ChangeLog: 2018-05-02 Pedro Alves <palves@redhat.com> John Baldwin <jhb@freebsd.org> * target.h (enum strata) <debug_stratum>: New. (struct target_ops) <all delegation methods>: Replace by C++ virtual methods, and drop "to_" prefix. All references updated throughout. <to_shortname, to_longname, to_doc, to_data, to_have_steppable_watchpoint, to_have_continuable_watchpoint, to_has_thread_control, to_attach_no_wait>: Delete, replaced by virtual methods. All references updated throughout. <can_attach, supports_terminal_ours, can_create_inferior, get_thread_control_capabilities, attach_no_wait>: New virtual methods. <insert_breakpoint, remove_breakpoint>: Now TARGET_DEFAULT_NORETURN methods. <info_proc>: Now returns bool. <to_magic>: Delete. (OPS_MAGIC): Delete. (current_target): Delete. All references replaced by references to ... (target_stack): ... this. New. (target_shortname, target_longname): Adjust. (target_can_run): Now a function declaration. (default_child_has_all_memory, default_child_has_memory) (default_child_has_stack, default_child_has_registers) (default_child_has_execution): Remove target_ops parameter. (complete_target_initialization): Delete. (memory_breakpoint_target): New template class. (test_target_ops): Refactor as a C++ class with virtual methods. * make-target-delegates (NAME_PART): Tighten. (POINTER_PART, CP_SYMBOL): New. (SIMPLE_RETURN_PART): Reimplement. (VEC_RETURN_PART): Expect less. (RETURN_PART, VIRTUAL_PART): New. (METHOD): Adjust to C++ virtual methods. (scan_target_h): Remove reference to C99. (dname): Output "target_ops::" prefix. (write_function_header): Adjust to output a C++ class method. (write_declaration): New. (write_delegator): Adjust to output a C++ class method. (tdname): Output "dummy_target::" prefix. (write_tdefault, write_debugmethod): Adjust to output a C++ class method. (tdefault_names, debug_names): Delete. (return_types, tdefaults, styles, argtypes_array): New. (top level): All methods are delegators. (print_class): New. (top level): Print dummy_target and debug_target classes. * target-delegates.c: Regenerate. * target-debug.h (target_debug_print_enum_info_proc_what) (target_debug_print_thread_control_capabilities) (target_debug_print_thread_info_p): New. * target.c (dummy_target): Delete. (the_dummy_target, the_debug_target): New. (target_stack): Now extern. (set_targetdebug): Push/unpush debug target. (default_child_has_all_memory, default_child_has_memory) (default_child_has_stack, default_child_has_registers) (default_child_has_execution): Remove target_ops parameter. (complete_target_initialization): Delete. (add_target_with_completer): No longer call complete_target_initialization. (target_supports_terminal_ours): Use regular delegation. (update_current_target): Delete. (push_target): No longer check magic number. Don't call update_current_target. (unpush_target): Don't call update_current_target. (target_is_pushed): No longer check magic number. (target_require_runnable): Skip for all stratums over process_stratum. (target_ops::info_proc): New. (target_info_proc): Use find_target_at and find_default_run_target. (target_supports_disable_randomization): Use regular delegation. (target_get_osdata): Use find_target_at. (target_ops::open, target_ops::close, target_ops::can_attach) (target_ops::attach, target_ops::can_create_inferior) (target_ops::create_inferior, target_ops::can_run) (target_can_run): New. (default_fileio_target): Use regular delegation. (target_ops::fileio_open, target_ops::fileio_pwrite) (target_ops::fileio_pread, target_ops::fileio_fstat) (target_ops::fileio_close, target_ops::fileio_unlink) (target_ops::fileio_readlink): New. (target_fileio_open_1, target_fileio_unlink) (target_fileio_readlink): Always call the target method. Handle FILEIO_ENOSYS. (return_zero, return_zero_has_execution): Delete. (init_dummy_target): Delete. (dummy_target::dummy_target, dummy_target::shortname) (dummy_target::longname, dummy_target::doc) (debug_target::debug_target, debug_target::shortname) (debug_target::longname, debug_target::doc): New. (target_supports_delete_record): Use regular delegation. (setup_target_debug): Delete. (maintenance_print_target_stack): Skip debug_stratum. (initialize_targets): Instantiate the_dummy_target and the_debug_target. * auxv.c (target_auxv_parse): Remove 'ops' parameter. Adjust to use target_stack. (target_auxv_search, fprint_target_auxv): Adjust. (info_auxv_command): Adjust to use target_stack. * auxv.h (target_auxv_parse): Remove 'ops' parameter. * exceptions.c (print_flush): Handle a NULL target_stack. * regcache.c (target_ops_no_register): Refactor as class with virtual methods. * exec.c (exec_target): New class. (exec_ops): Now an exec_target. (exec_open, exec_close_1, exec_get_section_table) (exec_xfer_partial, exec_files_info, exec_has_memory) (exec_make_note_section): Refactor as exec_target methods. (exec_file_clear, ignore, exec_remove_breakpoint, init_exec_ops): Delete. (exec_target::find_memory_regions): New. (_initialize_exec): Don't call init_exec_ops. * gdbcore.h (exec_file_clear): Delete. * corefile.c (core_target): Delete. (core_file_command): Adjust. * corelow.c (core_target): New class. (the_core_target): New. (core_close): Remove target_ops parameter. (core_close_cleanup): Adjust. (core_target::close): New. (core_open, core_detach, get_core_registers, core_files_info) (core_xfer_partial, core_thread_alive, core_read_description) (core_pid_to_str, core_thread_name, core_has_memory) (core_has_stack, core_has_registers, core_info_proc): Rework as core_target methods. (ignore, core_remove_breakpoint, init_core_ops): Delete. (_initialize_corelow): Initialize the_core_target. * gdbcore.h (core_target): Delete. (the_core_target): New. * ctf.c: (ctf_target): New class. (ctf_ops): Now a ctf_target. (ctf_open, ctf_close, ctf_files_info, ctf_fetch_registers) (ctf_xfer_partial, ctf_get_trace_state_variable_value) (ctf_trace_find, ctf_traceframe_info): Refactor as ctf_target methods. (init_ctf_ops): Delete. (_initialize_ctf): Don't call it. * tracefile-tfile.c (tfile_target): New class. (tfile_ops): Now a tfile_target. (tfile_open, tfile_close, tfile_files_info) (tfile_get_tracepoint_status, tfile_trace_find) (tfile_fetch_registers, tfile_xfer_partial) (tfile_get_trace_state_variable_value, tfile_traceframe_info): Refactor as tfile_target methods. (tfile_xfer_partial_features): Remove target_ops parameter. (init_tfile_ops): Delete. (_initialize_tracefile_tfile): Don't call it. * tracefile.c (tracefile_has_all_memory, tracefile_has_memory) (tracefile_has_stack, tracefile_has_registers) (tracefile_thread_alive, tracefile_get_trace_status): Refactor as tracefile_target methods. (init_tracefile_ops): Delete. (tracefile_target::tracefile_target): New. * tracefile.h: Include "target.h". (tracefile_target): New class. (init_tracefile_ops): Delete. * spu-multiarch.c (spu_multiarch_target): New class. (spu_ops): Now a spu_multiarch_target. (spu_thread_architecture, spu_region_ok_for_hw_watchpoint) (spu_fetch_registers, spu_store_registers, spu_xfer_partial) (spu_search_memory, spu_mourn_inferior): Refactor as spu_multiarch_target methods. (init_spu_ops): Delete. (_initialize_spu_multiarch): Remove references to init_spu_ops, complete_target_initialization. * ravenscar-thread.c (ravenscar_thread_target): New class. (ravenscar_ops): Now a ravenscar_thread_target. (ravenscar_resume, ravenscar_wait, ravenscar_update_thread_list) (ravenscar_thread_alive, ravenscar_pid_to_str) (ravenscar_fetch_registers, ravenscar_store_registers) (ravenscar_prepare_to_store, ravenscar_stopped_by_sw_breakpoint) (ravenscar_stopped_by_hw_breakpoint) (ravenscar_stopped_by_watchpoint, ravenscar_stopped_data_address) (ravenscar_mourn_inferior, ravenscar_core_of_thread) (ravenscar_get_ada_task_ptid): Refactor as ravenscar_thread_target methods. (init_ravenscar_thread_ops): Delete. (_initialize_ravenscar): Remove references to init_ravenscar_thread_ops and complete_target_initialization. * bsd-uthread.c (bsd_uthread_ops_hack): Delete. (bsd_uthread_target): New class. (bsd_uthread_ops): Now a bsd_uthread_target. (bsd_uthread_activate): Adjust to refer to bsd_uthread_ops. (bsd_uthread_close, bsd_uthread_mourn_inferior) (bsd_uthread_fetch_registers, bsd_uthread_store_registers) (bsd_uthread_wait, bsd_uthread_resume, bsd_uthread_thread_alive) (bsd_uthread_update_thread_list, bsd_uthread_extra_thread_info) (bsd_uthread_pid_to_str): Refactor as bsd_uthread_target methods. (bsd_uthread_target): Delete function. (_initialize_bsd_uthread): Remove reference to complete_target_initialization. * bfd-target.c (target_bfd_data): Delete. Fields folded into ... (target_bfd): ... this new class. (target_bfd_xfer_partial, target_bfd_get_section_table) (target_bfd_close): Refactor as target_bfd methods. (target_bfd::~target_bfd): New. (target_bfd_reopen): Adjust. (target_bfd::close): New. * record-btrace.c (record_btrace_target): New class. (record_btrace_ops): Now a record_btrace_target. (record_btrace_open, record_btrace_stop_recording) (record_btrace_disconnect, record_btrace_close) (record_btrace_async, record_btrace_info) (record_btrace_insn_history, record_btrace_insn_history_range) (record_btrace_insn_history_from, record_btrace_call_history) (record_btrace_call_history_range) (record_btrace_call_history_from, record_btrace_record_method) (record_btrace_is_replaying, record_btrace_will_replay) (record_btrace_xfer_partial, record_btrace_insert_breakpoint) (record_btrace_remove_breakpoint, record_btrace_fetch_registers) (record_btrace_store_registers, record_btrace_prepare_to_store) (record_btrace_to_get_unwinder) (record_btrace_to_get_tailcall_unwinder, record_btrace_resume) (record_btrace_commit_resume, record_btrace_wait) (record_btrace_stop, record_btrace_can_execute_reverse) (record_btrace_stopped_by_sw_breakpoint) (record_btrace_supports_stopped_by_sw_breakpoint) (record_btrace_stopped_by_hw_breakpoint) (record_btrace_supports_stopped_by_hw_breakpoint) (record_btrace_update_thread_list, record_btrace_thread_alive) (record_btrace_goto_begin, record_btrace_goto_end) (record_btrace_goto, record_btrace_stop_replaying_all) (record_btrace_execution_direction) (record_btrace_prepare_to_generate_core) (record_btrace_done_generating_core): Refactor as record_btrace_target methods. (init_record_btrace_ops): Delete. (_initialize_record_btrace): Remove reference to init_record_btrace_ops. * record-full.c (RECORD_FULL_IS_REPLAY): Adjust to always refer to the execution_direction global. (record_full_base_target, record_full_target) (record_full_core_target): New classes. (record_full_ops): Now a record_full_target. (record_full_core_ops): Now a record_full_core_target. (record_full_target::detach, record_full_target::disconnect) (record_full_core_target::disconnect) (record_full_target::mourn_inferior, record_full_target::kill): New. (record_full_open, record_full_close, record_full_async): Refactor as methods of the record_full_base_target class. (record_full_resume, record_full_commit_resume): Refactor as methods of the record_full_target class. (record_full_wait, record_full_stopped_by_watchpoint) (record_full_stopped_data_address) (record_full_stopped_by_sw_breakpoint) (record_full_supports_stopped_by_sw_breakpoint) (record_full_stopped_by_hw_breakpoint) (record_full_supports_stopped_by_hw_breakpoint): Refactor as methods of the record_full_base_target class. (record_full_store_registers, record_full_xfer_partial) (record_full_insert_breakpoint, record_full_remove_breakpoint): Refactor as methods of the record_full_target class. (record_full_can_execute_reverse, record_full_get_bookmark) (record_full_goto_bookmark, record_full_execution_direction) (record_full_record_method, record_full_info, record_full_delete) (record_full_is_replaying, record_full_will_replay) (record_full_goto_begin, record_full_goto_end, record_full_goto) (record_full_stop_replaying): Refactor as methods of the record_full_base_target class. (record_full_core_resume, record_full_core_kill) (record_full_core_fetch_registers) (record_full_core_prepare_to_store) (record_full_core_store_registers, record_full_core_xfer_partial) (record_full_core_insert_breakpoint) (record_full_core_remove_breakpoint) (record_full_core_has_execution): Refactor as methods of the record_full_core_target class. (record_full_base_target::supports_delete_record): New. (init_record_full_ops): Delete. (init_record_full_core_ops): Delete. (record_full_save): Refactor as method of the record_full_base_target class. (_initialize_record_full): Remove references to init_record_full_ops and init_record_full_core_ops. * remote.c (remote_target, extended_remote_target): New classes. (remote_ops): Now a remote_target. (extended_remote_ops): Now an extended_remote_target. (remote_insert_fork_catchpoint, remote_remove_fork_catchpoint) (remote_insert_vfork_catchpoint, remote_remove_vfork_catchpoint) (remote_insert_exec_catchpoint, remote_remove_exec_catchpoint) (remote_pass_signals, remote_set_syscall_catchpoint) (remote_program_signals, ) (remote_thread_always_alive): Remove target_ops parameter. (remote_thread_alive, remote_thread_name) (remote_update_thread_list, remote_threads_extra_info) (remote_static_tracepoint_marker_at) (remote_static_tracepoint_markers_by_strid) (remote_get_ada_task_ptid, remote_close, remote_start_remote) (remote_open): Refactor as methods of remote_target. (extended_remote_open, extended_remote_detach) (extended_remote_attach, extended_remote_post_attach): (extended_remote_supports_disable_randomization) (extended_remote_create_inferior): : Refactor as method of extended_remote_target. (remote_set_permissions, remote_open_1, remote_detach) (remote_follow_fork, remote_follow_exec, remote_disconnect) (remote_resume, remote_commit_resume, remote_stop) (remote_interrupt, remote_pass_ctrlc, remote_terminal_inferior) (remote_terminal_ours, remote_wait, remote_fetch_registers) (remote_prepare_to_store, remote_store_registers) (remote_flash_erase, remote_flash_done, remote_files_info) (remote_kill, remote_mourn, remote_insert_breakpoint) (remote_remove_breakpoint, remote_insert_watchpoint) (remote_watchpoint_addr_within_range) (remote_remove_watchpoint, remote_region_ok_for_hw_watchpoint) (remote_check_watch_resources, remote_stopped_by_sw_breakpoint) (remote_supports_stopped_by_sw_breakpoint) (remote_stopped_by_hw_breakpoint) (remote_supports_stopped_by_hw_breakpoint) (remote_stopped_by_watchpoint, remote_stopped_data_address) (remote_insert_hw_breakpoint, remote_remove_hw_breakpoint) (remote_verify_memory): Refactor as methods of remote_target. (remote_write_qxfer, remote_read_qxfer): Remove target_ops parameter. (remote_xfer_partial, remote_get_memory_xfer_limit) (remote_search_memory, remote_rcmd, remote_memory_map) (remote_pid_to_str, remote_get_thread_local_address) (remote_get_tib_address, remote_read_description): Refactor as methods of remote_target. (remote_target::fileio_open, remote_target::fileio_pwrite) (remote_target::fileio_pread, remote_target::fileio_close): New. (remote_hostio_readlink, remote_hostio_fstat) (remote_filesystem_is_local, remote_can_execute_reverse) (remote_supports_non_stop, remote_supports_disable_randomization) (remote_supports_multi_process, remote_supports_cond_breakpoints) (remote_supports_enable_disable_tracepoint) (remote_supports_string_tracing) (remote_can_run_breakpoint_commands, remote_trace_init) (remote_download_tracepoint, remote_can_download_tracepoint) (remote_download_trace_state_variable, remote_enable_tracepoint) (remote_disable_tracepoint, remote_trace_set_readonly_regions) (remote_trace_start, remote_get_trace_status) (remote_get_tracepoint_status, remote_trace_stop) (remote_trace_find, remote_get_trace_state_variable_value) (remote_save_trace_data, remote_get_raw_trace_data) (remote_set_disconnected_tracing, remote_core_of_thread) (remote_set_circular_trace_buffer, remote_traceframe_info) (remote_get_min_fast_tracepoint_insn_len) (remote_set_trace_buffer_size, remote_set_trace_notes) (remote_use_agent, remote_can_use_agent, remote_enable_btrace) (remote_disable_btrace, remote_teardown_btrace) (remote_read_btrace, remote_btrace_conf) (remote_augmented_libraries_svr4_read, remote_load) (remote_pid_to_exec_file, remote_can_do_single_step) (remote_execution_direction, remote_thread_handle_to_thread_info): Refactor as methods of remote_target. (init_remote_ops, init_extended_remote_ops): Delete. (remote_can_async_p, remote_is_async_p, remote_async) (remote_thread_events, remote_upload_tracepoints) (remote_upload_trace_state_variables): Refactor as methods of remote_target. (_initialize_remote): Remove references to init_remote_ops and init_extended_remote_ops. * remote-sim.c (gdbsim_target): New class. (gdbsim_fetch_register, gdbsim_store_register, gdbsim_kill) (gdbsim_load, gdbsim_create_inferior, gdbsim_open, gdbsim_close) (gdbsim_detach, gdbsim_resume, gdbsim_interrupt) (gdbsim_wait, gdbsim_prepare_to_store, gdbsim_xfer_partial) (gdbsim_files_info, gdbsim_mourn_inferior, gdbsim_thread_alive) (gdbsim_pid_to_str, gdbsim_has_all_memory, gdbsim_has_memory): Refactor as methods of gdbsim_target. (gdbsim_ops): Now a gdbsim_target. (init_gdbsim_ops): Delete. (gdbsim_cntrl_c): Adjust. (_initialize_remote_sim): Remove reference to init_gdbsim_ops. * amd64-linux-nat.c (amd64_linux_nat_target): New class. (the_amd64_linux_nat_target): New. (amd64_linux_fetch_inferior_registers) (amd64_linux_store_inferior_registers): Refactor as methods of amd64_linux_nat_target. (_initialize_amd64_linux_nat): Adjust. Set linux_target. * i386-linux-nat.c: Don't include "linux-nat.h". (i386_linux_nat_target): New class. (the_i386_linux_nat_target): New. (i386_linux_fetch_inferior_registers) (i386_linux_store_inferior_registers, i386_linux_resume): Refactor as methods of i386_linux_nat_target. (_initialize_i386_linux_nat): Adjust. Set linux_target. * inf-child.c (inf_child_ops): Delete. (inf_child_fetch_inferior_registers) (inf_child_store_inferior_registers): Delete. (inf_child_post_attach, inf_child_prepare_to_store): Refactor as methods of inf_child_target. (inf_child_target::supports_terminal_ours) (inf_child_target::terminal_init) (inf_child_target::terminal_inferior) (inf_child_target::terminal_ours_for_output) (inf_child_target::terminal_ours, inf_child_target::interrupt) (inf_child_target::pass_ctrlc, inf_child_target::terminal_info): New. (inf_child_open, inf_child_disconnect, inf_child_close) (inf_child_mourn_inferior, inf_child_maybe_unpush_target) (inf_child_post_startup_inferior, inf_child_can_run) (inf_child_pid_to_exec_file): Refactor as methods of inf_child_target. (inf_child_follow_fork): Delete. (inf_child_target::can_create_inferior) (inf_child_target::can_attach): New. (inf_child_target::has_all_memory, inf_child_target::has_memory) (inf_child_target::has_stack, inf_child_target::has_registers) (inf_child_target::has_execution): New. (inf_child_fileio_open, inf_child_fileio_pwrite) (inf_child_fileio_pread, inf_child_fileio_fstat) (inf_child_fileio_close, inf_child_fileio_unlink) (inf_child_fileio_readlink, inf_child_use_agent) (inf_child_can_use_agent): Refactor as methods of inf_child_target. (return_zero, inf_child_target): Delete. (inf_child_target::inf_child_target): New. * inf-child.h: Include "target.h". (inf_child_target): Delete function prototype. (inf_child_target): New class. (inf_child_open_target, inf_child_mourn_inferior) (inf_child_maybe_unpush_target): Delete. * inf-ptrace.c (inf_ptrace_target::~inf_ptrace_target): New. (inf_ptrace_follow_fork, inf_ptrace_insert_fork_catchpoint) (inf_ptrace_remove_fork_catchpoint, inf_ptrace_create_inferior) (inf_ptrace_post_startup_inferior, inf_ptrace_mourn_inferior) (inf_ptrace_attach, inf_ptrace_post_attach, inf_ptrace_detach) (inf_ptrace_detach_success, inf_ptrace_kill, inf_ptrace_resume) (inf_ptrace_wait, inf_ptrace_xfer_partial) (inf_ptrace_thread_alive, inf_ptrace_files_info) (inf_ptrace_pid_to_str, inf_ptrace_auxv_parse): Refactor as methods of inf_ptrace_target. (inf_ptrace_target): Delete function. * inf-ptrace.h: Include "inf-child.h". (inf_ptrace_target): Delete function declaration. (inf_ptrace_target): New class. (inf_ptrace_trad_target, inf_ptrace_detach_success): Delete. * linux-nat.c (linux_target): New. (linux_ops, linux_ops_saved, super_xfer_partial): Delete. (linux_nat_target::~linux_nat_target): New. (linux_child_post_attach, linux_child_post_startup_inferior) (linux_child_follow_fork, linux_child_insert_fork_catchpoint) (linux_child_remove_fork_catchpoint) (linux_child_insert_vfork_catchpoint) (linux_child_remove_vfork_catchpoint) (linux_child_insert_exec_catchpoint) (linux_child_remove_exec_catchpoint) (linux_child_set_syscall_catchpoint, linux_nat_pass_signals) (linux_nat_create_inferior, linux_nat_attach, linux_nat_detach) (linux_nat_resume, linux_nat_stopped_by_watchpoint) (linux_nat_stopped_data_address) (linux_nat_stopped_by_sw_breakpoint) (linux_nat_supports_stopped_by_sw_breakpoint) (linux_nat_stopped_by_hw_breakpoint) (linux_nat_supports_stopped_by_hw_breakpoint, linux_nat_wait) (linux_nat_kill, linux_nat_mourn_inferior) (linux_nat_xfer_partial, linux_nat_thread_alive) (linux_nat_update_thread_list, linux_nat_pid_to_str) (linux_nat_thread_name, linux_child_pid_to_exec_file) (linux_child_static_tracepoint_markers_by_strid) (linux_nat_is_async_p, linux_nat_can_async_p) (linux_nat_supports_non_stop, linux_nat_always_non_stop_p) (linux_nat_supports_multi_process) (linux_nat_supports_disable_randomization, linux_nat_async) (linux_nat_stop, linux_nat_close, linux_nat_thread_address_space) (linux_nat_core_of_thread, linux_nat_filesystem_is_local) (linux_nat_fileio_open, linux_nat_fileio_readlink) (linux_nat_fileio_unlink, linux_nat_thread_events): Refactor as methods of linux_nat_target. (linux_nat_wait_1, linux_xfer_siginfo, linux_proc_xfer_partial) (linux_proc_xfer_spu, linux_nat_xfer_osdata): Remove target_ops parameter. (check_stopped_by_watchpoint): Adjust. (linux_xfer_partial): Delete. (linux_target_install_ops, linux_target, linux_nat_add_target): Delete. (linux_nat_target::linux_nat_target): New. * linux-nat.h: Include "inf-ptrace.h". (linux_nat_target): New. (linux_target, linux_target_install_ops, linux_nat_add_target): Delete function declarations. (linux_target): Declare global. * linux-thread-db.c (thread_db_target): New. (thread_db_target::thread_db_target): New. (thread_db_ops): Delete. (the_thread_db_target): New. (thread_db_detach, thread_db_wait, thread_db_mourn_inferior) (thread_db_update_thread_list, thread_db_pid_to_str) (thread_db_extra_thread_info) (thread_db_thread_handle_to_thread_info) (thread_db_get_thread_local_address, thread_db_get_ada_task_ptid) (thread_db_resume): Refactor as methods of thread_db_target. (init_thread_db_ops): Delete. (_initialize_thread_db): Remove reference to init_thread_db_ops. * x86-linux-nat.c: Don't include "linux-nat.h". (super_post_startup_inferior): Delete. (x86_linux_nat_target::~x86_linux_nat_target): New. (x86_linux_child_post_startup_inferior) (x86_linux_read_description, x86_linux_enable_btrace) (x86_linux_disable_btrace, x86_linux_teardown_btrace) (x86_linux_read_btrace, x86_linux_btrace_conf): Refactor as methods of x86_linux_nat_target. (x86_linux_create_target): Delete. Bits folded ... (x86_linux_add_target): ... here. Now takes a linux_nat_target pointer. * x86-linux-nat.h: Include "linux-nat.h" and "x86-nat.h". (x86_linux_nat_target): New class. (x86_linux_create_target): Delete. (x86_linux_add_target): Now takes a linux_nat_target pointer. * x86-nat.c (x86_insert_watchpoint, x86_remove_watchpoint) (x86_region_ok_for_watchpoint, x86_stopped_data_address) (x86_stopped_by_watchpoint, x86_insert_hw_breakpoint) (x86_remove_hw_breakpoint, x86_can_use_hw_breakpoint) (x86_stopped_by_hw_breakpoint): Remove target_ops parameter and make extern. (x86_use_watchpoints): Delete. * x86-nat.h: Include "breakpoint.h" and "target.h". (x86_use_watchpoints): Delete. (x86_can_use_hw_breakpoint, x86_region_ok_for_hw_watchpoint) (x86_stopped_by_watchpoint, x86_stopped_data_address) (x86_insert_watchpoint, x86_remove_watchpoint) (x86_insert_hw_breakpoint, x86_remove_hw_breakpoint) (x86_stopped_by_hw_breakpoint): New declarations. (x86_nat_target): New template class. * ppc-linux-nat.c (ppc_linux_nat_target): New class. (the_ppc_linux_nat_target): New. (ppc_linux_fetch_inferior_registers) (ppc_linux_can_use_hw_breakpoint) (ppc_linux_region_ok_for_hw_watchpoint) (ppc_linux_ranged_break_num_registers) (ppc_linux_insert_hw_breakpoint, ppc_linux_remove_hw_breakpoint) (ppc_linux_insert_mask_watchpoint) (ppc_linux_remove_mask_watchpoint) (ppc_linux_can_accel_watchpoint_condition) (ppc_linux_insert_watchpoint, ppc_linux_remove_watchpoint) (ppc_linux_stopped_data_address, ppc_linux_stopped_by_watchpoint) (ppc_linux_watchpoint_addr_within_range) (ppc_linux_masked_watch_num_registers) (ppc_linux_store_inferior_registers, ppc_linux_auxv_parse) (ppc_linux_read_description): Refactor as methods of ppc_linux_nat_target. (_initialize_ppc_linux_nat): Adjust. Set linux_target. * procfs.c (procfs_xfer_partial): Delete forward declaration. (procfs_target): New class. (the_procfs_target): New. (procfs_target): Delete function. (procfs_auxv_parse, procfs_attach, procfs_detach) (procfs_fetch_registers, procfs_store_registers, procfs_wait) (procfs_xfer_partial, procfs_resume, procfs_pass_signals) (procfs_files_info, procfs_kill_inferior, procfs_mourn_inferior) (procfs_create_inferior, procfs_update_thread_list) (procfs_thread_alive, procfs_pid_to_str) (procfs_can_use_hw_breakpoint, procfs_stopped_by_watchpoint) (procfs_stopped_data_address, procfs_insert_watchpoint) (procfs_remove_watchpoint, procfs_region_ok_for_hw_watchpoint) (proc_find_memory_regions, procfs_info_proc) (procfs_make_note_section): Refactor as methods of procfs_target. (_initialize_procfs): Adjust. * sol-thread.c (sol_thread_target): New class. (sol_thread_ops): Now a sol_thread_target. (sol_thread_detach, sol_thread_resume, sol_thread_wait) (sol_thread_fetch_registers, sol_thread_store_registers) (sol_thread_xfer_partial, sol_thread_mourn_inferior) (sol_thread_alive, solaris_pid_to_str, sol_update_thread_list) (sol_get_ada_task_ptid): Refactor as methods of sol_thread_target. (init_sol_thread_ops): Delete. (_initialize_sol_thread): Adjust. Remove references to init_sol_thread_ops and complete_target_initialization. * windows-nat.c (windows_nat_target): New class. (windows_fetch_inferior_registers) (windows_store_inferior_registers, windows_resume, windows_wait) (windows_attach, windows_detach, windows_pid_to_exec_file) (windows_files_info, windows_create_inferior) (windows_mourn_inferior, windows_interrupt, windows_kill_inferior) (windows_close, windows_pid_to_str, windows_xfer_partial) (windows_get_tib_address, windows_get_ada_task_ptid) (windows_thread_name, windows_thread_alive): Refactor as windows_nat_target methods. (do_initial_windows_stuff): Adjust. (windows_target): Delete function. (_initialize_windows_nat): Adjust. * darwin-nat.c (darwin_resume, darwin_wait_to, darwin_interrupt) (darwin_mourn_inferior, darwin_kill_inferior) (darwin_create_inferior, darwin_attach, darwin_detach) (darwin_pid_to_str, darwin_thread_alive, darwin_xfer_partial) (darwin_pid_to_exec_file, darwin_get_ada_task_ptid) (darwin_supports_multi_process): Refactor as darwin_nat_target methods. (darwin_resume_to, darwin_files_info): Delete. (_initialize_darwin_inferior): Rename to ... (_initialize_darwin_nat): ... this. Adjust to C++ification. * darwin-nat.h: Include "inf-child.h". (darwin_nat_target): New class. (darwin_complete_target): Delete. * i386-darwin-nat.c (i386_darwin_nat_target): New class. (darwin_target): New. (i386_darwin_fetch_inferior_registers) (i386_darwin_store_inferior_registers): Refactor as methods of darwin_nat_target. (darwin_complete_target): Delete, with ... (_initialize_i386_darwin_nat): ... bits factored out here. * alpha-linux-nat.c (alpha_linux_nat_target): New class. (the_alpha_linux_nat_target): New. (alpha_linux_register_u_offset): Refactor as alpha_linux_nat_target method. (_initialize_alpha_linux_nat): Adjust. * linux-nat-trad.c (inf_ptrace_register_u_offset): Delete. (inf_ptrace_fetch_register, inf_ptrace_fetch_registers) (inf_ptrace_store_register, inf_ptrace_store_registers): Refact as methods of linux_nat_trad_target. (linux_trad_target): Delete. * linux-nat-trad.h (linux_trad_target): Delete function. (linux_nat_trad_target): New class. * mips-linux-nat.c (mips_linux_nat_target): New class. (super_fetch_registers, super_store_registers, super_close): Delete. (the_mips_linux_nat_target): New. (mips64_linux_regsets_fetch_registers) (mips64_linux_regsets_store_registers) (mips64_linux_fetch_registers, mips64_linux_store_registers) (mips_linux_register_u_offset, mips_linux_read_description) (mips_linux_can_use_hw_breakpoint) (mips_linux_stopped_by_watchpoint) (mips_linux_stopped_data_address) (mips_linux_region_ok_for_hw_watchpoint) (mips_linux_insert_watchpoint, mips_linux_remove_watchpoint) (mips_linux_close): Refactor as methods of mips_linux_nat. (_initialize_mips_linux_nat): Adjust to C++ification. * aix-thread.c (aix_thread_target): New class. (aix_thread_ops): Now an aix_thread_target. (aix_thread_detach, aix_thread_resume, aix_thread_wait) (aix_thread_fetch_registers, aix_thread_store_registers) (aix_thread_xfer_partial, aix_thread_mourn_inferior) (aix_thread_thread_alive, aix_thread_pid_to_str) (aix_thread_extra_thread_info, aix_thread_get_ada_task_ptid): Refactor as methods of aix_thread_target. (init_aix_thread_ops): Delete. (_initialize_aix_thread): Remove references to init_aix_thread_ops and complete_target_initialization. * rs6000-nat.c (rs6000_xfer_shared_libraries): Delete. (rs6000_nat_target): New class. (the_rs6000_nat_target): New. (rs6000_fetch_inferior_registers, rs6000_store_inferior_registers) (rs6000_xfer_partial, rs6000_wait, rs6000_create_inferior) (rs6000_xfer_shared_libraries): Refactor as rs6000_nat_target methods. (super_create_inferior): Delete. (_initialize_rs6000_nat): Adjust to C++ification. * arm-linux-nat.c (arm_linux_nat_target): New class. (the_arm_linux_nat_target): New. (arm_linux_fetch_inferior_registers) (arm_linux_store_inferior_registers, arm_linux_read_description) (arm_linux_can_use_hw_breakpoint, arm_linux_insert_hw_breakpoint) (arm_linux_remove_hw_breakpoint) (arm_linux_region_ok_for_hw_watchpoint) (arm_linux_insert_watchpoint, arm_linux_remove_watchpoint) (arm_linux_stopped_data_address, arm_linux_stopped_by_watchpoint) (arm_linux_watchpoint_addr_within_range): Refactor as methods of arm_linux_nat_target. (_initialize_arm_linux_nat): Adjust to C++ification. * aarch64-linux-nat.c (aarch64_linux_nat_target): New class. (the_aarch64_linux_nat_target): New. (aarch64_linux_fetch_inferior_registers) (aarch64_linux_store_inferior_registers) (aarch64_linux_child_post_startup_inferior) (aarch64_linux_read_description) (aarch64_linux_can_use_hw_breakpoint) (aarch64_linux_insert_hw_breakpoint) (aarch64_linux_remove_hw_breakpoint) (aarch64_linux_insert_watchpoint, aarch64_linux_remove_watchpoint) (aarch64_linux_region_ok_for_hw_watchpoint) (aarch64_linux_stopped_data_address) (aarch64_linux_stopped_by_watchpoint) (aarch64_linux_watchpoint_addr_within_range) (aarch64_linux_can_do_single_step): Refactor as methods of aarch64_linux_nat_target. (super_post_startup_inferior): Delete. (_initialize_aarch64_linux_nat): Adjust to C++ification. * hppa-linux-nat.c (hppa_linux_nat_target): New class. (the_hppa_linux_nat_target): New. (hppa_linux_fetch_inferior_registers) (hppa_linux_store_inferior_registers): Refactor as methods of hppa_linux_nat_target. (_initialize_hppa_linux_nat): Adjust to C++ification. * ia64-linux-nat.c (ia64_linux_nat_target): New class. (the_ia64_linux_nat_target): New. (ia64_linux_insert_watchpoint, ia64_linux_remove_watchpoint) (ia64_linux_stopped_data_address) (ia64_linux_stopped_by_watchpoint, ia64_linux_fetch_registers) (ia64_linux_store_registers, ia64_linux_xfer_partial): Refactor as ia64_linux_nat_target methods. (super_xfer_partial): Delete. (_initialize_ia64_linux_nat): Adjust to C++ification. * m32r-linux-nat.c (m32r_linux_nat_target): New class. (the_m32r_linux_nat_target): New. (m32r_linux_fetch_inferior_registers) (m32r_linux_store_inferior_registers): Refactor as m32r_linux_nat_target methods. (_initialize_m32r_linux_nat): Adjust to C++ification. * m68k-linux-nat.c (m68k_linux_nat_target): New class. (the_m68k_linux_nat_target): New. (m68k_linux_fetch_inferior_registers) (m68k_linux_store_inferior_registers): Refactor as m68k_linux_nat_target methods. (_initialize_m68k_linux_nat): Adjust to C++ification. * s390-linux-nat.c (s390_linux_nat_target): New class. (the_s390_linux_nat_target): New. (s390_linux_fetch_inferior_registers) (s390_linux_store_inferior_registers, s390_stopped_by_watchpoint) (s390_insert_watchpoint, s390_remove_watchpoint) (s390_can_use_hw_breakpoint, s390_insert_hw_breakpoint) (s390_remove_hw_breakpoint, s390_region_ok_for_hw_watchpoint) (s390_auxv_parse, s390_read_description): Refactor as methods of s390_linux_nat_target. (_initialize_s390_nat): Adjust to C++ification. * sparc-linux-nat.c (sparc_linux_nat_target): New class. (the_sparc_linux_nat_target): New. (_initialize_sparc_linux_nat): Adjust to C++ification. * sparc-nat.c (sparc_fetch_inferior_registers) (sparc_store_inferior_registers): Remove target_ops parameter. * sparc-nat.h (sparc_fetch_inferior_registers) (sparc_store_inferior_registers): Remove target_ops parameter. * sparc64-linux-nat.c (sparc64_linux_nat_target): New class. (the_sparc64_linux_nat_target): New. (_initialize_sparc64_linux_nat): Adjust to C++ification. * spu-linux-nat.c (spu_linux_nat_target): New class. (the_spu_linux_nat_target): New. (spu_child_post_startup_inferior, spu_child_post_attach) (spu_child_wait, spu_fetch_inferior_registers) (spu_store_inferior_registers, spu_xfer_partial) (spu_can_use_hw_breakpoint): Refactor as spu_linux_nat_target methods. (_initialize_spu_nat): Adjust to C++ification. * tilegx-linux-nat.c (tilegx_linux_nat_target): New class. (the_tilegx_linux_nat_target): New. (fetch_inferior_registers, store_inferior_registers): Refactor as methods. (_initialize_tile_linux_nat): Adjust to C++ification. * xtensa-linux-nat.c (xtensa_linux_nat_target): New class. (the_xtensa_linux_nat_target): New. (xtensa_linux_fetch_inferior_registers) (xtensa_linux_store_inferior_registers): Refactor as xtensa_linux_nat_target methods. (_initialize_xtensa_linux_nat): Adjust to C++ification. * fbsd-nat.c (USE_SIGTRAP_SIGINFO): Delete. (fbsd_pid_to_exec_file, fbsd_find_memory_regions) (fbsd_find_memory_regions, fbsd_info_proc, fbsd_xfer_partial) (fbsd_thread_alive, fbsd_pid_to_str, fbsd_thread_name) (fbsd_update_thread_list, fbsd_resume, fbsd_wait) (fbsd_stopped_by_sw_breakpoint) (fbsd_supports_stopped_by_sw_breakpoint, fbsd_follow_fork) (fbsd_insert_fork_catchpoint, fbsd_remove_fork_catchpoint) (fbsd_insert_vfork_catchpoint, fbsd_remove_vfork_catchpoint) (fbsd_post_startup_inferior, fbsd_post_attach) (fbsd_insert_exec_catchpoint, fbsd_remove_exec_catchpoint) (fbsd_set_syscall_catchpoint) (super_xfer_partial, super_resume, super_wait) (fbsd_supports_stopped_by_hw_breakpoint): Delete. (fbsd_handle_debug_trap): Remove target_ops parameter. (fbsd_nat_add_target): Delete. * fbsd-nat.h: Include "inf-ptrace.h". (fbsd_nat_add_target): Delete. (USE_SIGTRAP_SIGINFO): Define. (fbsd_nat_target): New class. * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers) (amd64bsd_store_inferior_registers): Remove target_ops parameter. (amd64bsd_target): Delete. * amd64-bsd-nat.h: New file. * amd64-fbsd-nat.c: Include "amd64-bsd-nat.h" instead of "x86-bsd-nat.h". (amd64_fbsd_nat_target): New class. (the_amd64_fbsd_nat_target): New. (amd64fbsd_read_description): Refactor as method of amd64_fbsd_nat_target. (amd64_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New. (_initialize_amd64fbsd_nat): Adjust to C++ification. * amd64-nat.h (amd64bsd_target): Delete function declaration. * i386-bsd-nat.c (i386bsd_fetch_inferior_registers) (i386bsd_store_inferior_registers): Remove target_ops parameter. (i386bsd_target): Delete. * i386-bsd-nat.h (i386bsd_target): Delete function declaration. (i386bsd_fetch_inferior_registers) (i386bsd_store_inferior_registers): Declare. (i386_bsd_nat_target): New class. * i386-fbsd-nat.c (i386_fbsd_nat_target): New class. (the_i386_fbsd_nat_target): New. (i386fbsd_resume, i386fbsd_read_description): Refactor as i386_fbsd_nat_target methods. (i386_fbsd_nat_target::supports_stopped_by_hw_breakpoint): New. (_initialize_i386fbsd_nat): Adjust to C++ification. * x86-bsd-nat.c (super_mourn_inferior): Delete. (x86bsd_mourn_inferior, x86bsd_target): Delete. (_initialize_x86_bsd_nat): Adjust to C++ification. * x86-bsd-nat.h: Include "x86-nat.h". (x86bsd_target): Delete declaration. (x86bsd_nat_target): New class. * aarch64-fbsd-nat.c (aarch64_fbsd_nat_target): New class. (the_aarch64_fbsd_nat_target): New. (aarch64_fbsd_fetch_inferior_registers) (aarch64_fbsd_store_inferior_registers): Refactor as methods of aarch64_fbsd_nat_target. (_initialize_aarch64_fbsd_nat): Adjust to C++ification. * alpha-bsd-nat.c (alpha_bsd_nat_target): New class. (the_alpha_bsd_nat_target): New. (alphabsd_fetch_inferior_registers) (alphabsd_store_inferior_registers): Refactor as alpha_bsd_nat_target methods. (_initialize_alphabsd_nat): Refactor as methods of alpha_bsd_nat_target. * amd64-nbsd-nat.c: Include "amd64-bsd-nat.h". (the_amd64_nbsd_nat_target): New. (_initialize_amd64nbsd_nat): Adjust to C++ification. * amd64-obsd-nat.c: Include "amd64-bsd-nat.h". (the_amd64_obsd_nat_target): New. (_initialize_amd64obsd_nat): Adjust to C++ification. * arm-fbsd-nat.c (arm_fbsd_nat_target): New. (the_arm_fbsd_nat_target): New. (arm_fbsd_fetch_inferior_registers) (arm_fbsd_store_inferior_registers, arm_fbsd_read_description): (_initialize_arm_fbsd_nat): Refactor as methods of arm_fbsd_nat_target. (_initialize_arm_fbsd_nat): Adjust to C++ification. * arm-nbsd-nat.c (arm_netbsd_nat_target): New class. (the_arm_netbsd_nat_target): New. (armnbsd_fetch_registers, armnbsd_store_registers): Refactor as arm_netbsd_nat_target. (_initialize_arm_netbsd_nat): Adjust to C++ification. * hppa-nbsd-nat.c (hppa_nbsd_nat_target): New class. (the_hppa_nbsd_nat_target): New. (hppanbsd_fetch_registers, hppanbsd_store_registers): Refactor as hppa_nbsd_nat_target methods. (_initialize_hppanbsd_nat): Adjust to C++ification. * hppa-obsd-nat.c (hppa_obsd_nat_target): New class. (the_hppa_obsd_nat_target): New. (hppaobsd_fetch_registers, hppaobsd_store_registers): Refactor as methods of hppa_obsd_nat_target. (_initialize_hppaobsd_nat): Adjust to C++ification. Use add_target. * i386-nbsd-nat.c (the_i386_nbsd_nat_target): New. (_initialize_i386nbsd_nat): Adjust to C++ification. Use add_target. * i386-obsd-nat.c (the_i386_obsd_nat_target): New. (_initialize_i386obsd_nat): Use add_target. * m68k-bsd-nat.c (m68k_bsd_nat_target): New class. (the_m68k_bsd_nat_target): New. (m68kbsd_fetch_inferior_registers) (m68kbsd_store_inferior_registers): Refactor as methods of m68k_bsd_nat_target. (_initialize_m68kbsd_nat): Adjust to C++ification. * mips-fbsd-nat.c (mips_fbsd_nat_target): New class. (the_mips_fbsd_nat_target): New. (mips_fbsd_fetch_inferior_registers) (mips_fbsd_store_inferior_registers): Refactor as methods of mips_fbsd_nat_target. (_initialize_mips_fbsd_nat): Adjust to C++ification. Use add_target. * mips-nbsd-nat.c (mips_nbsd_nat_target): New class. (the_mips_nbsd_nat_target): New. (mipsnbsd_fetch_inferior_registers) (mipsnbsd_store_inferior_registers): Refactor as methods of mips_nbsd_nat_target. (_initialize_mipsnbsd_nat): Adjust to C++ification. * mips64-obsd-nat.c (mips64_obsd_nat_target): New class. (the_mips64_obsd_nat_target): New. (mips64obsd_fetch_inferior_registers) (mips64obsd_store_inferior_registers): Refactor as methods of mips64_obsd_nat_target. (_initialize_mips64obsd_nat): Adjust to C++ification. Use add_target. * nbsd-nat.c (nbsd_pid_to_exec_file): Refactor as method of nbsd_nat_target. * nbsd-nat.h: Include "inf-ptrace.h". (nbsd_nat_target): New class. * obsd-nat.c (obsd_pid_to_str, obsd_update_thread_list) (obsd_wait): Refactor as methods of obsd_nat_target. (obsd_add_target): Delete. * obsd-nat.h: Include "inf-ptrace.h". (obsd_nat_target): New class. * ppc-fbsd-nat.c (ppc_fbsd_nat_target): New class. (the_ppc_fbsd_nat_target): New. (ppcfbsd_fetch_inferior_registers) (ppcfbsd_store_inferior_registers): Refactor as methods of ppc_fbsd_nat_target. (_initialize_ppcfbsd_nat): Adjust to C++ification. Use add_target. * ppc-nbsd-nat.c (ppc_nbsd_nat_target): New class. (the_ppc_nbsd_nat_target): New. (ppcnbsd_fetch_inferior_registers) (ppcnbsd_store_inferior_registers): Refactor as methods of ppc_nbsd_nat_target. (_initialize_ppcnbsd_nat): Adjust to C++ification. * ppc-obsd-nat.c (ppc_obsd_nat_target): New class. (the_ppc_obsd_nat_target): New. (ppcobsd_fetch_registers, ppcobsd_store_registers): Refactor as methods of ppc_obsd_nat_target. (_initialize_ppcobsd_nat): Adjust to C++ification. Use add_target. * sh-nbsd-nat.c (sh_nbsd_nat_target): New class. (the_sh_nbsd_nat_target): New. (shnbsd_fetch_inferior_registers) (shnbsd_store_inferior_registers): Refactor as methods of sh_nbsd_nat_target. (_initialize_shnbsd_nat): Adjust to C++ification. * sparc-nat.c (sparc_xfer_wcookie): Make extern. (inf_ptrace_xfer_partial): Delete. (sparc_xfer_partial, sparc_target): Delete. * sparc-nat.h (sparc_fetch_inferior_registers) (sparc_store_inferior_registers, sparc_xfer_wcookie): Declare. (sparc_target): Delete function declaration. (sparc_target): New template class. * sparc-nbsd-nat.c (the_sparc_nbsd_nat_target): New. (_initialize_sparcnbsd_nat): Adjust to C++ification. * sparc64-fbsd-nat.c (the_sparc64_fbsd_nat_target): New. (_initialize_sparc64fbsd_nat): Adjust to C++ification. Use add_target. * sparc64-nbsd-nat.c (the_sparc64_nbsd_nat_target): New. (_initialize_sparc64nbsd_nat): Adjust to C++ification. * sparc64-obsd-nat.c (the_sparc64_obsd_nat_target): New. (_initialize_sparc64obsd_nat): Adjust to C++ification. Use add_target. * vax-bsd-nat.c (vax_bsd_nat_target): New class. (the_vax_bsd_nat_target): New. (vaxbsd_fetch_inferior_registers) (vaxbsd_store_inferior_registers): Refactor as vax_bsd_nat_target methods. (_initialize_vaxbsd_nat): Adjust to C++ification. * bsd-kvm.c (bsd_kvm_target): New class. (bsd_kvm_ops): Now a bsd_kvm_target. (bsd_kvm_open, bsd_kvm_close, bsd_kvm_xfer_partial) (bsd_kvm_files_info, bsd_kvm_fetch_registers) (bsd_kvm_thread_alive, bsd_kvm_pid_to_str): Refactor as methods of bsd_kvm_target. (bsd_kvm_return_one): Delete. (bsd_kvm_add_target): Adjust to C++ification. * nto-procfs.c (nto_procfs_target, nto_procfs_target_native) (nto_procfs_target_procfs): New classes. (procfs_open_1, procfs_thread_alive, procfs_update_thread_list) (procfs_files_info, procfs_pid_to_exec_file, procfs_attach) (procfs_post_attach, procfs_wait, procfs_fetch_registers) (procfs_xfer_partial, procfs_detach, procfs_insert_breakpoint) (procfs_remove_breakpoint, procfs_insert_hw_breakpoint) (procfs_remove_hw_breakpoint, procfs_resume) (procfs_mourn_inferior, procfs_create_inferior, procfs_interrupt) (procfs_kill_inferior, procfs_store_registers) (procfs_pass_signals, procfs_pid_to_str, procfs_can_run): Refactor as methods of nto_procfs_target. (nto_procfs_ops): Now an nto_procfs_target_procfs. (nto_native_ops): Delete. (procfs_open, procfs_native_open): Delete. (nto_native_ops): Now an nto_procfs_target_native. (init_procfs_targets): Adjust to C++ification. (procfs_can_use_hw_breakpoint, procfs_remove_hw_watchpoint) (procfs_insert_hw_watchpoint, procfs_stopped_by_watchpoint): Refactor as methods of nto_procfs_target. * go32-nat.c (go32_nat_target): New class. (the_go32_nat_target): New. (go32_attach, go32_resume, go32_wait, go32_fetch_registers) (go32_store_registers, go32_xfer_partial, go32_files_info) (go32_kill_inferior, go32_create_inferior, go32_mourn_inferior) (go32_terminal_init, go32_terminal_info, go32_terminal_inferior) (go32_terminal_ours, go32_pass_ctrlc, go32_thread_alive) (go32_pid_to_str): Refactor as methods of go32_nat_target. (go32_target): Delete. (_initialize_go32_nat): Adjust to C++ification. * gnu-nat.c (gnu_wait, gnu_resume, gnu_kill_inferior) (gnu_mourn_inferior, gnu_create_inferior, gnu_attach, gnu_detach) (gnu_stop, gnu_thread_alive, gnu_xfer_partial) (gnu_find_memory_regions, gnu_pid_to_str): Refactor as methods of gnu_nat_target. (gnu_target): Delete. * gnu-nat.h (gnu_target): Delete. (gnu_nat_target): New class. * i386-gnu-nat.c (gnu_base_target): New. (i386_gnu_nat_target): New class. (the_i386_gnu_nat_target): New. (_initialize_i386gnu_nat): Adjust to C++ification. gdb/testsuite/ChangeLog: 2018-05-02 Pedro Alves <palves@redhat.com> * gdb.base/breakpoint-in-ro-region.exp: Adjust to to_resume and to_log_command renames. * gdb.base/sss-bp-on-user-bp-2.exp: Likewise.
1489 lines
47 KiB
C
1489 lines
47 KiB
C
/* Read ELF (Executable and Linking Format) object files for GDB.
|
||
|
||
Copyright (C) 1991-2018 Free Software Foundation, Inc.
|
||
|
||
Written by Fred Fish at Cygnus Support.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include "bfd.h"
|
||
#include "elf-bfd.h"
|
||
#include "elf/common.h"
|
||
#include "elf/internal.h"
|
||
#include "elf/mips.h"
|
||
#include "symtab.h"
|
||
#include "symfile.h"
|
||
#include "objfiles.h"
|
||
#include "buildsym.h"
|
||
#include "stabsread.h"
|
||
#include "gdb-stabs.h"
|
||
#include "complaints.h"
|
||
#include "demangle.h"
|
||
#include "psympriv.h"
|
||
#include "filenames.h"
|
||
#include "probe.h"
|
||
#include "arch-utils.h"
|
||
#include "gdbtypes.h"
|
||
#include "value.h"
|
||
#include "infcall.h"
|
||
#include "gdbthread.h"
|
||
#include "regcache.h"
|
||
#include "bcache.h"
|
||
#include "gdb_bfd.h"
|
||
#include "build-id.h"
|
||
#include "location.h"
|
||
#include "auxv.h"
|
||
|
||
/* Forward declarations. */
|
||
extern const struct sym_fns elf_sym_fns_gdb_index;
|
||
extern const struct sym_fns elf_sym_fns_debug_names;
|
||
extern const struct sym_fns elf_sym_fns_lazy_psyms;
|
||
|
||
/* The struct elfinfo is available only during ELF symbol table and
|
||
psymtab reading. It is destroyed at the completion of psymtab-reading.
|
||
It's local to elf_symfile_read. */
|
||
|
||
struct elfinfo
|
||
{
|
||
asection *stabsect; /* Section pointer for .stab section */
|
||
asection *mdebugsect; /* Section pointer for .mdebug section */
|
||
};
|
||
|
||
/* Per-BFD data for probe info. */
|
||
|
||
static const struct bfd_data *probe_key = NULL;
|
||
|
||
/* Minimal symbols located at the GOT entries for .plt - that is the real
|
||
pointer where the given entry will jump to. It gets updated by the real
|
||
function address during lazy ld.so resolving in the inferior. These
|
||
minimal symbols are indexed for <tab>-completion. */
|
||
|
||
#define SYMBOL_GOT_PLT_SUFFIX "@got.plt"
|
||
|
||
/* Locate the segments in ABFD. */
|
||
|
||
static struct symfile_segment_data *
|
||
elf_symfile_segments (bfd *abfd)
|
||
{
|
||
Elf_Internal_Phdr *phdrs, **segments;
|
||
long phdrs_size;
|
||
int num_phdrs, num_segments, num_sections, i;
|
||
asection *sect;
|
||
struct symfile_segment_data *data;
|
||
|
||
phdrs_size = bfd_get_elf_phdr_upper_bound (abfd);
|
||
if (phdrs_size == -1)
|
||
return NULL;
|
||
|
||
phdrs = (Elf_Internal_Phdr *) alloca (phdrs_size);
|
||
num_phdrs = bfd_get_elf_phdrs (abfd, phdrs);
|
||
if (num_phdrs == -1)
|
||
return NULL;
|
||
|
||
num_segments = 0;
|
||
segments = XALLOCAVEC (Elf_Internal_Phdr *, num_phdrs);
|
||
for (i = 0; i < num_phdrs; i++)
|
||
if (phdrs[i].p_type == PT_LOAD)
|
||
segments[num_segments++] = &phdrs[i];
|
||
|
||
if (num_segments == 0)
|
||
return NULL;
|
||
|
||
data = XCNEW (struct symfile_segment_data);
|
||
data->num_segments = num_segments;
|
||
data->segment_bases = XCNEWVEC (CORE_ADDR, num_segments);
|
||
data->segment_sizes = XCNEWVEC (CORE_ADDR, num_segments);
|
||
|
||
for (i = 0; i < num_segments; i++)
|
||
{
|
||
data->segment_bases[i] = segments[i]->p_vaddr;
|
||
data->segment_sizes[i] = segments[i]->p_memsz;
|
||
}
|
||
|
||
num_sections = bfd_count_sections (abfd);
|
||
data->segment_info = XCNEWVEC (int, num_sections);
|
||
|
||
for (i = 0, sect = abfd->sections; sect != NULL; i++, sect = sect->next)
|
||
{
|
||
int j;
|
||
CORE_ADDR vma;
|
||
|
||
if ((bfd_get_section_flags (abfd, sect) & SEC_ALLOC) == 0)
|
||
continue;
|
||
|
||
vma = bfd_get_section_vma (abfd, sect);
|
||
|
||
for (j = 0; j < num_segments; j++)
|
||
if (segments[j]->p_memsz > 0
|
||
&& vma >= segments[j]->p_vaddr
|
||
&& (vma - segments[j]->p_vaddr) < segments[j]->p_memsz)
|
||
{
|
||
data->segment_info[i] = j + 1;
|
||
break;
|
||
}
|
||
|
||
/* We should have found a segment for every non-empty section.
|
||
If we haven't, we will not relocate this section by any
|
||
offsets we apply to the segments. As an exception, do not
|
||
warn about SHT_NOBITS sections; in normal ELF execution
|
||
environments, SHT_NOBITS means zero-initialized and belongs
|
||
in a segment, but in no-OS environments some tools (e.g. ARM
|
||
RealView) use SHT_NOBITS for uninitialized data. Since it is
|
||
uninitialized, it doesn't need a program header. Such
|
||
binaries are not relocatable. */
|
||
if (bfd_get_section_size (sect) > 0 && j == num_segments
|
||
&& (bfd_get_section_flags (abfd, sect) & SEC_LOAD) != 0)
|
||
warning (_("Loadable section \"%s\" outside of ELF segments"),
|
||
bfd_section_name (abfd, sect));
|
||
}
|
||
|
||
return data;
|
||
}
|
||
|
||
/* We are called once per section from elf_symfile_read. We
|
||
need to examine each section we are passed, check to see
|
||
if it is something we are interested in processing, and
|
||
if so, stash away some access information for the section.
|
||
|
||
For now we recognize the dwarf debug information sections and
|
||
line number sections from matching their section names. The
|
||
ELF definition is no real help here since it has no direct
|
||
knowledge of DWARF (by design, so any debugging format can be
|
||
used).
|
||
|
||
We also recognize the ".stab" sections used by the Sun compilers
|
||
released with Solaris 2.
|
||
|
||
FIXME: The section names should not be hardwired strings (what
|
||
should they be? I don't think most object file formats have enough
|
||
section flags to specify what kind of debug section it is.
|
||
-kingdon). */
|
||
|
||
static void
|
||
elf_locate_sections (bfd *ignore_abfd, asection *sectp, void *eip)
|
||
{
|
||
struct elfinfo *ei;
|
||
|
||
ei = (struct elfinfo *) eip;
|
||
if (strcmp (sectp->name, ".stab") == 0)
|
||
{
|
||
ei->stabsect = sectp;
|
||
}
|
||
else if (strcmp (sectp->name, ".mdebug") == 0)
|
||
{
|
||
ei->mdebugsect = sectp;
|
||
}
|
||
}
|
||
|
||
static struct minimal_symbol *
|
||
record_minimal_symbol (minimal_symbol_reader &reader,
|
||
const char *name, int name_len, bool copy_name,
|
||
CORE_ADDR address,
|
||
enum minimal_symbol_type ms_type,
|
||
asection *bfd_section, struct objfile *objfile)
|
||
{
|
||
struct gdbarch *gdbarch = get_objfile_arch (objfile);
|
||
|
||
if (ms_type == mst_text || ms_type == mst_file_text
|
||
|| ms_type == mst_text_gnu_ifunc)
|
||
address = gdbarch_addr_bits_remove (gdbarch, address);
|
||
|
||
return reader.record_full (name, name_len, copy_name, address,
|
||
ms_type,
|
||
gdb_bfd_section_index (objfile->obfd,
|
||
bfd_section));
|
||
}
|
||
|
||
/* Read the symbol table of an ELF file.
|
||
|
||
Given an objfile, a symbol table, and a flag indicating whether the
|
||
symbol table contains regular, dynamic, or synthetic symbols, add all
|
||
the global function and data symbols to the minimal symbol table.
|
||
|
||
In stabs-in-ELF, as implemented by Sun, there are some local symbols
|
||
defined in the ELF symbol table, which can be used to locate
|
||
the beginnings of sections from each ".o" file that was linked to
|
||
form the executable objfile. We gather any such info and record it
|
||
in data structures hung off the objfile's private data. */
|
||
|
||
#define ST_REGULAR 0
|
||
#define ST_DYNAMIC 1
|
||
#define ST_SYNTHETIC 2
|
||
|
||
static void
|
||
elf_symtab_read (minimal_symbol_reader &reader,
|
||
struct objfile *objfile, int type,
|
||
long number_of_symbols, asymbol **symbol_table,
|
||
bool copy_names)
|
||
{
|
||
struct gdbarch *gdbarch = get_objfile_arch (objfile);
|
||
asymbol *sym;
|
||
long i;
|
||
CORE_ADDR symaddr;
|
||
enum minimal_symbol_type ms_type;
|
||
/* Name of the last file symbol. This is either a constant string or is
|
||
saved on the objfile's filename cache. */
|
||
const char *filesymname = "";
|
||
int stripped = (bfd_get_symcount (objfile->obfd) == 0);
|
||
int elf_make_msymbol_special_p
|
||
= gdbarch_elf_make_msymbol_special_p (gdbarch);
|
||
|
||
for (i = 0; i < number_of_symbols; i++)
|
||
{
|
||
sym = symbol_table[i];
|
||
if (sym->name == NULL || *sym->name == '\0')
|
||
{
|
||
/* Skip names that don't exist (shouldn't happen), or names
|
||
that are null strings (may happen). */
|
||
continue;
|
||
}
|
||
|
||
/* Skip "special" symbols, e.g. ARM mapping symbols. These are
|
||
symbols which do not correspond to objects in the symbol table,
|
||
but have some other target-specific meaning. */
|
||
if (bfd_is_target_special_symbol (objfile->obfd, sym))
|
||
{
|
||
if (gdbarch_record_special_symbol_p (gdbarch))
|
||
gdbarch_record_special_symbol (gdbarch, objfile, sym);
|
||
continue;
|
||
}
|
||
|
||
if (type == ST_DYNAMIC
|
||
&& sym->section == bfd_und_section_ptr
|
||
&& (sym->flags & BSF_FUNCTION))
|
||
{
|
||
struct minimal_symbol *msym;
|
||
bfd *abfd = objfile->obfd;
|
||
asection *sect;
|
||
|
||
/* Symbol is a reference to a function defined in
|
||
a shared library.
|
||
If its value is non zero then it is usually the address
|
||
of the corresponding entry in the procedure linkage table,
|
||
plus the desired section offset.
|
||
If its value is zero then the dynamic linker has to resolve
|
||
the symbol. We are unable to find any meaningful address
|
||
for this symbol in the executable file, so we skip it. */
|
||
symaddr = sym->value;
|
||
if (symaddr == 0)
|
||
continue;
|
||
|
||
/* sym->section is the undefined section. However, we want to
|
||
record the section where the PLT stub resides with the
|
||
minimal symbol. Search the section table for the one that
|
||
covers the stub's address. */
|
||
for (sect = abfd->sections; sect != NULL; sect = sect->next)
|
||
{
|
||
if ((bfd_get_section_flags (abfd, sect) & SEC_ALLOC) == 0)
|
||
continue;
|
||
|
||
if (symaddr >= bfd_get_section_vma (abfd, sect)
|
||
&& symaddr < bfd_get_section_vma (abfd, sect)
|
||
+ bfd_get_section_size (sect))
|
||
break;
|
||
}
|
||
if (!sect)
|
||
continue;
|
||
|
||
/* On ia64-hpux, we have discovered that the system linker
|
||
adds undefined symbols with nonzero addresses that cannot
|
||
be right (their address points inside the code of another
|
||
function in the .text section). This creates problems
|
||
when trying to determine which symbol corresponds to
|
||
a given address.
|
||
|
||
We try to detect those buggy symbols by checking which
|
||
section we think they correspond to. Normally, PLT symbols
|
||
are stored inside their own section, and the typical name
|
||
for that section is ".plt". So, if there is a ".plt"
|
||
section, and yet the section name of our symbol does not
|
||
start with ".plt", we ignore that symbol. */
|
||
if (!startswith (sect->name, ".plt")
|
||
&& bfd_get_section_by_name (abfd, ".plt") != NULL)
|
||
continue;
|
||
|
||
msym = record_minimal_symbol
|
||
(reader, sym->name, strlen (sym->name), copy_names,
|
||
symaddr, mst_solib_trampoline, sect, objfile);
|
||
if (msym != NULL)
|
||
{
|
||
msym->filename = filesymname;
|
||
if (elf_make_msymbol_special_p)
|
||
gdbarch_elf_make_msymbol_special (gdbarch, sym, msym);
|
||
}
|
||
continue;
|
||
}
|
||
|
||
/* If it is a nonstripped executable, do not enter dynamic
|
||
symbols, as the dynamic symbol table is usually a subset
|
||
of the main symbol table. */
|
||
if (type == ST_DYNAMIC && !stripped)
|
||
continue;
|
||
if (sym->flags & BSF_FILE)
|
||
{
|
||
filesymname
|
||
= (const char *) bcache (sym->name, strlen (sym->name) + 1,
|
||
objfile->per_bfd->filename_cache);
|
||
}
|
||
else if (sym->flags & BSF_SECTION_SYM)
|
||
continue;
|
||
else if (sym->flags & (BSF_GLOBAL | BSF_LOCAL | BSF_WEAK
|
||
| BSF_GNU_UNIQUE))
|
||
{
|
||
struct minimal_symbol *msym;
|
||
|
||
/* Select global/local/weak symbols. Note that bfd puts abs
|
||
symbols in their own section, so all symbols we are
|
||
interested in will have a section. */
|
||
/* Bfd symbols are section relative. */
|
||
symaddr = sym->value + sym->section->vma;
|
||
/* For non-absolute symbols, use the type of the section
|
||
they are relative to, to intuit text/data. Bfd provides
|
||
no way of figuring this out for absolute symbols. */
|
||
if (sym->section == bfd_abs_section_ptr)
|
||
{
|
||
/* This is a hack to get the minimal symbol type
|
||
right for Irix 5, which has absolute addresses
|
||
with special section indices for dynamic symbols.
|
||
|
||
NOTE: uweigand-20071112: Synthetic symbols do not
|
||
have an ELF-private part, so do not touch those. */
|
||
unsigned int shndx = type == ST_SYNTHETIC ? 0 :
|
||
((elf_symbol_type *) sym)->internal_elf_sym.st_shndx;
|
||
|
||
switch (shndx)
|
||
{
|
||
case SHN_MIPS_TEXT:
|
||
ms_type = mst_text;
|
||
break;
|
||
case SHN_MIPS_DATA:
|
||
ms_type = mst_data;
|
||
break;
|
||
case SHN_MIPS_ACOMMON:
|
||
ms_type = mst_bss;
|
||
break;
|
||
default:
|
||
ms_type = mst_abs;
|
||
}
|
||
|
||
/* If it is an Irix dynamic symbol, skip section name
|
||
symbols, relocate all others by section offset. */
|
||
if (ms_type != mst_abs)
|
||
{
|
||
if (sym->name[0] == '.')
|
||
continue;
|
||
}
|
||
}
|
||
else if (sym->section->flags & SEC_CODE)
|
||
{
|
||
if (sym->flags & (BSF_GLOBAL | BSF_WEAK | BSF_GNU_UNIQUE))
|
||
{
|
||
if (sym->flags & BSF_GNU_INDIRECT_FUNCTION)
|
||
ms_type = mst_text_gnu_ifunc;
|
||
else
|
||
ms_type = mst_text;
|
||
}
|
||
/* The BSF_SYNTHETIC check is there to omit ppc64 function
|
||
descriptors mistaken for static functions starting with 'L'.
|
||
*/
|
||
else if ((sym->name[0] == '.' && sym->name[1] == 'L'
|
||
&& (sym->flags & BSF_SYNTHETIC) == 0)
|
||
|| ((sym->flags & BSF_LOCAL)
|
||
&& sym->name[0] == '$'
|
||
&& sym->name[1] == 'L'))
|
||
/* Looks like a compiler-generated label. Skip
|
||
it. The assembler should be skipping these (to
|
||
keep executables small), but apparently with
|
||
gcc on the (deleted) delta m88k SVR4, it loses.
|
||
So to have us check too should be harmless (but
|
||
I encourage people to fix this in the assembler
|
||
instead of adding checks here). */
|
||
continue;
|
||
else
|
||
{
|
||
ms_type = mst_file_text;
|
||
}
|
||
}
|
||
else if (sym->section->flags & SEC_ALLOC)
|
||
{
|
||
if (sym->flags & (BSF_GLOBAL | BSF_WEAK | BSF_GNU_UNIQUE))
|
||
{
|
||
if (sym->flags & BSF_GNU_INDIRECT_FUNCTION)
|
||
{
|
||
ms_type = mst_data_gnu_ifunc;
|
||
}
|
||
else if (sym->section->flags & SEC_LOAD)
|
||
{
|
||
ms_type = mst_data;
|
||
}
|
||
else
|
||
{
|
||
ms_type = mst_bss;
|
||
}
|
||
}
|
||
else if (sym->flags & BSF_LOCAL)
|
||
{
|
||
if (sym->section->flags & SEC_LOAD)
|
||
{
|
||
ms_type = mst_file_data;
|
||
}
|
||
else
|
||
{
|
||
ms_type = mst_file_bss;
|
||
}
|
||
}
|
||
else
|
||
{
|
||
ms_type = mst_unknown;
|
||
}
|
||
}
|
||
else
|
||
{
|
||
/* FIXME: Solaris2 shared libraries include lots of
|
||
odd "absolute" and "undefined" symbols, that play
|
||
hob with actions like finding what function the PC
|
||
is in. Ignore them if they aren't text, data, or bss. */
|
||
/* ms_type = mst_unknown; */
|
||
continue; /* Skip this symbol. */
|
||
}
|
||
msym = record_minimal_symbol
|
||
(reader, sym->name, strlen (sym->name), copy_names, symaddr,
|
||
ms_type, sym->section, objfile);
|
||
|
||
if (msym)
|
||
{
|
||
/* NOTE: uweigand-20071112: A synthetic symbol does not have an
|
||
ELF-private part. */
|
||
if (type != ST_SYNTHETIC)
|
||
{
|
||
/* Pass symbol size field in via BFD. FIXME!!! */
|
||
elf_symbol_type *elf_sym = (elf_symbol_type *) sym;
|
||
SET_MSYMBOL_SIZE (msym, elf_sym->internal_elf_sym.st_size);
|
||
}
|
||
|
||
msym->filename = filesymname;
|
||
if (elf_make_msymbol_special_p)
|
||
gdbarch_elf_make_msymbol_special (gdbarch, sym, msym);
|
||
}
|
||
|
||
/* If we see a default versioned symbol, install it under
|
||
its version-less name. */
|
||
if (msym != NULL)
|
||
{
|
||
const char *atsign = strchr (sym->name, '@');
|
||
|
||
if (atsign != NULL && atsign[1] == '@' && atsign > sym->name)
|
||
{
|
||
int len = atsign - sym->name;
|
||
|
||
record_minimal_symbol (reader, sym->name, len, true, symaddr,
|
||
ms_type, sym->section, objfile);
|
||
}
|
||
}
|
||
|
||
/* For @plt symbols, also record a trampoline to the
|
||
destination symbol. The @plt symbol will be used in
|
||
disassembly, and the trampoline will be used when we are
|
||
trying to find the target. */
|
||
if (msym && ms_type == mst_text && type == ST_SYNTHETIC)
|
||
{
|
||
int len = strlen (sym->name);
|
||
|
||
if (len > 4 && strcmp (sym->name + len - 4, "@plt") == 0)
|
||
{
|
||
struct minimal_symbol *mtramp;
|
||
|
||
mtramp = record_minimal_symbol (reader, sym->name, len - 4,
|
||
true, symaddr,
|
||
mst_solib_trampoline,
|
||
sym->section, objfile);
|
||
if (mtramp)
|
||
{
|
||
SET_MSYMBOL_SIZE (mtramp, MSYMBOL_SIZE (msym));
|
||
mtramp->created_by_gdb = 1;
|
||
mtramp->filename = filesymname;
|
||
if (elf_make_msymbol_special_p)
|
||
gdbarch_elf_make_msymbol_special (gdbarch,
|
||
sym, mtramp);
|
||
}
|
||
}
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
/* Build minimal symbols named `function@got.plt' (see SYMBOL_GOT_PLT_SUFFIX)
|
||
for later look ups of which function to call when user requests
|
||
a STT_GNU_IFUNC function. As the STT_GNU_IFUNC type is found at the target
|
||
library defining `function' we cannot yet know while reading OBJFILE which
|
||
of the SYMBOL_GOT_PLT_SUFFIX entries will be needed and later
|
||
DYN_SYMBOL_TABLE is no longer easily available for OBJFILE. */
|
||
|
||
static void
|
||
elf_rel_plt_read (minimal_symbol_reader &reader,
|
||
struct objfile *objfile, asymbol **dyn_symbol_table)
|
||
{
|
||
bfd *obfd = objfile->obfd;
|
||
const struct elf_backend_data *bed = get_elf_backend_data (obfd);
|
||
asection *relplt, *got_plt;
|
||
bfd_size_type reloc_count, reloc;
|
||
struct gdbarch *gdbarch = get_objfile_arch (objfile);
|
||
struct type *ptr_type = builtin_type (gdbarch)->builtin_data_ptr;
|
||
size_t ptr_size = TYPE_LENGTH (ptr_type);
|
||
|
||
if (objfile->separate_debug_objfile_backlink)
|
||
return;
|
||
|
||
got_plt = bfd_get_section_by_name (obfd, ".got.plt");
|
||
if (got_plt == NULL)
|
||
{
|
||
/* For platforms where there is no separate .got.plt. */
|
||
got_plt = bfd_get_section_by_name (obfd, ".got");
|
||
if (got_plt == NULL)
|
||
return;
|
||
}
|
||
|
||
/* Depending on system, we may find jump slots in a relocation
|
||
section for either .got.plt or .plt. */
|
||
asection *plt = bfd_get_section_by_name (obfd, ".plt");
|
||
int plt_elf_idx = (plt != NULL) ? elf_section_data (plt)->this_idx : -1;
|
||
|
||
int got_plt_elf_idx = elf_section_data (got_plt)->this_idx;
|
||
|
||
/* This search algorithm is from _bfd_elf_canonicalize_dynamic_reloc. */
|
||
for (relplt = obfd->sections; relplt != NULL; relplt = relplt->next)
|
||
{
|
||
const auto &this_hdr = elf_section_data (relplt)->this_hdr;
|
||
|
||
if (this_hdr.sh_type == SHT_REL || this_hdr.sh_type == SHT_RELA)
|
||
{
|
||
if (this_hdr.sh_info == plt_elf_idx
|
||
|| this_hdr.sh_info == got_plt_elf_idx)
|
||
break;
|
||
}
|
||
}
|
||
if (relplt == NULL)
|
||
return;
|
||
|
||
if (! bed->s->slurp_reloc_table (obfd, relplt, dyn_symbol_table, TRUE))
|
||
return;
|
||
|
||
std::string string_buffer;
|
||
|
||
/* Does ADDRESS reside in SECTION of OBFD? */
|
||
auto within_section = [obfd] (asection *section, CORE_ADDR address)
|
||
{
|
||
if (section == NULL)
|
||
return false;
|
||
|
||
return (bfd_get_section_vma (obfd, section) <= address
|
||
&& (address < bfd_get_section_vma (obfd, section)
|
||
+ bfd_get_section_size (section)));
|
||
};
|
||
|
||
reloc_count = relplt->size / elf_section_data (relplt)->this_hdr.sh_entsize;
|
||
for (reloc = 0; reloc < reloc_count; reloc++)
|
||
{
|
||
const char *name;
|
||
struct minimal_symbol *msym;
|
||
CORE_ADDR address;
|
||
const char *got_suffix = SYMBOL_GOT_PLT_SUFFIX;
|
||
const size_t got_suffix_len = strlen (SYMBOL_GOT_PLT_SUFFIX);
|
||
|
||
name = bfd_asymbol_name (*relplt->relocation[reloc].sym_ptr_ptr);
|
||
address = relplt->relocation[reloc].address;
|
||
|
||
asection *msym_section;
|
||
|
||
/* Does the pointer reside in either the .got.plt or .plt
|
||
sections? */
|
||
if (within_section (got_plt, address))
|
||
msym_section = got_plt;
|
||
else if (within_section (plt, address))
|
||
msym_section = plt;
|
||
else
|
||
continue;
|
||
|
||
/* We cannot check if NAME is a reference to
|
||
mst_text_gnu_ifunc/mst_data_gnu_ifunc as in OBJFILE the
|
||
symbol is undefined and the objfile having NAME defined may
|
||
not yet have been loaded. */
|
||
|
||
string_buffer.assign (name);
|
||
string_buffer.append (got_suffix, got_suffix + got_suffix_len);
|
||
|
||
msym = record_minimal_symbol (reader, string_buffer.c_str (),
|
||
string_buffer.size (),
|
||
true, address, mst_slot_got_plt,
|
||
msym_section, objfile);
|
||
if (msym)
|
||
SET_MSYMBOL_SIZE (msym, ptr_size);
|
||
}
|
||
}
|
||
|
||
/* The data pointer is htab_t for gnu_ifunc_record_cache_unchecked. */
|
||
|
||
static const struct objfile_data *elf_objfile_gnu_ifunc_cache_data;
|
||
|
||
/* Map function names to CORE_ADDR in elf_objfile_gnu_ifunc_cache_data. */
|
||
|
||
struct elf_gnu_ifunc_cache
|
||
{
|
||
/* This is always a function entry address, not a function descriptor. */
|
||
CORE_ADDR addr;
|
||
|
||
char name[1];
|
||
};
|
||
|
||
/* htab_hash for elf_objfile_gnu_ifunc_cache_data. */
|
||
|
||
static hashval_t
|
||
elf_gnu_ifunc_cache_hash (const void *a_voidp)
|
||
{
|
||
const struct elf_gnu_ifunc_cache *a
|
||
= (const struct elf_gnu_ifunc_cache *) a_voidp;
|
||
|
||
return htab_hash_string (a->name);
|
||
}
|
||
|
||
/* htab_eq for elf_objfile_gnu_ifunc_cache_data. */
|
||
|
||
static int
|
||
elf_gnu_ifunc_cache_eq (const void *a_voidp, const void *b_voidp)
|
||
{
|
||
const struct elf_gnu_ifunc_cache *a
|
||
= (const struct elf_gnu_ifunc_cache *) a_voidp;
|
||
const struct elf_gnu_ifunc_cache *b
|
||
= (const struct elf_gnu_ifunc_cache *) b_voidp;
|
||
|
||
return strcmp (a->name, b->name) == 0;
|
||
}
|
||
|
||
/* Record the target function address of a STT_GNU_IFUNC function NAME is the
|
||
function entry address ADDR. Return 1 if NAME and ADDR are considered as
|
||
valid and therefore they were successfully recorded, return 0 otherwise.
|
||
|
||
Function does not expect a duplicate entry. Use
|
||
elf_gnu_ifunc_resolve_by_cache first to check if the entry for NAME already
|
||
exists. */
|
||
|
||
static int
|
||
elf_gnu_ifunc_record_cache (const char *name, CORE_ADDR addr)
|
||
{
|
||
struct bound_minimal_symbol msym;
|
||
struct objfile *objfile;
|
||
htab_t htab;
|
||
struct elf_gnu_ifunc_cache entry_local, *entry_p;
|
||
void **slot;
|
||
|
||
msym = lookup_minimal_symbol_by_pc (addr);
|
||
if (msym.minsym == NULL)
|
||
return 0;
|
||
if (BMSYMBOL_VALUE_ADDRESS (msym) != addr)
|
||
return 0;
|
||
objfile = msym.objfile;
|
||
|
||
/* If .plt jumps back to .plt the symbol is still deferred for later
|
||
resolution and it has no use for GDB. */
|
||
const char *target_name = MSYMBOL_LINKAGE_NAME (msym.minsym);
|
||
size_t len = strlen (target_name);
|
||
|
||
/* Note we check the symbol's name instead of checking whether the
|
||
symbol is in the .plt section because some systems have @plt
|
||
symbols in the .text section. */
|
||
if (len > 4 && strcmp (target_name + len - 4, "@plt") == 0)
|
||
return 0;
|
||
|
||
htab = (htab_t) objfile_data (objfile, elf_objfile_gnu_ifunc_cache_data);
|
||
if (htab == NULL)
|
||
{
|
||
htab = htab_create_alloc_ex (1, elf_gnu_ifunc_cache_hash,
|
||
elf_gnu_ifunc_cache_eq,
|
||
NULL, &objfile->objfile_obstack,
|
||
hashtab_obstack_allocate,
|
||
dummy_obstack_deallocate);
|
||
set_objfile_data (objfile, elf_objfile_gnu_ifunc_cache_data, htab);
|
||
}
|
||
|
||
entry_local.addr = addr;
|
||
obstack_grow (&objfile->objfile_obstack, &entry_local,
|
||
offsetof (struct elf_gnu_ifunc_cache, name));
|
||
obstack_grow_str0 (&objfile->objfile_obstack, name);
|
||
entry_p
|
||
= (struct elf_gnu_ifunc_cache *) obstack_finish (&objfile->objfile_obstack);
|
||
|
||
slot = htab_find_slot (htab, entry_p, INSERT);
|
||
if (*slot != NULL)
|
||
{
|
||
struct elf_gnu_ifunc_cache *entry_found_p
|
||
= (struct elf_gnu_ifunc_cache *) *slot;
|
||
struct gdbarch *gdbarch = get_objfile_arch (objfile);
|
||
|
||
if (entry_found_p->addr != addr)
|
||
{
|
||
/* This case indicates buggy inferior program, the resolved address
|
||
should never change. */
|
||
|
||
warning (_("gnu-indirect-function \"%s\" has changed its resolved "
|
||
"function_address from %s to %s"),
|
||
name, paddress (gdbarch, entry_found_p->addr),
|
||
paddress (gdbarch, addr));
|
||
}
|
||
|
||
/* New ENTRY_P is here leaked/duplicate in the OBJFILE obstack. */
|
||
}
|
||
*slot = entry_p;
|
||
|
||
return 1;
|
||
}
|
||
|
||
/* Try to find the target resolved function entry address of a STT_GNU_IFUNC
|
||
function NAME. If the address is found it is stored to *ADDR_P (if ADDR_P
|
||
is not NULL) and the function returns 1. It returns 0 otherwise.
|
||
|
||
Only the elf_objfile_gnu_ifunc_cache_data hash table is searched by this
|
||
function. */
|
||
|
||
static int
|
||
elf_gnu_ifunc_resolve_by_cache (const char *name, CORE_ADDR *addr_p)
|
||
{
|
||
struct objfile *objfile;
|
||
|
||
ALL_PSPACE_OBJFILES (current_program_space, objfile)
|
||
{
|
||
htab_t htab;
|
||
struct elf_gnu_ifunc_cache *entry_p;
|
||
void **slot;
|
||
|
||
htab = (htab_t) objfile_data (objfile, elf_objfile_gnu_ifunc_cache_data);
|
||
if (htab == NULL)
|
||
continue;
|
||
|
||
entry_p = ((struct elf_gnu_ifunc_cache *)
|
||
alloca (sizeof (*entry_p) + strlen (name)));
|
||
strcpy (entry_p->name, name);
|
||
|
||
slot = htab_find_slot (htab, entry_p, NO_INSERT);
|
||
if (slot == NULL)
|
||
continue;
|
||
entry_p = (struct elf_gnu_ifunc_cache *) *slot;
|
||
gdb_assert (entry_p != NULL);
|
||
|
||
if (addr_p)
|
||
*addr_p = entry_p->addr;
|
||
return 1;
|
||
}
|
||
|
||
return 0;
|
||
}
|
||
|
||
/* Try to find the target resolved function entry address of a STT_GNU_IFUNC
|
||
function NAME. If the address is found it is stored to *ADDR_P (if ADDR_P
|
||
is not NULL) and the function returns 1. It returns 0 otherwise.
|
||
|
||
Only the SYMBOL_GOT_PLT_SUFFIX locations are searched by this function.
|
||
elf_gnu_ifunc_resolve_by_cache must have been already called for NAME to
|
||
prevent cache entries duplicates. */
|
||
|
||
static int
|
||
elf_gnu_ifunc_resolve_by_got (const char *name, CORE_ADDR *addr_p)
|
||
{
|
||
char *name_got_plt;
|
||
struct objfile *objfile;
|
||
const size_t got_suffix_len = strlen (SYMBOL_GOT_PLT_SUFFIX);
|
||
|
||
name_got_plt = (char *) alloca (strlen (name) + got_suffix_len + 1);
|
||
sprintf (name_got_plt, "%s" SYMBOL_GOT_PLT_SUFFIX, name);
|
||
|
||
ALL_PSPACE_OBJFILES (current_program_space, objfile)
|
||
{
|
||
bfd *obfd = objfile->obfd;
|
||
struct gdbarch *gdbarch = get_objfile_arch (objfile);
|
||
struct type *ptr_type = builtin_type (gdbarch)->builtin_data_ptr;
|
||
size_t ptr_size = TYPE_LENGTH (ptr_type);
|
||
CORE_ADDR pointer_address, addr;
|
||
asection *plt;
|
||
gdb_byte *buf = (gdb_byte *) alloca (ptr_size);
|
||
struct bound_minimal_symbol msym;
|
||
|
||
msym = lookup_minimal_symbol (name_got_plt, NULL, objfile);
|
||
if (msym.minsym == NULL)
|
||
continue;
|
||
if (MSYMBOL_TYPE (msym.minsym) != mst_slot_got_plt)
|
||
continue;
|
||
pointer_address = BMSYMBOL_VALUE_ADDRESS (msym);
|
||
|
||
plt = bfd_get_section_by_name (obfd, ".plt");
|
||
if (plt == NULL)
|
||
continue;
|
||
|
||
if (MSYMBOL_SIZE (msym.minsym) != ptr_size)
|
||
continue;
|
||
if (target_read_memory (pointer_address, buf, ptr_size) != 0)
|
||
continue;
|
||
addr = extract_typed_address (buf, ptr_type);
|
||
addr = gdbarch_convert_from_func_ptr_addr (gdbarch, addr, target_stack);
|
||
addr = gdbarch_addr_bits_remove (gdbarch, addr);
|
||
|
||
if (elf_gnu_ifunc_record_cache (name, addr))
|
||
{
|
||
if (addr_p != NULL)
|
||
*addr_p = addr;
|
||
return 1;
|
||
}
|
||
}
|
||
|
||
return 0;
|
||
}
|
||
|
||
/* Try to find the target resolved function entry address of a STT_GNU_IFUNC
|
||
function NAME. If the address is found it is stored to *ADDR_P (if ADDR_P
|
||
is not NULL) and the function returns 1. It returns 0 otherwise.
|
||
|
||
Both the elf_objfile_gnu_ifunc_cache_data hash table and
|
||
SYMBOL_GOT_PLT_SUFFIX locations are searched by this function. */
|
||
|
||
static int
|
||
elf_gnu_ifunc_resolve_name (const char *name, CORE_ADDR *addr_p)
|
||
{
|
||
if (elf_gnu_ifunc_resolve_by_cache (name, addr_p))
|
||
return 1;
|
||
|
||
if (elf_gnu_ifunc_resolve_by_got (name, addr_p))
|
||
return 1;
|
||
|
||
return 0;
|
||
}
|
||
|
||
/* Call STT_GNU_IFUNC - a function returning addresss of a real function to
|
||
call. PC is theSTT_GNU_IFUNC resolving function entry. The value returned
|
||
is the entry point of the resolved STT_GNU_IFUNC target function to call.
|
||
*/
|
||
|
||
static CORE_ADDR
|
||
elf_gnu_ifunc_resolve_addr (struct gdbarch *gdbarch, CORE_ADDR pc)
|
||
{
|
||
const char *name_at_pc;
|
||
CORE_ADDR start_at_pc, address;
|
||
struct type *func_func_type = builtin_type (gdbarch)->builtin_func_func;
|
||
struct value *function, *address_val;
|
||
CORE_ADDR hwcap = 0;
|
||
struct value *hwcap_val;
|
||
|
||
/* Try first any non-intrusive methods without an inferior call. */
|
||
|
||
if (find_pc_partial_function (pc, &name_at_pc, &start_at_pc, NULL)
|
||
&& start_at_pc == pc)
|
||
{
|
||
if (elf_gnu_ifunc_resolve_name (name_at_pc, &address))
|
||
return address;
|
||
}
|
||
else
|
||
name_at_pc = NULL;
|
||
|
||
function = allocate_value (func_func_type);
|
||
VALUE_LVAL (function) = lval_memory;
|
||
set_value_address (function, pc);
|
||
|
||
/* STT_GNU_IFUNC resolver functions usually receive the HWCAP vector as
|
||
parameter. FUNCTION is the function entry address. ADDRESS may be a
|
||
function descriptor. */
|
||
|
||
target_auxv_search (target_stack, AT_HWCAP, &hwcap);
|
||
hwcap_val = value_from_longest (builtin_type (gdbarch)
|
||
->builtin_unsigned_long, hwcap);
|
||
address_val = call_function_by_hand (function, NULL, 1, &hwcap_val);
|
||
address = value_as_address (address_val);
|
||
address = gdbarch_convert_from_func_ptr_addr (gdbarch, address, target_stack);
|
||
address = gdbarch_addr_bits_remove (gdbarch, address);
|
||
|
||
if (name_at_pc)
|
||
elf_gnu_ifunc_record_cache (name_at_pc, address);
|
||
|
||
return address;
|
||
}
|
||
|
||
/* Handle inferior hit of bp_gnu_ifunc_resolver, see its definition. */
|
||
|
||
static void
|
||
elf_gnu_ifunc_resolver_stop (struct breakpoint *b)
|
||
{
|
||
struct breakpoint *b_return;
|
||
struct frame_info *prev_frame = get_prev_frame (get_current_frame ());
|
||
struct frame_id prev_frame_id = get_stack_frame_id (prev_frame);
|
||
CORE_ADDR prev_pc = get_frame_pc (prev_frame);
|
||
int thread_id = ptid_to_global_thread_id (inferior_ptid);
|
||
|
||
gdb_assert (b->type == bp_gnu_ifunc_resolver);
|
||
|
||
for (b_return = b->related_breakpoint; b_return != b;
|
||
b_return = b_return->related_breakpoint)
|
||
{
|
||
gdb_assert (b_return->type == bp_gnu_ifunc_resolver_return);
|
||
gdb_assert (b_return->loc != NULL && b_return->loc->next == NULL);
|
||
gdb_assert (frame_id_p (b_return->frame_id));
|
||
|
||
if (b_return->thread == thread_id
|
||
&& b_return->loc->requested_address == prev_pc
|
||
&& frame_id_eq (b_return->frame_id, prev_frame_id))
|
||
break;
|
||
}
|
||
|
||
if (b_return == b)
|
||
{
|
||
/* No need to call find_pc_line for symbols resolving as this is only
|
||
a helper breakpointer never shown to the user. */
|
||
|
||
symtab_and_line sal;
|
||
sal.pspace = current_inferior ()->pspace;
|
||
sal.pc = prev_pc;
|
||
sal.section = find_pc_overlay (sal.pc);
|
||
sal.explicit_pc = 1;
|
||
b_return
|
||
= set_momentary_breakpoint (get_frame_arch (prev_frame), sal,
|
||
prev_frame_id,
|
||
bp_gnu_ifunc_resolver_return).release ();
|
||
|
||
/* set_momentary_breakpoint invalidates PREV_FRAME. */
|
||
prev_frame = NULL;
|
||
|
||
/* Add new b_return to the ring list b->related_breakpoint. */
|
||
gdb_assert (b_return->related_breakpoint == b_return);
|
||
b_return->related_breakpoint = b->related_breakpoint;
|
||
b->related_breakpoint = b_return;
|
||
}
|
||
}
|
||
|
||
/* Handle inferior hit of bp_gnu_ifunc_resolver_return, see its definition. */
|
||
|
||
static void
|
||
elf_gnu_ifunc_resolver_return_stop (struct breakpoint *b)
|
||
{
|
||
struct gdbarch *gdbarch = get_frame_arch (get_current_frame ());
|
||
struct type *func_func_type = builtin_type (gdbarch)->builtin_func_func;
|
||
struct type *value_type = TYPE_TARGET_TYPE (func_func_type);
|
||
struct regcache *regcache = get_thread_regcache (inferior_ptid);
|
||
struct value *func_func;
|
||
struct value *value;
|
||
CORE_ADDR resolved_address, resolved_pc;
|
||
|
||
gdb_assert (b->type == bp_gnu_ifunc_resolver_return);
|
||
|
||
while (b->related_breakpoint != b)
|
||
{
|
||
struct breakpoint *b_next = b->related_breakpoint;
|
||
|
||
switch (b->type)
|
||
{
|
||
case bp_gnu_ifunc_resolver:
|
||
break;
|
||
case bp_gnu_ifunc_resolver_return:
|
||
delete_breakpoint (b);
|
||
break;
|
||
default:
|
||
internal_error (__FILE__, __LINE__,
|
||
_("handle_inferior_event: Invalid "
|
||
"gnu-indirect-function breakpoint type %d"),
|
||
(int) b->type);
|
||
}
|
||
b = b_next;
|
||
}
|
||
gdb_assert (b->type == bp_gnu_ifunc_resolver);
|
||
gdb_assert (b->loc->next == NULL);
|
||
|
||
func_func = allocate_value (func_func_type);
|
||
VALUE_LVAL (func_func) = lval_memory;
|
||
set_value_address (func_func, b->loc->related_address);
|
||
|
||
value = allocate_value (value_type);
|
||
gdbarch_return_value (gdbarch, func_func, value_type, regcache,
|
||
value_contents_raw (value), NULL);
|
||
resolved_address = value_as_address (value);
|
||
resolved_pc = gdbarch_convert_from_func_ptr_addr (gdbarch,
|
||
resolved_address,
|
||
target_stack);
|
||
resolved_pc = gdbarch_addr_bits_remove (gdbarch, resolved_pc);
|
||
|
||
gdb_assert (current_program_space == b->pspace || b->pspace == NULL);
|
||
elf_gnu_ifunc_record_cache (event_location_to_string (b->location.get ()),
|
||
resolved_pc);
|
||
|
||
b->type = bp_breakpoint;
|
||
update_breakpoint_locations (b, current_program_space,
|
||
find_function_start_sal (resolved_pc, NULL, true),
|
||
{});
|
||
}
|
||
|
||
/* A helper function for elf_symfile_read that reads the minimal
|
||
symbols. */
|
||
|
||
static void
|
||
elf_read_minimal_symbols (struct objfile *objfile, int symfile_flags,
|
||
const struct elfinfo *ei)
|
||
{
|
||
bfd *synth_abfd, *abfd = objfile->obfd;
|
||
long symcount = 0, dynsymcount = 0, synthcount, storage_needed;
|
||
asymbol **symbol_table = NULL, **dyn_symbol_table = NULL;
|
||
asymbol *synthsyms;
|
||
struct dbx_symfile_info *dbx;
|
||
|
||
if (symtab_create_debug)
|
||
{
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"Reading minimal symbols of objfile %s ...\n",
|
||
objfile_name (objfile));
|
||
}
|
||
|
||
/* If we already have minsyms, then we can skip some work here.
|
||
However, if there were stabs or mdebug sections, we go ahead and
|
||
redo all the work anyway, because the psym readers for those
|
||
kinds of debuginfo need extra information found here. This can
|
||
go away once all types of symbols are in the per-BFD object. */
|
||
if (objfile->per_bfd->minsyms_read
|
||
&& ei->stabsect == NULL
|
||
&& ei->mdebugsect == NULL)
|
||
{
|
||
if (symtab_create_debug)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"... minimal symbols previously read\n");
|
||
return;
|
||
}
|
||
|
||
minimal_symbol_reader reader (objfile);
|
||
|
||
/* Allocate struct to keep track of the symfile. */
|
||
dbx = XCNEW (struct dbx_symfile_info);
|
||
set_objfile_data (objfile, dbx_objfile_data_key, dbx);
|
||
|
||
/* Process the normal ELF symbol table first. */
|
||
|
||
storage_needed = bfd_get_symtab_upper_bound (objfile->obfd);
|
||
if (storage_needed < 0)
|
||
error (_("Can't read symbols from %s: %s"),
|
||
bfd_get_filename (objfile->obfd),
|
||
bfd_errmsg (bfd_get_error ()));
|
||
|
||
if (storage_needed > 0)
|
||
{
|
||
/* Memory gets permanently referenced from ABFD after
|
||
bfd_canonicalize_symtab so it must not get freed before ABFD gets. */
|
||
|
||
symbol_table = (asymbol **) bfd_alloc (abfd, storage_needed);
|
||
symcount = bfd_canonicalize_symtab (objfile->obfd, symbol_table);
|
||
|
||
if (symcount < 0)
|
||
error (_("Can't read symbols from %s: %s"),
|
||
bfd_get_filename (objfile->obfd),
|
||
bfd_errmsg (bfd_get_error ()));
|
||
|
||
elf_symtab_read (reader, objfile, ST_REGULAR, symcount, symbol_table,
|
||
false);
|
||
}
|
||
|
||
/* Add the dynamic symbols. */
|
||
|
||
storage_needed = bfd_get_dynamic_symtab_upper_bound (objfile->obfd);
|
||
|
||
if (storage_needed > 0)
|
||
{
|
||
/* Memory gets permanently referenced from ABFD after
|
||
bfd_get_synthetic_symtab so it must not get freed before ABFD gets.
|
||
It happens only in the case when elf_slurp_reloc_table sees
|
||
asection->relocation NULL. Determining which section is asection is
|
||
done by _bfd_elf_get_synthetic_symtab which is all a bfd
|
||
implementation detail, though. */
|
||
|
||
dyn_symbol_table = (asymbol **) bfd_alloc (abfd, storage_needed);
|
||
dynsymcount = bfd_canonicalize_dynamic_symtab (objfile->obfd,
|
||
dyn_symbol_table);
|
||
|
||
if (dynsymcount < 0)
|
||
error (_("Can't read symbols from %s: %s"),
|
||
bfd_get_filename (objfile->obfd),
|
||
bfd_errmsg (bfd_get_error ()));
|
||
|
||
elf_symtab_read (reader, objfile, ST_DYNAMIC, dynsymcount,
|
||
dyn_symbol_table, false);
|
||
|
||
elf_rel_plt_read (reader, objfile, dyn_symbol_table);
|
||
}
|
||
|
||
/* Contrary to binutils --strip-debug/--only-keep-debug the strip command from
|
||
elfutils (eu-strip) moves even the .symtab section into the .debug file.
|
||
|
||
bfd_get_synthetic_symtab on ppc64 for each function descriptor ELF symbol
|
||
'name' creates a new BSF_SYNTHETIC ELF symbol '.name' with its code
|
||
address. But with eu-strip files bfd_get_synthetic_symtab would fail to
|
||
read the code address from .opd while it reads the .symtab section from
|
||
a separate debug info file as the .opd section is SHT_NOBITS there.
|
||
|
||
With SYNTH_ABFD the .opd section will be read from the original
|
||
backlinked binary where it is valid. */
|
||
|
||
if (objfile->separate_debug_objfile_backlink)
|
||
synth_abfd = objfile->separate_debug_objfile_backlink->obfd;
|
||
else
|
||
synth_abfd = abfd;
|
||
|
||
/* Add synthetic symbols - for instance, names for any PLT entries. */
|
||
|
||
synthcount = bfd_get_synthetic_symtab (synth_abfd, symcount, symbol_table,
|
||
dynsymcount, dyn_symbol_table,
|
||
&synthsyms);
|
||
if (synthcount > 0)
|
||
{
|
||
long i;
|
||
|
||
std::unique_ptr<asymbol *[]>
|
||
synth_symbol_table (new asymbol *[synthcount]);
|
||
for (i = 0; i < synthcount; i++)
|
||
synth_symbol_table[i] = synthsyms + i;
|
||
elf_symtab_read (reader, objfile, ST_SYNTHETIC, synthcount,
|
||
synth_symbol_table.get (), true);
|
||
|
||
xfree (synthsyms);
|
||
synthsyms = NULL;
|
||
}
|
||
|
||
/* Install any minimal symbols that have been collected as the current
|
||
minimal symbols for this objfile. The debug readers below this point
|
||
should not generate new minimal symbols; if they do it's their
|
||
responsibility to install them. "mdebug" appears to be the only one
|
||
which will do this. */
|
||
|
||
reader.install ();
|
||
|
||
if (symtab_create_debug)
|
||
fprintf_unfiltered (gdb_stdlog, "Done reading minimal symbols.\n");
|
||
}
|
||
|
||
/* Scan and build partial symbols for a symbol file.
|
||
We have been initialized by a call to elf_symfile_init, which
|
||
currently does nothing.
|
||
|
||
This function only does the minimum work necessary for letting the
|
||
user "name" things symbolically; it does not read the entire symtab.
|
||
Instead, it reads the external and static symbols and puts them in partial
|
||
symbol tables. When more extensive information is requested of a
|
||
file, the corresponding partial symbol table is mutated into a full
|
||
fledged symbol table by going back and reading the symbols
|
||
for real.
|
||
|
||
We look for sections with specific names, to tell us what debug
|
||
format to look for: FIXME!!!
|
||
|
||
elfstab_build_psymtabs() handles STABS symbols;
|
||
mdebug_build_psymtabs() handles ECOFF debugging information.
|
||
|
||
Note that ELF files have a "minimal" symbol table, which looks a lot
|
||
like a COFF symbol table, but has only the minimal information necessary
|
||
for linking. We process this also, and use the information to
|
||
build gdb's minimal symbol table. This gives us some minimal debugging
|
||
capability even for files compiled without -g. */
|
||
|
||
static void
|
||
elf_symfile_read (struct objfile *objfile, symfile_add_flags symfile_flags)
|
||
{
|
||
bfd *abfd = objfile->obfd;
|
||
struct elfinfo ei;
|
||
|
||
memset ((char *) &ei, 0, sizeof (ei));
|
||
if (!(objfile->flags & OBJF_READNEVER))
|
||
bfd_map_over_sections (abfd, elf_locate_sections, (void *) & ei);
|
||
|
||
elf_read_minimal_symbols (objfile, symfile_flags, &ei);
|
||
|
||
/* ELF debugging information is inserted into the psymtab in the
|
||
order of least informative first - most informative last. Since
|
||
the psymtab table is searched `most recent insertion first' this
|
||
increases the probability that more detailed debug information
|
||
for a section is found.
|
||
|
||
For instance, an object file might contain both .mdebug (XCOFF)
|
||
and .debug_info (DWARF2) sections then .mdebug is inserted first
|
||
(searched last) and DWARF2 is inserted last (searched first). If
|
||
we don't do this then the XCOFF info is found first - for code in
|
||
an included file XCOFF info is useless. */
|
||
|
||
if (ei.mdebugsect)
|
||
{
|
||
const struct ecoff_debug_swap *swap;
|
||
|
||
/* .mdebug section, presumably holding ECOFF debugging
|
||
information. */
|
||
swap = get_elf_backend_data (abfd)->elf_backend_ecoff_debug_swap;
|
||
if (swap)
|
||
elfmdebug_build_psymtabs (objfile, swap, ei.mdebugsect);
|
||
}
|
||
if (ei.stabsect)
|
||
{
|
||
asection *str_sect;
|
||
|
||
/* Stab sections have an associated string table that looks like
|
||
a separate section. */
|
||
str_sect = bfd_get_section_by_name (abfd, ".stabstr");
|
||
|
||
/* FIXME should probably warn about a stab section without a stabstr. */
|
||
if (str_sect)
|
||
elfstab_build_psymtabs (objfile,
|
||
ei.stabsect,
|
||
str_sect->filepos,
|
||
bfd_section_size (abfd, str_sect));
|
||
}
|
||
|
||
if (dwarf2_has_info (objfile, NULL))
|
||
{
|
||
dw_index_kind index_kind;
|
||
|
||
/* elf_sym_fns_gdb_index cannot handle simultaneous non-DWARF
|
||
debug information present in OBJFILE. If there is such debug
|
||
info present never use an index. */
|
||
if (!objfile_has_partial_symbols (objfile)
|
||
&& dwarf2_initialize_objfile (objfile, &index_kind))
|
||
{
|
||
switch (index_kind)
|
||
{
|
||
case dw_index_kind::GDB_INDEX:
|
||
objfile_set_sym_fns (objfile, &elf_sym_fns_gdb_index);
|
||
break;
|
||
case dw_index_kind::DEBUG_NAMES:
|
||
objfile_set_sym_fns (objfile, &elf_sym_fns_debug_names);
|
||
break;
|
||
}
|
||
}
|
||
else
|
||
{
|
||
/* It is ok to do this even if the stabs reader made some
|
||
partial symbols, because OBJF_PSYMTABS_READ has not been
|
||
set, and so our lazy reader function will still be called
|
||
when needed. */
|
||
objfile_set_sym_fns (objfile, &elf_sym_fns_lazy_psyms);
|
||
}
|
||
}
|
||
/* If the file has its own symbol tables it has no separate debug
|
||
info. `.dynsym'/`.symtab' go to MSYMBOLS, `.debug_info' goes to
|
||
SYMTABS/PSYMTABS. `.gnu_debuglink' may no longer be present with
|
||
`.note.gnu.build-id'.
|
||
|
||
.gnu_debugdata is !objfile_has_partial_symbols because it contains only
|
||
.symtab, not .debug_* section. But if we already added .gnu_debugdata as
|
||
an objfile via find_separate_debug_file_in_section there was no separate
|
||
debug info available. Therefore do not attempt to search for another one,
|
||
objfile->separate_debug_objfile->separate_debug_objfile GDB guarantees to
|
||
be NULL and we would possibly violate it. */
|
||
|
||
else if (!objfile_has_partial_symbols (objfile)
|
||
&& objfile->separate_debug_objfile == NULL
|
||
&& objfile->separate_debug_objfile_backlink == NULL)
|
||
{
|
||
std::string debugfile = find_separate_debug_file_by_buildid (objfile);
|
||
|
||
if (debugfile.empty ())
|
||
debugfile = find_separate_debug_file_by_debuglink (objfile);
|
||
|
||
if (!debugfile.empty ())
|
||
{
|
||
gdb_bfd_ref_ptr abfd (symfile_bfd_open (debugfile.c_str ()));
|
||
|
||
symbol_file_add_separate (abfd.get (), debugfile.c_str (),
|
||
symfile_flags, objfile);
|
||
}
|
||
}
|
||
}
|
||
|
||
/* Callback to lazily read psymtabs. */
|
||
|
||
static void
|
||
read_psyms (struct objfile *objfile)
|
||
{
|
||
if (dwarf2_has_info (objfile, NULL))
|
||
dwarf2_build_psymtabs (objfile);
|
||
}
|
||
|
||
/* Initialize anything that needs initializing when a completely new symbol
|
||
file is specified (not just adding some symbols from another file, e.g. a
|
||
shared library).
|
||
|
||
We reinitialize buildsym, since we may be reading stabs from an ELF
|
||
file. */
|
||
|
||
static void
|
||
elf_new_init (struct objfile *ignore)
|
||
{
|
||
stabsread_new_init ();
|
||
buildsym_new_init ();
|
||
}
|
||
|
||
/* Perform any local cleanups required when we are done with a particular
|
||
objfile. I.E, we are in the process of discarding all symbol information
|
||
for an objfile, freeing up all memory held for it, and unlinking the
|
||
objfile struct from the global list of known objfiles. */
|
||
|
||
static void
|
||
elf_symfile_finish (struct objfile *objfile)
|
||
{
|
||
dwarf2_free_objfile (objfile);
|
||
}
|
||
|
||
/* ELF specific initialization routine for reading symbols. */
|
||
|
||
static void
|
||
elf_symfile_init (struct objfile *objfile)
|
||
{
|
||
/* ELF objects may be reordered, so set OBJF_REORDERED. If we
|
||
find this causes a significant slowdown in gdb then we could
|
||
set it in the debug symbol readers only when necessary. */
|
||
objfile->flags |= OBJF_REORDERED;
|
||
}
|
||
|
||
/* Implementation of `sym_get_probes', as documented in symfile.h. */
|
||
|
||
static const std::vector<probe *> &
|
||
elf_get_probes (struct objfile *objfile)
|
||
{
|
||
std::vector<probe *> *probes_per_bfd;
|
||
|
||
/* Have we parsed this objfile's probes already? */
|
||
probes_per_bfd = (std::vector<probe *> *) bfd_data (objfile->obfd, probe_key);
|
||
|
||
if (probes_per_bfd == NULL)
|
||
{
|
||
probes_per_bfd = new std::vector<probe *>;
|
||
|
||
/* Here we try to gather information about all types of probes from the
|
||
objfile. */
|
||
for (const static_probe_ops *ops : all_static_probe_ops)
|
||
ops->get_probes (probes_per_bfd, objfile);
|
||
|
||
set_bfd_data (objfile->obfd, probe_key, probes_per_bfd);
|
||
}
|
||
|
||
return *probes_per_bfd;
|
||
}
|
||
|
||
/* Helper function used to free the space allocated for storing SystemTap
|
||
probe information. */
|
||
|
||
static void
|
||
probe_key_free (bfd *abfd, void *d)
|
||
{
|
||
std::vector<probe *> *probes = (std::vector<probe *> *) d;
|
||
|
||
for (probe *p : *probes)
|
||
delete p;
|
||
|
||
delete probes;
|
||
}
|
||
|
||
|
||
|
||
/* Implementation `sym_probe_fns', as documented in symfile.h. */
|
||
|
||
static const struct sym_probe_fns elf_probe_fns =
|
||
{
|
||
elf_get_probes, /* sym_get_probes */
|
||
};
|
||
|
||
/* Register that we are able to handle ELF object file formats. */
|
||
|
||
static const struct sym_fns elf_sym_fns =
|
||
{
|
||
elf_new_init, /* init anything gbl to entire symtab */
|
||
elf_symfile_init, /* read initial info, setup for sym_read() */
|
||
elf_symfile_read, /* read a symbol file into symtab */
|
||
NULL, /* sym_read_psymbols */
|
||
elf_symfile_finish, /* finished with file, cleanup */
|
||
default_symfile_offsets, /* Translate ext. to int. relocation */
|
||
elf_symfile_segments, /* Get segment information from a file. */
|
||
NULL,
|
||
default_symfile_relocate, /* Relocate a debug section. */
|
||
&elf_probe_fns, /* sym_probe_fns */
|
||
&psym_functions
|
||
};
|
||
|
||
/* The same as elf_sym_fns, but not registered and lazily reads
|
||
psymbols. */
|
||
|
||
const struct sym_fns elf_sym_fns_lazy_psyms =
|
||
{
|
||
elf_new_init, /* init anything gbl to entire symtab */
|
||
elf_symfile_init, /* read initial info, setup for sym_read() */
|
||
elf_symfile_read, /* read a symbol file into symtab */
|
||
read_psyms, /* sym_read_psymbols */
|
||
elf_symfile_finish, /* finished with file, cleanup */
|
||
default_symfile_offsets, /* Translate ext. to int. relocation */
|
||
elf_symfile_segments, /* Get segment information from a file. */
|
||
NULL,
|
||
default_symfile_relocate, /* Relocate a debug section. */
|
||
&elf_probe_fns, /* sym_probe_fns */
|
||
&psym_functions
|
||
};
|
||
|
||
/* The same as elf_sym_fns, but not registered and uses the
|
||
DWARF-specific GNU index rather than psymtab. */
|
||
const struct sym_fns elf_sym_fns_gdb_index =
|
||
{
|
||
elf_new_init, /* init anything gbl to entire symab */
|
||
elf_symfile_init, /* read initial info, setup for sym_red() */
|
||
elf_symfile_read, /* read a symbol file into symtab */
|
||
NULL, /* sym_read_psymbols */
|
||
elf_symfile_finish, /* finished with file, cleanup */
|
||
default_symfile_offsets, /* Translate ext. to int. relocatin */
|
||
elf_symfile_segments, /* Get segment information from a file. */
|
||
NULL,
|
||
default_symfile_relocate, /* Relocate a debug section. */
|
||
&elf_probe_fns, /* sym_probe_fns */
|
||
&dwarf2_gdb_index_functions
|
||
};
|
||
|
||
/* The same as elf_sym_fns, but not registered and uses the
|
||
DWARF-specific .debug_names index rather than psymtab. */
|
||
const struct sym_fns elf_sym_fns_debug_names =
|
||
{
|
||
elf_new_init, /* init anything gbl to entire symab */
|
||
elf_symfile_init, /* read initial info, setup for sym_red() */
|
||
elf_symfile_read, /* read a symbol file into symtab */
|
||
NULL, /* sym_read_psymbols */
|
||
elf_symfile_finish, /* finished with file, cleanup */
|
||
default_symfile_offsets, /* Translate ext. to int. relocatin */
|
||
elf_symfile_segments, /* Get segment information from a file. */
|
||
NULL,
|
||
default_symfile_relocate, /* Relocate a debug section. */
|
||
&elf_probe_fns, /* sym_probe_fns */
|
||
&dwarf2_debug_names_functions
|
||
};
|
||
|
||
/* STT_GNU_IFUNC resolver vector to be installed to gnu_ifunc_fns_p. */
|
||
|
||
static const struct gnu_ifunc_fns elf_gnu_ifunc_fns =
|
||
{
|
||
elf_gnu_ifunc_resolve_addr,
|
||
elf_gnu_ifunc_resolve_name,
|
||
elf_gnu_ifunc_resolver_stop,
|
||
elf_gnu_ifunc_resolver_return_stop
|
||
};
|
||
|
||
void
|
||
_initialize_elfread (void)
|
||
{
|
||
probe_key = register_bfd_data_with_cleanup (NULL, probe_key_free);
|
||
add_symtab_fns (bfd_target_elf_flavour, &elf_sym_fns);
|
||
|
||
elf_objfile_gnu_ifunc_cache_data = register_objfile_data ();
|
||
gnu_ifunc_fns_p = &elf_gnu_ifunc_fns;
|
||
}
|