6c2659886f
I'd like to enable the -Wmissing-declarations warning. However, it
warns for every _initialize function, for example:
CXX dcache.o
/home/smarchi/src/binutils-gdb/gdb/dcache.c: In function ‘void _initialize_dcache()’:
/home/smarchi/src/binutils-gdb/gdb/dcache.c:688:1: error: no previous declaration for ‘void _initialize_dcache()’ [-Werror=missing-declarations]
_initialize_dcache (void)
^~~~~~~~~~~~~~~~~~
The only practical way forward I found is to add back the declarations,
which were removed by this commit:
commit 481695ed5f
Author: John Baldwin <jhb@FreeBSD.org>
Date: Sat Sep 9 11:02:37 2017 -0700
Remove unnecessary function prototypes.
I don't think it's a big problem to have the declarations for these
functions, but if anybody has a better solution for this, I'll be happy
to use it.
gdb/ChangeLog:
* aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
* aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
* aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
* aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
* aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
* ada-exp.y (_initialize_ada_exp): Add declaration.
* ada-lang.c (_initialize_ada_language): Add declaration.
* ada-tasks.c (_initialize_tasks): Add declaration.
* agent.c (_initialize_agent): Add declaration.
* aix-thread.c (_initialize_aix_thread): Add declaration.
* alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
* alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
* alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
* alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
* alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
* alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
* amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
* amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
* amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
* amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
* amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
* amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
* amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
* amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
* amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
* amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
* amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
* amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
* amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
* amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
* annotate.c (_initialize_annotate): Add declaration.
* arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
* arc-tdep.c (_initialize_arc_tdep): Add declaration.
* arch-utils.c (_initialize_gdbarch_utils): Add declaration.
* arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
* arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
* arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
* arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
* arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
* arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
* arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
* arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
* arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
* arm-tdep.c (_initialize_arm_tdep): Add declaration.
* arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
* auto-load.c (_initialize_auto_load): Add declaration.
* auxv.c (_initialize_auxv): Add declaration.
* avr-tdep.c (_initialize_avr_tdep): Add declaration.
* ax-gdb.c (_initialize_ax_gdb): Add declaration.
* bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
* bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
* break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
* break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
* break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
* breakpoint.c (_initialize_breakpoint): Add declaration.
* bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
* btrace.c (_initialize_btrace): Add declaration.
* charset.c (_initialize_charset): Add declaration.
* cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
* cli/cli-dump.c (_initialize_cli_dump): Add declaration.
* cli/cli-interp.c (_initialize_cli_interp): Add declaration.
* cli/cli-logging.c (_initialize_cli_logging): Add declaration.
* cli/cli-script.c (_initialize_cli_script): Add declaration.
* cli/cli-style.c (_initialize_cli_style): Add declaration.
* coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
* coffread.c (_initialize_coffread): Add declaration.
* compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
* compile/compile.c (_initialize_compile): Add declaration.
* complaints.c (_initialize_complaints): Add declaration.
* completer.c (_initialize_completer): Add declaration.
* copying.c (_initialize_copying): Add declaration.
* corefile.c (_initialize_core): Add declaration.
* corelow.c (_initialize_corelow): Add declaration.
* cp-abi.c (_initialize_cp_abi): Add declaration.
* cp-namespace.c (_initialize_cp_namespace): Add declaration.
* cp-support.c (_initialize_cp_support): Add declaration.
* cp-valprint.c (_initialize_cp_valprint): Add declaration.
* cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
* cris-tdep.c (_initialize_cris_tdep): Add declaration.
* csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
* csky-tdep.c (_initialize_csky_tdep): Add declaration.
* ctfread.c (_initialize_ctfread): Add declaration.
* d-lang.c (_initialize_d_language): Add declaration.
* darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
* darwin-nat.c (_initialize_darwin_nat): Add declaration.
* dbxread.c (_initialize_dbxread): Add declaration.
* dcache.c (_initialize_dcache): Add declaration.
* disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
* disasm.c (_initialize_disasm): Add declaration.
* dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
* dummy-frame.c (_initialize_dummy_frame): Add declaration.
* dwarf-index-cache.c (_initialize_index_cache): Add declaration.
* dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
* dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
* dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
* dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
* dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
* dwarf2read.c (_initialize_dwarf2_read): Add declaration.
* elfread.c (_initialize_elfread): Add declaration.
* exec.c (_initialize_exec): Add declaration.
* extension.c (_initialize_extension): Add declaration.
* f-lang.c (_initialize_f_language): Add declaration.
* f-valprint.c (_initialize_f_valprint): Add declaration.
* fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
* fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
* filesystem.c (_initialize_filesystem): Add declaration.
* findcmd.c (_initialize_mem_search): Add declaration.
* findvar.c (_initialize_findvar): Add declaration.
* fork-child.c (_initialize_fork_child): Add declaration.
* frame-base.c (_initialize_frame_base): Add declaration.
* frame-unwind.c (_initialize_frame_unwind): Add declaration.
* frame.c (_initialize_frame): Add declaration.
* frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
* frv-tdep.c (_initialize_frv_tdep): Add declaration.
* ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
* gcore.c (_initialize_gcore): Add declaration.
* gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
* gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
* gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
* gdbarch.c (_initialize_gdbarch): Add declaration.
* gdbtypes.c (_initialize_gdbtypes): Add declaration.
* gnu-nat.c (_initialize_gnu_nat): Add declaration.
* gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
* gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
* go-lang.c (_initialize_go_language): Add declaration.
* go32-nat.c (_initialize_go32_nat): Add declaration.
* guile/guile.c (_initialize_guile): Add declaration.
* h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
* hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
* hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
* hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
* hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
* hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
* hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
* hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
* i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
* i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
* i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
* i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
* i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
* i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
* i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
* i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
* i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
* i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
* i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
* i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
* i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
* i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
* i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
* i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
* i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
* i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
* i386-tdep.c (_initialize_i386_tdep): Add declaration.
* i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
* ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
* ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
* ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
* ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
* ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
* infcall.c (_initialize_infcall): Add declaration.
* infcmd.c (_initialize_infcmd): Add declaration.
* inflow.c (_initialize_inflow): Add declaration.
* infrun.c (_initialize_infrun): Add declaration.
* interps.c (_initialize_interpreter): Add declaration.
* iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
* jit.c (_initialize_jit): Add declaration.
* language.c (_initialize_language): Add declaration.
* linux-fork.c (_initialize_linux_fork): Add declaration.
* linux-nat.c (_initialize_linux_nat): Add declaration.
* linux-tdep.c (_initialize_linux_tdep): Add declaration.
* linux-thread-db.c (_initialize_thread_db): Add declaration.
* lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
* m2-lang.c (_initialize_m2_language): Add declaration.
* m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
* m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
* m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
* m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
* m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
* m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
* m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
* m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
* m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
* m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
* machoread.c (_initialize_machoread): Add declaration.
* macrocmd.c (_initialize_macrocmd): Add declaration.
* macroscope.c (_initialize_macroscope): Add declaration.
* maint-test-options.c (_initialize_maint_test_options): Add declaration.
* maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
* maint.c (_initialize_maint_cmds): Add declaration.
* mdebugread.c (_initialize_mdebugread): Add declaration.
* memattr.c (_initialize_mem): Add declaration.
* mep-tdep.c (_initialize_mep_tdep): Add declaration.
* mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
* mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
* mi/mi-interp.c (_initialize_mi_interp): Add declaration.
* mi/mi-main.c (_initialize_mi_main): Add declaration.
* microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
* microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
* mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
* mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
* mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
* mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
* mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
* mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
* mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
* mips-tdep.c (_initialize_mips_tdep): Add declaration.
* mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
* mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
* mipsread.c (_initialize_mipsread): Add declaration.
* mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
* mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
* moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
* msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
* nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
* nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
* nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
* nto-procfs.c (_initialize_procfs): Add declaration.
* objc-lang.c (_initialize_objc_language): Add declaration.
* observable.c (_initialize_observer): Add declaration.
* opencl-lang.c (_initialize_opencl_language): Add declaration.
* or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
* or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
* osabi.c (_initialize_gdb_osabi): Add declaration.
* osdata.c (_initialize_osdata): Add declaration.
* p-valprint.c (_initialize_pascal_valprint): Add declaration.
* parse.c (_initialize_parse): Add declaration.
* ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
* ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
* ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
* ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
* ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
* ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
* ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
* printcmd.c (_initialize_printcmd): Add declaration.
* probe.c (_initialize_probe): Add declaration.
* proc-api.c (_initialize_proc_api): Add declaration.
* proc-events.c (_initialize_proc_events): Add declaration.
* proc-service.c (_initialize_proc_service): Add declaration.
* procfs.c (_initialize_procfs): Add declaration.
* producer.c (_initialize_producer): Add declaration.
* psymtab.c (_initialize_psymtab): Add declaration.
* python/python.c (_initialize_python): Add declaration.
* ravenscar-thread.c (_initialize_ravenscar): Add declaration.
* record-btrace.c (_initialize_record_btrace): Add declaration.
* record-full.c (_initialize_record_full): Add declaration.
* record.c (_initialize_record): Add declaration.
* regcache-dump.c (_initialize_regcache_dump): Add declaration.
* regcache.c (_initialize_regcache): Add declaration.
* reggroups.c (_initialize_reggroup): Add declaration.
* remote-notif.c (_initialize_notif): Add declaration.
* remote-sim.c (_initialize_remote_sim): Add declaration.
* remote.c (_initialize_remote): Add declaration.
* reverse.c (_initialize_reverse): Add declaration.
* riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
* riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
* riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
* riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
* riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
* rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
* rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
* rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
Add declaration.
* rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
* rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
* run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
* rust-exp.y (_initialize_rust_exp): Add declaration.
* rx-tdep.c (_initialize_rx_tdep): Add declaration.
* s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
* s390-linux-nat.c (_initialize_s390_nat): Add declaration.
* s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
* s390-tdep.c (_initialize_s390_tdep): Add declaration.
* score-tdep.c (_initialize_score_tdep): Add declaration.
* ser-go32.c (_initialize_ser_dos): Add declaration.
* ser-mingw.c (_initialize_ser_windows): Add declaration.
* ser-pipe.c (_initialize_ser_pipe): Add declaration.
* ser-tcp.c (_initialize_ser_tcp): Add declaration.
* ser-uds.c (_initialize_ser_socket): Add declaration.
* ser-unix.c (_initialize_ser_hardwire): Add declaration.
* serial.c (_initialize_serial): Add declaration.
* sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
* sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
* sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
* sh-tdep.c (_initialize_sh_tdep): Add declaration.
* skip.c (_initialize_step_skip): Add declaration.
* sol-thread.c (_initialize_sol_thread): Add declaration.
* solib-aix.c (_initialize_solib_aix): Add declaration.
* solib-darwin.c (_initialize_darwin_solib): Add declaration.
* solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
* solib-frv.c (_initialize_frv_solib): Add declaration.
* solib-svr4.c (_initialize_svr4_solib): Add declaration.
* solib-target.c (_initialize_solib_target): Add declaration.
* solib.c (_initialize_solib): Add declaration.
* source-cache.c (_initialize_source_cache): Add declaration.
* source.c (_initialize_source): Add declaration.
* sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
* sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
* sparc-nat.c (_initialize_sparc_nat): Add declaration.
* sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
* sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
* sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
* sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
* sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
* sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
* sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
* sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
* sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
* sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
* sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
* sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
* sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
* sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
* sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
* sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
* stabsread.c (_initialize_stabsread): Add declaration.
* stack.c (_initialize_stack): Add declaration.
* stap-probe.c (_initialize_stap_probe): Add declaration.
* std-regs.c (_initialize_frame_reg): Add declaration.
* symfile-debug.c (_initialize_symfile_debug): Add declaration.
* symfile-mem.c (_initialize_symfile_mem): Add declaration.
* symfile.c (_initialize_symfile): Add declaration.
* symmisc.c (_initialize_symmisc): Add declaration.
* symtab.c (_initialize_symtab): Add declaration.
* target.c (_initialize_target): Add declaration.
* target-connection.c (_initialize_target_connection): Add
declaration.
* target-dcache.c (_initialize_target_dcache): Add declaration.
* target-descriptions.c (_initialize_target_descriptions): Add declaration.
* thread.c (_initialize_thread): Add declaration.
* tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
* tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
* tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
* tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
* tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
* tracectf.c (_initialize_ctf): Add declaration.
* tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
* tracefile.c (_initialize_tracefile): Add declaration.
* tracepoint.c (_initialize_tracepoint): Add declaration.
* tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
* tui/tui-interp.c (_initialize_tui_interp): Add declaration.
* tui/tui-layout.c (_initialize_tui_layout): Add declaration.
* tui/tui-regs.c (_initialize_tui_regs): Add declaration.
* tui/tui-stack.c (_initialize_tui_stack): Add declaration.
* tui/tui-win.c (_initialize_tui_win): Add declaration.
* tui/tui.c (_initialize_tui): Add declaration.
* typeprint.c (_initialize_typeprint): Add declaration.
* ui-style.c (_initialize_ui_style): Add declaration.
* unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
* unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
* unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
* unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
* unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
* unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
* unittests/filtered_iterator-selftests.c
(_initialize_filtered_iterator_selftests): Add declaration.
* unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
* unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
* unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
* unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
* unittests/main-thread-selftests.c
(_initialize_main_thread_selftests): Add declaration.
* unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
* unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
* unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
* unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
* unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
* unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
* unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
* unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
* unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
* unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
* unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
* unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
* unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
* unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
* unittests/tui-selftests.c (_initialize_tui_selftest): Add
declaration.
* unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
* unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
* unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
* unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
* user-regs.c (_initialize_user_regs): Add declaration.
* utils.c (_initialize_utils): Add declaration.
* v850-tdep.c (_initialize_v850_tdep): Add declaration.
* valops.c (_initialize_valops): Add declaration.
* valprint.c (_initialize_valprint): Add declaration.
* value.c (_initialize_values): Add declaration.
* varobj.c (_initialize_varobj): Add declaration.
* vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
* vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
* vax-tdep.c (_initialize_vax_tdep): Add declaration.
* windows-nat.c (_initialize_windows_nat): Add declaration.
(_initialize_check_for_gdb_ini): Add declaration.
(_initialize_loadable): Add declaration.
* windows-tdep.c (_initialize_windows_tdep): Add declaration.
* x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
* x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
* xcoffread.c (_initialize_xcoffread): Add declaration.
* xml-support.c (_initialize_xml_support): Add declaration.
* xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
* xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
* xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
* xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
Change-Id: I13eec7e0ed2b3c427377a7bdb055cf46da64def9
621 lines
18 KiB
C
621 lines
18 KiB
C
/* Everything about syscall catchpoints, for GDB.
|
|
|
|
Copyright (C) 2009-2020 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include <ctype.h>
|
|
#include "breakpoint.h"
|
|
#include "gdbcmd.h"
|
|
#include "inferior.h"
|
|
#include "cli/cli-utils.h"
|
|
#include "annotate.h"
|
|
#include "mi/mi-common.h"
|
|
#include "valprint.h"
|
|
#include "arch-utils.h"
|
|
#include "observable.h"
|
|
#include "xml-syscall.h"
|
|
#include "cli/cli-style.h"
|
|
|
|
/* An instance of this type is used to represent a syscall catchpoint.
|
|
A breakpoint is really of this type iff its ops pointer points to
|
|
CATCH_SYSCALL_BREAKPOINT_OPS. */
|
|
|
|
struct syscall_catchpoint : public breakpoint
|
|
{
|
|
/* Syscall numbers used for the 'catch syscall' feature. If no
|
|
syscall has been specified for filtering, it is empty.
|
|
Otherwise, it holds a list of all syscalls to be caught. */
|
|
std::vector<int> syscalls_to_be_caught;
|
|
};
|
|
|
|
struct catch_syscall_inferior_data
|
|
{
|
|
/* We keep a count of the number of times the user has requested a
|
|
particular syscall to be tracked, and pass this information to the
|
|
target. This lets capable targets implement filtering directly. */
|
|
|
|
/* Number of times that "any" syscall is requested. */
|
|
int any_syscall_count;
|
|
|
|
/* Count of each system call. */
|
|
std::vector<int> syscalls_counts;
|
|
|
|
/* This counts all syscall catch requests, so we can readily determine
|
|
if any catching is necessary. */
|
|
int total_syscalls_count;
|
|
};
|
|
|
|
static const struct inferior_key<struct catch_syscall_inferior_data>
|
|
catch_syscall_inferior_data;
|
|
|
|
static struct catch_syscall_inferior_data *
|
|
get_catch_syscall_inferior_data (struct inferior *inf)
|
|
{
|
|
struct catch_syscall_inferior_data *inf_data;
|
|
|
|
inf_data = catch_syscall_inferior_data.get (inf);
|
|
if (inf_data == NULL)
|
|
inf_data = catch_syscall_inferior_data.emplace (inf);
|
|
|
|
return inf_data;
|
|
}
|
|
|
|
/* Implement the "insert" breakpoint_ops method for syscall
|
|
catchpoints. */
|
|
|
|
static int
|
|
insert_catch_syscall (struct bp_location *bl)
|
|
{
|
|
struct syscall_catchpoint *c = (struct syscall_catchpoint *) bl->owner;
|
|
struct inferior *inf = current_inferior ();
|
|
struct catch_syscall_inferior_data *inf_data
|
|
= get_catch_syscall_inferior_data (inf);
|
|
|
|
++inf_data->total_syscalls_count;
|
|
if (c->syscalls_to_be_caught.empty ())
|
|
++inf_data->any_syscall_count;
|
|
else
|
|
{
|
|
for (int iter : c->syscalls_to_be_caught)
|
|
{
|
|
if (iter >= inf_data->syscalls_counts.size ())
|
|
inf_data->syscalls_counts.resize (iter + 1);
|
|
++inf_data->syscalls_counts[iter];
|
|
}
|
|
}
|
|
|
|
return target_set_syscall_catchpoint (inferior_ptid.pid (),
|
|
inf_data->total_syscalls_count != 0,
|
|
inf_data->any_syscall_count,
|
|
inf_data->syscalls_counts);
|
|
}
|
|
|
|
/* Implement the "remove" breakpoint_ops method for syscall
|
|
catchpoints. */
|
|
|
|
static int
|
|
remove_catch_syscall (struct bp_location *bl, enum remove_bp_reason reason)
|
|
{
|
|
struct syscall_catchpoint *c = (struct syscall_catchpoint *) bl->owner;
|
|
struct inferior *inf = current_inferior ();
|
|
struct catch_syscall_inferior_data *inf_data
|
|
= get_catch_syscall_inferior_data (inf);
|
|
|
|
--inf_data->total_syscalls_count;
|
|
if (c->syscalls_to_be_caught.empty ())
|
|
--inf_data->any_syscall_count;
|
|
else
|
|
{
|
|
for (int iter : c->syscalls_to_be_caught)
|
|
{
|
|
if (iter >= inf_data->syscalls_counts.size ())
|
|
/* Shouldn't happen. */
|
|
continue;
|
|
--inf_data->syscalls_counts[iter];
|
|
}
|
|
}
|
|
|
|
return target_set_syscall_catchpoint (inferior_ptid.pid (),
|
|
inf_data->total_syscalls_count != 0,
|
|
inf_data->any_syscall_count,
|
|
inf_data->syscalls_counts);
|
|
}
|
|
|
|
/* Implement the "breakpoint_hit" breakpoint_ops method for syscall
|
|
catchpoints. */
|
|
|
|
static int
|
|
breakpoint_hit_catch_syscall (const struct bp_location *bl,
|
|
const address_space *aspace, CORE_ADDR bp_addr,
|
|
const struct target_waitstatus *ws)
|
|
{
|
|
/* We must check if we are catching specific syscalls in this
|
|
breakpoint. If we are, then we must guarantee that the called
|
|
syscall is the same syscall we are catching. */
|
|
int syscall_number = 0;
|
|
const struct syscall_catchpoint *c
|
|
= (const struct syscall_catchpoint *) bl->owner;
|
|
|
|
if (ws->kind != TARGET_WAITKIND_SYSCALL_ENTRY
|
|
&& ws->kind != TARGET_WAITKIND_SYSCALL_RETURN)
|
|
return 0;
|
|
|
|
syscall_number = ws->value.syscall_number;
|
|
|
|
/* Now, checking if the syscall is the same. */
|
|
if (!c->syscalls_to_be_caught.empty ())
|
|
{
|
|
for (int iter : c->syscalls_to_be_caught)
|
|
if (syscall_number == iter)
|
|
return 1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
/* Implement the "print_it" breakpoint_ops method for syscall
|
|
catchpoints. */
|
|
|
|
static enum print_stop_action
|
|
print_it_catch_syscall (bpstat bs)
|
|
{
|
|
struct ui_out *uiout = current_uiout;
|
|
struct breakpoint *b = bs->breakpoint_at;
|
|
/* These are needed because we want to know in which state a
|
|
syscall is. It can be in the TARGET_WAITKIND_SYSCALL_ENTRY
|
|
or TARGET_WAITKIND_SYSCALL_RETURN, and depending on it we
|
|
must print "called syscall" or "returned from syscall". */
|
|
struct target_waitstatus last;
|
|
struct syscall s;
|
|
struct gdbarch *gdbarch = bs->bp_location_at->gdbarch;
|
|
|
|
get_last_target_status (nullptr, nullptr, &last);
|
|
|
|
get_syscall_by_number (gdbarch, last.value.syscall_number, &s);
|
|
|
|
annotate_catchpoint (b->number);
|
|
maybe_print_thread_hit_breakpoint (uiout);
|
|
|
|
if (b->disposition == disp_del)
|
|
uiout->text ("Temporary catchpoint ");
|
|
else
|
|
uiout->text ("Catchpoint ");
|
|
if (uiout->is_mi_like_p ())
|
|
{
|
|
uiout->field_string ("reason",
|
|
async_reason_lookup (last.kind == TARGET_WAITKIND_SYSCALL_ENTRY
|
|
? EXEC_ASYNC_SYSCALL_ENTRY
|
|
: EXEC_ASYNC_SYSCALL_RETURN));
|
|
uiout->field_string ("disp", bpdisp_text (b->disposition));
|
|
}
|
|
uiout->field_signed ("bkptno", b->number);
|
|
|
|
if (last.kind == TARGET_WAITKIND_SYSCALL_ENTRY)
|
|
uiout->text (" (call to syscall ");
|
|
else
|
|
uiout->text (" (returned from syscall ");
|
|
|
|
if (s.name == NULL || uiout->is_mi_like_p ())
|
|
uiout->field_signed ("syscall-number", last.value.syscall_number);
|
|
if (s.name != NULL)
|
|
uiout->field_string ("syscall-name", s.name);
|
|
|
|
uiout->text ("), ");
|
|
|
|
return PRINT_SRC_AND_LOC;
|
|
}
|
|
|
|
/* Implement the "print_one" breakpoint_ops method for syscall
|
|
catchpoints. */
|
|
|
|
static void
|
|
print_one_catch_syscall (struct breakpoint *b,
|
|
struct bp_location **last_loc)
|
|
{
|
|
struct syscall_catchpoint *c = (struct syscall_catchpoint *) b;
|
|
struct value_print_options opts;
|
|
struct ui_out *uiout = current_uiout;
|
|
struct gdbarch *gdbarch = b->loc->gdbarch;
|
|
|
|
get_user_print_options (&opts);
|
|
/* Field 4, the address, is omitted (which makes the columns not
|
|
line up too nicely with the headers, but the effect is relatively
|
|
readable). */
|
|
if (opts.addressprint)
|
|
uiout->field_skip ("addr");
|
|
annotate_field (5);
|
|
|
|
if (c->syscalls_to_be_caught.size () > 1)
|
|
uiout->text ("syscalls \"");
|
|
else
|
|
uiout->text ("syscall \"");
|
|
|
|
if (!c->syscalls_to_be_caught.empty ())
|
|
{
|
|
char *text = xstrprintf ("%s", "");
|
|
|
|
for (int iter : c->syscalls_to_be_caught)
|
|
{
|
|
char *previous_text = text;
|
|
struct syscall s;
|
|
get_syscall_by_number (gdbarch, iter, &s);
|
|
|
|
if (s.name != NULL)
|
|
text = xstrprintf ("%s%s, ", text, s.name);
|
|
else
|
|
text = xstrprintf ("%s%d, ", text, iter);
|
|
|
|
/* We have to xfree previous_text because xstrprintf dynamically
|
|
allocates new space for text on every call. */
|
|
xfree (previous_text);
|
|
}
|
|
/* Remove the last comma. */
|
|
text[strlen (text) - 2] = '\0';
|
|
uiout->field_string ("what", text);
|
|
/* xfree last text. */
|
|
xfree (text);
|
|
}
|
|
else
|
|
uiout->field_string ("what", "<any syscall>", metadata_style.style ());
|
|
uiout->text ("\" ");
|
|
|
|
if (uiout->is_mi_like_p ())
|
|
uiout->field_string ("catch-type", "syscall");
|
|
}
|
|
|
|
/* Implement the "print_mention" breakpoint_ops method for syscall
|
|
catchpoints. */
|
|
|
|
static void
|
|
print_mention_catch_syscall (struct breakpoint *b)
|
|
{
|
|
struct syscall_catchpoint *c = (struct syscall_catchpoint *) b;
|
|
struct gdbarch *gdbarch = b->loc->gdbarch;
|
|
|
|
if (!c->syscalls_to_be_caught.empty ())
|
|
{
|
|
if (c->syscalls_to_be_caught.size () > 1)
|
|
printf_filtered (_("Catchpoint %d (syscalls"), b->number);
|
|
else
|
|
printf_filtered (_("Catchpoint %d (syscall"), b->number);
|
|
|
|
for (int iter : c->syscalls_to_be_caught)
|
|
{
|
|
struct syscall s;
|
|
get_syscall_by_number (gdbarch, iter, &s);
|
|
|
|
if (s.name != NULL)
|
|
printf_filtered (" '%s' [%d]", s.name, s.number);
|
|
else
|
|
printf_filtered (" %d", s.number);
|
|
}
|
|
printf_filtered (")");
|
|
}
|
|
else
|
|
printf_filtered (_("Catchpoint %d (any syscall)"),
|
|
b->number);
|
|
}
|
|
|
|
/* Implement the "print_recreate" breakpoint_ops method for syscall
|
|
catchpoints. */
|
|
|
|
static void
|
|
print_recreate_catch_syscall (struct breakpoint *b, struct ui_file *fp)
|
|
{
|
|
struct syscall_catchpoint *c = (struct syscall_catchpoint *) b;
|
|
struct gdbarch *gdbarch = b->loc->gdbarch;
|
|
|
|
fprintf_unfiltered (fp, "catch syscall");
|
|
|
|
for (int iter : c->syscalls_to_be_caught)
|
|
{
|
|
struct syscall s;
|
|
|
|
get_syscall_by_number (gdbarch, iter, &s);
|
|
if (s.name != NULL)
|
|
fprintf_unfiltered (fp, " %s", s.name);
|
|
else
|
|
fprintf_unfiltered (fp, " %d", s.number);
|
|
}
|
|
|
|
print_recreate_thread (b, fp);
|
|
}
|
|
|
|
/* The breakpoint_ops structure to be used in syscall catchpoints. */
|
|
|
|
static struct breakpoint_ops catch_syscall_breakpoint_ops;
|
|
|
|
/* Returns non-zero if 'b' is a syscall catchpoint. */
|
|
|
|
static int
|
|
syscall_catchpoint_p (struct breakpoint *b)
|
|
{
|
|
return (b->ops == &catch_syscall_breakpoint_ops);
|
|
}
|
|
|
|
static void
|
|
create_syscall_event_catchpoint (int tempflag, std::vector<int> &&filter,
|
|
const struct breakpoint_ops *ops)
|
|
{
|
|
struct gdbarch *gdbarch = get_current_arch ();
|
|
|
|
std::unique_ptr<syscall_catchpoint> c (new syscall_catchpoint ());
|
|
init_catchpoint (c.get (), gdbarch, tempflag, NULL, ops);
|
|
c->syscalls_to_be_caught = std::move (filter);
|
|
|
|
install_breakpoint (0, std::move (c), 1);
|
|
}
|
|
|
|
/* Splits the argument using space as delimiter. */
|
|
|
|
static std::vector<int>
|
|
catch_syscall_split_args (const char *arg)
|
|
{
|
|
std::vector<int> result;
|
|
struct gdbarch *gdbarch = target_gdbarch ();
|
|
|
|
while (*arg != '\0')
|
|
{
|
|
int i, syscall_number;
|
|
char *endptr;
|
|
char cur_name[128];
|
|
struct syscall s;
|
|
|
|
/* Skip whitespace. */
|
|
arg = skip_spaces (arg);
|
|
|
|
for (i = 0; i < 127 && arg[i] && !isspace (arg[i]); ++i)
|
|
cur_name[i] = arg[i];
|
|
cur_name[i] = '\0';
|
|
arg += i;
|
|
|
|
/* Check if the user provided a syscall name, group, or a number. */
|
|
syscall_number = (int) strtol (cur_name, &endptr, 0);
|
|
if (*endptr == '\0')
|
|
{
|
|
get_syscall_by_number (gdbarch, syscall_number, &s);
|
|
result.push_back (s.number);
|
|
}
|
|
else if (startswith (cur_name, "g:")
|
|
|| startswith (cur_name, "group:"))
|
|
{
|
|
/* We have a syscall group. Let's expand it into a syscall
|
|
list before inserting. */
|
|
const char *group_name;
|
|
|
|
/* Skip over "g:" and "group:" prefix strings. */
|
|
group_name = strchr (cur_name, ':') + 1;
|
|
|
|
if (!get_syscalls_by_group (gdbarch, group_name, &result))
|
|
error (_("Unknown syscall group '%s'."), group_name);
|
|
}
|
|
else
|
|
{
|
|
/* We have a name. Let's check if it's valid and fetch a
|
|
list of matching numbers. */
|
|
if (!get_syscalls_by_name (gdbarch, cur_name, &result))
|
|
/* Here we have to issue an error instead of a warning,
|
|
because GDB cannot do anything useful if there's no
|
|
syscall number to be caught. */
|
|
error (_("Unknown syscall name '%s'."), cur_name);
|
|
}
|
|
}
|
|
|
|
return result;
|
|
}
|
|
|
|
/* Implement the "catch syscall" command. */
|
|
|
|
static void
|
|
catch_syscall_command_1 (const char *arg, int from_tty,
|
|
struct cmd_list_element *command)
|
|
{
|
|
int tempflag;
|
|
std::vector<int> filter;
|
|
struct syscall s;
|
|
struct gdbarch *gdbarch = get_current_arch ();
|
|
|
|
/* Checking if the feature if supported. */
|
|
if (gdbarch_get_syscall_number_p (gdbarch) == 0)
|
|
error (_("The feature 'catch syscall' is not supported on \
|
|
this architecture yet."));
|
|
|
|
tempflag = get_cmd_context (command) == CATCH_TEMPORARY;
|
|
|
|
arg = skip_spaces (arg);
|
|
|
|
/* We need to do this first "dummy" translation in order
|
|
to get the syscall XML file loaded or, most important,
|
|
to display a warning to the user if there's no XML file
|
|
for his/her architecture. */
|
|
get_syscall_by_number (gdbarch, 0, &s);
|
|
|
|
/* The allowed syntax is:
|
|
catch syscall
|
|
catch syscall <name | number> [<name | number> ... <name | number>]
|
|
|
|
Let's check if there's a syscall name. */
|
|
|
|
if (arg != NULL)
|
|
filter = catch_syscall_split_args (arg);
|
|
|
|
create_syscall_event_catchpoint (tempflag, std::move (filter),
|
|
&catch_syscall_breakpoint_ops);
|
|
}
|
|
|
|
|
|
/* Returns 0 if 'bp' is NOT a syscall catchpoint,
|
|
non-zero otherwise. */
|
|
static int
|
|
is_syscall_catchpoint_enabled (struct breakpoint *bp)
|
|
{
|
|
if (syscall_catchpoint_p (bp)
|
|
&& bp->enable_state != bp_disabled
|
|
&& bp->enable_state != bp_call_disabled)
|
|
return 1;
|
|
else
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
catch_syscall_enabled (void)
|
|
{
|
|
struct catch_syscall_inferior_data *inf_data
|
|
= get_catch_syscall_inferior_data (current_inferior ());
|
|
|
|
return inf_data->total_syscalls_count != 0;
|
|
}
|
|
|
|
/* Helper function for catching_syscall_number. If B is a syscall
|
|
catchpoint for SYSCALL_NUMBER, return 1 (which will make
|
|
'breakpoint_find_if' return). Otherwise, return 0. */
|
|
|
|
static int
|
|
catching_syscall_number_1 (struct breakpoint *b,
|
|
void *data)
|
|
{
|
|
int syscall_number = (int) (uintptr_t) data;
|
|
|
|
if (is_syscall_catchpoint_enabled (b))
|
|
{
|
|
struct syscall_catchpoint *c = (struct syscall_catchpoint *) b;
|
|
|
|
if (!c->syscalls_to_be_caught.empty ())
|
|
{
|
|
for (int iter : c->syscalls_to_be_caught)
|
|
if (syscall_number == iter)
|
|
return 1;
|
|
}
|
|
else
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
catching_syscall_number (int syscall_number)
|
|
{
|
|
struct breakpoint *b = breakpoint_find_if (catching_syscall_number_1,
|
|
(void *) (uintptr_t) syscall_number);
|
|
|
|
return b != NULL;
|
|
}
|
|
|
|
/* Complete syscall names. Used by "catch syscall". */
|
|
|
|
static void
|
|
catch_syscall_completer (struct cmd_list_element *cmd,
|
|
completion_tracker &tracker,
|
|
const char *text, const char *word)
|
|
{
|
|
struct gdbarch *gdbarch = get_current_arch ();
|
|
gdb::unique_xmalloc_ptr<const char *> group_list;
|
|
const char *prefix;
|
|
|
|
/* Completion considers ':' to be a word separator, so we use this to
|
|
verify whether the previous word was a group prefix. If so, we
|
|
build the completion list using group names only. */
|
|
for (prefix = word; prefix != text && prefix[-1] != ' '; prefix--)
|
|
;
|
|
|
|
if (startswith (prefix, "g:") || startswith (prefix, "group:"))
|
|
{
|
|
/* Perform completion inside 'group:' namespace only. */
|
|
group_list.reset (get_syscall_group_names (gdbarch));
|
|
if (group_list != NULL)
|
|
complete_on_enum (tracker, group_list.get (), word, word);
|
|
}
|
|
else
|
|
{
|
|
/* Complete with both, syscall names and groups. */
|
|
gdb::unique_xmalloc_ptr<const char *> syscall_list
|
|
(get_syscall_names (gdbarch));
|
|
group_list.reset (get_syscall_group_names (gdbarch));
|
|
|
|
const char **group_ptr = group_list.get ();
|
|
|
|
/* Hold on to strings while we're using them. */
|
|
std::vector<std::string> holders;
|
|
|
|
/* Append "group:" prefix to syscall groups. */
|
|
for (int i = 0; group_ptr[i] != NULL; i++)
|
|
holders.push_back (string_printf ("group:%s", group_ptr[i]));
|
|
|
|
for (int i = 0; group_ptr[i] != NULL; i++)
|
|
group_ptr[i] = holders[i].c_str ();
|
|
|
|
if (syscall_list != NULL)
|
|
complete_on_enum (tracker, syscall_list.get (), word, word);
|
|
if (group_list != NULL)
|
|
complete_on_enum (tracker, group_ptr, word, word);
|
|
}
|
|
}
|
|
|
|
static void
|
|
clear_syscall_counts (struct inferior *inf)
|
|
{
|
|
struct catch_syscall_inferior_data *inf_data
|
|
= get_catch_syscall_inferior_data (inf);
|
|
|
|
inf_data->total_syscalls_count = 0;
|
|
inf_data->any_syscall_count = 0;
|
|
inf_data->syscalls_counts.clear ();
|
|
}
|
|
|
|
static void
|
|
initialize_syscall_catchpoint_ops (void)
|
|
{
|
|
struct breakpoint_ops *ops;
|
|
|
|
initialize_breakpoint_ops ();
|
|
|
|
/* Syscall catchpoints. */
|
|
ops = &catch_syscall_breakpoint_ops;
|
|
*ops = base_breakpoint_ops;
|
|
ops->insert_location = insert_catch_syscall;
|
|
ops->remove_location = remove_catch_syscall;
|
|
ops->breakpoint_hit = breakpoint_hit_catch_syscall;
|
|
ops->print_it = print_it_catch_syscall;
|
|
ops->print_one = print_one_catch_syscall;
|
|
ops->print_mention = print_mention_catch_syscall;
|
|
ops->print_recreate = print_recreate_catch_syscall;
|
|
}
|
|
|
|
void _initialize_break_catch_syscall ();
|
|
void
|
|
_initialize_break_catch_syscall ()
|
|
{
|
|
initialize_syscall_catchpoint_ops ();
|
|
|
|
gdb::observers::inferior_exit.attach (clear_syscall_counts);
|
|
|
|
add_catch_command ("syscall", _("\
|
|
Catch system calls by their names, groups and/or numbers.\n\
|
|
Arguments say which system calls to catch. If no arguments are given,\n\
|
|
every system call will be caught. Arguments, if given, should be one\n\
|
|
or more system call names (if your system supports that), system call\n\
|
|
groups or system call numbers."),
|
|
catch_syscall_command_1,
|
|
catch_syscall_completer,
|
|
CATCH_PERMANENT,
|
|
CATCH_TEMPORARY);
|
|
}
|