65630365f7
This patch gets rid of catch_exceptions / catch_exceptions_with_msg. The latter is done mostly by getting rid of the three remaining vestigial libgdb wrapper functions, which are really pointless nowadays. This results in a good number of simplifications. (I checked that Insight doesn't use those functions.) The gdb.mi/mi-pthreads.exp change is necessary because this actually fixes a bug, IMO -- the patch stops MI's -thread-select causing output on the CLI stream. I.e., before: -thread-select 123456789 &"Thread ID 123456789 not known.\n" ^error,msg="Thread ID 123456789 not known." (gdb) After: -thread-select 123456789 ^error,msg="Thread ID 123456789 not known." (gdb) gdb/ChangeLog 2017-10-10 Pedro Alves <palves@redhat.com> Tom Tromey <tom@tromey.com> * breakpoint.c (struct captured_breakpoint_query_args) (do_captured_breakpoint_query, gdb_breakpoint_query): Delete. (print_breakpoint): New. * breakpoint.h (print_breakpoint): Declare. * common/common-exceptions.h (enum return_reason): Remove references to catch_exceptions. * exceptions.c (catch_exceptions, catch_exceptions_with_msg): Delete. * exceptions.h (catch_exceptions_ftype, catch_exceptions) (catch_exception_ftype, catch_exceptions_with_msg): Delete. * gdb.h: Delete. * gdbthread.h (thread_select): Declare. * mi/mi-cmd-break.c: Don't include gdb.h. (breakpoint_notify): Use print_breakpoint. * mi/mi-cmd-catch.c: Don't include gdb.h. * mi/mi-interp.c: Don't include gdb.h. (mi_print_breakpoint_for_event): New. (mi_breakpoint_created, mi_breakpoint_modified): Use mi_print_breakpoint_for_event. * mi/mi-main.c: Don't include gdb.h. (mi_cmd_thread_select): Parse the global thread ID here. Use thread_select instead of gdb_thread_select. (mi_cmd_thread_list_ids): Output "thread-ids" tuple here instead of using gdb_list_thread_ids. * remote-fileio.c (do_remote_fileio_request): Change type. Reply FILEIO_ENOSYS here. (remote_fileio_request): Use TRY/CATCH instead of catch_exceptions. * symfile-mem.c (struct symbol_file_add_from_memory_args) (symbol_file_add_from_memory_wrapper): Delete. (add_vsyscall_page): Use TRY/CATCH instead of catch_exceptions. * thread.c: Don't include gdb.h. (do_captured_list_thread_ids, gdb_list_thread_ids): Delete. (thread_alive): Use thread_select. (do_captured_thread_select): Delete, parts salvaged as ... (thread_select): ... this new function. (gdb_thread_select): Delete. gdb/testsuite/ChangeLog 2017-10-10 Pedro Alves <palves@redhat.com> * gdb.mi/mi-pthreads.exp (check_mi_thread_command_set): Don't expect CLI output.
78 lines
2.4 KiB
Plaintext
78 lines
2.4 KiB
Plaintext
# Copyright 2002-2017 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This file tests MI thread commands.
|
|
# Specifically, we are testing the MI command set and the console (in MI)
|
|
# command set ("interpreter-exec") and that the commands that are executed
|
|
# via these command pathways are properly executed. Console commands
|
|
# executed via MI should use MI output wrappers, MI event handlers, etc.
|
|
|
|
load_lib mi-support.exp
|
|
set MIFLAGS "-i=mi"
|
|
|
|
gdb_exit
|
|
if {[mi_gdb_start]} {
|
|
continue
|
|
}
|
|
|
|
# This procedure tests the various thread commands in MI.
|
|
proc check_mi_thread_command_set {} {
|
|
|
|
mi_runto done_making_threads
|
|
|
|
set thread_list [get_mi_thread_list "in check_mi_thread_command_set"]
|
|
|
|
mi_gdb_test "-thread-select" \
|
|
{\^error,msg="-thread-select: USAGE: threadnum."} \
|
|
"check_mi_thread_command_set: -thread-select"
|
|
|
|
mi_gdb_test "-thread-select 123456789" \
|
|
{\^error,msg="Thread ID 123456789 not known\."} \
|
|
"check_mi_thread_command_set: -thread-select 123456789"
|
|
|
|
foreach thread $thread_list {
|
|
# line and file are optional.
|
|
# many of the threads are blocked in libc calls,
|
|
# and many people have libc's with no symbols.
|
|
mi_gdb_test "-thread-select $thread" \
|
|
"\\^done,new-thread-id=\"$thread\",frame={.*}(,line=\"(-)?\[0-9\]+\",file=\".*\")?" \
|
|
"check_mi_thread_command_set: -thread-select $thread"
|
|
}
|
|
|
|
foreach thread $thread_list {
|
|
mi_gdb_test "-interpreter-exec console \"thread $thread\"" \
|
|
".*=thread-selected,id=\"$thread\".*\r\n\\^done" \
|
|
"check =thread-selected: thread $thread"
|
|
}
|
|
}
|
|
|
|
#
|
|
# Start here
|
|
#
|
|
standard_testfile pthreads.c
|
|
|
|
set options [list debug]
|
|
if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } {
|
|
return -1
|
|
}
|
|
|
|
mi_gdb_reinitialize_dir $srcdir/$subdir
|
|
mi_gdb_load $binfile
|
|
|
|
check_mi_thread_command_set
|
|
|
|
mi_gdb_exit
|
|
|