e6a58aa8a7
[This patch should go on top of "linux_qxfer_libraries_svr4: Use std::string", I should have sent them together as a series.] I noticed that linux_qxfer_libraries_svr4 used xml_escape_text, which returns an std::string. That string is then copied into a larger buffer. It would be more efficient if we had a version of xml_escape_text which appended to an existing string instead of returning a new one. This is what this patch does. I manually verified that the output of linux_qxfer_libraries_svr4 didn't change before/after the patch. gdb/ChangeLog: * common/xml-utils.c (xml_escape_text): Move code to... (xml_escape_text_append): ... this new function. * common/xml-utils.h (xml_escape_text_append): New declaration. * unittests/xml-utils-selftests.c (test_xml_escape_text_append): New function. (_initialize_xml_utils): register test_xml_escape_text_append as a selftest. gdb/gdbserver/ChangeLog: * linux-low.c (linux_qxfer_libraries_svr4): Use xml_escape_text_append.
59 lines
1.7 KiB
C
59 lines
1.7 KiB
C
/* Unit tests for the xml-utils.c file.
|
|
|
|
Copyright (C) 2017-2018 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "xml-utils.h"
|
|
#include "selftest.h"
|
|
|
|
namespace selftests {
|
|
namespace xml_utils {
|
|
|
|
static void test_xml_escape_text ()
|
|
{
|
|
const char *input = "<this isn't=\"xml\"> &";
|
|
const char *expected_output = "<this isn't="xml"> &";
|
|
std::string actual_output = xml_escape_text (input);
|
|
|
|
SELF_CHECK (actual_output == expected_output);
|
|
}
|
|
|
|
static void test_xml_escape_text_append ()
|
|
{
|
|
/* Make sure that we do indeed append. */
|
|
std::string actual_output = "foo<xml>";
|
|
const char *input = "<this isn't=\"xml\"> &";
|
|
const char *expected_output
|
|
= "foo<xml><this isn't="xml"> &";
|
|
xml_escape_text_append (&actual_output, input);
|
|
|
|
SELF_CHECK (actual_output == expected_output);
|
|
}
|
|
|
|
}
|
|
}
|
|
|
|
void
|
|
_initialize_xml_utils ()
|
|
{
|
|
selftests::register_test ("xml_escape_text",
|
|
selftests::xml_utils::test_xml_escape_text);
|
|
selftests::register_test ("xml_escape_text_append",
|
|
selftests::xml_utils::test_xml_escape_text_append);
|
|
}
|