6c2659886f
I'd like to enable the -Wmissing-declarations warning. However, it
warns for every _initialize function, for example:
CXX dcache.o
/home/smarchi/src/binutils-gdb/gdb/dcache.c: In function ‘void _initialize_dcache()’:
/home/smarchi/src/binutils-gdb/gdb/dcache.c:688:1: error: no previous declaration for ‘void _initialize_dcache()’ [-Werror=missing-declarations]
_initialize_dcache (void)
^~~~~~~~~~~~~~~~~~
The only practical way forward I found is to add back the declarations,
which were removed by this commit:
commit 481695ed5f
Author: John Baldwin <jhb@FreeBSD.org>
Date: Sat Sep 9 11:02:37 2017 -0700
Remove unnecessary function prototypes.
I don't think it's a big problem to have the declarations for these
functions, but if anybody has a better solution for this, I'll be happy
to use it.
gdb/ChangeLog:
* aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
* aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
* aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
* aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
* aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
* aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
* ada-exp.y (_initialize_ada_exp): Add declaration.
* ada-lang.c (_initialize_ada_language): Add declaration.
* ada-tasks.c (_initialize_tasks): Add declaration.
* agent.c (_initialize_agent): Add declaration.
* aix-thread.c (_initialize_aix_thread): Add declaration.
* alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
* alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
* alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
* alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
* alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
* alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
* amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
* amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
* amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
* amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
* amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
* amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
* amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
* amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
* amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
* amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
* amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
* amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
* amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
* amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
* annotate.c (_initialize_annotate): Add declaration.
* arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
* arc-tdep.c (_initialize_arc_tdep): Add declaration.
* arch-utils.c (_initialize_gdbarch_utils): Add declaration.
* arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
* arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
* arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
* arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
* arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
* arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
* arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
* arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
* arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
* arm-tdep.c (_initialize_arm_tdep): Add declaration.
* arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
* auto-load.c (_initialize_auto_load): Add declaration.
* auxv.c (_initialize_auxv): Add declaration.
* avr-tdep.c (_initialize_avr_tdep): Add declaration.
* ax-gdb.c (_initialize_ax_gdb): Add declaration.
* bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
* bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
* break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
* break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
* break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
* breakpoint.c (_initialize_breakpoint): Add declaration.
* bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
* btrace.c (_initialize_btrace): Add declaration.
* charset.c (_initialize_charset): Add declaration.
* cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
* cli/cli-dump.c (_initialize_cli_dump): Add declaration.
* cli/cli-interp.c (_initialize_cli_interp): Add declaration.
* cli/cli-logging.c (_initialize_cli_logging): Add declaration.
* cli/cli-script.c (_initialize_cli_script): Add declaration.
* cli/cli-style.c (_initialize_cli_style): Add declaration.
* coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
* coffread.c (_initialize_coffread): Add declaration.
* compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
* compile/compile.c (_initialize_compile): Add declaration.
* complaints.c (_initialize_complaints): Add declaration.
* completer.c (_initialize_completer): Add declaration.
* copying.c (_initialize_copying): Add declaration.
* corefile.c (_initialize_core): Add declaration.
* corelow.c (_initialize_corelow): Add declaration.
* cp-abi.c (_initialize_cp_abi): Add declaration.
* cp-namespace.c (_initialize_cp_namespace): Add declaration.
* cp-support.c (_initialize_cp_support): Add declaration.
* cp-valprint.c (_initialize_cp_valprint): Add declaration.
* cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
* cris-tdep.c (_initialize_cris_tdep): Add declaration.
* csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
* csky-tdep.c (_initialize_csky_tdep): Add declaration.
* ctfread.c (_initialize_ctfread): Add declaration.
* d-lang.c (_initialize_d_language): Add declaration.
* darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
* darwin-nat.c (_initialize_darwin_nat): Add declaration.
* dbxread.c (_initialize_dbxread): Add declaration.
* dcache.c (_initialize_dcache): Add declaration.
* disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
* disasm.c (_initialize_disasm): Add declaration.
* dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
* dummy-frame.c (_initialize_dummy_frame): Add declaration.
* dwarf-index-cache.c (_initialize_index_cache): Add declaration.
* dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
* dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
* dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
* dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
* dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
* dwarf2read.c (_initialize_dwarf2_read): Add declaration.
* elfread.c (_initialize_elfread): Add declaration.
* exec.c (_initialize_exec): Add declaration.
* extension.c (_initialize_extension): Add declaration.
* f-lang.c (_initialize_f_language): Add declaration.
* f-valprint.c (_initialize_f_valprint): Add declaration.
* fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
* fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
* filesystem.c (_initialize_filesystem): Add declaration.
* findcmd.c (_initialize_mem_search): Add declaration.
* findvar.c (_initialize_findvar): Add declaration.
* fork-child.c (_initialize_fork_child): Add declaration.
* frame-base.c (_initialize_frame_base): Add declaration.
* frame-unwind.c (_initialize_frame_unwind): Add declaration.
* frame.c (_initialize_frame): Add declaration.
* frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
* frv-tdep.c (_initialize_frv_tdep): Add declaration.
* ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
* gcore.c (_initialize_gcore): Add declaration.
* gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
* gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
* gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
* gdbarch.c (_initialize_gdbarch): Add declaration.
* gdbtypes.c (_initialize_gdbtypes): Add declaration.
* gnu-nat.c (_initialize_gnu_nat): Add declaration.
* gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
* gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
* go-lang.c (_initialize_go_language): Add declaration.
* go32-nat.c (_initialize_go32_nat): Add declaration.
* guile/guile.c (_initialize_guile): Add declaration.
* h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
* hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
* hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
* hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
* hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
* hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
* hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
* hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
* i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
* i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
* i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
* i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
* i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
* i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
* i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
* i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
* i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
* i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
* i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
* i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
* i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
* i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
* i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
* i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
* i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
* i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
* i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
* i386-tdep.c (_initialize_i386_tdep): Add declaration.
* i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
* ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
* ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
* ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
* ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
* ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
* infcall.c (_initialize_infcall): Add declaration.
* infcmd.c (_initialize_infcmd): Add declaration.
* inflow.c (_initialize_inflow): Add declaration.
* infrun.c (_initialize_infrun): Add declaration.
* interps.c (_initialize_interpreter): Add declaration.
* iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
* jit.c (_initialize_jit): Add declaration.
* language.c (_initialize_language): Add declaration.
* linux-fork.c (_initialize_linux_fork): Add declaration.
* linux-nat.c (_initialize_linux_nat): Add declaration.
* linux-tdep.c (_initialize_linux_tdep): Add declaration.
* linux-thread-db.c (_initialize_thread_db): Add declaration.
* lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
* m2-lang.c (_initialize_m2_language): Add declaration.
* m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
* m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
* m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
* m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
* m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
* m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
* m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
* m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
* m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
* m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
* machoread.c (_initialize_machoread): Add declaration.
* macrocmd.c (_initialize_macrocmd): Add declaration.
* macroscope.c (_initialize_macroscope): Add declaration.
* maint-test-options.c (_initialize_maint_test_options): Add declaration.
* maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
* maint.c (_initialize_maint_cmds): Add declaration.
* mdebugread.c (_initialize_mdebugread): Add declaration.
* memattr.c (_initialize_mem): Add declaration.
* mep-tdep.c (_initialize_mep_tdep): Add declaration.
* mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
* mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
* mi/mi-interp.c (_initialize_mi_interp): Add declaration.
* mi/mi-main.c (_initialize_mi_main): Add declaration.
* microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
* microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
* mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
* mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
* mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
* mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
* mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
* mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
* mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
* mips-tdep.c (_initialize_mips_tdep): Add declaration.
* mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
* mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
* mipsread.c (_initialize_mipsread): Add declaration.
* mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
* mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
* moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
* msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
* nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
* nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
* nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
* nto-procfs.c (_initialize_procfs): Add declaration.
* objc-lang.c (_initialize_objc_language): Add declaration.
* observable.c (_initialize_observer): Add declaration.
* opencl-lang.c (_initialize_opencl_language): Add declaration.
* or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
* or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
* osabi.c (_initialize_gdb_osabi): Add declaration.
* osdata.c (_initialize_osdata): Add declaration.
* p-valprint.c (_initialize_pascal_valprint): Add declaration.
* parse.c (_initialize_parse): Add declaration.
* ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
* ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
* ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
* ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
* ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
* ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
* ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
* ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
* printcmd.c (_initialize_printcmd): Add declaration.
* probe.c (_initialize_probe): Add declaration.
* proc-api.c (_initialize_proc_api): Add declaration.
* proc-events.c (_initialize_proc_events): Add declaration.
* proc-service.c (_initialize_proc_service): Add declaration.
* procfs.c (_initialize_procfs): Add declaration.
* producer.c (_initialize_producer): Add declaration.
* psymtab.c (_initialize_psymtab): Add declaration.
* python/python.c (_initialize_python): Add declaration.
* ravenscar-thread.c (_initialize_ravenscar): Add declaration.
* record-btrace.c (_initialize_record_btrace): Add declaration.
* record-full.c (_initialize_record_full): Add declaration.
* record.c (_initialize_record): Add declaration.
* regcache-dump.c (_initialize_regcache_dump): Add declaration.
* regcache.c (_initialize_regcache): Add declaration.
* reggroups.c (_initialize_reggroup): Add declaration.
* remote-notif.c (_initialize_notif): Add declaration.
* remote-sim.c (_initialize_remote_sim): Add declaration.
* remote.c (_initialize_remote): Add declaration.
* reverse.c (_initialize_reverse): Add declaration.
* riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
* riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
* riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
* riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
* riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
* rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
* rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
* rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
Add declaration.
* rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
* rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
* run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
* rust-exp.y (_initialize_rust_exp): Add declaration.
* rx-tdep.c (_initialize_rx_tdep): Add declaration.
* s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
* s390-linux-nat.c (_initialize_s390_nat): Add declaration.
* s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
* s390-tdep.c (_initialize_s390_tdep): Add declaration.
* score-tdep.c (_initialize_score_tdep): Add declaration.
* ser-go32.c (_initialize_ser_dos): Add declaration.
* ser-mingw.c (_initialize_ser_windows): Add declaration.
* ser-pipe.c (_initialize_ser_pipe): Add declaration.
* ser-tcp.c (_initialize_ser_tcp): Add declaration.
* ser-uds.c (_initialize_ser_socket): Add declaration.
* ser-unix.c (_initialize_ser_hardwire): Add declaration.
* serial.c (_initialize_serial): Add declaration.
* sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
* sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
* sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
* sh-tdep.c (_initialize_sh_tdep): Add declaration.
* skip.c (_initialize_step_skip): Add declaration.
* sol-thread.c (_initialize_sol_thread): Add declaration.
* solib-aix.c (_initialize_solib_aix): Add declaration.
* solib-darwin.c (_initialize_darwin_solib): Add declaration.
* solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
* solib-frv.c (_initialize_frv_solib): Add declaration.
* solib-svr4.c (_initialize_svr4_solib): Add declaration.
* solib-target.c (_initialize_solib_target): Add declaration.
* solib.c (_initialize_solib): Add declaration.
* source-cache.c (_initialize_source_cache): Add declaration.
* source.c (_initialize_source): Add declaration.
* sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
* sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
* sparc-nat.c (_initialize_sparc_nat): Add declaration.
* sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
* sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
* sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
* sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
* sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
* sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
* sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
* sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
* sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
* sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
* sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
* sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
* sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
* sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
* sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
* sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
* stabsread.c (_initialize_stabsread): Add declaration.
* stack.c (_initialize_stack): Add declaration.
* stap-probe.c (_initialize_stap_probe): Add declaration.
* std-regs.c (_initialize_frame_reg): Add declaration.
* symfile-debug.c (_initialize_symfile_debug): Add declaration.
* symfile-mem.c (_initialize_symfile_mem): Add declaration.
* symfile.c (_initialize_symfile): Add declaration.
* symmisc.c (_initialize_symmisc): Add declaration.
* symtab.c (_initialize_symtab): Add declaration.
* target.c (_initialize_target): Add declaration.
* target-connection.c (_initialize_target_connection): Add
declaration.
* target-dcache.c (_initialize_target_dcache): Add declaration.
* target-descriptions.c (_initialize_target_descriptions): Add declaration.
* thread.c (_initialize_thread): Add declaration.
* tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
* tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
* tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
* tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
* tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
* tracectf.c (_initialize_ctf): Add declaration.
* tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
* tracefile.c (_initialize_tracefile): Add declaration.
* tracepoint.c (_initialize_tracepoint): Add declaration.
* tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
* tui/tui-interp.c (_initialize_tui_interp): Add declaration.
* tui/tui-layout.c (_initialize_tui_layout): Add declaration.
* tui/tui-regs.c (_initialize_tui_regs): Add declaration.
* tui/tui-stack.c (_initialize_tui_stack): Add declaration.
* tui/tui-win.c (_initialize_tui_win): Add declaration.
* tui/tui.c (_initialize_tui): Add declaration.
* typeprint.c (_initialize_typeprint): Add declaration.
* ui-style.c (_initialize_ui_style): Add declaration.
* unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
* unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
* unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
* unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
* unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
* unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
* unittests/filtered_iterator-selftests.c
(_initialize_filtered_iterator_selftests): Add declaration.
* unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
* unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
* unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
* unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
* unittests/main-thread-selftests.c
(_initialize_main_thread_selftests): Add declaration.
* unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
* unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
* unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
* unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
* unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
* unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
* unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
* unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
* unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
* unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
* unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
* unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
* unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
* unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
* unittests/tui-selftests.c (_initialize_tui_selftest): Add
declaration.
* unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
* unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
* unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
* unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
* user-regs.c (_initialize_user_regs): Add declaration.
* utils.c (_initialize_utils): Add declaration.
* v850-tdep.c (_initialize_v850_tdep): Add declaration.
* valops.c (_initialize_valops): Add declaration.
* valprint.c (_initialize_valprint): Add declaration.
* value.c (_initialize_values): Add declaration.
* varobj.c (_initialize_varobj): Add declaration.
* vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
* vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
* vax-tdep.c (_initialize_vax_tdep): Add declaration.
* windows-nat.c (_initialize_windows_nat): Add declaration.
(_initialize_check_for_gdb_ini): Add declaration.
(_initialize_loadable): Add declaration.
* windows-tdep.c (_initialize_windows_tdep): Add declaration.
* x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
* x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
* xcoffread.c (_initialize_xcoffread): Add declaration.
* xml-support.c (_initialize_xml_support): Add declaration.
* xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
* xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
* xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
* xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
Change-Id: I13eec7e0ed2b3c427377a7bdb055cf46da64def9
997 lines
24 KiB
C
997 lines
24 KiB
C
/* Definitions for BFD wrappers used by GDB.
|
||
|
||
Copyright (C) 2011-2020 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include "gdb_bfd.h"
|
||
#include "ui-out.h"
|
||
#include "gdbcmd.h"
|
||
#include "hashtab.h"
|
||
#include "gdbsupport/filestuff.h"
|
||
#ifdef HAVE_MMAP
|
||
#include <sys/mman.h>
|
||
#ifndef MAP_FAILED
|
||
#define MAP_FAILED ((void *) -1)
|
||
#endif
|
||
#endif
|
||
#include "target.h"
|
||
#include "gdb/fileio.h"
|
||
#include "inferior.h"
|
||
|
||
/* An object of this type is stored in the section's user data when
|
||
mapping a section. */
|
||
|
||
struct gdb_bfd_section_data
|
||
{
|
||
/* Size of the data. */
|
||
bfd_size_type size;
|
||
/* If the data was mmapped, this is the length of the map. */
|
||
bfd_size_type map_len;
|
||
/* The data. If NULL, the section data has not been read. */
|
||
void *data;
|
||
/* If the data was mmapped, this is the map address. */
|
||
void *map_addr;
|
||
};
|
||
|
||
/* A hash table holding every BFD that gdb knows about. This is not
|
||
to be confused with 'gdb_bfd_cache', which is used for sharing
|
||
BFDs; in contrast, this hash is used just to implement
|
||
"maint info bfd". */
|
||
|
||
static htab_t all_bfds;
|
||
|
||
/* An object of this type is stored in each BFD's user data. */
|
||
|
||
struct gdb_bfd_data
|
||
{
|
||
gdb_bfd_data (bfd *abfd)
|
||
: mtime (bfd_get_mtime (abfd)),
|
||
size (bfd_get_size (abfd)),
|
||
relocation_computed (0),
|
||
needs_relocations (0),
|
||
crc_computed (0)
|
||
{
|
||
struct stat buf;
|
||
|
||
if (bfd_stat (abfd, &buf) == 0)
|
||
{
|
||
inode = buf.st_ino;
|
||
device_id = buf.st_dev;
|
||
}
|
||
else
|
||
{
|
||
/* The stat failed. */
|
||
inode = 0;
|
||
device_id = 0;
|
||
}
|
||
}
|
||
|
||
~gdb_bfd_data ()
|
||
{
|
||
}
|
||
|
||
/* The reference count. */
|
||
int refc = 1;
|
||
|
||
/* The mtime of the BFD at the point the cache entry was made. */
|
||
time_t mtime;
|
||
|
||
/* The file size (in bytes) at the point the cache entry was made. */
|
||
off_t size;
|
||
|
||
/* The inode of the file at the point the cache entry was made. */
|
||
ino_t inode;
|
||
|
||
/* The device id of the file at the point the cache entry was made. */
|
||
dev_t device_id;
|
||
|
||
/* This is true if we have determined whether this BFD has any
|
||
sections requiring relocation. */
|
||
unsigned int relocation_computed : 1;
|
||
|
||
/* This is true if any section needs relocation. */
|
||
unsigned int needs_relocations : 1;
|
||
|
||
/* This is true if we have successfully computed the file's CRC. */
|
||
unsigned int crc_computed : 1;
|
||
|
||
/* The file's CRC. */
|
||
unsigned long crc = 0;
|
||
|
||
/* If the BFD comes from an archive, this points to the archive's
|
||
BFD. Otherwise, this is NULL. */
|
||
bfd *archive_bfd = nullptr;
|
||
|
||
/* Table of all the bfds this bfd has included. */
|
||
std::vector<gdb_bfd_ref_ptr> included_bfds;
|
||
|
||
/* The registry. */
|
||
REGISTRY_FIELDS = {};
|
||
};
|
||
|
||
#define GDB_BFD_DATA_ACCESSOR(ABFD) \
|
||
((struct gdb_bfd_data *) bfd_usrdata (ABFD))
|
||
|
||
DEFINE_REGISTRY (bfd, GDB_BFD_DATA_ACCESSOR)
|
||
|
||
/* A hash table storing all the BFDs maintained in the cache. */
|
||
|
||
static htab_t gdb_bfd_cache;
|
||
|
||
/* When true gdb will reuse an existing bfd object if the filename,
|
||
modification time, and file size all match. */
|
||
|
||
static bool bfd_sharing = true;
|
||
static void
|
||
show_bfd_sharing (struct ui_file *file, int from_tty,
|
||
struct cmd_list_element *c, const char *value)
|
||
{
|
||
fprintf_filtered (file, _("BFD sharing is %s.\n"), value);
|
||
}
|
||
|
||
/* When non-zero debugging of the bfd caches is enabled. */
|
||
|
||
static unsigned int debug_bfd_cache;
|
||
static void
|
||
show_bfd_cache_debug (struct ui_file *file, int from_tty,
|
||
struct cmd_list_element *c, const char *value)
|
||
{
|
||
fprintf_filtered (file, _("BFD cache debugging is %s.\n"), value);
|
||
}
|
||
|
||
/* The type of an object being looked up in gdb_bfd_cache. We use
|
||
htab's capability of storing one kind of object (BFD in this case)
|
||
and using a different sort of object for searching. */
|
||
|
||
struct gdb_bfd_cache_search
|
||
{
|
||
/* The filename. */
|
||
const char *filename;
|
||
/* The mtime. */
|
||
time_t mtime;
|
||
/* The file size (in bytes). */
|
||
off_t size;
|
||
/* The inode of the file. */
|
||
ino_t inode;
|
||
/* The device id of the file. */
|
||
dev_t device_id;
|
||
};
|
||
|
||
/* A hash function for BFDs. */
|
||
|
||
static hashval_t
|
||
hash_bfd (const void *b)
|
||
{
|
||
const bfd *abfd = (const struct bfd *) b;
|
||
|
||
/* It is simplest to just hash the filename. */
|
||
return htab_hash_string (bfd_get_filename (abfd));
|
||
}
|
||
|
||
/* An equality function for BFDs. Note that this expects the caller
|
||
to search using struct gdb_bfd_cache_search only, not BFDs. */
|
||
|
||
static int
|
||
eq_bfd (const void *a, const void *b)
|
||
{
|
||
const bfd *abfd = (const struct bfd *) a;
|
||
const struct gdb_bfd_cache_search *s
|
||
= (const struct gdb_bfd_cache_search *) b;
|
||
struct gdb_bfd_data *gdata = (struct gdb_bfd_data *) bfd_usrdata (abfd);
|
||
|
||
return (gdata->mtime == s->mtime
|
||
&& gdata->size == s->size
|
||
&& gdata->inode == s->inode
|
||
&& gdata->device_id == s->device_id
|
||
&& strcmp (bfd_get_filename (abfd), s->filename) == 0);
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
int
|
||
is_target_filename (const char *name)
|
||
{
|
||
return startswith (name, TARGET_SYSROOT_PREFIX);
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
int
|
||
gdb_bfd_has_target_filename (struct bfd *abfd)
|
||
{
|
||
return is_target_filename (bfd_get_filename (abfd));
|
||
}
|
||
|
||
|
||
/* Return the system error number corresponding to ERRNUM. */
|
||
|
||
static int
|
||
fileio_errno_to_host (int errnum)
|
||
{
|
||
switch (errnum)
|
||
{
|
||
case FILEIO_EPERM:
|
||
return EPERM;
|
||
case FILEIO_ENOENT:
|
||
return ENOENT;
|
||
case FILEIO_EINTR:
|
||
return EINTR;
|
||
case FILEIO_EIO:
|
||
return EIO;
|
||
case FILEIO_EBADF:
|
||
return EBADF;
|
||
case FILEIO_EACCES:
|
||
return EACCES;
|
||
case FILEIO_EFAULT:
|
||
return EFAULT;
|
||
case FILEIO_EBUSY:
|
||
return EBUSY;
|
||
case FILEIO_EEXIST:
|
||
return EEXIST;
|
||
case FILEIO_ENODEV:
|
||
return ENODEV;
|
||
case FILEIO_ENOTDIR:
|
||
return ENOTDIR;
|
||
case FILEIO_EISDIR:
|
||
return EISDIR;
|
||
case FILEIO_EINVAL:
|
||
return EINVAL;
|
||
case FILEIO_ENFILE:
|
||
return ENFILE;
|
||
case FILEIO_EMFILE:
|
||
return EMFILE;
|
||
case FILEIO_EFBIG:
|
||
return EFBIG;
|
||
case FILEIO_ENOSPC:
|
||
return ENOSPC;
|
||
case FILEIO_ESPIPE:
|
||
return ESPIPE;
|
||
case FILEIO_EROFS:
|
||
return EROFS;
|
||
case FILEIO_ENOSYS:
|
||
return ENOSYS;
|
||
case FILEIO_ENAMETOOLONG:
|
||
return ENAMETOOLONG;
|
||
}
|
||
return -1;
|
||
}
|
||
|
||
/* Wrapper for target_fileio_open suitable for passing as the
|
||
OPEN_FUNC argument to gdb_bfd_openr_iovec. The supplied
|
||
OPEN_CLOSURE is unused. */
|
||
|
||
static void *
|
||
gdb_bfd_iovec_fileio_open (struct bfd *abfd, void *inferior)
|
||
{
|
||
const char *filename = bfd_get_filename (abfd);
|
||
int fd, target_errno;
|
||
int *stream;
|
||
|
||
gdb_assert (is_target_filename (filename));
|
||
|
||
fd = target_fileio_open_warn_if_slow ((struct inferior *) inferior,
|
||
filename
|
||
+ strlen (TARGET_SYSROOT_PREFIX),
|
||
FILEIO_O_RDONLY, 0,
|
||
&target_errno);
|
||
if (fd == -1)
|
||
{
|
||
errno = fileio_errno_to_host (target_errno);
|
||
bfd_set_error (bfd_error_system_call);
|
||
return NULL;
|
||
}
|
||
|
||
stream = XCNEW (int);
|
||
*stream = fd;
|
||
return stream;
|
||
}
|
||
|
||
/* Wrapper for target_fileio_pread suitable for passing as the
|
||
PREAD_FUNC argument to gdb_bfd_openr_iovec. */
|
||
|
||
static file_ptr
|
||
gdb_bfd_iovec_fileio_pread (struct bfd *abfd, void *stream, void *buf,
|
||
file_ptr nbytes, file_ptr offset)
|
||
{
|
||
int fd = *(int *) stream;
|
||
int target_errno;
|
||
file_ptr pos, bytes;
|
||
|
||
pos = 0;
|
||
while (nbytes > pos)
|
||
{
|
||
QUIT;
|
||
|
||
bytes = target_fileio_pread (fd, (gdb_byte *) buf + pos,
|
||
nbytes - pos, offset + pos,
|
||
&target_errno);
|
||
if (bytes == 0)
|
||
/* Success, but no bytes, means end-of-file. */
|
||
break;
|
||
if (bytes == -1)
|
||
{
|
||
errno = fileio_errno_to_host (target_errno);
|
||
bfd_set_error (bfd_error_system_call);
|
||
return -1;
|
||
}
|
||
|
||
pos += bytes;
|
||
}
|
||
|
||
return pos;
|
||
}
|
||
|
||
/* Wrapper for target_fileio_close suitable for passing as the
|
||
CLOSE_FUNC argument to gdb_bfd_openr_iovec. */
|
||
|
||
static int
|
||
gdb_bfd_iovec_fileio_close (struct bfd *abfd, void *stream)
|
||
{
|
||
int fd = *(int *) stream;
|
||
int target_errno;
|
||
|
||
xfree (stream);
|
||
|
||
/* Ignore errors on close. These may happen with remote
|
||
targets if the connection has already been torn down. */
|
||
target_fileio_close (fd, &target_errno);
|
||
|
||
/* Zero means success. */
|
||
return 0;
|
||
}
|
||
|
||
/* Wrapper for target_fileio_fstat suitable for passing as the
|
||
STAT_FUNC argument to gdb_bfd_openr_iovec. */
|
||
|
||
static int
|
||
gdb_bfd_iovec_fileio_fstat (struct bfd *abfd, void *stream,
|
||
struct stat *sb)
|
||
{
|
||
int fd = *(int *) stream;
|
||
int target_errno;
|
||
int result;
|
||
|
||
result = target_fileio_fstat (fd, sb, &target_errno);
|
||
if (result == -1)
|
||
{
|
||
errno = fileio_errno_to_host (target_errno);
|
||
bfd_set_error (bfd_error_system_call);
|
||
}
|
||
|
||
return result;
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
gdb_bfd_ref_ptr
|
||
gdb_bfd_open (const char *name, const char *target, int fd)
|
||
{
|
||
hashval_t hash;
|
||
void **slot;
|
||
bfd *abfd;
|
||
struct gdb_bfd_cache_search search;
|
||
struct stat st;
|
||
|
||
if (is_target_filename (name))
|
||
{
|
||
if (!target_filesystem_is_local ())
|
||
{
|
||
gdb_assert (fd == -1);
|
||
|
||
return gdb_bfd_openr_iovec (name, target,
|
||
gdb_bfd_iovec_fileio_open,
|
||
current_inferior (),
|
||
gdb_bfd_iovec_fileio_pread,
|
||
gdb_bfd_iovec_fileio_close,
|
||
gdb_bfd_iovec_fileio_fstat);
|
||
}
|
||
|
||
name += strlen (TARGET_SYSROOT_PREFIX);
|
||
}
|
||
|
||
if (gdb_bfd_cache == NULL)
|
||
gdb_bfd_cache = htab_create_alloc (1, hash_bfd, eq_bfd, NULL,
|
||
xcalloc, xfree);
|
||
|
||
if (fd == -1)
|
||
{
|
||
fd = gdb_open_cloexec (name, O_RDONLY | O_BINARY, 0);
|
||
if (fd == -1)
|
||
{
|
||
bfd_set_error (bfd_error_system_call);
|
||
return NULL;
|
||
}
|
||
}
|
||
|
||
search.filename = name;
|
||
if (fstat (fd, &st) < 0)
|
||
{
|
||
/* Weird situation here. */
|
||
search.mtime = 0;
|
||
search.size = 0;
|
||
search.inode = 0;
|
||
search.device_id = 0;
|
||
}
|
||
else
|
||
{
|
||
search.mtime = st.st_mtime;
|
||
search.size = st.st_size;
|
||
search.inode = st.st_ino;
|
||
search.device_id = st.st_dev;
|
||
}
|
||
|
||
/* Note that this must compute the same result as hash_bfd. */
|
||
hash = htab_hash_string (name);
|
||
/* Note that we cannot use htab_find_slot_with_hash here, because
|
||
opening the BFD may fail; and this would violate hashtab
|
||
invariants. */
|
||
abfd = (struct bfd *) htab_find_with_hash (gdb_bfd_cache, &search, hash);
|
||
if (bfd_sharing && abfd != NULL)
|
||
{
|
||
if (debug_bfd_cache)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"Reusing cached bfd %s for %s\n",
|
||
host_address_to_string (abfd),
|
||
bfd_get_filename (abfd));
|
||
close (fd);
|
||
return gdb_bfd_ref_ptr::new_reference (abfd);
|
||
}
|
||
|
||
abfd = bfd_fopen (name, target, FOPEN_RB, fd);
|
||
if (abfd == NULL)
|
||
return NULL;
|
||
|
||
if (debug_bfd_cache)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"Creating new bfd %s for %s\n",
|
||
host_address_to_string (abfd),
|
||
bfd_get_filename (abfd));
|
||
|
||
if (bfd_sharing)
|
||
{
|
||
slot = htab_find_slot_with_hash (gdb_bfd_cache, &search, hash, INSERT);
|
||
gdb_assert (!*slot);
|
||
*slot = abfd;
|
||
}
|
||
|
||
return gdb_bfd_ref_ptr::new_reference (abfd);
|
||
}
|
||
|
||
/* A helper function that releases any section data attached to the
|
||
BFD. */
|
||
|
||
static void
|
||
free_one_bfd_section (bfd *abfd, asection *sectp, void *ignore)
|
||
{
|
||
struct gdb_bfd_section_data *sect
|
||
= (struct gdb_bfd_section_data *) bfd_section_userdata (sectp);
|
||
|
||
if (sect != NULL && sect->data != NULL)
|
||
{
|
||
#ifdef HAVE_MMAP
|
||
if (sect->map_addr != NULL)
|
||
{
|
||
int res;
|
||
|
||
res = munmap (sect->map_addr, sect->map_len);
|
||
gdb_assert (res == 0);
|
||
}
|
||
else
|
||
#endif
|
||
xfree (sect->data);
|
||
}
|
||
}
|
||
|
||
/* Close ABFD, and warn if that fails. */
|
||
|
||
static int
|
||
gdb_bfd_close_or_warn (struct bfd *abfd)
|
||
{
|
||
int ret;
|
||
const char *name = bfd_get_filename (abfd);
|
||
|
||
bfd_map_over_sections (abfd, free_one_bfd_section, NULL);
|
||
|
||
ret = bfd_close (abfd);
|
||
|
||
if (!ret)
|
||
warning (_("cannot close \"%s\": %s"),
|
||
name, bfd_errmsg (bfd_get_error ()));
|
||
|
||
return ret;
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
void
|
||
gdb_bfd_ref (struct bfd *abfd)
|
||
{
|
||
struct gdb_bfd_data *gdata;
|
||
void **slot;
|
||
|
||
if (abfd == NULL)
|
||
return;
|
||
|
||
gdata = (struct gdb_bfd_data *) bfd_usrdata (abfd);
|
||
|
||
if (debug_bfd_cache)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"Increase reference count on bfd %s (%s)\n",
|
||
host_address_to_string (abfd),
|
||
bfd_get_filename (abfd));
|
||
|
||
if (gdata != NULL)
|
||
{
|
||
gdata->refc += 1;
|
||
return;
|
||
}
|
||
|
||
/* Ask BFD to decompress sections in bfd_get_full_section_contents. */
|
||
abfd->flags |= BFD_DECOMPRESS;
|
||
|
||
gdata = new gdb_bfd_data (abfd);
|
||
bfd_set_usrdata (abfd, gdata);
|
||
bfd_alloc_data (abfd);
|
||
|
||
/* This is the first we've seen it, so add it to the hash table. */
|
||
slot = htab_find_slot (all_bfds, abfd, INSERT);
|
||
gdb_assert (slot && !*slot);
|
||
*slot = abfd;
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
void
|
||
gdb_bfd_unref (struct bfd *abfd)
|
||
{
|
||
struct gdb_bfd_data *gdata;
|
||
struct gdb_bfd_cache_search search;
|
||
bfd *archive_bfd;
|
||
|
||
if (abfd == NULL)
|
||
return;
|
||
|
||
gdata = (struct gdb_bfd_data *) bfd_usrdata (abfd);
|
||
gdb_assert (gdata->refc >= 1);
|
||
|
||
gdata->refc -= 1;
|
||
if (gdata->refc > 0)
|
||
{
|
||
if (debug_bfd_cache)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"Decrease reference count on bfd %s (%s)\n",
|
||
host_address_to_string (abfd),
|
||
bfd_get_filename (abfd));
|
||
return;
|
||
}
|
||
|
||
if (debug_bfd_cache)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"Delete final reference count on bfd %s (%s)\n",
|
||
host_address_to_string (abfd),
|
||
bfd_get_filename (abfd));
|
||
|
||
archive_bfd = gdata->archive_bfd;
|
||
search.filename = bfd_get_filename (abfd);
|
||
|
||
if (gdb_bfd_cache && search.filename)
|
||
{
|
||
hashval_t hash = htab_hash_string (search.filename);
|
||
void **slot;
|
||
|
||
search.mtime = gdata->mtime;
|
||
search.size = gdata->size;
|
||
search.inode = gdata->inode;
|
||
search.device_id = gdata->device_id;
|
||
slot = htab_find_slot_with_hash (gdb_bfd_cache, &search, hash,
|
||
NO_INSERT);
|
||
|
||
if (slot && *slot)
|
||
htab_clear_slot (gdb_bfd_cache, slot);
|
||
}
|
||
|
||
bfd_free_data (abfd);
|
||
delete gdata;
|
||
bfd_set_usrdata (abfd, NULL); /* Paranoia. */
|
||
|
||
htab_remove_elt (all_bfds, abfd);
|
||
|
||
gdb_bfd_close_or_warn (abfd);
|
||
|
||
gdb_bfd_unref (archive_bfd);
|
||
}
|
||
|
||
/* A helper function that returns the section data descriptor
|
||
associated with SECTION. If no such descriptor exists, a new one
|
||
is allocated and cleared. */
|
||
|
||
static struct gdb_bfd_section_data *
|
||
get_section_descriptor (asection *section)
|
||
{
|
||
struct gdb_bfd_section_data *result;
|
||
|
||
result = (struct gdb_bfd_section_data *) bfd_section_userdata (section);
|
||
|
||
if (result == NULL)
|
||
{
|
||
result = ((struct gdb_bfd_section_data *)
|
||
bfd_zalloc (section->owner, sizeof (*result)));
|
||
bfd_set_section_userdata (section, result);
|
||
}
|
||
|
||
return result;
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
const gdb_byte *
|
||
gdb_bfd_map_section (asection *sectp, bfd_size_type *size)
|
||
{
|
||
bfd *abfd;
|
||
struct gdb_bfd_section_data *descriptor;
|
||
bfd_byte *data;
|
||
|
||
gdb_assert ((sectp->flags & SEC_RELOC) == 0);
|
||
gdb_assert (size != NULL);
|
||
|
||
abfd = sectp->owner;
|
||
|
||
descriptor = get_section_descriptor (sectp);
|
||
|
||
/* If the data was already read for this BFD, just reuse it. */
|
||
if (descriptor->data != NULL)
|
||
goto done;
|
||
|
||
#ifdef HAVE_MMAP
|
||
if (!bfd_is_section_compressed (abfd, sectp))
|
||
{
|
||
/* The page size, used when mmapping. */
|
||
static int pagesize;
|
||
|
||
if (pagesize == 0)
|
||
pagesize = getpagesize ();
|
||
|
||
/* Only try to mmap sections which are large enough: we don't want
|
||
to waste space due to fragmentation. */
|
||
|
||
if (bfd_section_size (sectp) > 4 * pagesize)
|
||
{
|
||
descriptor->size = bfd_section_size (sectp);
|
||
descriptor->data = bfd_mmap (abfd, 0, descriptor->size, PROT_READ,
|
||
MAP_PRIVATE, sectp->filepos,
|
||
&descriptor->map_addr,
|
||
&descriptor->map_len);
|
||
|
||
if ((caddr_t)descriptor->data != MAP_FAILED)
|
||
{
|
||
#if HAVE_POSIX_MADVISE
|
||
posix_madvise (descriptor->map_addr, descriptor->map_len,
|
||
POSIX_MADV_WILLNEED);
|
||
#endif
|
||
goto done;
|
||
}
|
||
|
||
/* On failure, clear out the section data and try again. */
|
||
memset (descriptor, 0, sizeof (*descriptor));
|
||
}
|
||
}
|
||
#endif /* HAVE_MMAP */
|
||
|
||
/* Handle compressed sections, or ordinary uncompressed sections in
|
||
the no-mmap case. */
|
||
|
||
descriptor->size = bfd_section_size (sectp);
|
||
descriptor->data = NULL;
|
||
|
||
data = NULL;
|
||
if (!bfd_get_full_section_contents (abfd, sectp, &data))
|
||
{
|
||
warning (_("Can't read data for section '%s' in file '%s'"),
|
||
bfd_section_name (sectp),
|
||
bfd_get_filename (abfd));
|
||
/* Set size to 0 to prevent further attempts to read the invalid
|
||
section. */
|
||
*size = 0;
|
||
return NULL;
|
||
}
|
||
descriptor->data = data;
|
||
|
||
done:
|
||
gdb_assert (descriptor->data != NULL);
|
||
*size = descriptor->size;
|
||
return (const gdb_byte *) descriptor->data;
|
||
}
|
||
|
||
/* Return 32-bit CRC for ABFD. If successful store it to *FILE_CRC_RETURN and
|
||
return 1. Otherwise print a warning and return 0. ABFD seek position is
|
||
not preserved. */
|
||
|
||
static int
|
||
get_file_crc (bfd *abfd, unsigned long *file_crc_return)
|
||
{
|
||
unsigned long file_crc = 0;
|
||
|
||
if (bfd_seek (abfd, 0, SEEK_SET) != 0)
|
||
{
|
||
warning (_("Problem reading \"%s\" for CRC: %s"),
|
||
bfd_get_filename (abfd), bfd_errmsg (bfd_get_error ()));
|
||
return 0;
|
||
}
|
||
|
||
for (;;)
|
||
{
|
||
gdb_byte buffer[8 * 1024];
|
||
bfd_size_type count;
|
||
|
||
count = bfd_bread (buffer, sizeof (buffer), abfd);
|
||
if (count == (bfd_size_type) -1)
|
||
{
|
||
warning (_("Problem reading \"%s\" for CRC: %s"),
|
||
bfd_get_filename (abfd), bfd_errmsg (bfd_get_error ()));
|
||
return 0;
|
||
}
|
||
if (count == 0)
|
||
break;
|
||
file_crc = bfd_calc_gnu_debuglink_crc32 (file_crc, buffer, count);
|
||
}
|
||
|
||
*file_crc_return = file_crc;
|
||
return 1;
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
int
|
||
gdb_bfd_crc (struct bfd *abfd, unsigned long *crc_out)
|
||
{
|
||
struct gdb_bfd_data *gdata = (struct gdb_bfd_data *) bfd_usrdata (abfd);
|
||
|
||
if (!gdata->crc_computed)
|
||
gdata->crc_computed = get_file_crc (abfd, &gdata->crc);
|
||
|
||
if (gdata->crc_computed)
|
||
*crc_out = gdata->crc;
|
||
return gdata->crc_computed;
|
||
}
|
||
|
||
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
gdb_bfd_ref_ptr
|
||
gdb_bfd_fopen (const char *filename, const char *target, const char *mode,
|
||
int fd)
|
||
{
|
||
bfd *result = bfd_fopen (filename, target, mode, fd);
|
||
|
||
return gdb_bfd_ref_ptr::new_reference (result);
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
gdb_bfd_ref_ptr
|
||
gdb_bfd_openr (const char *filename, const char *target)
|
||
{
|
||
bfd *result = bfd_openr (filename, target);
|
||
|
||
return gdb_bfd_ref_ptr::new_reference (result);
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
gdb_bfd_ref_ptr
|
||
gdb_bfd_openw (const char *filename, const char *target)
|
||
{
|
||
bfd *result = bfd_openw (filename, target);
|
||
|
||
return gdb_bfd_ref_ptr::new_reference (result);
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
gdb_bfd_ref_ptr
|
||
gdb_bfd_openr_iovec (const char *filename, const char *target,
|
||
void *(*open_func) (struct bfd *nbfd,
|
||
void *open_closure),
|
||
void *open_closure,
|
||
file_ptr (*pread_func) (struct bfd *nbfd,
|
||
void *stream,
|
||
void *buf,
|
||
file_ptr nbytes,
|
||
file_ptr offset),
|
||
int (*close_func) (struct bfd *nbfd,
|
||
void *stream),
|
||
int (*stat_func) (struct bfd *abfd,
|
||
void *stream,
|
||
struct stat *sb))
|
||
{
|
||
bfd *result = bfd_openr_iovec (filename, target,
|
||
open_func, open_closure,
|
||
pread_func, close_func, stat_func);
|
||
|
||
return gdb_bfd_ref_ptr::new_reference (result);
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
void
|
||
gdb_bfd_mark_parent (bfd *child, bfd *parent)
|
||
{
|
||
struct gdb_bfd_data *gdata;
|
||
|
||
gdb_bfd_ref (child);
|
||
/* No need to stash the filename here, because we also keep a
|
||
reference on the parent archive. */
|
||
|
||
gdata = (struct gdb_bfd_data *) bfd_usrdata (child);
|
||
if (gdata->archive_bfd == NULL)
|
||
{
|
||
gdata->archive_bfd = parent;
|
||
gdb_bfd_ref (parent);
|
||
}
|
||
else
|
||
gdb_assert (gdata->archive_bfd == parent);
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
gdb_bfd_ref_ptr
|
||
gdb_bfd_openr_next_archived_file (bfd *archive, bfd *previous)
|
||
{
|
||
bfd *result = bfd_openr_next_archived_file (archive, previous);
|
||
|
||
if (result)
|
||
gdb_bfd_mark_parent (result, archive);
|
||
|
||
return gdb_bfd_ref_ptr (result);
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
void
|
||
gdb_bfd_record_inclusion (bfd *includer, bfd *includee)
|
||
{
|
||
struct gdb_bfd_data *gdata;
|
||
|
||
gdata = (struct gdb_bfd_data *) bfd_usrdata (includer);
|
||
gdata->included_bfds.push_back (gdb_bfd_ref_ptr::new_reference (includee));
|
||
}
|
||
|
||
|
||
|
||
gdb_static_assert (ARRAY_SIZE (_bfd_std_section) == 4);
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
int
|
||
gdb_bfd_section_index (bfd *abfd, asection *section)
|
||
{
|
||
if (section == NULL)
|
||
return -1;
|
||
else if (section == bfd_com_section_ptr)
|
||
return bfd_count_sections (abfd);
|
||
else if (section == bfd_und_section_ptr)
|
||
return bfd_count_sections (abfd) + 1;
|
||
else if (section == bfd_abs_section_ptr)
|
||
return bfd_count_sections (abfd) + 2;
|
||
else if (section == bfd_ind_section_ptr)
|
||
return bfd_count_sections (abfd) + 3;
|
||
return section->index;
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
int
|
||
gdb_bfd_count_sections (bfd *abfd)
|
||
{
|
||
return bfd_count_sections (abfd) + 4;
|
||
}
|
||
|
||
/* See gdb_bfd.h. */
|
||
|
||
int
|
||
gdb_bfd_requires_relocations (bfd *abfd)
|
||
{
|
||
struct gdb_bfd_data *gdata = (struct gdb_bfd_data *) bfd_usrdata (abfd);
|
||
|
||
if (gdata->relocation_computed == 0)
|
||
{
|
||
asection *sect;
|
||
|
||
for (sect = abfd->sections; sect != NULL; sect = sect->next)
|
||
if ((sect->flags & SEC_RELOC) != 0)
|
||
{
|
||
gdata->needs_relocations = 1;
|
||
break;
|
||
}
|
||
|
||
gdata->relocation_computed = 1;
|
||
}
|
||
|
||
return gdata->needs_relocations;
|
||
}
|
||
|
||
|
||
|
||
/* A callback for htab_traverse that prints a single BFD. */
|
||
|
||
static int
|
||
print_one_bfd (void **slot, void *data)
|
||
{
|
||
bfd *abfd = (struct bfd *) *slot;
|
||
struct gdb_bfd_data *gdata = (struct gdb_bfd_data *) bfd_usrdata (abfd);
|
||
struct ui_out *uiout = (struct ui_out *) data;
|
||
|
||
ui_out_emit_tuple tuple_emitter (uiout, NULL);
|
||
uiout->field_signed ("refcount", gdata->refc);
|
||
uiout->field_string ("addr", host_address_to_string (abfd));
|
||
uiout->field_string ("filename", bfd_get_filename (abfd));
|
||
uiout->text ("\n");
|
||
|
||
return 1;
|
||
}
|
||
|
||
/* Implement the 'maint info bfd' command. */
|
||
|
||
static void
|
||
maintenance_info_bfds (const char *arg, int from_tty)
|
||
{
|
||
struct ui_out *uiout = current_uiout;
|
||
|
||
ui_out_emit_table table_emitter (uiout, 3, -1, "bfds");
|
||
uiout->table_header (10, ui_left, "refcount", "Refcount");
|
||
uiout->table_header (18, ui_left, "addr", "Address");
|
||
uiout->table_header (40, ui_left, "filename", "Filename");
|
||
|
||
uiout->table_body ();
|
||
htab_traverse (all_bfds, print_one_bfd, uiout);
|
||
}
|
||
|
||
void _initialize_gdb_bfd ();
|
||
void
|
||
_initialize_gdb_bfd ()
|
||
{
|
||
all_bfds = htab_create_alloc (10, htab_hash_pointer, htab_eq_pointer,
|
||
NULL, xcalloc, xfree);
|
||
|
||
add_cmd ("bfds", class_maintenance, maintenance_info_bfds, _("\
|
||
List the BFDs that are currently open."),
|
||
&maintenanceinfolist);
|
||
|
||
add_setshow_boolean_cmd ("bfd-sharing", no_class,
|
||
&bfd_sharing, _("\
|
||
Set whether gdb will share bfds that appear to be the same file."), _("\
|
||
Show whether gdb will share bfds that appear to be the same file."), _("\
|
||
When enabled gdb will reuse existing bfds rather than reopening the\n\
|
||
same file. To decide if two files are the same then gdb compares the\n\
|
||
filename, file size, file modification time, and file inode."),
|
||
NULL,
|
||
&show_bfd_sharing,
|
||
&maintenance_set_cmdlist,
|
||
&maintenance_show_cmdlist);
|
||
|
||
add_setshow_zuinteger_cmd ("bfd-cache", class_maintenance,
|
||
&debug_bfd_cache, _("\
|
||
Set bfd cache debugging."), _("\
|
||
Show bfd cache debugging."), _("\
|
||
When non-zero, bfd cache specific debugging is enabled."),
|
||
NULL,
|
||
&show_bfd_cache_debug,
|
||
&setdebuglist, &showdebuglist);
|
||
}
|