binutils-gdb/gdb/mi
Pedro Alves 8061491427 Fix PR mi/20431 - Missing MI prompts after sync execution MI command (-exec-continue, etc.) errors
gdb 7.11 introduced an MI regression: a failing MI sync execution
command misses printing the MI prompt, and then all subsequent command
miss it too:

 $ gdb-7.11.1 -i=mi
 [...]
 p 1
 &"p 1\n"
 ~"$1 = 1"
 ~"\n"
 ^done
 (gdb)                                        <<< prompted ok
 -exec-continue
 ^error,msg="The program is not being run."   <<< missing prompt after this
 print 1
 &"print 1\n"
 ~"$2 = 1"
 ~"\n"
 ^done                                        <<< missing prompt after this


gdb 7.10.1 behaved correctly, even with "set mi-async on":

 -exec-continue
 ^error,msg="The program is not being run."
 (gdb)                                        <<< prompted ok

etc.

Bisecting points at:

  commit 0b333c5e7d
  Author: Pedro Alves <palves@redhat.com>
  Date:   Wed Sep 9 18:23:23 2015 +0100

      Merge async and sync code paths some more
  [...]

The problem is that when an exception is thrown, we leave the prompt
state set to PROMPT_BLOCKED, and then mi_execute_command_input_handler
doesn't print the prompt.  It used to work because before that patch,
we happened to skip disabling stdin if the current target didn't do
async (which it never does before execution).

I was surprised to find that this bug isn't caught by the testsuite,
so I made a thorough test that tests all combinations of pairs of:

 - a failing synchronous execution command
 - a failing non-execution command
 - a non-failing command

gdb/ChangeLog:
2016-08-09  Pedro Alves  <palves@redhat.com>

	PR mi/20431
	* mi/mi-main.c (mi_execute_command): Enable input and set prompt
	state to PROMPT_NEEDED.

gdb/testsuite/ChangeLog:
2016-08-09  Pedro Alves  <palves@redhat.com>

	PR mi/20431
	* gdb.mi/mi-cmd-error.exp: New file.
2016-08-09 22:45:39 +01:00
..
ChangeLog-1999-2003
mi-cmd-break.c Enable/update legacy linespecs in MI. 2016-02-09 14:31:04 -08:00
mi-cmd-break.h GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-cmd-catch.c GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-cmd-disas.c GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-cmd-env.c GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-cmd-file.c GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-cmd-info.c GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-cmd-stack.c remove trivialy unused variables 2016-05-07 20:12:53 -04:00
mi-cmd-target.c GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-cmd-var.c varobj: Cleanup dead code 2016-02-07 09:45:02 -05:00
mi-cmds.c GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-cmds.h Make raw_stdout be per MI instance 2016-06-21 01:11:50 +01:00
mi-common.c GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-common.h Make raw_stdout be per MI instance 2016-06-21 01:11:50 +01:00
mi-console.c GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-console.h GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-getopt.c GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-getopt.h GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-interp.c Make stdin be per UI 2016-06-21 01:11:54 +01:00
mi-main.c Fix PR mi/20431 - Missing MI prompts after sync execution MI command (-exec-continue, etc.) errors 2016-08-09 22:45:39 +01:00
mi-main.h Make raw_stdout be per MI instance 2016-06-21 01:11:50 +01:00
mi-out.c GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-out.h GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-parse.c GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-parse.h GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00
mi-symbol-cmds.c GDB copyright headers update after running GDB's copyright.py script. 2016-01-01 08:43:22 +04:00