15763a09d4
The [wait -i $gdb_spawn_id] in the test is dangerous in the sense that it won't be subject to timeout logic. So if GDB fails quiting, this testcase hangs forever, hanging the test run with it. See: https://sourceware.org/ml/gdb-patches/2016-10/msg00728.html Instead of 'wait'ing directly, use gdb_test_multiple and expect 'eof'. Tested that the testcase no longer hangs by hacking the test to send "info threads" instead of "quit". Tested with --target_board={unix, native-gdbserver,native-extended-gdbserver} and tested with --host_board=local-remote-host as well. gdb/testsuite/ChangeLog: 2017-10-20 Pedro Alves <palves@redhat.com> * gdb.base/quit.exp: Use gdb_test_multiple and expect 'eof' before 'wait -i'. Use gdb_assert and remote_close.
38 lines
1.2 KiB
Plaintext
38 lines
1.2 KiB
Plaintext
# Copyright (C) 2016-2017 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Check the "quit" command.
|
|
|
|
clean_restart
|
|
|
|
# Test that a syntax error causes quit to abort.
|
|
# Regression test for PR gdb/20604.
|
|
gdb_test "quit()" "A syntax error in expression, near .*" \
|
|
"quit with syntax error"
|
|
|
|
# Test that an expression can be used to set the error code.
|
|
|
|
set test "quit with expression"
|
|
gdb_test_multiple "quit 22+1" $test {
|
|
eof {
|
|
set result [wait -i $gdb_spawn_id]
|
|
verbose $result
|
|
gdb_assert {[lindex $result 2] == 0 && [lindex $result 3] == 23} $test
|
|
|
|
remote_close host
|
|
clear_gdb_spawn_id
|
|
}
|
|
}
|