76727919ce
This converts observers from using a special source-generating script to be plain C++. This version of the patch takes advantage of C++11 by using std::function and variadic templates; incorporates Pedro's patches; and renames the header file to "observable.h" (this change eliminates the need for a clean rebuild). Note that Pedro's patches used a template lambda in tui-hooks.c, but this failed to compile on some buildbot instances (presumably due to differing C++ versions); I replaced this with an ordinary template function. Regression tested on the buildbot. gdb/ChangeLog 2018-03-19 Pedro Alves <palves@redhat.com> Tom Tromey <tom@tromey.com> * unittests/observable-selftests.c: New file. * common/observable.h: New file. * observable.h: New file. * ada-lang.c, ada-tasks.c, agent.c, aix-thread.c, annotate.c, arm-tdep.c, auto-load.c, auxv.c, break-catch-syscall.c, breakpoint.c, bsd-uthread.c, cli/cli-interp.c, cli/cli-setshow.c, corefile.c, dummy-frame.c, event-loop.c, event-top.c, exec.c, extension.c, frame.c, gdbarch.c, guile/scm-breakpoint.c, infcall.c, infcmd.c, inferior.c, inflow.c, infrun.c, jit.c, linux-tdep.c, linux-thread-db.c, m68klinux-tdep.c, mi/mi-cmd-break.c, mi/mi-interp.c, mi/mi-main.c, objfiles.c, ppc-linux-nat.c, ppc-linux-tdep.c, printcmd.c, procfs.c, python/py-breakpoint.c, python/py-finishbreakpoint.c, python/py-inferior.c, python/py-unwind.c, ravenscar-thread.c, record-btrace.c, record-full.c, record.c, regcache.c, remote.c, riscv-tdep.c, sol-thread.c, solib-aix.c, solib-spu.c, solib.c, spu-multiarch.c, spu-tdep.c, stack.c, symfile-mem.c, symfile.c, symtab.c, thread.c, top.c, tracepoint.c, tui/tui-hooks.c, tui/tui-interp.c, valops.c: Update all users. * tui/tui-hooks.c (tui_bp_created_observer) (tui_bp_deleted_observer, tui_bp_modified_observer) (tui_inferior_exit_observer, tui_before_prompt_observer) (tui_normal_stop_observer, tui_register_changed_observer): Remove. (tui_observers_token): New global. (attach_or_detach, tui_attach_detach_observers): New functions. (tui_install_hooks, tui_remove_hooks): Use tui_attach_detach_observers. * record-btrace.c (record_btrace_thread_observer): Remove. (record_btrace_thread_observer_token): New global. * observer.sh: Remove. * observer.c: Rename to observable.c. * observable.c (namespace gdb_observers): Define new objects. (observer_debug): Move into gdb_observers namespace. (struct observer, struct observer_list, xalloc_observer_list_node) (xfree_observer_list_node, generic_observer_attach) (generic_observer_detach, generic_observer_notify): Remove. (_initialize_observer): Update. Don't include observer.inc. * Makefile.in (generated_files): Remove observer.h, observer.inc. (clean mostlyclean): Likewise. (observer.h, observer.inc): Remove targets. (SUBDIR_UNITTESTS_SRCS): Add observable-selftests.c. (COMMON_SFILES): Use observable.c, not observer.c. * .gitignore: Remove observer.h. gdb/doc/ChangeLog 2018-03-19 Tom Tromey <tom@tromey.com> * observer.texi: Remove. gdb/testsuite/ChangeLog 2018-03-19 Tom Tromey <tom@tromey.com> * gdb.gdb/observer.exp: Remove.
224 lines
7.3 KiB
C
224 lines
7.3 KiB
C
/* Reading symbol files from memory.
|
|
|
|
Copyright (C) 1986-2018 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
/* This file defines functions (and commands to exercise those
|
|
functions) for reading debugging information from object files
|
|
whose images are mapped directly into the inferior's memory. For
|
|
example, the Linux kernel maps a "syscall DSO" into each process's
|
|
address space; this DSO provides kernel-specific code for some
|
|
system calls.
|
|
|
|
At the moment, BFD only has functions for parsing object files from
|
|
memory for the ELF format, even though the general idea isn't
|
|
ELF-specific. This means that BFD only provides the functions GDB
|
|
needs when configured for ELF-based targets. So these functions
|
|
may only be compiled on ELF-based targets.
|
|
|
|
GDB has no idea whether it has been configured for an ELF-based
|
|
target or not: it just tries to handle whatever files it is given.
|
|
But this means there are no preprocessor symbols on which we could
|
|
make these functions' compilation conditional.
|
|
|
|
So, for the time being, we put these functions alone in this file,
|
|
and have .mt files reference them as appropriate. In the future, I
|
|
hope BFD will provide a format-independent bfd_from_remote_memory
|
|
entry point. */
|
|
|
|
|
|
#include "defs.h"
|
|
#include "symtab.h"
|
|
#include "gdbcore.h"
|
|
#include "objfiles.h"
|
|
#include "gdbcmd.h"
|
|
#include "target.h"
|
|
#include "value.h"
|
|
#include "symfile.h"
|
|
#include "observable.h"
|
|
#include "auxv.h"
|
|
#include "elf/common.h"
|
|
#include "gdb_bfd.h"
|
|
|
|
/* Verify parameters of target_read_memory_bfd and target_read_memory are
|
|
compatible. */
|
|
|
|
gdb_static_assert (sizeof (CORE_ADDR) == sizeof (bfd_vma));
|
|
gdb_static_assert (sizeof (gdb_byte) == sizeof (bfd_byte));
|
|
gdb_static_assert (sizeof (ssize_t) <= sizeof (bfd_size_type));
|
|
|
|
/* Provide bfd/ compatible prototype for target_read_memory. Casting would not
|
|
be enough as LEN width may differ. */
|
|
|
|
static int
|
|
target_read_memory_bfd (bfd_vma memaddr, bfd_byte *myaddr, bfd_size_type len)
|
|
{
|
|
/* MYADDR must be already allocated for the LEN size so it has to fit in
|
|
ssize_t. */
|
|
gdb_assert ((ssize_t) len == len);
|
|
|
|
return target_read_memory (memaddr, myaddr, len);
|
|
}
|
|
|
|
/* Read inferior memory at ADDR to find the header of a loaded object file
|
|
and read its in-core symbols out of inferior memory. SIZE, if
|
|
non-zero, is the known size of the object. TEMPL is a bfd
|
|
representing the target's format. NAME is the name to use for this
|
|
symbol file in messages; it can be NULL or a malloc-allocated string
|
|
which will be attached to the BFD. */
|
|
static struct objfile *
|
|
symbol_file_add_from_memory (struct bfd *templ, CORE_ADDR addr,
|
|
size_t size, char *name, int from_tty)
|
|
{
|
|
struct objfile *objf;
|
|
struct bfd *nbfd;
|
|
struct bfd_section *sec;
|
|
bfd_vma loadbase;
|
|
symfile_add_flags add_flags = 0;
|
|
|
|
if (bfd_get_flavour (templ) != bfd_target_elf_flavour)
|
|
error (_("add-symbol-file-from-memory not supported for this target"));
|
|
|
|
nbfd = bfd_elf_bfd_from_remote_memory (templ, addr, size, &loadbase,
|
|
target_read_memory_bfd);
|
|
if (nbfd == NULL)
|
|
error (_("Failed to read a valid object file image from memory."));
|
|
|
|
/* Manage the new reference for the duration of this function. */
|
|
gdb_bfd_ref_ptr nbfd_holder = new_bfd_ref (nbfd);
|
|
|
|
xfree (bfd_get_filename (nbfd));
|
|
if (name == NULL)
|
|
nbfd->filename = xstrdup ("shared object read from target memory");
|
|
else
|
|
nbfd->filename = name;
|
|
|
|
if (!bfd_check_format (nbfd, bfd_object))
|
|
error (_("Got object file from memory but can't read symbols: %s."),
|
|
bfd_errmsg (bfd_get_error ()));
|
|
|
|
section_addr_info sai;
|
|
for (sec = nbfd->sections; sec != NULL; sec = sec->next)
|
|
if ((bfd_get_section_flags (nbfd, sec) & (SEC_ALLOC|SEC_LOAD)) != 0)
|
|
sai.emplace_back (bfd_get_section_vma (nbfd, sec) + loadbase,
|
|
bfd_get_section_name (nbfd, sec),
|
|
sec->index);
|
|
|
|
if (from_tty)
|
|
add_flags |= SYMFILE_VERBOSE;
|
|
|
|
objf = symbol_file_add_from_bfd (nbfd, bfd_get_filename (nbfd),
|
|
add_flags, &sai, OBJF_SHARED, NULL);
|
|
|
|
add_target_sections_of_objfile (objf);
|
|
|
|
/* This might change our ideas about frames already looked at. */
|
|
reinit_frame_cache ();
|
|
|
|
return objf;
|
|
}
|
|
|
|
|
|
static void
|
|
add_symbol_file_from_memory_command (const char *args, int from_tty)
|
|
{
|
|
CORE_ADDR addr;
|
|
struct bfd *templ;
|
|
|
|
if (args == NULL)
|
|
error (_("add-symbol-file-from-memory requires an expression argument"));
|
|
|
|
addr = parse_and_eval_address (args);
|
|
|
|
/* We need some representative bfd to know the target we are looking at. */
|
|
if (symfile_objfile != NULL)
|
|
templ = symfile_objfile->obfd;
|
|
else
|
|
templ = exec_bfd;
|
|
if (templ == NULL)
|
|
error (_("Must use symbol-file or exec-file "
|
|
"before add-symbol-file-from-memory."));
|
|
|
|
symbol_file_add_from_memory (templ, addr, 0, NULL, from_tty);
|
|
}
|
|
|
|
/* Try to add the symbols for the vsyscall page, if there is one.
|
|
This function is called via the inferior_created observer. */
|
|
|
|
static void
|
|
add_vsyscall_page (struct target_ops *target, int from_tty)
|
|
{
|
|
struct mem_range vsyscall_range;
|
|
|
|
if (gdbarch_vsyscall_range (target_gdbarch (), &vsyscall_range))
|
|
{
|
|
struct bfd *bfd;
|
|
|
|
if (core_bfd != NULL)
|
|
bfd = core_bfd;
|
|
else if (exec_bfd != NULL)
|
|
bfd = exec_bfd;
|
|
else
|
|
/* FIXME: cagney/2004-05-06: Should not require an existing
|
|
BFD when trying to create a run-time BFD of the VSYSCALL
|
|
page in the inferior. Unfortunately that's the current
|
|
interface so for the moment bail. Introducing a
|
|
``bfd_runtime'' (a BFD created using the loaded image) file
|
|
format should fix this. */
|
|
{
|
|
warning (_("Could not load vsyscall page "
|
|
"because no executable was specified"));
|
|
return;
|
|
}
|
|
|
|
char *name = xstrprintf ("system-supplied DSO at %s",
|
|
paddress (target_gdbarch (), vsyscall_range.start));
|
|
TRY
|
|
{
|
|
/* Pass zero for FROM_TTY, because the action of loading the
|
|
vsyscall DSO was not triggered by the user, even if the
|
|
user typed "run" at the TTY. */
|
|
symbol_file_add_from_memory (bfd,
|
|
vsyscall_range.start,
|
|
vsyscall_range.length,
|
|
name,
|
|
0 /* from_tty */);
|
|
}
|
|
CATCH (ex, RETURN_MASK_ALL)
|
|
{
|
|
exception_print (gdb_stderr, ex);
|
|
}
|
|
END_CATCH
|
|
}
|
|
}
|
|
|
|
void
|
|
_initialize_symfile_mem (void)
|
|
{
|
|
add_cmd ("add-symbol-file-from-memory", class_files,
|
|
add_symbol_file_from_memory_command,
|
|
_("Load the symbols out of memory from a "
|
|
"dynamically loaded object file.\n"
|
|
"Give an expression for the address "
|
|
"of the file's shared object file header."),
|
|
&cmdlist);
|
|
|
|
/* Want to know of each new inferior so that its vsyscall info can
|
|
be extracted. */
|
|
gdb::observers::inferior_created.attach (add_vsyscall_page);
|
|
}
|