binutils-gdb/gdb/bfd-target.c
Tom Tromey ade72a3453 Use gdb_bfd_ref_ptr in target_bfd
I noticed that target_bfd was using manual reference counting for the
BFD it held.  This patch changes it to use gdb_bfd_ref_ptr instead.

Tested by the buildbot.

ChangeLog
2018-05-04  Tom Tromey  <tom@tromey.com>

	* bfd-target.c (target_bfd::m_bfd): Now a gdb_bfd_ref_ptr.
	(target_bfd::target_bfd, target_bfd::~target_bfd): Update.
2018-05-04 12:10:43 -06:00

117 lines
2.8 KiB
C

/* Very simple "bfd" target, for GDB, the GNU debugger.
Copyright (C) 2003-2018 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "target.h"
#include "bfd-target.h"
#include "exec.h"
#include "gdb_bfd.h"
/* A target that wraps a BFD. */
static const target_info target_bfd_target_info = {
"bfd",
N_("BFD backed target"),
N_("You should never see this")
};
class target_bfd : public target_ops
{
public:
explicit target_bfd (struct bfd *bfd);
~target_bfd () override;
const target_info &info () const override
{ return target_bfd_target_info; }
void close () override;
target_xfer_status
xfer_partial (target_object object,
const char *annex, gdb_byte *readbuf,
const gdb_byte *writebuf,
ULONGEST offset, ULONGEST len,
ULONGEST *xfered_len) override;
target_section_table *get_section_table () override;
private:
/* The BFD we're wrapping. */
gdb_bfd_ref_ptr m_bfd;
/* The section table build from the ALLOC sections in BFD. Note
that we can't rely on extracting the BFD from a random section in
the table, since the table can be legitimately empty. */
struct target_section_table m_table;
};
target_xfer_status
target_bfd::xfer_partial (target_object object,
const char *annex, gdb_byte *readbuf,
const gdb_byte *writebuf,
ULONGEST offset, ULONGEST len,
ULONGEST *xfered_len)
{
switch (object)
{
case TARGET_OBJECT_MEMORY:
{
return section_table_xfer_memory_partial (readbuf, writebuf,
offset, len, xfered_len,
m_table.sections,
m_table.sections_end,
NULL);
}
default:
return TARGET_XFER_E_IO;
}
}
target_section_table *
target_bfd::get_section_table ()
{
return &m_table;
}
target_bfd::target_bfd (struct bfd *abfd)
: m_bfd (gdb_bfd_ref_ptr::new_reference (abfd))
{
this->to_stratum = file_stratum;
m_table.sections = NULL;
m_table.sections_end = NULL;
build_section_table (abfd, &m_table.sections, &m_table.sections_end);
}
target_bfd::~target_bfd ()
{
xfree (m_table.sections);
}
target_ops *
target_bfd_reopen (struct bfd *abfd)
{
return new target_bfd (abfd);
}
void
target_bfd::close ()
{
delete this;
}