binutils-gdb/gdb/common/filestuff.c
Pedro Alves 8658d16d9d common/filestuff.c: No sockets on DJGPP.
Building gdb with --host=i586-pc-msdosdjgpp ends up with:

 i586-pc-msdosdjgpp-gcc -g -O2 -I../../src/gdb/config/djgpp  -I. -I../../src/gdb -I../../src/gdb/common -I../../src/gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../src/gdb/../include/opcode -I../../src/gdb/../opcodes/.. -I../../src/gdb/../readline/.. -I../bfd -I../../src/gdb/../bfd -I../../src/gdb/../include -I../libdecnumber -I../../src/gdb/../libdecnumber -I./../intl -I../../src/gdb/gnulib/import -Ibuild-gnulib/import    -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Werror -c -o filestuff.o -MT filestuff.o -MMD -MP -MF .deps/filestuff.Tpo ../../src/gdb/common/filestuff.c
 ../../src/gdb/common/filestuff.c:38:24: fatal error: sys/socket.h: No such file or directory

There are no sockets on djgpp.  This #ifdef's out the bits in the file
that use sockets, depending on whether winsock or sys/socket.h is
available.

As alternative approach, given ser-tcp.c, ser-pipe.c, etc. are split
into separate files, and which to use is selected by configure.ac:

 dnl Figure out which of the many generic ser-*.c files the _host_ supports.
 SER_HARDWIRE="ser-base.o ser-unix.o ser-pipe.o ser-tcp.o"
 case ${host} in
  *go32* ) SER_HARDWIRE=ser-go32.o ;;
  *djgpp* ) SER_HARDWIRE=ser-go32.o ;;
  *mingw32*) SER_HARDWIRE="ser-base.o ser-tcp.o ser-mingw.o" ;;
 esac
 AC_SUBST(SER_HARDWIRE)

... I considered splitting filestuff.c similarly.  But I quickly gave
up on the idea, as it looked like a lot more complication over this
approach, for no real gain.  Plus, there are uses of these functions
outside the ser*.c framework.

gdbserver's configure.ac is already checking for sys/socket.h.

gdb/
2013-05-23  Pedro Alves  <palves@redhat.com>

	* common/filestuff.c [USE_WIN32API]: Define HAVE_SOCKETS.
	[HAVE_SYS_SOCKET_H]: Define HAVE_SOCKETS.
	(socket_mark_cloexec, gdb_socketpair_cloexec, gdb_socket_cloexec):
	Only define if HAVE_SOCKETS is defined.
	* configure.ac: Check for sys/socket.h.
	* config.in, configure: Regenerate.
2013-05-23 18:37:00 +00:00

408 lines
7.8 KiB
C
Raw Blame History

This file contains invisible Unicode characters

This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

/* Low-level file-handling.
Copyright (C) 2012, 2013 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#ifdef GDBSERVER
#include "server.h"
#else
#include "defs.h"
#include "gdb_string.h"
#endif
#include "filestuff.h"
#include "gdb_vecs.h"
#include <string.h>
#include <fcntl.h>
#include <unistd.h>
#include <sys/types.h>
#include "gdb_stat.h"
#ifdef USE_WIN32API
#include <winsock2.h>
#include <windows.h>
#define HAVE_SOCKETS 1
#elif defined HAVE_SYS_SOCKET_H
#include <sys/socket.h>
/* Define HAVE_F_GETFD if we plan to use F_GETFD. */
#define HAVE_F_GETFD F_GETFD
#define HAVE_SOCKETS 1
#endif
#ifdef HAVE_SYS_RESOURCE_H
#include <sys/resource.h>
#endif /* HAVE_SYS_RESOURCE_H */
#ifndef O_CLOEXEC
#define O_CLOEXEC 0
#endif
#ifndef SOCK_CLOEXEC
#define SOCK_CLOEXEC 0
#endif
#ifndef HAVE_FDWALK
#include "gdb_dirent.h"
/* Replacement for fdwalk, if the system doesn't define it. Walks all
open file descriptors (though this implementation may walk closed
ones as well, depending on the host platform's capabilities) and
call FUNC with ARG. If FUNC returns non-zero, stops immediately
and returns the same value. Otherwise, returns zero when
finished. */
static int
fdwalk (int (*func) (void *, int), void *arg)
{
/* Checking __linux__ isn't great but it isn't clear what would be
better. There doesn't seem to be a good way to check for this in
configure. */
#ifdef __linux__
DIR *dir;
dir = opendir ("/proc/self/fd");
if (dir != NULL)
{
struct dirent *entry;
int result = 0;
for (entry = readdir (dir); entry != NULL; entry = readdir (dir))
{
long fd;
char *tail;
int result;
errno = 0;
fd = strtol (entry->d_name, &tail, 10);
if (*tail != '\0' || errno != 0)
continue;
if ((int) fd != fd)
{
/* What can we do here really? */
continue;
}
if (fd == dirfd (dir))
continue;
result = func (arg, fd);
if (result != 0)
break;
}
closedir (dir);
return result;
}
/* We may fall through to the next case. */
#endif
{
int max, fd;
#ifdef HAVE_GETRLIMIT
struct rlimit rlim;
if (getrlimit (RLIMIT_NOFILE, &rlim) == 0 && rlim.rlim_max != RLIM_INFINITY)
max = rlim.rlim_max;
else
#endif
{
#ifdef _SC_OPEN_MAX
max = sysconf (_SC_OPEN_MAX);
#else
/* Whoops. */
return 0;
#endif /* _SC_OPEN_MAX */
}
for (fd = 0; fd < max; ++fd)
{
struct stat sb;
int result;
/* Only call FUNC for open fds. */
if (fstat (fd, &sb) == -1)
continue;
result = func (arg, fd);
if (result != 0)
return result;
}
return 0;
}
}
#endif /* HAVE_FDWALK */
/* A VEC holding all the fds open when notice_open_fds was called. We
don't use a hashtab because libiberty isn't linked into gdbserver;
and anyway we don't expect there to be many open fds. */
DEF_VEC_I (int);
static VEC (int) *open_fds;
/* An fdwalk callback function used by notice_open_fds. It puts the
given file descriptor into the vec. */
static int
do_mark_open_fd (void *ignore, int fd)
{
VEC_safe_push (int, open_fds, fd);
return 0;
}
/* See filestuff.h. */
void
notice_open_fds (void)
{
fdwalk (do_mark_open_fd, NULL);
}
/* See filestuff.h. */
void
mark_fd_no_cloexec (int fd)
{
do_mark_open_fd (NULL, fd);
}
/* See filestuff.h. */
void
unmark_fd_no_cloexec (int fd)
{
int i, val;
for (i = 0; VEC_iterate (int, open_fds, i, val); ++i)
{
if (fd == val)
{
VEC_unordered_remove (int, open_fds, i);
return;
}
}
gdb_assert_not_reached (_("fd not found in open_fds"));
}
/* Helper function for close_most_fds that closes the file descriptor
if appropriate. */
static int
do_close (void *ignore, int fd)
{
int i, val;
for (i = 0; VEC_iterate (int, open_fds, i, val); ++i)
{
if (fd == val)
{
/* Keep this one open. */
return 0;
}
}
close (fd);
return 0;
}
/* See filestuff.h. */
void
close_most_fds (void)
{
fdwalk (do_close, NULL);
}
/* This is a tri-state flag. When zero it means we haven't yet tried
O_CLOEXEC. When positive it means that O_CLOEXEC works on this
host. When negative, it means that O_CLOEXEC doesn't work. We
track this state because, while gdb might have been compiled
against a libc that supplies O_CLOEXEC, there is no guarantee that
the kernel supports it. */
static int trust_o_cloexec;
/* Mark FD as close-on-exec, ignoring errors. Update
TRUST_O_CLOEXEC. */
static void
mark_cloexec (int fd)
{
#ifdef HAVE_F_GETFD
int old = fcntl (fd, F_GETFD, 0);
if (old != -1)
{
fcntl (fd, F_SETFD, old | FD_CLOEXEC);
if (trust_o_cloexec == 0)
{
if ((old & FD_CLOEXEC) != 0)
trust_o_cloexec = 1;
else
trust_o_cloexec = -1;
}
}
#endif /* HAVE_F_GETFD */
}
/* Depending on TRUST_O_CLOEXEC, mark FD as close-on-exec. */
static void
maybe_mark_cloexec (int fd)
{
if (trust_o_cloexec <= 0)
mark_cloexec (fd);
}
#ifdef HAVE_SOCKETS
/* Like maybe_mark_cloexec, but for callers that use SOCK_CLOEXEC. */
static void
socket_mark_cloexec (int fd)
{
if (SOCK_CLOEXEC == 0 || trust_o_cloexec <= 0)
mark_cloexec (fd);
}
#endif
/* See filestuff.h. */
int
gdb_open_cloexec (const char *filename, int flags, unsigned long mode)
{
int fd = open (filename, flags | O_CLOEXEC, mode);
if (fd >= 0)
maybe_mark_cloexec (fd);
return fd;
}
/* See filestuff.h. */
FILE *
gdb_fopen_cloexec (const char *filename, const char *opentype)
{
FILE *result = NULL;
static int fopen_e_ever_failed;
if (!fopen_e_ever_failed)
{
char *copy;
copy = alloca (strlen (opentype) + 2);
strcpy (copy, opentype);
/* This is a glibc extension but we try it unconditionally on
this path. */
strcat (copy, "e");
result = fopen (filename, copy);
}
if (result == NULL)
{
/* Fallback. */
result = fopen (filename, opentype);
if (result != NULL)
fopen_e_ever_failed = 1;
}
if (result != NULL)
maybe_mark_cloexec (fileno (result));
return result;
}
#ifdef HAVE_SOCKETS
/* See filestuff.h. */
int
gdb_socketpair_cloexec (int namespace, int style, int protocol, int filedes[2])
{
#ifdef HAVE_SOCKETPAIR
int result = socketpair (namespace, style | SOCK_CLOEXEC, protocol, filedes);
if (result != -1)
{
socket_mark_cloexec (filedes[0]);
socket_mark_cloexec (filedes[1]);
}
return result;
#else
gdb_assert_not_reached (_("socketpair not available on this host"));
#endif
}
/* See filestuff.h. */
int
gdb_socket_cloexec (int namespace, int style, int protocol)
{
int result = socket (namespace, style | SOCK_CLOEXEC, protocol);
if (result != -1)
socket_mark_cloexec (result);
return result;
}
#endif
/* See filestuff.h. */
int
gdb_pipe_cloexec (int filedes[2])
{
int result;
#ifdef HAVE_PIPE2
result = pipe2 (filedes, O_CLOEXEC);
if (result != -1)
{
maybe_mark_cloexec (filedes[0]);
maybe_mark_cloexec (filedes[1]);
}
#else
#ifdef HAVE_PIPE
result = pipe (filedes);
if (result != -1)
{
mark_cloexec (filedes[0]);
mark_cloexec (filedes[1]);
}
#else /* HAVE_PIPE */
gdb_assert_not_reached (_("pipe not available on this host"));
#endif /* HAVE_PIPE */
#endif /* HAVE_PIPE2 */
return result;
}