OpenE2K
/
dwarves
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[LIB]: cu__find_parameter_by_id should look inside namespaces too 

This is simplified by introducing list__find_tag_by_id. I guess in the end the
right thing is to use a hashtable to find the ids. Trying to have specialized
find_foo_by_id functions instead of having just one that traverses _all_ the
tags is becoming less of a performance advantage as struct class now has
namespaces, i.e. functions can be inside structs and to find abstract_origin,
specification, etc references we have to traverse most of the tree anyway...

Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
This commit is contained in:
Arnaldo Carvalho de Melo 2007-05-26 17:53:40 -03:00
parent 5824b679d5
commit aa91264ea0
1 changed files with 24 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
dwarves.c
View File

@ -894,43 +894,39 @@ static struct variable *cu__find_variable_by_id(const struct cu *self,
return NULL;
}
static struct tag *ftype__find_parm_by_id(const struct ftype *self,
const Dwarf_Off id)
static struct tag *list__find_tag_by_id(const struct list_head *self,
const Dwarf_Off id)
{
struct tag *pos;
struct tag *pos, *tag;
list_for_each_entry(pos, &self->parms, node)
list_for_each_entry(pos, self, node) {
if (pos->id == id)
return pos;
return 0;
switch (pos->tag) {
case DW_TAG_namespace:
tag = list__find_tag_by_id(&tag__namespace(pos)->tags, id);
break;
case DW_TAG_subprogram:
tag = list__find_tag_by_id(&tag__ftype(pos)->parms, id);
if (tag == NULL)
tag = list__find_tag_by_id(&tag__function(pos)->lexblock.tags, id);
break;
default:
continue;
}
if (tag != NULL)
return tag;
}
return NULL;
}
static struct tag *cu__find_parameter_by_id(const struct cu *self,
const Dwarf_Off id)
{
struct tag *pos;
list_for_each_entry(pos, &self->tags, node) {
/*
* There can't be any at the top level CU tags list,
* it'll be in the ftype->parms list or in the lexblock->tags
* list, see comment in die__create_new_parameter to see why
* the later is possible.
*/
if (pos->tag == DW_TAG_subprogram) {
struct function *fn = tag__function(pos);
struct tag *tag = ftype__find_parm_by_id(&fn->proto,
id);
if (tag != NULL) {
tag = lexblock__find_tag_by_id(&fn->lexblock,
id);
if (tag != NULL)
return tag;
}
}
}
return NULL;
return list__find_tag_by_id(&self->tags, id);
}
static size_t array_type__nr_entries(const struct array_type *self)