OpenE2K
/
dwarves
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[CTRACER]: Dont emit duplicate probes for functions with the same name 

This is more like a bandaid, namespace clashes should be handled properly in
the future, but for now, well behaved projects will get the profits ;)

Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
This commit is contained in:
Arnaldo Carvalho de Melo 2007-01-13 14:56:16 -02:00
parent 0bf740a74c
commit b7fcbac565
1 changed files with 44 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

47
ctracer.c
View File

@ -9,8 +9,10 @@
#include <getopt.h>
#include <limits.h>
#include <search.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/types.h>
#include "dwarves.h"
@ -21,6 +23,35 @@ static struct cus *kprobes_cus;
static LIST_HEAD(cus__definitions);
static LIST_HEAD(cus__fwd_decls);
static void *jprobes_emitted;
static void *kretprobes_emitted;
static int methods__compare(const void *a, const void *b)
{
return strcmp(a, b);
}
static int methods__add(void **table, const char *str)
{
char **s = tsearch(str, table, methods__compare);
if (s != NULL) {
if (*s == str) {
char *dup = strdup(str);
if (dup != NULL)
*s = dup;
else {
tdelete(str, table, methods__compare);
return -1;
}
} else
return -1;
} else
return -1;
return 0;
}
static void method__add(struct cu *cu, struct function *function)
{
list_add(&function->tool_node, &cu->tool_list);
@ -105,6 +136,9 @@ static int cu_emit_kprobes_iterator(struct cu *cu, void *cookie)
struct function *pos;
list_for_each_entry(pos, &cu->tool_list, tool_node) {
if (methods__add(&jprobes_emitted, function__name(pos, cu)) != 0)
continue;
pos->priv = (void *)1; /* Mark as visited, for the table iterator */
cus__emit_ftype_definitions(cus, cu, &pos->proto);
function__emit_kprobes(pos, cu, target);
}
@ -117,7 +151,8 @@ static int cu_emit_kprobes_table_iterator(struct cu *cu, void *cookie)
struct function *pos;
list_for_each_entry(pos, &cu->tool_list, tool_node)
printf("\t&jprobe__%s,\n", function__name(pos, cu));
if (pos->priv != NULL)
printf("\t&jprobe__%s,\n", function__name(pos, cu));
return 0;
}
@ -144,8 +179,13 @@ static int cu_emit_kretprobes_iterator(struct cu *cu, void *cookie)
{
struct function *pos;
list_for_each_entry(pos, &cu->tool_list, tool_node)
list_for_each_entry(pos, &cu->tool_list, tool_node) {
if (methods__add(&kretprobes_emitted,
function__name(pos, cu)) != 0)
continue;
pos->priv = (void *)1; /* Mark as visited, for the table iterator */
function__emit_kretprobes(pos, cu);
}
return 0;
}
@ -155,7 +195,8 @@ static int cu_emit_kretprobes_table_iterator(struct cu *cu, void *cookie)
struct function *pos;
list_for_each_entry(pos, &cu->tool_list, tool_node)
printf("\t&kretprobe__%s,\n", function__name(pos, cu));
if (pos->priv != NULL)
printf("\t&kretprobe__%s,\n", function__name(pos, cu));
return 0;
}