OpenE2K
/
dwarves
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fprintf: Remove unused printf arg when printing enumerations 

A cut'n'paste error, noticed by coverity:

  Error: PRINTF_ARGS: [#def16]
  dwarves-1.13/dwarves_fprintf.c:369: extra_argument: This argument was not used by the format string: "conf->suffix". [Note: The source code implementation of the function has been overridden by a builtin model.]
  #  367|   	 */
  #  368|   	if (type->size / 8 != sizeof(int))
  #  369|-> 		printed += fprintf(fp, " __attribute__((__packed__))", conf->suffix);
  #  370|
  #  371|   	if (conf->suffix)

Reported-by: William Cohen <wcohen@redhat.com>
Fixes: 28a3bc7add ("fprintf: Support packed enums")
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo 2019-07-02 10:29:49 -03:00
parent 71c4f83f28
commit e95dacb704
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dwarves_fprintf.c
View File

@ -366,7 +366,7 @@ size_t enumeration__fprintf(const struct tag *tag, const struct cu *cu,
* enumeration, use sizeof(int) for now.
*/
if (type->size / 8 != sizeof(int))
printed += fprintf(fp, " __attribute__((__packed__))", conf->suffix);
printed += fprintf(fp, " %s", "__attribute__((__packed__))");
if (conf->suffix)
printed += fprintf(fp, " %s", conf->suffix);