OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

analyzer: associate -Wanalyzer-double-fclose with CWE-1341 

gcc/analyzer/ChangeLog:
	* sm-file.cc (double_fclose::emit): Associate the warning with
	CWE-1341 ("Multiple Releases of Same Resource or Handle").

gcc/testsuite/ChangeLog:
	* gcc.dg/analyzer/file-1.c (test_1): Verify that double-fclose is
	associated with CWE-1341.

Signed-off-by: David Malcolm <dmalcolm@redhat.com>
This commit is contained in:
David Malcolm 2022-06-16 17:27:08 -04:00
parent 753aaa949a
commit 065d191893
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gcc/analyzer/sm-file.cc
View File

@ -178,9 +178,12 @@ public:
bool emit (rich_location *rich_loc) final override
{
return warning_at (rich_loc, get_controlling_option (),
"double %<fclose%> of FILE %qE",
m_arg);
diagnostic_metadata m;
/* CWE-1341: Multiple Releases of Same Resource or Handle. */
m.add_cwe (1341);
return warning_meta (rich_loc, m, get_controlling_option (),
"double %<fclose%> of FILE %qE",
m_arg);
}
label_text describe_state_change (const evdesc::state_change &change)

2
gcc/testsuite/gcc.dg/analyzer/file-1.c
View File

@ -14,7 +14,7 @@ test_1 (const char *path)
fclose (f); /* { dg-message "\\(4\\) \\.\\.\\.to here" "to here" } */
/* { dg-message "\\(5\\) first 'fclose' here" "first fclose" { target *-*-* } .-1 } */
fclose (f); /* { dg-warning "double 'fclose' of FILE 'f'" "warning" } */
fclose (f); /* { dg-warning "double 'fclose' of FILE 'f' \\\[CWE-1341\\\]" "warning" } */
/* { dg-message "second 'fclose' here; first 'fclose' was at \\(5\\)" "second fclose" { target *-*-* } .-1 } */
}