OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR sanitizer/64906 (-fsanitize=integer-divide-by-zero creates false -Wmaybe-uninitialized warning)

Browse Source 
PR sanitizer/64906
	* c-ubsan.c (ubsan_instrument_division): Also pre-evaluate OP1.

	* c-c++-common/ubsan/pr64906.c: New test.

From-SVN: r228112
This commit is contained in:
Marek Polacek 2015-09-25 09:50:29 +00:00 committed by Marek Polacek
parent 89e5941d8c
commit 15dbc1a6df
4 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gcc/c-family/ChangeLog
View File

@ -1,3 +1,8 @@
2015-09-25 Marek Polacek <polacek@redhat.com>
PR sanitizer/64906
* c-ubsan.c (ubsan_instrument_division): Also pre-evaluate OP1.
2015-09-24 Patrick Palka <ppalka@gcc.gnu.org>
* c-indentation.c (should_warn_for_misleading_indentation):

1
gcc/c-family/c-ubsan.c
View File

@ -104,6 +104,7 @@ ubsan_instrument_division (location_t loc, tree op0, tree op1)
}
}
t = fold_build2 (COMPOUND_EXPR, TREE_TYPE (t), unshare_expr (op0), t);
t = fold_build2 (COMPOUND_EXPR, TREE_TYPE (t), unshare_expr (op1), t);
if (flag_sanitize_undefined_trap_on_error)
tt = build_call_expr_loc (loc, builtin_decl_explicit (BUILT_IN_TRAP), 0);
else

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2015-09-25 Marek Polacek <polacek@redhat.com>
PR sanitizer/64906
* c-c++-common/ubsan/pr64906.c: New test.
2015-09-24 H.J. Lu <hongjiu.lu@intel.com>
* gcc.target/i386/pr66749.c (dg-options): Replace -mtune=iamcu

12
gcc/testsuite/c-c++-common/ubsan/pr64906.c Normal file
View File

@ -0,0 +1,12 @@
/* PR sanitizer/64906 */
/* { dg-do compile } */
/* { dg-options "-fsanitize=integer-divide-by-zero -O -Werror=maybe-uninitialized" } */
int
fn1 (int f, int s)
{
int ret = 0;
if (f)
ret = s / (f ? (unsigned long) 8 : 0);
return ret;
}