OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Make ltrans type canonicals compatible with WPA ones 

This patch fixes profiledbootstrap failure with LTO enabled.
Not refining alias sets from WPA to ltrans time is a good invariant to
maintain and the canonical type hash behaves this way.  However I broke
this with the ODR logic.

Normally we define canonical types for C++ ODR types according to their
type names.  However to make ODR types compatible with C types we check
if structurally equivalent C type exists and if so, we ignore ODR
names giving up on the precision.

This however is not stable between WPA and ltrans since at ltrans the
type merging does not see as many types as WPA does.  To make this
consistent the patch makes WPA ODR_TYPE_P == 0 for ODR types that
conflicted with non-ODR type.

I had to drop one sanity check in ipa-utils.h (that I think is not very
important - I added it while introducing CXX_ODR_P machinery) and also
it now may happen that we query odr_based_tbaa_p before registering
first ODR type so we do not want to ICE here.
ODR type registration happens early to produce ODR violation warings.
Those are not done at ltrans, so dropping the registration is safe. The
type will still be added while computing the type inheritance graph if
needed for devirtualization (and late devirtualization is not very
useful anyway since it won't enable inlining).

gcc/ChangeLog:
	PR bootstrap/97857
	* ipa-devirt.c (odr_based_tbaa_p): Do not ICE when
	odr_hash is not initialized
	* ipa-utils.h (type_with_linkage_p): Do not sanity check
	CXX_ODR_P.
	* tree-streamer-out.c (pack_ts_type_common_value_fields): Set
	CXX_ODR_P according to the canonical type.

gcc/lto/ChangeLog:
	PR bootstrap/97857
	* lto-common.c (gimple_register_canonical_type_1): Only
	register types with TYPE_CXX_ODR_P flag; sanity check that no
	conflict happens at ltrans time.
This commit is contained in:
Jan Hubicka 2020-11-17 15:38:13 +01:00
parent 8a97aed0d2
commit 18dd295638
4 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gcc/ipa-devirt.c
View File

@ -2032,6 +2032,8 @@ odr_based_tbaa_p (const_tree type)
{
if (!RECORD_OR_UNION_TYPE_P (type))
return false;
if (!odr_hash)
return false;
odr_type t = get_odr_type (const_cast <tree> (type), false);
if (!t || !t->tbaa_enabled)
return false;

2
gcc/ipa-utils.h
View File

@ -211,8 +211,6 @@ type_with_linkage_p (const_tree t)
if (!TYPE_CONTEXT (t))
return false;
gcc_checking_assert (TREE_CODE (t) == ENUMERAL_TYPE || TYPE_CXX_ODR_P (t));
return true;
}

5
gcc/lto/lto-common.c
View File

@ -415,8 +415,8 @@ gimple_register_canonical_type_1 (tree t, hashval_t hash)
that we can use to lookup structurally equivalent non-ODR type.
In case we decide to treat type as unique ODR type we recompute hash based
on name and let TBAA machinery know about our decision. */
if (RECORD_OR_UNION_TYPE_P (t)
&& odr_type_p (t) && !odr_type_violation_reported_p (t))
if (RECORD_OR_UNION_TYPE_P (t) && odr_type_p (t)
&& TYPE_CXX_ODR_P (t) && !odr_type_violation_reported_p (t))
{
/* Anonymous namespace types never conflict with non-C++ types. */
if (type_with_linkage_p (t) && type_in_anonymous_namespace_p (t))
@ -434,6 +434,7 @@ gimple_register_canonical_type_1 (tree t, hashval_t hash)
if (slot && !TYPE_CXX_ODR_P (*(tree *)slot))
{
tree nonodr = *(tree *)slot;
gcc_checking_assert (!flag_ltrans);
if (symtab->dump_file)
{
fprintf (symtab->dump_file,

6
gcc/tree-streamer-out.c
View File

@ -343,7 +343,11 @@ pack_ts_type_common_value_fields (struct bitpack_d *bp, tree expr)
{
bp_pack_value (bp, TYPE_TRANSPARENT_AGGR (expr), 1);
bp_pack_value (bp, TYPE_FINAL_P (expr), 1);
bp_pack_value (bp, TYPE_CXX_ODR_P (expr), 1);
/* alias_ptr_types_compatible_p relies on fact that during LTO
types do not get refined from WPA time to ltrans. */
bp_pack_value (bp, flag_wpa && TYPE_CANONICAL (expr)
? TYPE_CXX_ODR_P (TYPE_CANONICAL (expr))
: TYPE_CXX_ODR_P (expr), 1);
}
else if (TREE_CODE (expr) == ARRAY_TYPE)
bp_pack_value (bp, TYPE_NONALIASED_COMPONENT (expr), 1);