OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

backport: re PR target/81407 ([avr] Diagnose if a variable in progmem needs constructing.) 

gcc/
	Backport from 2017-07-12 trunk r250151.
	PR target/81407
	* config/avr/avr.c (avr_encode_section_info)
	[progmem && !TREE_READONLY]: Error if progmem object needs
	constructing.

From-SVN: r250522
This commit is contained in:
Georg-Johann Lay 2017-07-25 14:32:30 +00:00 committed by Georg-Johann Lay
parent ca73e1b3d3
commit 1e0bc91345
2 changed files with 25 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gcc/ChangeLog
View File

@ -1,3 +1,12 @@
2017-07-25 Georg-Johann Lay <avr@gjlay.de>
Backport from 2017-07-12 trunk r250151.
PR target/81407
* config/avr/avr.c (avr_encode_section_info)
[progmem && !TREE_READONLY]: Error if progmem object needs
constructing.
2017-07-25 Wilco Dijkstra <wdijkstr@arm.com>
PR target/79041

24
gcc/config/avr/avr.c
View File

@ -10140,18 +10140,26 @@ avr_encode_section_info (tree decl, rtx rtl, int new_decl_p)
if (new_decl_p
&& decl && DECL_P (decl)
&& NULL_TREE == DECL_INITIAL (decl)
&& !DECL_EXTERNAL (decl)
&& avr_progmem_p (decl, DECL_ATTRIBUTES (decl)))
{
// Don't warn for (implicit) aliases like in PR80462.
tree asmname = DECL_ASSEMBLER_NAME (decl);
varpool_node *node = varpool_node::get_for_asmname (asmname);
bool alias_p = node && node->alias;
if (!TREE_READONLY (decl))
{
// This might happen with C++ if stuff needs constructing.
error ("variable %q+D with dynamic initialization put "
"into program memory area", decl);
}
else if (NULL_TREE == DECL_INITIAL (decl))
{
// Don't warn for (implicit) aliases like in PR80462.
tree asmname = DECL_ASSEMBLER_NAME (decl);
varpool_node *node = varpool_node::get_for_asmname (asmname);
bool alias_p = node && node->alias;
if (!alias_p)
warning (OPT_Wuninitialized, "uninitialized variable %q+D put into "
"program memory area", decl);
if (!alias_p)
warning (OPT_Wuninitialized, "uninitialized variable %q+D put "
"into program memory area", decl);
}
}
default_encode_section_info (decl, rtl, new_decl_p);