OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR c/29521 (Confusing warning for return with expression in function returning void) 

2007-02-13  Manuel Lopez-Ibanez  <manu@gcc.gnu.org>

	PR c/29521
	* c-typeck.c (c_finish_return): Improve warning message.

testsuite/
	* gcc.dg/c90-return-1.c: Update output.
	* gcc.dg/c99-return-1.c: Likewise.

From-SVN: r121876
This commit is contained in:
Manuel López-Ibáñez 2007-02-13 00:29:17 +00:00
parent bad333ffe3
commit 2397c5750e
5 changed files with 44 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gcc/ChangeLog
View File

@ -1,3 +1,8 @@
2007-02-13 Manuel Lopez-Ibanez <manu@gcc.gnu.org>
PR c/29521
* c-typeck.c (c_finish_return): Improve warning message.
2007-02-12 Manuel Lopez-Ibanez <manu@gcc.gnu.org>
* alias.c (find_symbolic_term): Delete unused function.

4
gcc/c-typeck.c
View File

@ -6935,8 +6935,10 @@ c_finish_return (tree retval)
else if (valtype == 0 || TREE_CODE (valtype) == VOID_TYPE)
{
current_function_returns_null = 1;
if (pedantic || TREE_CODE (TREE_TYPE (retval)) != VOID_TYPE)
if (TREE_CODE (TREE_TYPE (retval)) != VOID_TYPE)
pedwarn ("%<return%> with a value, in function returning void");
else if (pedantic)
pedwarn ("ISO C forbids %<return%> with expression, in function returning void");
}
else
{

6
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,9 @@
2007-02-13 Manuel Lopez-Ibanez <manu@gcc.gnu.org>
PR c/29521
* gcc.dg/c90-return-1.c: Update output.
* gcc.dg/c99-return-1.c: Likewise.
2007-02-13 Paul Thomas <pault@gcc.gnu.org>
PR fortran/30554

15
gcc/testsuite/gcc.dg/pr29521-2.c Normal file
View File

@ -0,0 +1,15 @@
/* PR 29521 : warning for return with expression in function returning void */
/* { dg-do compile } */
/* { dg-options "-pedantic-errors" } */
void func (void) { }
void func2 (void)
{
return func (); /* { dg-error "ISO C forbids 'return' with expression" } */
}
void func3 (void)
{
return 1; /* { dg-error "'return' with a value" } */
}

15
gcc/testsuite/gcc.dg/pr29521.c Normal file
View File

@ -0,0 +1,15 @@
/* PR 29521 : warning for return with expression in function returning void */
/* { dg-do compile } */
/* { dg-options "" } */
void func (void) { }
void func2 (void)
{
return func ();
}
void func3 (void)
{
return 1; /* { dg-warning "'return' with a value" } */
}