OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

builtins.c (fold_builtin_strlen): Remove TODO comment.

Browse Source 
2018-09-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>

        * builtins.c (fold_builtin_strlen): Remove TODO comment.

testsuite:
2018-09-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>

        * gcc.dg/warn-strlen-no-nul.c: Add some missing test cases.

From-SVN: r264334
This commit is contained in:
Bernd Edlinger 2018-09-14 20:36:19 +00:00 committed by Bernd Edlinger
parent 05172c0937
commit 2870a4da4f
4 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gcc/ChangeLog
View File

@ -1,3 +1,7 @@
2018-09-14 Bernd Edlinger <bernd.edlinger@hotmail.de>
* builtins.c (fold_builtin_strlen): Remove TODO comment.
2018-09-14 Bernd Edlinger <bernd.edlinger@hotmail.de>
revert:

2
gcc/builtins.c
View File

@ -8462,7 +8462,7 @@ fold_builtin_strlen (location_t loc, tree type, tree arg)
return fold_convert_loc (loc, type, len);
if (!nonstr)
c_strlen (arg, 1, &nonstr); /* TODO: add test coverage here. */
c_strlen (arg, 1, &nonstr);
if (nonstr)
{

4
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,7 @@
2018-09-14 Bernd Edlinger <bernd.edlinger@hotmail.de>
* gcc.dg/warn-strlen-no-nul.c: Add some missing test cases.
2018-09-14 Martin Sebor <msebor@redhat.com>
* gcc.dg/warn-stpcpy-no-nul.c: New test.

11
gcc/testsuite/gcc.dg/warn-strlen-no-nul.c
View File

@ -9,6 +9,7 @@ const char a[5] = "12345"; /* { dg-message "declared here" } */
int v0 = 0;
int v1 = 1;
volatile int v2;
void sink (int, ...);
@ -117,10 +118,8 @@ T (v0 ? b[i0] : &b[i3][i0] + i1); /* { dg-warning "nul" } */
T (v0 ? b[i0] : &b[i3][i0] + i1); /* { dg-warning "nul" } */
T (v0 ? b[i1] : &b[i3][i1] + v0); /* { dg-warning "nul" } */
/* It's possible to detect the missing nul in the following two
expressions but GCC doesn't do it yet. */
T (v0 ? &b[3][1] + v0 : b[2]); /* { dg-warning "nul" "bug" } */
T (v0 ? &b[3][v0] : &b[3][v1]); /* { dg-warning "nul" "bug" } */
T (v0 ? &b[3][1] + v0 : b[2]); /* { dg-warning "nul" } */
T (v0 ? &b[3][v0] : &b[3][v1]); /* { dg-warning "nul" } */
struct A { char a[5], b[5]; };
@ -299,3 +298,7 @@ T (v0 ? &ba[3].a[1].a[1] : ba[0].a[0].a); /* { dg-warning "nul" } */
T (v0 ? ba[0].a[0].a : ba[0].a[1].b);
T (v0 ? ba[0].a[1].b : ba[0].a[0].a);
T (v2 ? b[1] : &b[3][1] + v2); /* { dg-warning "nul" } */
T (v2 ? &b[3][1] + v2 : b[2]); /* { dg-warning "nul" } */
T (v2 ? &b[3][v2] : &b[2][v2]); /* { dg-warning "nul" } */