[AArch64] Revert "Improve TLS Descriptor pattern to release RTL loop IV opt"

2015-09-28  Jiong Wang  <jiong.wang@arm.com>

	Revert:
	2015-08-06  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
		    Jiong Wang  <jiong.wang@arm.com>

	* config/aarch64/aarch64.d (tlsdesc_small_pseudo_<mode>): New pattern.
	* config/aarch64/aarch64.h (reg_class): New enumeration FIXED_REG0.
	(REG_CLASS_NAMES): Likewise.
	(REG_CLASS_CONTENTS): Likewise.
	* config/aarch64/aarch64.c (aarch64_class_max_nregs): Likewise.
	(aarch64_register_move_cost): Likewise.
	(aarch64_load_symref_appropriately): Invoke the new added pattern if
	possible.
	* config/aarch64/constraints.md (Uc0): New constraint.

From-SVN: r228211
This commit is contained in:
Jiong Wang 2015-09-28 16:16:43 +00:00 committed by Jiong Wang
parent db7b65ff72
commit 2876a13f6c
6 changed files with 24 additions and 73 deletions

View File

@ -1,3 +1,19 @@
2015-09-28 Jiong Wang <jiong.wang@arm.com>
Revert:
2015-08-06 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
Jiong Wang <jiong.wang@arm.com>
* config/aarch64/aarch64.d (tlsdesc_small_pseudo_<mode>): New pattern.
* config/aarch64/aarch64.h (reg_class): New enumeration FIXED_REG0.
(REG_CLASS_NAMES): Likewise.
(REG_CLASS_CONTENTS): Likewise.
* config/aarch64/aarch64.c (aarch64_class_max_nregs): Likewise.
(aarch64_register_move_cost): Likewise.
(aarch64_load_symref_appropriately): Invoke the new added pattern if
possible.
* config/aarch64/constraints.md (Uc0): New constraint.
2015-09-28 Daniel Hellstrom <daniel@gaisler.com>
* config/sparc/t-rtems: Remove -muser-mode. Add ut699, at697f and leon.

View File

@ -1061,39 +1061,22 @@ aarch64_load_symref_appropriately (rtx dest, rtx imm,
{
machine_mode mode = GET_MODE (dest);
rtx x0 = gen_rtx_REG (mode, R0_REGNUM);
rtx offset;
rtx tp;
gcc_assert (mode == Pmode || mode == ptr_mode);
if (can_create_pseudo_p ())
{
rtx reg = gen_reg_rtx (mode);
if (TARGET_ILP32)
emit_insn (gen_tlsdesc_small_pseudo_si (reg, imm));
else
emit_insn (gen_tlsdesc_small_pseudo_di (reg, imm));
offset = reg;
}
/* In ILP32, the got entry is always of SImode size. Unlike
small GOT, the dest is fixed at reg 0. */
if (TARGET_ILP32)
emit_insn (gen_tlsdesc_small_si (imm));
else
{
/* In ILP32, the got entry is always of SImode size. Unlike
small GOT, the dest is fixed at reg 0. */
if (TARGET_ILP32)
emit_insn (gen_tlsdesc_small_si (imm));
else
emit_insn (gen_tlsdesc_small_di (imm));
offset = x0;
}
emit_insn (gen_tlsdesc_small_di (imm));
tp = aarch64_load_tp (NULL);
if (mode != Pmode)
tp = gen_lowpart (mode, tp);
emit_insn (gen_rtx_SET (dest, gen_rtx_PLUS (mode, tp, offset)));
emit_insn (gen_rtx_SET (dest, gen_rtx_PLUS (mode, tp, x0)));
set_unique_reg_note (get_last_insn (), REG_EQUIV, imm);
return;
}
@ -5084,7 +5067,6 @@ aarch64_class_max_nregs (reg_class_t regclass, machine_mode mode)
aarch64_vector_mode_p (mode)
? (GET_MODE_SIZE (mode) + UNITS_PER_VREG - 1) / UNITS_PER_VREG
: (GET_MODE_SIZE (mode) + UNITS_PER_WORD - 1) / UNITS_PER_WORD;
case FIXED_REG0:
case STACK_REG:
return 1;
@ -6972,10 +6954,10 @@ aarch64_register_move_cost (machine_mode mode,
= aarch64_tune_params.regmove_cost;
/* Caller save and pointer regs are equivalent to GENERAL_REGS. */
if (to == CALLER_SAVE_REGS || to == POINTER_REGS || to == FIXED_REG0)
if (to == CALLER_SAVE_REGS || to == POINTER_REGS)
to = GENERAL_REGS;
if (from == CALLER_SAVE_REGS || from == POINTER_REGS || from == FIXED_REG0)
if (from == CALLER_SAVE_REGS || from == POINTER_REGS)
from = GENERAL_REGS;
/* Moving between GPR and stack cost is the same as GP2GP. */

View File

@ -405,7 +405,6 @@ extern unsigned aarch64_architecture_version;
enum reg_class
{
NO_REGS,
FIXED_REG0,
CALLER_SAVE_REGS,
GENERAL_REGS,
STACK_REG,
@ -421,7 +420,6 @@ enum reg_class
#define REG_CLASS_NAMES \
{ \
"NO_REGS", \
"FIXED_REG0", \
"CALLER_SAVE_REGS", \
"GENERAL_REGS", \
"STACK_REG", \
@ -434,7 +432,6 @@ enum reg_class
#define REG_CLASS_CONTENTS \
{ \
{ 0x00000000, 0x00000000, 0x00000000 }, /* NO_REGS */ \
{ 0x00000001, 0x00000000, 0x00000000 }, /* FIXED_REG0 */ \
{ 0x0007ffff, 0x00000000, 0x00000000 }, /* CALLER_SAVE_REGS */ \
{ 0x7fffffff, 0x00000000, 0x00000003 }, /* GENERAL_REGS */ \
{ 0x80000000, 0x00000000, 0x00000000 }, /* STACK_REG */ \

View File

@ -4773,25 +4773,6 @@
[(set_attr "type" "call")
(set_attr "length" "16")])
;; The same as tlsdesc_small_<mode> with hard register hiding.
;; The first operand is actually x0, while we wrap it under a delicated
;; register class so that before register allocation, it's seen as pseudo
;; register. The reason for doing this is we don't expose hard register X0
;; as the destination of set as it will cause trouble for RTL loop iv.
;; RTL loop iv will abort ongoing optimization once it finds there is hard reg
;; as destination of set.
(define_insn "tlsdesc_small_pseudo_<mode>"
[(set (match_operand:PTR 0 "register_operand" "=Uc0")
(unspec:PTR [(match_operand 1 "aarch64_valid_symref" "S")]
UNSPEC_TLSDESC))
(clobber (reg:DI LR_REGNUM))
(clobber (reg:CC CC_REGNUM))
(clobber (match_scratch:DI 2 "=r"))]
"TARGET_TLS_DESC"
"adrp\\t<w>0, %A1\;ldr\\t%<w>2, [%<w>0, #%L1]\;add\\t%<w>0, %<w>0, %L1\;.tlsdesccall\\t%1\;blr\\t%2"
[(set_attr "type" "call")
(set_attr "length" "16")])
(define_insn "stack_tie"
[(set (mem:BLK (scratch))
(unspec:BLK [(match_operand:DI 0 "register_operand" "rk")

View File

@ -24,9 +24,6 @@
(define_register_constraint "Ucs" "CALLER_SAVE_REGS"
"@internal The caller save registers.")
(define_register_constraint "Uc0" "FIXED_REG0"
"@internal Represent X0/W0.")
(define_register_constraint "w" "FP_REGS"
"Floating point and SIMD vector registers.")

View File

@ -1,22 +0,0 @@
/* { dg-do compile } */
/* { dg-require-effective-target tls_native } */
/* { dg-options "-O2 -fpic -fdump-rtl-loop2_invariant" } */
/* { dg-skip-if "-mcmodel=large, no support for -fpic" { aarch64-*-* } { "-mcmodel=large" } { "" } } */
int cal (int, int);
__thread int tls_data;
int
foo (int bound)
{
int i = 0;
int sum = 0;
for (i; i < bound; i++)
sum = cal (sum, tls_data);
return sum;
}
/* Insn sequences for TLS descriptor should be hoisted out of the loop. */
/* { dg-final { scan-rtl-dump "Decided" "loop2_invariant" } } */