git_commit.py: Add tests for signatures.

* gcc-changelog/git_commit.py: Refactor to make flake8 happy.
	* gcc-changelog/test_email.py: Add new test.
	* gcc-changelog/test_patches.txt: Add new patch.
This commit is contained in:
Martin Liska 2020-05-20 11:05:23 +02:00
parent 3bcaf16edd
commit 29c34351be
No known key found for this signature in database
GPG Key ID: 4DC182DC0FA73785
4 changed files with 47 additions and 2 deletions

View File

@ -1,3 +1,9 @@
2020-05-20 Martin Liska <mliska@suse.cz>
* gcc-changelog/git_commit.py: Refactor to make flake8 happy.
* gcc-changelog/test_email.py: Add new test.
* gcc-changelog/test_patches.txt: Add new patch.
2020-05-20 Frederik Harwath <frederik@codesourcery.com>
* gcc-changelog/git_commit.py: Skip over lines starting

View File

@ -155,9 +155,10 @@ REVIEWED_BY_PREFIX = 'reviewed-by: '
REVIEWED_ON_PREFIX = 'reviewed-on: '
SIGNED_OFF_BY_PREFIX = 'signed-off-by: '
REVIEW_PREFIXES = (REVIEWED_BY_PREFIX, REVIEWED_ON_PREFIX,\
REVIEW_PREFIXES = (REVIEWED_BY_PREFIX, REVIEWED_ON_PREFIX,
SIGNED_OFF_BY_PREFIX)
class Error:
def __init__(self, message, line=None):
self.message = message
@ -350,7 +351,6 @@ class GitCommit:
else:
pr_line = line.lstrip()
lowered_line = line.lower()
if lowered_line.startswith(CO_AUTHORED_BY_PREFIX):
name = line[len(CO_AUTHORED_BY_PREFIX):]

View File

@ -262,3 +262,8 @@ class TestGccChangelog(unittest.TestCase):
def test_cherry_pick_format(self):
email = self.from_patch_glob('0001-c-Alias.patch')
assert not email.errors
def test_signatures(self):
email = self.from_patch_glob('0001-RISC-V-Make-unique.patch')
assert not email.errors
assert len(email.changelog_entries) == 1

View File

@ -2410,4 +2410,38 @@ index b8f03d18541..7230ac724ba 100644
+
--
2.26.2
=== 0001-RISC-V-Make-unique.patch ===
From adce62f53d8ad00e8110a6a2de7962d7a850de16 Mon Sep 17 00:00:00 2001
From: Keith Packard <keithp@keithp.com>
Date: Wed, 29 Apr 2020 09:49:56 -0700
Subject: [PATCH] RISC-V: Make unique SECCAT_SRODATA names start with .srodata
(not .sdata2)
default_unique_section uses ".sdata2" as a prefix for SECCAT_SRODATA
unique sections, but RISC-V uses ".srodata" instead. Override the
TARGET_ASM_UNIQUE_SECTION function to catch this case, allowing the
default to be used for all other sections.
gcc/
* config/riscv/riscv.c (riscv_unique_section): New.
(TARGET_ASM_UNIQUE_SECTION): New.
Signed-off-by: Keith Packard <keithp@keithp.com>
Reviewed-by: Keith Packard <keithp@keithp.com>
Reviewed-on: Keith Packard <keithp@keithp.com>
Co-Authored-by: Keith Packard <keithp@keithp.com>
---
gcc/ChangeLog | 5 +++++
gcc/config/riscv/riscv.c | 40 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 45 insertions(+)
diff --git a/gcc/config/riscv/riscv.c b/gcc/config/riscv/riscv.c
index e4c08d780db..1ad9799fce4 100644
--- a/gcc/config/riscv/riscv.c
+++ b/gcc/config/riscv/riscv.c
@@ -1 +1,2 @@
+
--
2.26.2