From 300471993fe5472c86b85b88557520c30f1309d7 Mon Sep 17 00:00:00 2001 From: Alexandre Oliva Date: Mon, 19 Feb 2007 06:22:43 +0000 Subject: [PATCH] tree-sra.c (sra_build_assignment): Replace assertion checking with a comment explaining why it can't be done. * tree-sra.c (sra_build_assignment): Replace assertion checking with a comment explaining why it can't be done. From-SVN: r122123 --- gcc/ChangeLog | 5 +++++ gcc/tree-sra.c | 14 ++++++++------ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 36a386a7114..f92097b1ea9 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2007-02-19 Alexandre Oliva + + * tree-sra.c (sra_build_assignment): Replace assertion + checking with a comment explaining why it can't be done. + 2007-02-18 Sandra Loosemore PR middle-end/30833 diff --git a/gcc/tree-sra.c b/gcc/tree-sra.c index a392589fc60..cb8f63d1833 100644 --- a/gcc/tree-sra.c +++ b/gcc/tree-sra.c @@ -1731,12 +1731,14 @@ generate_element_ref (struct sra_elt *elt) static tree sra_build_assignment (tree dst, tree src) { -#if 0 /* ENABLE_CHECKING */ - /* This test ought to pass, but it is unfortunately too strict for - now. */ - gcc_assert (TYPE_CANONICAL (TYPE_MAIN_VARIANT (TREE_TYPE (dst))) - == TYPE_CANONICAL (TYPE_MAIN_VARIANT (TREE_TYPE (src)))); -#endif + /* It was hoped that we could perform some type sanity checking + here, but since front-ends can emit accesses of fields in types + different from their nominal types and copy structures containing + them as a whole, we'd have to handle such differences here. + Since such accesses under different types require compatibility + anyway, there's little point in making tests and/or adding + conversions to ensure the types of src and dst are the same. + So we just assume type differences at this point are ok. */ return build2 (GIMPLE_MODIFY_STMT, void_type_node, dst, src); }