re PR fortran/50070 (Segmentation fault at size_binop_loc in fold-const.c)

2011-08-17  Janus Weil  <janus@gcc.gnu.org>

	PR fortran/50070
	* resolve.c (resolve_fl_variable): Reject non-constant character lengths
	in COMMON variables.


2011-08-17  Janus Weil  <janus@gcc.gnu.org>

	PR fortran/50070
	* gfortran.dg/common_13.f90: New.

From-SVN: r177825
This commit is contained in:
Janus Weil 2011-08-17 11:14:18 +02:00
parent 0de8f67e3f
commit 30228b6181
4 changed files with 37 additions and 8 deletions

View File

@ -1,3 +1,9 @@
2011-08-17 Janus Weil <janus@gcc.gnu.org>
PR fortran/50070
* resolve.c (resolve_fl_variable): Reject non-constant character lengths
in COMMON variables.
2011-08-16 Tobias Burnus <burnus@net-b.de>
Dominique Dhumieres <dominiq@lps.ens.fr>

View File

@ -10169,15 +10169,22 @@ resolve_fl_variable (gfc_symbol *sym, int mp_flag)
if (!gfc_is_constant_expr (e)
&& !(e->expr_type == EXPR_VARIABLE
&& e->symtree->n.sym->attr.flavor == FL_PARAMETER)
&& sym->ns->proc_name
&& (sym->ns->proc_name->attr.flavor == FL_MODULE
|| sym->ns->proc_name->attr.is_main_program)
&& !sym->attr.use_assoc)
&& e->symtree->n.sym->attr.flavor == FL_PARAMETER))
{
gfc_error ("'%s' at %L must have constant character length "
"in this context", sym->name, &sym->declared_at);
return FAILURE;
if (!sym->attr.use_assoc && sym->ns->proc_name
&& (sym->ns->proc_name->attr.flavor == FL_MODULE
|| sym->ns->proc_name->attr.is_main_program))
{
gfc_error ("'%s' at %L must have constant character length "
"in this context", sym->name, &sym->declared_at);
return FAILURE;
}
if (sym->attr.in_common)
{
gfc_error ("COMMON variable '%s' at %L must have constant "
"character length", sym->name, &sym->declared_at);
return FAILURE;
}
}
}

View File

@ -1,3 +1,8 @@
2011-08-17 Janus Weil <janus@gcc.gnu.org>
PR fortran/50070
* gfortran.dg/common_13.f90: New.
2011-08-16 Jason Merrill <jason@redhat.com>
PR c++/50086

View File

@ -0,0 +1,11 @@
! { dg-do compile }
!
! PR 50070: Segmentation fault at size_binop_loc in fold-const.c
!
! Contributed by Vittorio Zecca <zeccav@gmail.com>
subroutine sub
common n,z ! { dg-error "must have constant character length" }
integer :: n
character(len=n) :: z
end