OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR rtl-optimization/12953 (tree inline bug and fix)

Browse Source 
2003-11-12  Alexey Starovoytov  <alexey.starovoytov@sun.com>
	    Roger Sayle  <roger@eyesopen.com>

	PR optimization/12953
	* tree-inline.c (inline_forbidden_p_1): Added check for BUILT_IN
	before switch by FUNCTION_CODE.

Co-Authored-By: Roger Sayle <roger@eyesopen.com>

From-SVN: r73502
This commit is contained in:
Alexey Starovoytov 2003-11-12 18:12:57 +00:00 committed by Roger Sayle
parent 94f773991e
commit 3197c4fd19
2 changed files with 46 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gcc/ChangeLog
View File

@ -1,3 +1,10 @@
2003-11-12 Alexey Starovoytov <alexey.starovoytov@sun.com>
Roger Sayle <roger@eyesopen.com>
PR optimization/12953
* tree-inline.c (inline_forbidden_p_1): Added check for BUILT_IN
before switch by FUNCTION_CODE.
2003-11-12 Richard Earnshaw <rearnsha@arm.com> 2003-11-12 Richard Earnshaw <rearnsha@arm.com>
* arm.md (storehi): Avoid use of explicit subreg. * arm.md (storehi): Avoid use of explicit subreg.

75
gcc/tree-inline.c
View File

@ -1000,10 +1000,11 @@ inline_forbidden_p_1 (tree *nodep, int *walk_subtrees ATTRIBUTE_UNUSED,
switch (TREE_CODE (node)) switch (TREE_CODE (node))
{ {
case CALL_EXPR: case CALL_EXPR:
/* Refuse to inline alloca call unless user explicitly forced so as this /* Refuse to inline alloca call unless user explicitly forced so as
may change program's memory overhead drastically when the function this may change program's memory overhead drastically when the
using alloca is called in loop. In GCC present in SPEC2000 inlining function using alloca is called in loop. In GCC present in
into schedule_block cause it to require 2GB of ram instead of 256MB. */ SPEC2000 inlining into schedule_block cause it to require 2GB of
RAM instead of 256MB. */
if (alloca_call_p (node) if (alloca_call_p (node)
&& !lookup_attribute ("always_inline", DECL_ATTRIBUTES (fn))) && !lookup_attribute ("always_inline", DECL_ATTRIBUTES (fn)))
{ {
@ -1025,40 +1026,42 @@ inline_forbidden_p_1 (tree *nodep, int *walk_subtrees ATTRIBUTE_UNUSED,
return node; return node;
} }
switch (DECL_FUNCTION_CODE (t)) if (DECL_BUILT_IN (t))
{ switch (DECL_FUNCTION_CODE (t))
/* We cannot inline functions that take a variable number of
arguments. */
case BUILT_IN_VA_START:
case BUILT_IN_STDARG_START:
case BUILT_IN_NEXT_ARG:
case BUILT_IN_VA_END:
{ {
inline_forbidden_reason /* We cannot inline functions that take a variable number of
= N_("%Jfunction '%F' can never be inlined because it " arguments. */
"uses variable argument lists"); case BUILT_IN_VA_START:
return node; case BUILT_IN_STDARG_START:
} case BUILT_IN_NEXT_ARG:
case BUILT_IN_LONGJMP: case BUILT_IN_VA_END:
{ {
/* We can't inline functions that call __builtin_longjmp at all. inline_forbidden_reason
The non-local goto machinery really requires the destination = N_("%Jfunction '%F' can never be inlined because it "
be in a different function. If we allow the function calling "uses variable argument lists");
__builtin_longjmp to be inlined into the function calling return node;
__builtin_setjmp, Things will Go Awry. */ }
/* ??? Need front end help to identify "regular" non-local goto. */ case BUILT_IN_LONGJMP:
if (DECL_BUILT_IN_CLASS (t) == BUILT_IN_NORMAL) {
{ /* We can't inline functions that call __builtin_longjmp at
inline_forbidden_reason all. The non-local goto machinery really requires the
= N_("%Jfunction '%F' can never be inlined " destination be in a different function. If we allow the
"because it uses setjmp-longjmp exception handling"); function calling __builtin_longjmp to be inlined into the
return node; function calling __builtin_setjmp, Things will Go Awry. */
} /* ??? Need front end help to identify "regular" non-local
} goto. */
if (DECL_BUILT_IN_CLASS (t) == BUILT_IN_NORMAL)
{
inline_forbidden_reason
= N_("%Jfunction '%F' can never be inlined because "
"it uses setjmp-longjmp exception handling");
return node;
}
}
default: default:
break; break;
} }
break; break;
#ifndef INLINER_FOR_JAVA #ifndef INLINER_FOR_JAVA