OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[Ada] Restore defensive guard in checks for volatile actuals

Browse Source 
When flagging names of volatile objects occurring in actual parameters
it is safer to guard against identifiers without entity. This is
redundant (because earlier in the resolution of actual parameters we
already guard against actuals with Any_Type), but perhaps such
identifiers will become allowed in constructs like:

   Subprogram_Call
     (Actual =>
        (declare
           X : Boolean := ...
             with Annotate (GNATprove, ...)));
                            ^^^^^^^^^

which include an identifier that does not denote any entity.

Code cleanup related to handling of volatile components; behaviour is
unaffected.

gcc/ada/

	* sem_res.adb (Flag_Effectively_Volatile_Objects): Restore
	redundant guard.
This commit is contained in:
Piotr Trojanek 2022-03-30 12:00:20 +02:00 committed by Pierre-Marie de Rodat
parent de0665fc7f
commit 33400df641
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gcc/ada/sem_res.adb
View File

@ -3873,7 +3873,8 @@ package body Sem_Res is
-- selector_name in selected_component or as a choice in
-- component_association.
if Is_Object (Id)
if Present (Id)
and then Is_Object (Id)
and then Ekind (Id) not in E_Component | E_Discriminant
and then Is_Effectively_Volatile_For_Reading (Id)
and then