OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

pointer-query: Fix ICE with non-pointer param [PR105635] 

The gimple_parm_array_size function comment talks about pointe parameters
but doesn't actually verify it, it checks whether an attribute is present
on the function and then just uses TREE_TYPE (TREE_TYPE (var)) which
assumes a pointer type (or in theory could work for ARRAY_TYPE but
c-family languages which only have that attribute will never have ARRAY_TYPE
parameters; and for VECTOR_TYPE/COMPLEX_TYPE it would mean something quite
different).

So, this patch punts early if var doesn't have pointer/reference type.

2022-05-19  Jakub Jelinek  <jakub@redhat.com>

	PR c/105635
	* pointer-query.cc (gimple_parm_array_size): Return NULL if var
	doesn't have pointer or reference type.

	* gcc.dg/pr105635.c: New test.
This commit is contained in:
Jakub Jelinek 2022-05-19 11:56:21 +02:00
parent b8944f0438
commit 3b4daa0b3c
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gcc/pointer-query.cc
View File

@ -555,7 +555,7 @@ gimple_parm_array_size (tree ptr, wide_int rng[2],
from the current function declaratation (e.g., attribute access or
related). */
tree var = SSA_NAME_VAR (ptr);
if (TREE_CODE (var) != PARM_DECL)
if (TREE_CODE (var) != PARM_DECL || !POINTER_TYPE_P (TREE_TYPE (var)))
return NULL_TREE;
const unsigned prec = TYPE_PRECISION (sizetype);

11
gcc/testsuite/gcc.dg/pr105635.c Normal file
View File

@ -0,0 +1,11 @@
/* PR c/105635 */
/* { dg-do compile } */
/* { dg-options "-Wall" } */
void foo (int, int[*]); /* { dg-message "previous declaration of 'foo' with type" } */
foo (int x, int y) /* { dg-warning "return type defaults to 'int'" } */
{ /* { dg-warning "conflicting types for 'foo'" "" { target *-*-* } .-1 } */
/* { dg-message "declared here" "" { target *-*-* } .-2 } */
return (x >= 0) != (y < 0); /* { dg-warning "'return' with a value, in function returning void" } */
}