OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

loop-invariant: JUMP_INSNs aren't loop invariant [PR97954]

Browse Source 
The following testcase ICEs because loop invariant motion moves asm goto
with a single output as invariant.
Normally, jumps aren't really moved, because if they are single set,
they have their SET_DEST (pc) and pc_rtx has VOIDmode on which one of the
functions find_invariant_insn calls bails out.  The code already punts on
insns that can throw or trap.  And for asm goto without outputs, it isn't
single set, or asm goto with two or more outputs it isn't single set either.

2020-12-01  Jakub Jelinek  <jakub@redhat.com>

	PR rtl-optimization/97954
	* loop-invariant.c (find_invariant_insn): Punt on JUMP_P insns.

	* gcc.dg/pr97954.c: New test.
This commit is contained in:
Jakub Jelinek 2020-12-01 16:23:59 +01:00
parent 2133e773ab
commit 404d0ca782
2 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gcc/loop-invariant.c
View File

@ -1099,6 +1099,10 @@ find_invariant_insn (rtx_insn *insn, bool always_reached, bool always_executed)
if (HAVE_cc0 && sets_cc0_p (insn))
return;
/* Jumps have control flow side-effects. */
if (JUMP_P (insn))
return;
set = single_set (insn);
if (!set)
return;

12
gcc/testsuite/gcc.dg/pr97954.c Normal file
View File

@ -0,0 +1,12 @@
/* PR rtl-optimization/97954 */
/* { dg-do compile } */
/* { dg-options "-O2" } */
int
foo (void)
{
int x;
lab:
asm goto ("": "=r" (x) : : : lab);
return x;
}