OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

PR tree-optimization/83369 - Missing diagnostics during inlining 

gcc/ChangeLog:

	PR tree-optimization/83369
	* tree-ssa-ccp.c (pass_post_ipa_warn::execute): Use %G to print
	inlining context.

gcc/testsuite/ChangeLog:

	PR tree-optimization/83369
	gcc.dg/Wnonnull.c: New test.

From-SVN: r257400
This commit is contained in:
Martin Sebor 2018-02-05 22:45:04 +00:00 committed by Martin Sebor
parent d66f032937
commit 48fe6bbb71
4 changed files with 54 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/ChangeLog
View File

@ -1,3 +1,9 @@
2018-02-05 Martin Sebor <msebor@redhat.com>
PR tree-optimization/83369
* tree-ssa-ccp.c (pass_post_ipa_warn::execute): Use %G to print
inlining context.
2018-02-05 Martin Liska <mliska@suse.cz>
* doc/invoke.texi: Cherry-pick upstream r323995.

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2018-02-05 Martin Sebor <msebor@redhat.com>
PR tree-optimization/83369
gcc.dg/Wnonnull.c: New test.
2018-02-05 Richard Sandiford <richard.sandiford@linaro.org>
* lib/lto.exp (lto_handle_diagnostics): Remove messages_by_file

41
gcc/testsuite/gcc.dg/Wnonnull.c Normal file
View File

@ -0,0 +1,41 @@
/* PR tree-optimization/83369 - Missing diagnostics during inlining
{ dg-do compile }
{ dg-options "-O2 -Wall" } */
#include <string.h>
char buf[100];
struct Test
{
const char* s1;
const char* s2;
};
__attribute ((nonnull (1, 2)))
inline char*
my_strcpy (char *restrict dst, const char *restrict src, size_t size)
{
size_t len = strlen (src); /* { dg-warning "argument 1 null where non-null expected" } */
if (len < size)
memcpy (dst, src, len + 1); /* { dg-warning "argument 2 null where non-null expected" } */
else
{
memcpy (dst, src, size - 1); /* { dg-warning "argument 2 null where non-null expected" } */
dst[size - 1] = '\0';
}
return dst;
}
void test (struct Test* test)
{
if (test->s1)
my_strcpy (buf, test->s1, sizeof buf);
else if (test->s2)
my_strcpy (buf, test->s2, sizeof buf);
else
my_strcpy (buf, test->s2, sizeof buf);
}
/* Verify that the inlining context is printed for -Wnonnull:
{ dg-message "function .my_strcpy..*inlined from .test." "" { target *-*-* } 0 } */

4
gcc/tree-ssa-ccp.c
View File

@ -3458,8 +3458,8 @@ pass_post_ipa_warn::execute (function *fun)
location_t loc = gimple_location (stmt);
if (warning_at (loc, OPT_Wnonnull,
"argument %u null where non-null "
"expected", i + 1))
"%Gargument %u null where non-null "
"expected", as_a <gcall *>(stmt), i + 1))
{
tree fndecl = gimple_call_fndecl (stmt);
if (fndecl && DECL_IS_BUILTIN (fndecl))