OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Introduce -fprofile-update=prefer-atomic

Browse Source 
PR bootstrap/78069
	* common.opt: Add prefer-atomic as a new enum value for
	-fprofile-update.
	* coretypes.h: Likewise.
	* doc/invoke.texi: Document the new option value.
	* gcc.c: Replace atomic with prefer-atomic.  Remove warning.
	* tree-profile.c (tree_profiling): Select default value
	of -fprofile-update when 'prefer-atomic' is selected.
	PR bootstrap/78069
	* gcc.dg/no_profile_instrument_function-attr-1.c: Update test
	to match scanned pattern.
	* gcc.dg/tree-ssa/ssa-lim-11.c: Likewise.

From-SVN: r242386
This commit is contained in:
Martin Liska 2016-11-14 13:09:48 +01:00 committed by Martin Liska
parent f6b9a2a0c5
commit 4d2098539a
9 changed files with 53 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
gcc/ChangeLog
View File

@ -1,3 +1,14 @@
2016-11-14 Martin Liska <mliska@suse.cz>
PR bootstrap/78069
* common.opt: Add prefer-atomic as a new enum value for
-fprofile-update.
* coretypes.h: Likewise.
* doc/invoke.texi: Document the new option value.
* gcc.c: Replace atomic with prefer-atomic. Remove warning.
* tree-profile.c (tree_profiling): Select default value
of -fprofile-update when 'prefer-atomic' is selected.
2016-11-14 Wilco Dijkstra <wdijkstr@arm.com>
* config/arm/cortex-a57.md (cortex_a57_alu): Move extend here, bfm...

5
gcc/common.opt
View File

@ -1959,7 +1959,7 @@ Enable correction of flow inconsistent profile data input.
fprofile-update=
Common Joined RejectNegative Enum(profile_update) Var(flag_profile_update) Init(PROFILE_UPDATE_SINGLE)
-fprofile-update=[single|atomic] Set the profile update method.
-fprofile-update=[single|atomic|prefer-atomic] Set the profile update method.
Enum
Name(profile_update) Type(enum profile_update) UnknownError(unknown profile update method %qs)
@ -1970,6 +1970,9 @@ Enum(profile_update) String(single) Value(PROFILE_UPDATE_SINGLE)
EnumValue
Enum(profile_update) String(atomic) Value(PROFILE_UPDATE_ATOMIC)
EnumValue
Enum(profile_update) String(prefer-atomic) Value(PROFILE_UPDATE_PREFER_ATOMIC)
fprofile-generate
Common
Enable common options for generating profile info for profile feedback directed optimizations.

3
gcc/coretypes.h
View File

@ -177,7 +177,8 @@ enum offload_abi {
/* Types of profile update methods. */
enum profile_update {
PROFILE_UPDATE_SINGLE,
PROFILE_UPDATE_ATOMIC
PROFILE_UPDATE_ATOMIC,
PROFILE_UPDATE_PREFER_ATOMIC
};
/* Types of unwind/exception handling info that can be generated. */

11
gcc/doc/invoke.texi
View File

@ -10504,13 +10504,18 @@ To optimize the program based on the collected profile information, use
Alter the update method for an application instrumented for profile
feedback based optimization. The @var{method} argument should be one of
@samp{single} or @samp{atomic}. The first one is useful for single-threaded
applications, while the second one prevents profile corruption by emitting
thread-safe code.
@samp{single}, @samp{atomic} or @samp{prefer-atomic}.
The first one is useful for single-threaded applications,
while the second one prevents profile corruption by emitting thread-safe code.
@strong{Warning:} When an application does not properly join all threads
(or creates an detached thread), a profile file can be still corrupted.
Using @samp{prefer-atomic} would be transformed either to @samp{atomic},
when supported by a target, or to @samp{single} otherwise. The GCC driver
automatically selects @samp{prefer-atomic} when @option{-pthread}
is present in the command line.
@item -fsanitize=address
@opindex fsanitize=address
Enable AddressSanitizer, a fast memory error detector.

6
gcc/gcc.c
View File

@ -1144,11 +1144,7 @@ static const char *cc1_options =
%{coverage:-fprofile-arcs -ftest-coverage}\
%{fprofile-arcs|fprofile-generate*|coverage:\
%{!fprofile-update=single:\
%{pthread:-fprofile-update=atomic}}}\
%{fprofile-update=single:\
%{fprofile-arcs|fprofile-generate*|coverage:\
%{pthread:%n-fprofile-update=atomic should be used\
for a multithreaded application}}}";
%{pthread:-fprofile-update=prefer-atomic}}}";
static const char *asm_options =
"%{-target-help:%:print-asm-header()} "

7
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,10 @@
2016-11-14 Martin Liska <mliska@suse.cz>
PR bootstrap/78069
* gcc.dg/no_profile_instrument_function-attr-1.c: Update test
to match scanned pattern.
* gcc.dg/tree-ssa/ssa-lim-11.c: Likewise.
2016-11-14 Richard Biener <rguenther@suse.de>
PR tree-optimization/78312

2
gcc/testsuite/gcc.dg/no_profile_instrument_function-attr-1.c
View File

@ -1,4 +1,4 @@
/* { dg-options "-O2 -fprofile-generate -fdump-tree-optimized" } */
/* { dg-options "-O2 -fprofile-generate -fprofile-update=single -fdump-tree-optimized" } */
__attribute__ ((no_profile_instrument_function))
int foo()

2
gcc/testsuite/gcc.dg/tree-ssa/ssa-lim-11.c
View File

@ -1,5 +1,5 @@
/* { dg-do compile } */
/* { dg-options "-O -fprofile-arcs -fdump-tree-lim2-details" } */
/* { dg-options "-O -fprofile-arcs -fprofile-update=single -fdump-tree-lim2-details" } */
/* { dg-require-profiling "-fprofile-generate" } */
struct thread_param

35
gcc/tree-profile.c
View File

@ -592,25 +592,26 @@ tree_profiling (void)
struct cgraph_node *node;
/* Verify whether we can utilize atomic update operations. */
if (flag_profile_update == PROFILE_UPDATE_ATOMIC)
{
bool can_support = false;
unsigned HOST_WIDE_INT gcov_type_size
= tree_to_uhwi (TYPE_SIZE_UNIT (get_gcov_type ()));
if (gcov_type_size == 4)
can_support
= HAVE_sync_compare_and_swapsi || HAVE_atomic_compare_and_swapsi;
else if (gcov_type_size == 8)
can_support
= HAVE_sync_compare_and_swapdi || HAVE_atomic_compare_and_swapdi;
bool can_support_atomic = false;
unsigned HOST_WIDE_INT gcov_type_size
= tree_to_uhwi (TYPE_SIZE_UNIT (get_gcov_type ()));
if (gcov_type_size == 4)
can_support_atomic
= HAVE_sync_compare_and_swapsi || HAVE_atomic_compare_and_swapsi;
else if (gcov_type_size == 8)
can_support_atomic
= HAVE_sync_compare_and_swapdi || HAVE_atomic_compare_and_swapdi;
if (!can_support)
{
warning (0, "target does not support atomic profile update, "
"single mode is selected");
flag_profile_update = PROFILE_UPDATE_SINGLE;
}
if (flag_profile_update == PROFILE_UPDATE_ATOMIC
&& !can_support_atomic)
{
warning (0, "target does not support atomic profile update, "
"single mode is selected");
flag_profile_update = PROFILE_UPDATE_SINGLE;
}
else if (flag_profile_update == PROFILE_UPDATE_PREFER_ATOMIC)
flag_profile_update = can_support_atomic
? PROFILE_UPDATE_ATOMIC : PROFILE_UPDATE_SINGLE;
/* This is a small-ipa pass that gets called only once, from
cgraphunit.c:ipa_passes(). */