OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR fortran/43362 (ICE with structure constuctor with DT component) 

2010-03-14  Tobias Burnus  <burnus@net-b.de>

        PR fortran/43362
        * resolve.c (resolve_structure_cons): Add missing PURE
        * constraint.
        (resolve_ordinary_assign): Add check to avoid segfault.

2010-03-14  Tobias Burnus  <burnus@net-b.de>

        PR fortran/43362
        * gfortran.dg/impure_constructor_1.f90: New test.

From-SVN: r157447
This commit is contained in:
Tobias Burnus 2010-03-14 14:18:28 +01:00 committed by Tobias Burnus
parent 9fd6e05c4a
commit 4eceddd758
4 changed files with 52 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/fortran/ChangeLog
View File

@ -1,3 +1,9 @@
2010-03-14 Tobias Burnus <burnus@net-b.de>
PR fortran/43362
* resolve.c (resolve_structure_cons): Add missing PURE constraint.
(resolve_ordinary_assign): Add check to avoid segfault.
2010-03-12 Paul Thomas <pault@gcc.gnu.org>
PR fortran/43291

11
gcc/fortran/resolve.c
View File

@ -921,6 +921,16 @@ resolve_structure_cons (gfc_expr *expr)
"for pointer component '%s' should be a POINTER or "
"a TARGET", &cons->expr->where, comp->name);
}
/* F2003, C1272 (3). */
if (gfc_pure (NULL) && cons->expr->expr_type == EXPR_VARIABLE
&& gfc_impure_variable (cons->expr->symtree->n.sym))
{
t = FAILURE;
gfc_error ("Invalid expression in the derived type constructor for pointer "
"component '%s' at %L in PURE procedure", comp->name,
&cons->expr->where);
}
}
return t;
@ -7947,6 +7957,7 @@ resolve_ordinary_assign (gfc_code *code, gfc_namespace *ns)
if (lhs->ts.type == BT_DERIVED
&& lhs->expr_type == EXPR_VARIABLE
&& lhs->ts.u.derived->attr.pointer_comp
&& rhs->expr_type == EXPR_VARIABLE
&& gfc_impure_variable (rhs->symtree->n.sym))
{
gfc_error ("The impure variable at %L is assigned to "

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2010-03-14 Tobias Burnus <burnus@net-b.de>
PR fortran/43362
* gfortran.dg/impure_constructor_1.f90: New test.
2010-03-13 Sebastian Pop <sebastian.pop@amd.com>
PR middle-end/43354

30
gcc/testsuite/gfortran.dg/impure_constructor_1.f90 Normal file
View File

@ -0,0 +1,30 @@
! { dg-do compile }
!
! PR fortran/43362
!
module m
implicit none
type t
integer, pointer :: a
end type t
type t2
type(t) :: b
end type t2
type t3
type(t), pointer :: b
end type t3
contains
pure subroutine foo(x)
type(t), target, intent(in) :: x
type(t2) :: y
type(t3) :: z
! The following gave an ICE but is valid:
y = t2(x) ! Note: F2003, C1272 (3) and (4) do not apply
! Variant which is invalid as C1272 (3) applies
z = t3(x) ! { dg-error "Invalid expression in the derived type constructor" }
end subroutine foo
end module m