OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR c++/60373 (half warning: visibility attribute ignored because it)

Browse Source 
/cp
2014-05-20  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/60373
	* decl.c (duplicate_decls): Replace pair of warning_at with
	warning_at + inform.
	(maybe_commonize_var): Likewise.

/testsuite
2014-05-20  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/60373
	* g++.dg/cpp0x/Wattributes1.C: New.
	* g++.dg/ext/visibility/redecl1.C: Adjust.
	* g++.dg/ext/visibility/visibility-7.C: Likewise.

From-SVN: r210646
This commit is contained in:
Paolo Carlini 2014-05-20 15:16:48 +00:00 committed by Paolo Carlini
parent efa72acd62
commit 512eacee8f
6 changed files with 35 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gcc/cp/ChangeLog
View File

@ -1,3 +1,10 @@
2014-05-20 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/60373
* decl.c (duplicate_decls): Replace pair of warning_at with
warning_at + inform.
(maybe_commonize_var): Likewise.
2014-05-20 Richard Sandiford <rsandifo@linux.vnet.ibm.com>
PR bootstrap/61210

22
gcc/cp/decl.c
View File

@ -2306,10 +2306,11 @@ duplicate_decls (tree newdecl, tree olddecl, bool newdecl_is_friend)
&& DECL_VISIBILITY_SPECIFIED (newdecl)
&& DECL_VISIBILITY (newdecl) != DECL_VISIBILITY (olddecl))
{
warning_at (input_location, OPT_Wattributes,
"%q+D: visibility attribute ignored because it", newdecl);
warning_at (DECL_SOURCE_LOCATION (olddecl), OPT_Wattributes,
"conflicts with previous declaration here");
if (warning_at (DECL_SOURCE_LOCATION (newdecl), OPT_Wattributes,
"%qD: visibility attribute ignored because it "
"conflicts with previous declaration", newdecl))
inform (DECL_SOURCE_LOCATION (olddecl),
"previous declaration of %qD", olddecl);
}
/* Choose the declaration which specified visibility. */
if (DECL_VISIBILITY_SPECIFIED (olddecl))
@ -5026,13 +5027,12 @@ maybe_commonize_var (tree decl)
be merged. */
TREE_PUBLIC (decl) = 0;
DECL_COMMON (decl) = 0;
warning_at (input_location, 0,
"sorry: semantics of inline function static "
"data %q+#D are wrong (you%'ll wind up "
"with multiple copies)", decl);
warning_at (DECL_SOURCE_LOCATION (decl), 0,
" you can work around this by removing "
"the initializer");
if (warning_at (DECL_SOURCE_LOCATION (decl), 0,
"sorry: semantics of inline function static "
"data %q#D are wrong (you%'ll wind up "
"with multiple copies)", decl))
inform (DECL_SOURCE_LOCATION (decl),
"you can work around this by removing the initializer");
}
}
}

7
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,10 @@
2014-05-20 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/60373
* g++.dg/cpp0x/Wattributes1.C: New.
* g++.dg/ext/visibility/redecl1.C: Adjust.
* g++.dg/ext/visibility/visibility-7.C: Likewise.
2014-05-20 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
* gcc.target/powerpc/vsxcopy.c: New test.

8
gcc/testsuite/g++.dg/cpp0x/Wattributes1.C Normal file
View File

@ -0,0 +1,8 @@
// PR c++/60373
// { dg-do compile { target c++11 } }
// { dg-require-visibility "" }
#include <new>
__attribute__((visibility("hidden")))void*operator new(std::size_t); // { dg-warning "visibility attribute ignored" }
// { dg-message "previous declaration" "" { target *-*-* } 128 }

2
gcc/testsuite/g++.dg/ext/visibility/redecl1.C
View File

@ -3,5 +3,5 @@
struct __attribute((visibility("hidden"))) B;
struct __attribute((visibility("default"))) B; // { dg-error "visibility" }
__attribute ((visibility ("hidden"))) void f(); // { dg-warning "previous" }
__attribute ((visibility ("hidden"))) void f(); // { dg-message "previous" }
__attribute ((visibility ("default"))) void f(); // { dg-warning "visibility" }

2
gcc/testsuite/g++.dg/ext/visibility/visibility-7.C
View File

@ -4,7 +4,7 @@
extern int
__attribute__((visibility ("hidden")))
xyzzy; /* { dg-warning "previous declaration here" "" } */
xyzzy; /* { dg-message "previous declaration" "" } */
int
__attribute__((visibility ("protected")))