OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR fortran/88298 (Bogus conversion warning for CSHIFT with -fno-range-check -m64) 

2019-02-02  Thomas Koenig  <tkoenig@gcc.gnu.org>

	PR fortran/88298
	* arith.c (gfc_int2int): Do not warn if src->do_not_warn is set.
	* gfortran.h (gfc_expr): Add flag do_not_warn.
	* intrinsic.c (gfc_convert_type_warn): Set expr->do_not_warn if
	no warning is desired.

2019-02-02  Thomas Koenig  <tkoenig@gcc.gnu.org>

	PR fortran/88298
	* gfortran.dg/warn_conversion_10.f90: New test.

From-SVN: r268475
This commit is contained in:
Thomas Koenig 2019-02-02 16:21:43 +00:00
parent a3df90b967
commit 5197d79937
6 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gcc/fortran/ChangeLog
View File

@ -1,3 +1,11 @@
2019-02-02 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/88298
* arith.c (gfc_int2int): Do not warn if src->do_not_warn is set.
* gfortran.h (gfc_expr): Add flag do_not_warn.
* intrinsic.c (gfc_convert_type_warn): Set expr->do_not_warn if
no warning is desired.
2019-02-02 Paul Thomas <pault@gcc.gnu.org>
PR fortran/88393

2
gcc/fortran/arith.c
View File

@ -2061,7 +2061,7 @@ gfc_int2int (gfc_expr *src, int kind)
gfc_convert_mpz_to_signed (result->value.integer,
gfc_integer_kinds[k].bit_size);
if (warn_conversion && kind < src->ts.kind)
if (warn_conversion && !src->do_not_warn && kind < src->ts.kind)
gfc_warning_now (OPT_Wconversion, "Conversion from %qs to %qs at %L",
gfc_typename (&src->ts), gfc_typename (&result->ts),
&src->where);

3
gcc/fortran/gfortran.h
View File

@ -2168,6 +2168,9 @@ typedef struct gfc_expr
unsigned int do_not_resolve_again : 1;
/* Set this if no warning should be given somewhere in a lower level. */
unsigned int do_not_warn : 1;
/* If an expression comes from a Hollerith constant or compile-time
evaluation of a transfer statement, it may have a prescribed target-
memory representation, and these cannot always be backformed from

2
gcc/fortran/intrinsic.c
View File

@ -5028,6 +5028,8 @@ gfc_convert_type_warn (gfc_expr *expr, gfc_typespec *ts, int eflag, int wflag)
if (ts->type == BT_UNKNOWN)
goto bad;
expr->do_not_warn = ! wflag;
/* NULL and zero size arrays get their type here, unless they already have a
typespec. */
if ((expr->expr_type == EXPR_NULL

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2019-02-02 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/88298
* gfortran.dg/warn_conversion_10.f90: New test.
2019-02-02 Paul Thomas <pault@gcc.gnu.org>
PR fortran/88393

8
gcc/testsuite/gfortran.dg/warn_conversion_10.f90 Normal file
View File

@ -0,0 +1,8 @@
! { dg-do compile }
! { dg-options "-fno-range-check -Wconversion" }
! PR 88298 - this used to warn unnecessarily. Original test case by
! Harald Anlauf.
subroutine bug (j, js)
integer :: j, js(3,2)
js(:,:) = cshift (js(:,:), shift=j, dim=1)
end subroutine bug