OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use dlsym to check if libdl is needed for plugin

Browse Source 
config/plugins.m4 has

 if test "$plugins" = "yes"; then
    AC_SEARCH_LIBS([dlopen], [dl])
  fi

Plugin uses dlsym, but libasan.so only intercepts dlopen, not dlsym:

[hjl@gnu-tools-1 binutils-text]$ nm -D /lib64/libasan.so.4| grep " dl"
0000000000038580 W dlclose
                 U dl_iterate_phdr
000000000004dc50 W dlopen
                 U dlsym
                 U dlvsym
[hjl@gnu-tools-1 binutils-text]$

Testing dlopen for libdl leads to false negative when -fsanitize=address
is used.  It results in link failure:

../bfd/.libs/libbfd.a(plugin.o): undefined reference to symbol 'dlsym@@GLIBC_2.16'

dlsym should be used to check if libdl is needed for plugin.

	PR gas/22318
	* plugins.m4 (AC_PLUGINS): Use dlsym to check if libdl is needed.

From-SVN: r259140
This commit is contained in:
H.J. Lu 2018-04-05 17:49:39 +00:00 committed by H.J. Lu
parent da0c07b20f
commit 520a02b6fa
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
config/ChangeLog
View File

@ -1,3 +1,8 @@
2018-04-05 H.J. Lu <hongjiu.lu@intel.com>
PR gas/22318
* plugins.m4 (AC_PLUGINS): Use dlsym to check if libdl is needed.
2018-02-14 Igor Tsimbalist <igor.v.tsimbalist@intel.com> 2018-02-14 Igor Tsimbalist <igor.v.tsimbalist@intel.com>
PR target/84148 PR target/84148

2
config/plugins.m4
View File

@ -16,6 +16,6 @@ AC_DEFUN([AC_PLUGINS],
[plugins=$maybe_plugins] [plugins=$maybe_plugins]
) )
if test "$plugins" = "yes"; then if test "$plugins" = "yes"; then
AC_SEARCH_LIBS([dlopen], [dl]) AC_SEARCH_LIBS([dlsym], [dl])
fi fi
]) ])