OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR c/91815 (questionable error on type definition at file scope)

Browse Source 
PR c/91815
	* c-decl.c (pushdecl): In C detect duplicate declarations across scopes
	of identifiers in the external scope only for variables and functions.

From-SVN: r275992
This commit is contained in:
Eric Botcazou 2019-09-20 09:11:20 +00:00 committed by Eric Botcazou
parent 6e222b2a3a
commit 522da4c233
5 changed files with 45 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/c/ChangeLog
View File

@ -1,3 +1,9 @@
2019-09-20 Eric Botcazou <ebotcazou@adacore.com>
PR c/91815
* c-decl.c (pushdecl): In C detect duplicate declarations across scopes
of identifiers in the external scope only for variables and functions.
2019-09-04 Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
PR c/78736

7
gcc/c/c-decl.c
View File

@ -3130,8 +3130,11 @@ pushdecl (tree x)
detecting duplicate declarations of the same object, no matter
what scope they are in; this is what we do here. (C99 6.2.7p2:
All declarations that refer to the same object or function shall
have compatible type; otherwise, the behavior is undefined.) */
if (DECL_EXTERNAL (x) || scope == file_scope)
have compatible type; otherwise, the behavior is undefined.)
However, in Objective-C, we also want to detect declarations
conflicting with those of the basic types. */
if ((DECL_EXTERNAL (x) || scope == file_scope)
&& (VAR_OR_FUNCTION_DECL_P (x) || c_dialect_objc ()))
{
tree type = TREE_TYPE (x);
tree vistype = NULL_TREE;

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2019-09-20 Eric Botcazou <ebotcazou@adacore.com>
* gcc.dg/typedef-var-1.c: New test.
* gcc.dg/typedef-var-2.c: Likewise.
2019-09-20 Martin Jambor <mjambor@suse.cz>
* g++.dg/ipa/pr81248.C: Adjust dg-options and dump-scan.

14
gcc/testsuite/gcc.dg/typedef-var-1.c Normal file
View File

@ -0,0 +1,14 @@
/* PR c/91815 */
/* { dg-do compile } */
int f (void)
{
extern int t;
extern float v;
return (v > 0.0f);
}
typedef float t;
t v = 4.5f;

15
gcc/testsuite/gcc.dg/typedef-var-2.c Normal file
View File

@ -0,0 +1,15 @@
/* PR c/91815 */
/* { dg-do compile } */
int f (void)
{
extern float v;
return (v > 0.0f);
}
extern int t;
typedef float t; /* { dg-error "redeclared as different kind of symbol" } */
t v = 4.5f;