OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR c++/21347 (spurious warning with -Wctor-dtor-privacy) 

PR c++/21347
	* class.c (maybe_warn_about_overly_private_class): Lazy
	constructors are public.
	PR c++/21347
	* g++.dg/warn/Wctor-dtor.C: New test.

From-SVN: r105441
This commit is contained in:
Mark Mitchell 2005-10-15 18:13:25 +00:00 committed by Mark Mitchell
parent b27cedc611
commit 550d1bf420
4 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gcc/cp/ChangeLog
View File

@ -1,3 +1,9 @@
2005-10-15 Mark Mitchell <mark@codesourcery.com>
PR c++/21347
* class.c (maybe_warn_about_overly_private_class): Lazy
constructors are public.
2005-10-14 Mark Mitchell <mark@codesourcery.com>
PR c++/19565

5
gcc/cp/class.c
View File

@ -1537,7 +1537,10 @@ maybe_warn_about_overly_private_class (tree t)
return;
}
if (TYPE_HAS_CONSTRUCTOR (t))
if (TYPE_HAS_CONSTRUCTOR (t)
/* Implicitly generated constructors are always public. */
&& (!CLASSTYPE_LAZY_DEFAULT_CTOR (t)
|| !CLASSTYPE_LAZY_COPY_CTOR (t)))
{
int nonprivate_ctor = 0;

5
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2005-10-15 Mark Mitchell <mark@codesourcery.com>
PR c++/21347
* g++.dg/warn/Wctor-dtor.C: New test.
2005-10-14 Volker Reichelt <reichelt@igpm.rwth-aachen.de>
PR c/23439

13
gcc/testsuite/g++.dg/warn/Wctor-dtor.C Normal file
View File

@ -0,0 +1,13 @@
// PR c++/21347
// { dg-options "-Wctor-dtor-privacy" }
class A {
public:
int x;
int getX() { return x; } // comment out to avoid warning
};
int foo() {
A a; // accepted: clearly the ctor is not private
return a.x;
}