From 552ab9772fb2bb59f2e3d3706f2cd304e95c8741 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Wed, 28 Mar 2012 21:33:15 +0000 Subject: [PATCH] compiler: fix crashes. The compiler would crash on: if true || x, y := 1, 2 {} and var s string s = append(s, "hello") Reported in issue 3186. From-SVN: r185928 --- gcc/go/gofrontend/expressions.cc | 2 ++ gcc/go/gofrontend/parse.cc | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/gcc/go/gofrontend/expressions.cc b/gcc/go/gofrontend/expressions.cc index 4c493f87665..f2a81de8add 100644 --- a/gcc/go/gofrontend/expressions.cc +++ b/gcc/go/gofrontend/expressions.cc @@ -7441,6 +7441,8 @@ Builtin_call_expression::check_one_arg() void Builtin_call_expression::do_check_types(Gogo*) { + if (this->is_error_expression()) + return; switch (this->code_) { case BUILTIN_INVALID: diff --git a/gcc/go/gofrontend/parse.cc b/gcc/go/gofrontend/parse.cc index 1a9c153a578..7207db58d0d 100644 --- a/gcc/go/gofrontend/parse.cc +++ b/gcc/go/gofrontend/parse.cc @@ -3971,7 +3971,7 @@ Parse::if_stat() bool saw_simple_stat = false; Expression* cond = NULL; - bool saw_send_stmt; + bool saw_send_stmt = false; if (this->simple_stat_may_start_here()) { cond = this->simple_stat(false, &saw_send_stmt, NULL, NULL);