gimple-expr.c (useless_type_conversion_p): Reinstate type canonical check for aggregate types and beef up comment for mode...

* gimple-expr.c (useless_type_conversion_p): Reinstate type canonical
	check for aggregate types and beef up comment for mode check.

From-SVN: r229714
This commit is contained in:
Eric Botcazou 2015-11-03 17:19:30 +00:00 committed by Eric Botcazou
parent 34148d68c7
commit 5993d1c9a3
4 changed files with 17 additions and 8 deletions

View File

@ -1,3 +1,8 @@
2015-11-03 Eric Botcazou <ebotcazou@adacore.com>
* gimple-expr.c (useless_type_conversion_p): Reinstate type canonical
check for aggregate types and beef up comment for mode check.
2015-11-03 Richard Biener <rguenther@suse.de>
* tree-vect-data-refs.c (vect_analyze_data_refs): Do not collect

View File

@ -86,7 +86,8 @@ useless_type_conversion_p (tree outer_type, tree inner_type)
if (inner_type == outer_type)
return true;
/* Changes in machine mode are never useless conversions unless. */
/* Changes in machine mode are never useless conversions because the RTL
middle-end expects explicit conversions between modes. */
if (TYPE_MODE (inner_type) != TYPE_MODE (outer_type))
return false;
@ -262,14 +263,13 @@ useless_type_conversion_p (tree outer_type, tree inner_type)
return true;
}
/* For aggregates compare only the size. Accesses to fields do have
a type information by themselves and thus we only care if we can i.e.
use the types in move operations. */
/* For aggregates we rely on TYPE_CANONICAL exclusively and require
explicit conversions for types involving to be structurally
compared types. */
else if (AGGREGATE_TYPE_P (inner_type)
&& TREE_CODE (inner_type) == TREE_CODE (outer_type))
return (TYPE_MODE (outer_type) != BLKmode
|| operand_equal_p (TYPE_SIZE (inner_type),
TYPE_SIZE (outer_type), 0));
return TYPE_CANONICAL (inner_type)
&& TYPE_CANONICAL (inner_type) == TYPE_CANONICAL (outer_type);
else if (TREE_CODE (inner_type) == OFFSET_TYPE
&& TREE_CODE (outer_type) == OFFSET_TYPE)

View File

@ -1,3 +1,7 @@
2015-11-03 Eric Botcazou <ebotcazou@adacore.com>
* gnat.dg/discr45.adb: Only compile the test.
2015-11-03 Evgeny Stupachenko <evstupac@gmail.com>
* g++.dg/ext/mvc4.C: Add dg-require-ifunc condition.

View File

@ -1,4 +1,4 @@
-- { dg-do run }
-- { dg-do compile }
-- { dg-options "-O2 -gnatws" }
procedure Discr45 is