OpenE2K/gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

c-decl.c (grokdeclarator): Instead of looking at TREE_OVERFLOW check if the constant fits in the index type.

Browse Source 
2011-05-03  Richard Guenther  <rguenther@suse.de>

	* c-decl.c (grokdeclarator): Instead of looking at
	TREE_OVERFLOW check if the constant fits in the index type.

	* gcc.dg/large-size-array-5.c: New testcase.

From-SVN: r173297
This commit is contained in:
Richard Guenther 2011-05-03 08:48:00 +00:00 committed by Richard Biener
parent 539d6b4aec
commit 60a45536f1
4 changed files with 25 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gcc/ChangeLog
View File

@ -1,3 +1,8 @@
2011-05-03 Richard Guenther <rguenther@suse.de>
* c-decl.c (grokdeclarator): Instead of looking at
TREE_OVERFLOW check if the constant fits in the index type.
2011-05-03 Richard Sandiford <richard.sandiford@linaro.org>
* config/arm/neon.md (vec_load_lanes<mode><mode>): New expanders,

16
gcc/c-decl.c
View File

@ -5368,15 +5368,13 @@ grokdeclarator (const struct c_declarator *declarator,
convert (index_type,
size_one_node));
/* If that overflowed, the array is too big. ???
While a size of INT_MAX+1 technically shouldn't
cause an overflow (because we subtract 1), the
overflow is recorded during the conversion to
index_type, before the subtraction. Handling
this case seems like an unnecessary
complication. */
if (TREE_CODE (itype) == INTEGER_CST
&& TREE_OVERFLOW (itype))
/* The above overflows when size does not fit
in index_type.
??? While a size of INT_MAX+1 technically shouldn't
cause an overflow (because we subtract 1), handling
this case seems like an unnecessary complication. */
if (TREE_CODE (size) == INTEGER_CST
&& !int_fits_type_p (size, index_type))
{
if (name)
error_at (loc, "size of array %qE is too large",

4
gcc/testsuite/ChangeLog
View File

@ -1,3 +1,7 @@
2011-05-03 Richard Guenther <rguenther@suse.de>
* gcc.dg/large-size-array-5.c: New testcase.
2011-05-03 Richard Sandiford <richard.sandiford@linaro.org>
* gcc.dg/vect/vect-strided-u16-i3.c: New test.

9
gcc/testsuite/gcc.dg/large-size-array-5.c Normal file
View File

@ -0,0 +1,9 @@
/* { dg-do compile } */
/* { dg-options "-Wno-overflow" } */
typedef __SIZE_TYPE__ size_t;
extern char a[((size_t)-1 >> 1) + 1]; /* { dg-error "too large" } */
extern char b[((size_t)-1 >> 1)];
extern int c[(((size_t)-1 >> 1) + 1) / sizeof(int)]; /* { dg-error "too large" } */
extern int d[((size_t)-1 >> 1) / sizeof(int)];