OpenE2K
/
gcc
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

re PR target/84786 ([miscompilation] vunpcklpd accessing xmm16-22 targeting KNL) 

PR target/84786
	* config/i386/sse.md (sse2_loadhpd): Use Yv constraint rather than v
	on the last operand.

	* gcc.target/i386/avx512f-pr84786-1.c: New test.
	* gcc.target/i386/avx512f-pr84786-2.c: New test.

From-SVN: r258475
This commit is contained in:
Jakub Jelinek 2018-03-13 09:03:28 +01:00 committed by Jakub Jelinek
parent 1f4e9d223c
commit 639e8522c0
5 changed files with 52 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gcc/ChangeLog
View File

@ -1,5 +1,9 @@
2018-03-13 Jakub Jelinek <jakub@redhat.com>
PR target/84786
* config/i386/sse.md (sse2_loadhpd): Use Yv constraint rather than v
on the last operand.
PR c++/84704
* tree.c (stabilize_reference_1): Return save_expr (e) for
STATEMENT_LIST even if it doesn't have side-effects.

6
gcc/config/i386/sse.md
View File

@ -9022,14 +9022,14 @@
;; see comment above inline_secondary_memory_needed function in i386.c
(define_insn "sse2_loadhpd"
[(set (match_operand:V2DF 0 "nonimmediate_operand"
"=x,v,x,v,o,o ,o")
"=x,v,x,v ,o,o ,o")
(vec_concat:V2DF
(vec_select:DF
(match_operand:V2DF 1 "nonimmediate_operand"
" 0,v,0,v,0,0 ,0")
" 0,v,0,v ,0,0 ,0")
(parallel [(const_int 0)]))
(match_operand:DF 2 "nonimmediate_operand"
" m,m,x,v,x,*f,r")))]
" m,m,x,Yv,x,*f,r")))]
"TARGET_SSE2 && !(MEM_P (operands[1]) && MEM_P (operands[2]))"
"@
movhpd\t{%2, %0|%0, %2}

4
gcc/testsuite/ChangeLog
View File

@ -1,5 +1,9 @@
2018-03-13 Jakub Jelinek <jakub@redhat.com>
PR target/84786
* gcc.target/i386/avx512f-pr84786-1.c: New test.
* gcc.target/i386/avx512f-pr84786-2.c: New test.
PR c++/84808
* g++.dg/cpp1y/constexpr-84808.C: New test.

25
gcc/testsuite/gcc.target/i386/avx512f-pr84786-1.c Normal file
View File

@ -0,0 +1,25 @@
/* PR target/84786 */
/* { dg-do run { target { ! ia32 } } } */
/* { dg-options "-mavx512f -mno-avx512vl -O2" } */
/* { dg-require-effective-target avx512f } */
#include "avx512f-check.h"
typedef double V __attribute__((vector_size (16)));
__attribute__((noipa)) V
foo (V x, double y)
{
register double z __asm ("xmm18");
asm volatile ("" : "=v" (z) : "0" (y));
x[1] = z;
return x;
}
static void
avx512f_test (void)
{
V a = foo ((V) { 1.0, 2.0 }, 3.0);
if (a[0] != 1.0 || a[1] != 3.0)
abort ();
}

16
gcc/testsuite/gcc.target/i386/avx512f-pr84786-2.c Normal file
View File

@ -0,0 +1,16 @@
/* PR target/84786 */
/* { dg-do compile { target { ! ia32 } } } */
/* { dg-options "-mavx512f -mno-avx512vl -O2" } */
typedef double V __attribute__((vector_size (16)));
__attribute__((noipa)) V
foo (V x, double y)
{
register double z __asm ("xmm18");
asm volatile ("" : "=v" (z) : "0" (y));
x[1] = z;
return x;
}
/* { dg-final { scan-assembler-not "vunpcklpd\[\^\n\r]*xmm(1\[6-9]|\[23]\[0-9])" } } */